Create Task
Maniphest T12010

Replace KLocalSocket[Server] in KIO by QLocalSocket[Server]
Open, Needs TriagePublic
Actions

Description

Do we still need our own implementation of this?

Related Objects
Search...

vkrause created this task.Nov 10 2019, 4:01 PM
nicolasfella added a subscriber: nicolasfella.Nov 21 2019, 3:38 PM

I briefly looked into this. I guess it's doable, but not trivial.

ConnectionBackend in KIO abstracts over KLocalSocket and QTcpSocket which works since KLocalSocket inherits from QTcpSocket. This is not possible with QLocalSocket since that inherits directly from QIODevice.

QAbstractSocket looks like the abstraction we want , but for some reason QLocalSocket does not inherit from QAbstractSocket, which seems weird to me. Maybe we can change that for Qt 6.

nicolasfella added a comment.Nov 24 2019, 10:13 PM

Alternative approach: remove QTCPSocket codepath completely. It was only used for when (K|Q)LocalSocket wasn't supporting Windows. KLocalSocket can then be killed

nicolasfella moved this task from Backlog to In Progress on the KF6 board.Dec 16 2019, 1:00 AM
nicolasfella moved this task from In Progress to Announced on the KF6 board.Apr 15 2020, 11:26 AM
nicolasfella moved this task from Announced to Done on the KF6 board.
ervin moved this task from Done to Announced on the KF6 board.Jul 12 2020, 1:24 PM