Create Task
Maniphest T11930

Rethink Lock, Login and Logout Screen's Color Modularity
Open, NormalPublic
Actions

Description

The lock, login and logout screens are coded in such a way that they utilize the complementary colors of a particular color scheme.

Breeze and Breeze Dark have been adjusted to work normally under this condition. Normally = white text and a dimmed background in both cases.

It is still, however, possible to get alternative colors with some desktop themes and color schemes.

This results in black text and the wallpaper being brightened instead of dimmed.

The end result is not very attractive, particulary in the case of the lock and login screens:

:

A usability issue also presents itself in the sense that we can't (shouldn't) put shadows behind black text (see D24997)

It also seems this modularity feature is not that modular. From my testing, text is always either white or black, and not some custom color.

Related Objects

filipf created this task.Oct 28 2019, 9:49 PM
filipf triaged this task as Normal priority.
ngraham added a subscriber: ngraham.Oct 28 2019, 9:53 PM

To repeat my relevant comment from D24997:

If the lock and login screens are able to display arbitrary text colors from the user's color scheme, we will never be rid of these kinds of problems. I see two practical solutions:

  • Hardcode white as the text color and black as the shadow color and don't respect the color scheme
  • Tweak the ui yet again (ugh) to replace the text shadows with rounded rectangles using a contrasting color from the color scheme

Otherwise we will be playing whack-a-mole forever, and will have to live with really ugly results for many cases (e.g. the case where the blurred wallpaper becomes lightened and the text is dark).

ndavis added a subscriber: ndavis.Oct 29 2019, 12:28 AM

I agree with Nate.

GB_2 added a subscriber: GB_2.Jul 7 2021, 5:52 PM

If this hasn't already been fixed then we should just hardcode the colors, looks the best and should be easy to do.

filipf added a comment.Jul 7 2021, 6:21 PM
In T11930#259816, @GB_2 wrote:

If this hasn't already been fixed then we should just hardcode the colors, looks the best and should be easy to do.

I tried that once and if I remember correctly the problem is you can't recolor tool buttons, there is just no color property. And there's always at least one of them at the bottom of the screen.

ngraham added a comment.Jul 24 2021, 2:01 AM

You can force a particular color group though.

ndavis added a comment.EditedJul 25 2021, 8:50 PM
In T11930#260908, @ngraham wrote:

You can force a particular color group though.

Doesn't work if the theme SVG itself requests a specific color group (e.g., ColorScheme-ButtonBackground)