Koko uses KDirModel in QML, but it has some issues like QWidgets dialogs with error messages popping up. The model itself isn't depending on Widgets, but it uses other stuff from KioWidgets.
joburlcache_p.h should be straightforward to move to core
fileundomanager has some widgets depencencies that need to be untangled first
| Status | Assigned | Task | ||
|---|---|---|---|---|
| Open | None | T11547 Remove unneeded QWidget dependencies to set parent windows or display errors | ||
| Open | None | T12089 KIO for KF6 | ||
| Open | dfaure | T11549 KIO: remove unneeded QWidget dependencies to set parent windows or display errors | ||
| Open | dfaure | T11821 Move KDirModel to KioGui |
Since JobUrlCache is entirely internal to KDirModel, I would move it to KioGui together with KDirModel, to avoid having to export it from KioCore.
FileUndoManager already has an interface for the GUI stuff (FileUndoManager::UiInterface).
We "just" need to make that pure abstract, move the implementation to a subclass, and possibly hook in that subclass automatically from KioWidgets like we do for delegates. Or we let the few apps using FileUndoManager choose which impl to use (the widgets one or their own, like dolphin already does by calling setUiInterface).
Next issue: KDirModel uses KDirLister (which extends KCoreDirLister with QWidget* and KMessageBox for errors).
Idea: take a JobUiDelegate in KCoreDirLister, remove KDirLister, rename KCoreDirLister to KDirLister.
And set the ui delegate from the factory automatically like in KIO jobs.
Better plan, let KCoreDirLister emit error(KJob*) and handle that in apps and in KDirModel.
I locally attempted the move to kiogui, to see what would create problems.
I had to move all of clipboardupdater.cpp fileundomanager.cpp joburlcache.cpp kdirmodel.cpp org.kde.kuiserver.xml org.kde.kio.FileUndoManager.xml,
adjust export macros, qCDebug
add linking to KIconThemes
export ClipboardUpdater for usage by kiowidgets
make use of ../gui/org.kde.kuiserver.xml in kiowidgets/CMakeLists.txt
Apart from the known issues (KDirLister=>KCoreDirLister, FileUndoManager::UiInterface which clearly needs to stay in KIOWidgets) I found another issue: the signal KIO::WidgetsAskUserActionHandler::askUserDeleteResult provides a QWidget* which is used by e.g. KDirOperator to find out if it is the target for that signal. This is a case where we don't want to change to QWindow*, there could be multiple widgets in the same window. Ah, but QObject* would do. I'll add TODOs.