virtualkeyboard: resize the focused window to make room for the keyboard
Audited6bc2ddd56a09
Actions

Authored by mart on Mar 20 2019, 10:04 AM.

Description

virtualkeyboard: resize the focused window to make room for the keyboard

Summary:
alternative approach: try to resize the winidow to make room for the keyboard.
the new input wayland protocol doesn't have anymore the overlap rectangle (and it would not be going to work with qwidget apps anyways)

in the future will probably be needed anextension to the input protocol v3 which partially gets back this, tough window resizing is needed regardless

what's missing: the resize should be "temporary" and the window should be restored to its previous geometry when the keyboard closes

Test Plan: tested with test QML code

Reviewers: Plasma, KWin, bshah, graesslin, romangg, davidedmundson

Reviewed By: Plasma, KWin, romangg, davidedmundson

Subscribers: nicolasfella, mart, kwin, davidedmundson, graesslin

Tags: KWin

Maniphest Tasks: T9815

Differential Revision: https://phabricator.kde.org/D18818

Details

Auditors

romangg

Committed

mart	Mar 20 2019, 10:05 AM

Reviewer

Plasma

Differential Revision

D18818: virtualkeyboard: resize the focused window to make room for the keyboard

Parents

R108:d51070223b0a: There's no qml folder here anymore

Branches

Unknown

Tags

Unknown

mart committed R108:6bc2ddd56a09: virtualkeyboard: resize the focused window to make room for the keyboard (authored by mart).Mar 20 2019, 10:05 AM

romangg raised a concern with this commit.Mar 20 2019, 1:38 PM

romangg added a subscriber: romangg.

romangg added inline comments.

/virtualkeyboard.cpp
250	This leads to a segmentation fault on shutdown of the compositor. The function apparently is called after `m_inputWindow` is freed. if (!m_inputWindow ) { return; } before fixes that.