Allows KWin scripts to change the value of client.activities property.
Diff Detail
- Repository
- R108 KWin
- Lint
Lint Skipped - Unit
Unit Tests Skipped
The Toplevel class contains mostly read-only properties (I wonder whether it's actually worth to put properties in the Toplevel class since Deleted windows are not exposed to scripting). Could you please put Q_PROPERTY(QStringList activities READ activities WRITE setOnActivities NOTIFY activitiesChanged) in the AbstractClient class instead?
abstract_client.h | ||
---|---|---|
888 | It's already declared in the Toplevel class, remove it? |
abstract_client.h | ||
---|---|---|
888 | Initially I had tried without it, but I got this compilation error: [ 48%] Building CXX object CMakeFiles/kwin.dir/kwin_autogen/mocs_compilation.cpp.o In file included from /home/tiago/kde/build/kwin/kwin_autogen/mocs_compilation.cpp:2: /home/tiago/kde/build/kwin/kwin_autogen/EWIEGA46WW/moc_abstract_client.cpp: In function ‘void checkNotifySignalValidity_KWin__AbstractClient(KWin::AbstractClient*)’: /home/tiago/kde/build/kwin/kwin_autogen/EWIEGA46WW/moc_abstract_client.cpp:1155:26: error: no matching function for call to ‘KWin::AbstractClient::activitiesChanged()’ 1155 | t->activitiesChanged(); | ^ In file included from /home/tiago/kde/src/kwin/abstract_client.h:24, from /home/tiago/kde/build/kwin/kwin_autogen/EWIEGA46WW/moc_abstract_client.cpp:10, from /home/tiago/kde/build/kwin/kwin_autogen/mocs_compilation.cpp:2: /home/tiago/kde/src/kwin/toplevel.h:610:10: note: candidate: ‘void KWin::Toplevel::activitiesChanged(KWin::Toplevel*)’ 610 | void activitiesChanged(KWin::Toplevel* toplevel); | ^~~~~~~~~~~~~~~~~ /home/tiago/kde/src/kwin/toplevel.h:610:10: note: candidate expects 1 argument, 0 provided [ 48%] Linking CXX executable ../bin/testScriptedEffectLoader |
abstract_client.h | ||
---|---|---|
888 | Hmm, that's interesting... I'll need some time to think how to resolve this issue. |
Hey man, can you join our vdg team on Telegram? Here is the link: https://t.me/vdgmainroom
We would like to talk about Parachute
abstract_client.h | ||
---|---|---|
888 | Shouldn't activitiesChanged be activitiesChanged() instead of activitiesChanged(KWin::AbstractClient* client); or activitiesChanged(KWin::Toplevel* topLevel); |
abstract_client.h | ||
---|---|---|
888 | I don't see the necessity of the parameter either, but I'm not an KWin expert. Can I submit the change or does anyone think differently? |
abstract_client.h | ||
---|---|---|
888 | I suggest to just remove activitiesChanged() signal in the Toplevel class. Is there any chance that you open a MR over here https://invent.kde.org/plasma/kwin/ ? | |
888 | that you could open* |
abstract_client.h | ||
---|---|---|
888 | Sure. I'll do it there. |