Differential D29425

Fix Windows Build
ClosedPublic
Actions

Authored by meven on May 4 2020, 6:19 PM.

Details

Reviewers
elvisangelaccio
ngraham
Group Reviewers
Dolphin
Commits
R318:31f5dc7f7c34: Fix Windows Build
Summary

Due to D25335

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.May 4 2020, 6:19 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptMay 4 2020, 6:19 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
meven requested review of this revision.May 4 2020, 6:19 PM
meven retitled this revision from Fix Window Build to Fix Windows Build.May 4 2020, 6:22 PM
ngraham accepted this revision.May 4 2020, 6:47 PM
This revision is now accepted and ready to land.May 4 2020, 6:47 PM
elvisangelaccio added a comment.May 4 2020, 8:11 PM

Wait, so the new feature does not work on Windows?

meven added a comment.May 5 2020, 5:30 AM
In D29425#663442, @elvisangelaccio wrote:

Wait, so the new feature does not work on Windows?

Indeed no, see KDirectoryContentsCounterWorker::subItemsCount #iddef

Closed by commit R318:31f5dc7f7c34: Fix Windows Build (authored by meven). · Explain WhyMay 5 2020, 5:31 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 81967

View Options

src/kitemviews/private/kdirectorycontentscounterworker.cpp

Loading...