Differential D28363

Don't incorrectly claim to support KIO::open
ClosedPublic
Actions

Authored by feverfew on Mar 27 2020, 9:16 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
KIO GDrive
Commits
R219:aa6e987eed44: Don't incorrectly claim to support KIO::open
Summary

Docs for KProtocolManager::supportsOpening() states that when it
returns true, it means that the protocol supports the FileJob interface
(KIO::open). GDrive does not support this interface so this function should
return false. To make it do so, the json file needs to be amended.

Test Plan

Compiles

Diff Detail

Repository
R219 KIO GDrive
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
feverfew requested review of this revision.Mar 27 2020, 9:16 PM
feverfew created this revision.
feverfew added a reviewer: KIO GDrive.Mar 27 2020, 9:17 PM
feverfew added a project: KIO GDrive.
feverfew added a subscriber: KIO GDrive.
elvisangelaccio accepted this revision.Mar 29 2020, 10:48 AM

Please push to the 1.3 branch. Thanks!

This revision is now accepted and ready to land.Mar 29 2020, 10:48 AM
Closed by commit R219:aa6e987eed44: Don't incorrectly claim to support KIO::open (authored by feverfew). · Explain WhyMar 30 2020, 5:17 PM
This revision was automatically updated to reflect the committed changes.
feverfew added a comment.Mar 30 2020, 5:20 PM

@elvisangelaccio Done. I don't know how you choose for fixes in release branches to get into master so I'll let you sort that out (and what is it, for future reference)?

elvisangelaccio added a comment.Apr 5 2020, 2:58 PM
In D28363#638317, @feverfew wrote:

@elvisangelaccio Done. I don't know how you choose for fixes in release branches to get into master so I'll let you sort that out (and what is it, for future reference)?

As a general rule, every fix in a stable/release branch should get merged into master (by merging the whole branch). I've done that now.

Revision Contents
Changeset List

PathPackages
Mgdrive.json (2 lines)

Diff 78924

View Options

gdrive.json

Loading...