Remove top margin.
Workaround to get paintedheight for label. (Undefined or paintedheight
does not work.)
Base plotter's top margin on labels size.
Add small spacing at the bottom.
Add 0 value.
Align labels to the right.
Details
Details
- Reviewers
jgrulich ngraham - Group Reviewers
Plasma VDG - Maniphest Tasks
- T10470: Improve the visuals of tray popups
- Commits
- R116:4ca1e7e34fd6: [Applet]Fix dimensions of traffic Monitor
Before
After
Diff Detail
Diff Detail
- Repository
- R116 Plasma Network Management Applet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Changes:
Added O value and aligned to the right.
Used Math.round
Made the plot's topMargin more specific. (Need to alling lines with labels)
Made comment more clear.
About the label workaround:
It is the complete opposite problem of PlasmaComponents checkboxes, where label cannot take implicitHeight.
Here it always takes implicitHeight with undefined or paintedheight.
applet/contents/ui/TrafficMonitor.qml | ||
---|---|---|
64–65 | We could probably just use a smaller predefined unit, like largeSpacing, instead of coming up with a semi-random-looking value derived from the label height |
Comment Actions
Accepting from my side. I'll wait for Nate to do the final review as I don't consider myself expert to QML and UI.