I'm not sure if there are any other changes to be made. On making this change, Kruler appears in the 'Utilities' category in the Kickoff launcher.
BUG: 271937
cfeck | |
kishoreg |
KDE Applications |
I'm not sure if there are any other changes to be made. On making this change, Kruler appears in the 'Utilities' category in the Kickoff launcher.
BUG: 271937
Check in Kickoff launcher and in application menu that appears when you middle-click on the desktop.
Lint Skipped |
Unit Tests Skipped |
I'm not sure if there are any other changes to be made.
KRuler belongs to kdegraphics from a repo-metadata point of view, which also ends up with: https://kde.org/applications/graphics/org.kde.kruler
We may want to move it to the kdeutils group.
@dakon What do you think?
If it would be "move it out of extragear, where will we place it" I would say kdeutils is fine. But it seems to sit in KDE Applications for quite a while, so I'm unsure if moving it to another module does more confusion than benefit. After all, if you say it helps if it's in utils, I'll welcome it as it would fit IMHO. I'm just not convinced (yet?) that the move provides a benefit in itself.
@elvisangelaccio Would one also have to change the category here (https://phabricator.kde.org/source/kde-build-metadata/browse/master/logical-module-structure$246) in addition to the repo-metadata, or is that done automatically by some script?
This patch will change it's location in the desktop Application menu (Kickoff etc). It will also change its location on kde.org/applications website (which gets updated by a nightly job on binary-factory). It will show in a different category in Discover and maybe other app stores.
The categories in repo-metadata are not used anywhere I'm aware of.
I disagree with this change, why is it an Utility and not a graphics program?
Also can you explain why you decided to drop the X-KDE-More?
The categories in repo-metadata are not used anywhere I'm aware of.
They are used at least for l10n subdirectory
I removed it because I didn't think it was necessary, but I can add it back if you think that would be better. I just don't understand the advantage of having the 'more applications' submenu in the various categories of the applications menu, especially when there doesn't seem to be any well-defined criterion for putting an application there, and non-KDE applications don't seem to use it anyway.
Because it's a support tool you use for accomplishing some other task, not something you use for its own functionality independent ofwhatever else you're doing. It's a utility in the same way Spectacle is a utility.
Please re-add the X-KDE-More; bit as that's unrelated to this change. If we really need to do that, let's do it in a separate patch.
I would suggest to not change the internal category and keep in under the "kdegraphics" group. Spectacle has been already mentioned: graphical tool, it shows in the "Utility" section.
Thanks, looks good to me now. Let's keep this open for a few days to see if anyone else has any remaining comments, then land it.
I'm going to say something wild, can we have it in both categories so you don't break the workflow of people that know kruler has been in Applications->Graphics for years?
Kmail also does something similar (it appears in both 'Office' and 'Internet' categories).
Just committed this with Albert's suggested change in https://invent.kde.org/graphics/kruler/commit/6cde990b68438aea2dc13199b846fdc37457b52a.