It is functional on the desktop as well and provides a place for controls for desktop to desktop features (e.g. MprisRemote, LockPlugin) and controls for non-Plasma desktops (e.g. Remotekeyboard, not yet implemented)
Details
- Reviewers
apol sredman - Group Reviewers
KDE Connect - Commits
- R224:f1b0d016ab7c: Always build Kirigami app
Builds
Diff Detail
- Repository
- R224 KDE Connect
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
This builds and runs for me (once I install the KF5 Declarative package)
Is it going to cause a problem for the Windows build? I see that Harbormaster has said that everything is good but I don't know how to check if this means Windows is good as well :)
Harbormaster is not (yet) integrated with build.kde.org, but the CI has been building the app since a few months without causing problems. I don't see the recent build failure on Windows related to it
Does it work for you to:
- Pull this patch
- Run cmake in a fresh directory
- make
- Run bin/kcapp?
When I do this, I get the errors:
QQmlApplicationEngine failed to load component qrc:/qml/main.qml:38 Type FindDevicesPage unavailable qrc:/qml/FindDevicesPage.qml:55 Cannot assign object to property
This might be my fault, but the thing I noticed is on my laptop, where I had previously set EXPERIMENTALAPP_ENABLED to ON in cmake, the app launched, and on my home computer the app did not launch (I think with this same error message, but I actually didn't look that carefully...)
However, if I follow these steps on my laptop, the app does not launch.
Actually, it doesn't look like the fresh directory is necessary. On my laptop, in the regular build directory, I get the same error after running make clean
@sredman it works for me. The application needs some polishing though.
I don't mind whether we install it by default or not for now.
Sorry it took me so long to look in to this.
The commit which breaks the app for me is b4b48b97d627fccf44ea392dad0a3c8b4d4cf6ca. Very probably the issue is just that I don't have a recent enough version of the relevant library.
I did not have the qt5-qtquickcontrols2-devel package installed. After installing this, it seems to be fine (and I can build and run master). Missing dependency?
find_package(Qt5QuickControls2 REQUIRED)
CMakeLists.txt | ||
---|---|---|
90–91 | There is no kirigami on sailfish (until 3.0 atleast...) so best to make thie if(not ......) also, what about win32? |
It needs the dependency on qt5-quickcontrols2
find_package(Qt5QuickControls2 REQUIRED)