Change Details

I've already made some preparation for bundling a static build of FFmpeg into the Windows installers (and zip packages). I intend to use the builds from here: https://ffmpeg.zeranoe.com/builds/ (the 4.0 static builds for Windows 64-bit or 32-bit depending on build target). Only ffmpeg.exe and the README/LICENSE text files are to be included. I've tried with the 64-bit build: bundling FFmpeg adds 14.6MB to the installer. When it is actually installed, it uses up 59.5MB of disk space. I have a few questions before proceeding: 1. Should it be bundled with the installer and packages (i.e. should I proceed with this task)? 2. Should the FFmpeg component be an optional choice in the installer? Should it be selected by default? (Alvin: I think it should be selected by default but can be deselected by the user.) 3. Are there any licensing implications? (It is GPLv3 so it should be fine?) Do I need to add any additional license text to the installer? (The installer already contains a GPLv3 text but that specifically refers to Krita.) 4. Are there any other issues with doing this?

I've already made some preparation for bundling a static build of FFmpeg into the Windows installers (and zip packages). I intend to use the builds from here: https://ffmpeg.zeranoe.com/builds/ (the 4.0 static builds for Windows 64-bit or 32-bit depending on build target). Only ffmpeg.exe and the README/LICENSE text files are to be included. I've tried with the 64-bit build: bundling FFmpeg adds 14.6MB to the installer. When it is actually installed, it uses up 59.5MB of disk space. I have a few questions before proceeding: 1. Should it be bundled with the installer and packages (i.e. should I proceed with this task)? 2. Should the FFmpeg component be an optional choice in the installer? Should it be selected by default? (Alvin: I think it should be selected by default but can be deselected by the user.) 3. Are there any licensing implications? (It is GPLv3 so it should be fine?) Do I need to add any additional license text to the installer? (The installer already contains a GPLv3 text but that specifically refers to Krita.) 4. Should it still be downloaded in the 3rdparty dependency build like other deps? 5. Should @rempt make a zip with only ffmpeg.exe and the README/LICENSE text files (for each of 32-bit and 64-bit) to files.kde.org, or should I have CMake download the complete static build zip file? 6. Are there any other issues with doing this?

I've already made some preparation for bundling a static build of FFmpeg into the Windows installers (and zip packages). I intend to use the builds from here: https://ffmpeg.zeranoe.com/builds/ (the 4.0 static builds for Windows 64-bit or 32-bit depending on build target). Only ffmpeg.exe and the README/LICENSE text files are to be included. I've tried with the 64-bit build: bundling FFmpeg adds 14.6MB to the installer. When it is actually installed, it uses up 59.5MB of disk space. I have a few questions before proceeding: 1. Should it be bundled with the installer and packages (i.e. should I proceed with this task)? 2. Should the FFmpeg component be an optional choice in the installer? Should it be selected by default? (Alvin: I think it should be selected by default but can be deselected by the user.) 3. Are there any licensing implications? (It is GPLv3 so it should be fine?) Do I need to add any additional license text to the installer? (The installer already contains a GPLv3 text but that specifically refers to Krita.) 4. Should it still be downloaded in the 3rdparty dependency build like other deps? 5. Should @rempt make a zip with only ffmpeg.exe and the README/LICENSE text files (for each of 32-bit and 64-bit) to files.kde.org, or should I have CMake download the complete static build zip file? 6. Are there any other issues with doing this?