We need an internal colour selector, so that we can allow filters and the like to access wide gamut colours.
I am not supossed to touch T2337 anymore due GSOC regulations, so this goes here:
Okay, so this gsoc I got the following done:
* softproofing, per image, per view.
* gamut-warnings.
* adaptation state slider.
* Configuration is stored within the kra file.
* a default setup in the settings, but the actual configuration is in image properties.
* OCIO look support.
* a spinbox selector that can select HDR and wide gamut values without hassle.
* an onscreen color picker
* a fancy wide-gamut color selector.
* a dialog that combines these things into a nice little UI file. Working both modally and non-modally.
Bugs:
* ~~The HSV and HSL modes do something weird with grayscale values. The result seems to give actual colors, but I have no clue what is causing either error.~~
** ~~HSL is now fixed, but HSV has an error in the actual conversion, I think.~~ Was an 'undefined' value [done]
* ~~I can't seem to get the display renderer updating to work properly.~~ [done]
Other priority todos:
* Figure out inheritance mess, and then stick this/these widgets everywhere.
** ~~libs/ui/layerstyles/WdgColorOverlay.ui~~
** ~~libs/ui/layerstyles/WdgSatin.ui~~
** ~~libs/ui/layerstyles/WdgStroke.ui~~
** ~~libs/ui/layerstyles/wdgBevelAndEmboss.ui~~
** ~~libs/ui/layerstyles/wdgInnerGlow.ui~~
** ~~libs/ui/layerstyles/wdgdropshadow.ui~~
** ~~plugins/dockers/animation/onion_skins_docker.ui~~
** plugins/dockers/griddocker/grid_config_widget.ui
** plugins/extensions/gmic/kis_gmic_settings_widget.cpp
** plugins/filters/indexcolors/kiswdgindexcolors.cpp
** plugins/filters/indexcolors/kiswdgindexcolors.h
** plugins/flake/textshape/dialogs/CharacterHighlighting.ui
** plugins/flake/textshape/dialogs/FontDecorations.ui
** plugins/flake/textshape/dialogs/ParagraphDecorations.ui
** plugins/generators/pattern/wdgpatternoptions.ui
** plugins/impex/jpeg/kis_wdg_options_jpeg.ui
** plugins/impex/png/kis_wdg_options_png.ui
** ~~libs/ui/dialogs/kis_dlg_image_properties.cc~~
** ~~libs/ui/dialogs/kis_dlg_image_properties.h~~
** ~~libs/ui/dialogs/kis_dlg_preferences.cc~~
** ~~libs/ui/dialogs/kis_dlg_preferences.h~~
** ~~libs/ui/recorder/kis_recorded_paint_action_editor.cc~~
** ~~libs/ui/recorder/kis_recorded_paint_action_editor.h~~
** libs/widgets/CMakeLists.txt
** libs/widgets/KoColorPopupAction.cpp
** libs/widgets/KoColorPopupAction.h
** libs/widgets/KoFillConfigWidget.cpp
** libs/widgets/KoGradientEditWidget.cpp
** libs/widgets/KoGradientEditWidget.h
** libs/widgets/KoShadowConfigWidget.cpp
** libs/widgets/KoStrokeConfigWidget.cpp
** plugins/dockers/digitalmixer/digitalmixer_dock.cc
** plugins/dockers/digitalmixer/digitalmixer_dock.h
** plugins/flake/textshape/TextTool.cpp
** plugins/flake/textshape/TextTool.h
** plugins/flake/textshape/dialogs/SimpleTableWidget.cpp
** plugins/tools/karbonplugins/filtereffects/FloodEffectConfigWidget.cpp
** plugins/tools/karbonplugins/filtereffects/FloodEffectConfigWidget.h
Missing elements:
* ~~Hex code input.~~ [DONE]
* ~~Palette input. I wasn't too sure how to tackle this one yet.~~
** ~~It seems QColorDialog has a public function to access it's custom colors, might be useful to pull that from the system into s KoColorSet sometime.~~ - > We decided it wasn't necessary.
* OCIO widget: I need more time for this.
Other:
* ~~The visual color selector has a class named 'visual color selector shape' which deals with all the painting and that is then subclasses by the rectangle shape. We can thus extend this easily to other shapes.~~
* ~~That would mean we could replace the pop-up triangle with a wide-gamut variant too.~~ [DONE]
* ~~The visual color selector is capable of a lot of things, but there's no gui for configuring this yet, and I think we'd need to sit down and think a bit about this.~~ [DONE] (Uses the advanced color selector config)