Change Details

We currently get the following sequence of calls: KDEPlatformFileDialogHelper::setDirectory QUrl("sftp://server/home/alr48/cheri/build_sdk.sh") KDEPlatformFileDialogHelper::setDirectory QUrl("sftp://server/home/alr48/cheri/build_sdk.sh") KDEPlatformFileDialogHelper::selectFile QUrl("file:///home/alex/build_sdk.sh") KDEPlatformFileDialogHelper::setDirectory QUrl("file:///home/alex/) Previously KDEPlatformFileDialogHelper::selectFile() would change options()->initialDirectory() unconditionally even if it was already set by the QFileDialog code. The final setDirectory() call is actually a call to setDirectory(options->initialDirectory()) which was set in the selectFile() call. It no longer seems to be required to derive initialDirectory from the selectFile() call and this will now to override the correct initial directory that was set by Qt. Qt should not be passing a local URL when the actual directory URL is remote but the code in QFileDialogPrivate::init() unconditionally sets a local URL until https://codereview.qt-project.org/#/c/182661/ or another fix is submitted. BUG: 374913

Previously KDEPlatformFileDialogHelper::selectFile() would change options()->initialDirectory() unconditionally even if it was already set by the QFileDialog code. Since Qt 5.7.1 it is no longer necessary to derive initialDirectory from the selectFile() call. In fact it is actuall harmful since it will now override the correct initial directory that was set by Qt. Without this patch I got the following debug output: ``` KDEPlatformFileDialogHelper::setDirectory QUrl("sftp://server/home/alr48/cheri/build_sdk.sh") KDEPlatformFileDialogHelper::setDirectory QUrl("sftp://server/home/alr48/cheri/build_sdk.sh") KDEPlatformFileDialogHelper::selectFile QUrl("file:///home/alex/build_sdk.sh") KDEPlatformFileDialogHelper::setDirectory QUrl("file:///home/alex/) ``` The final setDirectory() call is actually a call to `setDirectory(options->initialDirectory())` which was set in `selectFile()`. To completely fix selection of remote URLs this also depends on https://codereview.qt-project.org/#/c/182661/ which is now in the 5.9 branch of Qt and should be part of the next 5.9 point release and 5.11. We now depend on Qt 5.9 so we can remove this code without a check for version >= 5.7.1. BUG: 374913

We currently get the following sequence of calls: KDEPlatformFileDialogHelper::setDirectory QUrl("sftp://server/home/alr48/cheri/build_sdk.sh")Previously KDEPlatformFileDialogHelper::selectFile() would change options()->initialDirectory() unconditionally even if it was already set by the QFileDialog code. Since Qt 5.7.1 it is no longer necessary KDEPlatformFileDialogHelper::setto derive initialDirectory QUrl("sftp://server/home/alr48/cheri/build_sdk.sh")from the selectFile() call. In fact it is KDEPlatformFileDialogHelper::selectFile QUrl("file:///home/alex/build_sdk.sh")actuall harmful since it will now override the correct initial directory KDEPlatformFileDialogHelper::setDirectory QUrl("file:///home/alex/)that was set by Qt. Without this patch I got the following debug output: Previously ``` KDEPlatformFileDialogHelper::selectFile() would changetDirectory QUrl("sftp://server/home/alr48/cheri/build_sdk.sh") options()->initialKDEPlatformFileDialogHelper::setDirectory() unconditionally even if it was already QUrl("sftp://server/home/alr48/cheri/build_sdk.sh") set by the QKDEPlatformFileDialog code. The final setDirectory() call is actually a callHelper::selectFile QUrl("file:///home/alex/build_sdk.sh") to setDirectory(options->initialKDEPlatformFileDialogHelper::setDirectory()) which was set in the selectFile( QUrl("file:///home/alex/) call. It no longer seems to be required to derive initialDirectory from the``` selectFile() call and this will now to override the correct initial directoryThe final setDirectory() call is actually a call to that was set by Qt.`setDirectory(options->initialDirectory())` which was set in `selectFile()`. To completely fix selection of remote URLs this also depends on Qt should not be passing a local URL when the actual directory URL is remotehttps://codereview.qt-project.org/#/c/182661/ which is now in the 5.9 but the code in QFileDialogPrivate::init() unconditionally sets a local URLranch of Qt and should be part of the next 5.9 point release and 5.11. We now depend on Qt 5.9 so we can remove this code without a check for until https://codereview.qt-project.org/#/c/182661/ or another fix is submittedversion >= 5.7.1. BUG: 374913