Change Details

Porting the Fonts KCM to QML in 24b960f92284 set the state of the font preview labels to `disabled`, resulting in a light gray text with too little contrast to enable a usable preview of the chosen font. In the `QWidgets` based KCM the following code was used: QLabel::setFrameStyle(QFrame::StyledPanel | QFrame::Sunken) As that property is not available from QML, we reset the text colour to solve the problem. It's still not using the proper frame colour, though, but that does not seem like too much of an issue. Alternatively we could use a `Frame` and a `Label`, but this approach has even more problems, e.g. the frame does not respect the rounded border mandated by Breeze, and the horizontal alignment of each row would need to be adapted.

Porting the Fonts KCM to QML in 24b960f92284 set the state of the font preview labels to `disabled`, resulting in a light gray text with too little contrast to enable a usable preview of the chosen font. In the `QWidgets` based KCM the following code was used: QLabel::setFrameStyle(QFrame::StyledPanel | QFrame::Sunken) As that property is not available from QML, we use an alternative approach by setting the state to `readOnly`. To also indicate visually that nothing can be typed into the textedit, we add `Kirigami.Theme.inherit: true` which results in changing the background from white to grey.

Porting the Fonts KCM to QML in 24b960f92284 set the state of the font preview labels to `disabled`, resulting in a light gray text with too little contrast to enable a usable preview of the chosen font. In the `QWidgets` based KCM the following code was used: QLabel::setFrameStyle(QFrame::StyledPanel | QFrame::Sunken) As that property is not available from QML, we reset the text colour to solve the problem. It's still not using the proper frame colour, though,we use an alternative but that does not seem like too much of an issue. Alternatively we could use a `Frame` and a `Label`,approach by setting the state to `readOnly`. but this approachTo also indicate has even more problems, e.g.visually that nothing can be typed into the textedit, the frame does not respect the roundedwe add border mandated by Breeze, and the horizontal alignment of each row`Kirigami.Theme.inherit: true` which results in changing the would need to be adaptedbackground from white to grey.