Change Details

We receive many complaints and bug reports about the current UI for adjusting panel thickness. People don't figure out that they have to drag on the button, and when they do, they complain that they can't set the value finely enough. Furthermore there are some bugs with scrolling and dragging behavior. This patch removes the draggable button and replaces it with a more conventional SpinBox, this is given scroll-adjustment behaviors in D29534. This yields the following improvements: - The way you adjust panel thickness is now more obvious - Fine-tuning panel thickness is now easier - Panel thickness can now be specified numerically - We have one fewer custom control to maintain - Bugs in custom scrolling implementation go away The current click/touch-and-drag behavior is therefore removed. I think this is acceptable because it's not a very good match for this use case anyway; a drag-based UI favors large changes where precision of the final result is not important. This does not describe the panel adjustment use case where you are changing the value by at most a few dozen and very commonly just want to adjust it up or down a tiny amount or want to end up at a specific size. Touch friendliness is maintained because this SpinBox has an inherently touch-friendly design with large touchable buttons that can be held down to quickly adjust the value. I wouldn't mind using this design elsewhere too; see T9460 BUG: 414045 BUG: 418700 BUG: 421169 FIXED-IN: 5.19

We receive many complaints and bug reports about the current UI for adjusting panel thickness. People don't figure out that they have to drag on the button, and when they do, they complain that they can't set the value finely enough. Furthermore there are some bugs with scrolling and dragging behavior. This patch removes the draggable button and replaces it with a more conventional SpinBox, which in D29534. is given ability to adjust the values by scrolling over it or clicking and dragging. This yields the following improvements: - The way you adjust panel thickness is now more obvious - The existing drag-to-adjust behavior is much nicer and less buggy - Panel thickness can now be specified numerically - Fine-tuning panel thickness is now easier using any adjustment method - We have one fewer custom control to maintain - Bugs in custom scrolling implementation go away Touch friendliness is maintained because this SpinBox has an inherently touch-friendly design with large touchable buttons that can be held down to quickly adjust the value, and touch-and -drag still works after D29534 is applied. I wouldn't mind using this SpinBox design elsewhere too; see T9460. BUG: 414045 BUG: 418700 BUG: 421169 FIXED-IN: 5.19

We receive many complaints and bug reports about the current UI for adjusting panel thickness. People don't figure out that they have to drag on the button, and when they do, they complain that they can't set the value finely enough. Furthermore there are some bugs with scrolling and dragging behavior. This patch removes the draggable button and replaces it with a more conventional SpinBox, thiswhich in D29534. is given scroll-ability to adjustment behaviors in D29534t the values by scrolling over it or clicking and dragging. This yields the following improvements: - The way you adjust panel thickness is now more obvious - Fine-tun- The existing panel thickness is now easierdrag-to-adjust behavior is much nicer and less buggy - Panel thickness can now be specified numerically - We have one fewer custom control to maintain - Bugs in custom scrolling implementation go away The current click/touch-and-drag behavior is therefore removed. I think this is acceptableFine-tuning panel thickness is now easier using any adjustment method because it's not a very good match for this use case anyway; a drag-based UI favors large- We have one fewer custom control to maintain changes where precision of the final result is not important. This does not describe the panel adjustment use case where you are changing the value by at most a few dozen and very- Bugs in custom scrolling implementation go away Touch friendliness is maintained because this SpinBox has an inherently touch-friendly design commonly just want to adjust it up orwith large touchable buttons that can be held down a tiny amount or want to end up at a specificto quickly adjust the value, and touch-and size-drag still works after D29534 is applied. Touch friendliness is maintained because this SpinBox has an inherently touch-friendly design with large touchable buttons that can be held down to quickly adjust the value. I wouldn't mind using thisI wouldn't mind using this SpinBox design elsewhere too; see T9460. BUG: 414045 BUG: 418700 BUG: 421169 FIXED-IN: 5.19