Change Details

Remove the global search bar and allows each tab to have it's own search. For this I created a new class TerminalWidget - that's the combination of the TerminalDisplay and SearchBar, and extracted the uses of TermianlDisplay and SearchBar that where scattered around the code, making the resulting code less tangled. Testing: created tabs, created search boxes, searched, closed.

Now, this review is probabely way bigger than I wanted as it touches too many things to make it work. The old searchbar had some issues as it made the text jump around if programs that refreshed the screen where used (like top, htop or any curses application) and after a few round of reviews we got to the conclusion that it was better that the search behaved a bit like chrome: be smaller and on top of the TerminalDisplay instead of being added in a QLayout. To simplify positioning and maintenance removed the global search bar and now every TerminalDisplay has it's own searchbar that's setup only once, for this there's a new class TerminalWidget that holds the TerminalDisplay and the SearchBar and positions them. Tests done: - Open multiple tabs and open the search bar, test the search in multiple tabs. - Open / close tabs while top is running - Delete the konsole configuration and test the window size - Mark "don't save window size" and test the new window size - Drag & drop the terminal from a tab to detach a view Known issues: - If the tab detached had search enabled, the search will be disabled and you need to search again - If you have multiple tabs and splits ctrl + shift + f will complain about multiple shortcuts

RemoveNow, this review is probabely way bigger than I wanted as it touches too many things to make it work. The old searchbar had some issues as it made the text jump around if programs that refreshed the screen where used (like top, htop or any curses application) and after a few round of reviews we got to the conclusion that it was better that the search behaved a bit like chrome: be smaller and on top of the TerminalDisplay instead of being added in a QLayout. To simplify positioning and maintenance removed the global search bar and allows each tab to havenow every TerminalDisplay has it's own search.hbar that's setup only once, Ffor this I created a news there's a new class TerminalWidget that holds the TerminalDisplay and the SearchBar and positions them. Tests done: class TerminalWidget - that's- Open multiple tabs and open the search bar, test the combination ofsearch in multiple tabs. the TerminalDisplay and SearchBar, and extracted- Open / close tabs while top is running the uses of TermianlDisplay- Delete the konsole configuration and SearchBar thattest the window size where scattered around the code, making- Mark "don't save window size" and test the resultingnew window size code less tangled.- Drag & drop the terminal from a tab to detach a view Testing:Known issues: - If the tab detached had search enabled, the search will be disabled and you need to search again created- If you have multiple tabs, created search boxes, searched, closed.s and splits ctrl + shift + f will complain about multiple shortcuts