Change Details

When a user tries to set operation mode to "Times", the Apply button remains enabled after it's been clicked. The reason for that is timings provided by the kcm include seconds and milliseconds, while timings sent by KWin don't. Because seconds and milliseconds are different, CompositorAdapter:: checkStaged() will return false even though hours and minutes haven't been modified by the user. In order to address this problem, my patch adjusts the TimeField component so it provides Date objects with seconds and milliseconds set to 0. There is another way to fix this issue though. We could check whether only hours and minutes have been changed in checkStaged() method.

When a user tries to set operation mode to "Times", the Apply button remains enabled after it's been clicked. The reason for that is timings provided by the kcm include seconds and milliseconds, while timings sent by KWin don't. Because seconds and milliseconds are different, CompositorAdapter:: checkStaged() will return false even though hours and minutes haven't been modified by the user. In order to address this problem, my patch adjusts the TimeField component so it provides Date objects with seconds and milliseconds set to 0. There is another way to fix this issue though. We could check in CompositorAdaptor::checkStaged() method whether only hours and minutes have been modified.

When a user tries to set operation mode to "Times", the Apply button remains enabled after it's been clicked. The reason for that is timings provided by the kcm include seconds and milliseconds, while timings sent by KWin don't. Because seconds and milliseconds are different, CompositorAdapter:: checkStaged() will return false even though hours and minutes haven't been modified by the user. In order to address this problem, my patch adjusts the TimeField component so it provides Date objects with seconds and milliseconds set to 0. There is another way to fix this issue though. We could check in CompositorAdaptor::checkStaged() method whether only hours and whether only hours and minutes have been changed in checkStaged() methodmodified.