Change Details

The Dim Inactive effect sees the world a little bit differently. m_activeWindow is currently active window that can be dimmed later on. In most cases, it's the same as effects->activeWindow(). In rare cases, it can be nullptr(e.g. when active window is a context menu popup) even when effects->activeWindow() is not equal to nullptr. canDimWindow is a helper that returns true if a given window should be dimmed, otherwise it returns false. It has one special case: if a given window is equal to m_activeWindow, return false. I.e. don't dim active windows. Currently, if user changes config of this effect, active window becomes dimmed. The reason for that is we hit that special case when deciding whether effects->activeWindow() should be m_activeWindow. This change addresses that problem by resetting m_activeWindow so we don't hit that special case.

The Dim Inactive effect sees the world a little bit differently. m_activeWindow is currently active window that can be dimmed later on. In most cases, it's the same as effects->activeWindow(). In rare cases, it can be nullptr, even when effects->activeWindow() is not equal to nullptr (e.g. when active window is a context menu popup). canDimWindow is a helper that returns true if a given window should be dimmed, otherwise it returns false. It has one special case: if a given window is equal to m_activeWindow, return false. I.e. don't dim active windows. Currently, if user changes config of this effect, active window becomes dimmed. The reason for that is we hit that special case when deciding whether effects->activeWindow() should be m_activeWindow. This change addresses that problem by resetting m_activeWindow so we don't hit that special case.

The Dim Inactive effect sees the world a little bit differently. m_activeWindow is currently active window that can be dimmed later on. In most cases, it's the same as effects->activeWindow(). In rare cases, it can be nullptr(e.g., even when effects->active wWindow() is a context menu popup)not equal to nullptr even(e.g. when effects->activeW window() is not equal to nullptra context menu popup). canDimWindow is a helper that returns true if a given window should be dimmed, otherwise it returns false. It has one special case: if a given window is equal to m_activeWindow, return false. I.e. don't dim active windows. Currently, if user changes config of this effect, active window becomes dimmed. The reason for that is we hit that special case when deciding whether effects->activeWindow() should be m_activeWindow. This change addresses that problem by resetting m_activeWindow so we don't hit that special case.