Change Details

As noted by asensi in D11898 shift is erroneously being filtered out. This patch fixes that. I decided that if the user types a capital letter then we should only match entries that have the same case for the entire string. E.g typing 'hamBurglar' will not match 'HamBurglar' but typing 'hamburglar' or 'HamBurglar' will. This allows quicker access too bookmarks with capital letters. Eg with the bookmarks 'HamBurglar' and 'hamhorder' the user can type 'H' and instantly match 'HamBurglar'. Requiring the user to either match all case or none of it feels both fair and easy for the user to understand. Matching things with a partial case matches feels like it will cause too much confusion. For example should typing hamBurglar match 'HamBurglar' and 'hamBurglar'? What about the case when there is only the 'HamBurglar' bookmark should it match it then? Etc.

As noted by asensi in D11898 shift is erroneously being filtered out. This patch fixes that. I decided that if the user types a capital letter then we should only match entries that have the same case for the entire string. E.g typing 'hamBurglar' will not match 'HamBurglar' but typing 'hamburglar' or 'HamBurglar' will. This allows quicker access too bookmarks with capital letters. Eg with the bookmarks 'HamBurglar' and 'hamhorder' the user can type 'H' and instantly match 'HamBurglar'. Requiring the user to either match all case or none of it feels both fair and easy for the user to understand. Matching things with a partial case matches feels like it will cause too much confusion. For example should typing hamBurglar match 'HamBurglar' and 'hamBurglar'? What about the case when there is only the 'HamBurglar' bookmark should it match it then? Etc.

As noted by asensi in D11898 shift is erroneously being filtered out. This patch fixes that. I decided that if the user types a capital letter then we should only match entries that have the same case for the entire string. E.g typing 'hamBurglar' will not match 'HamBurglar' but typing 'hamburglar' or 'HamBurglar' will. This allows quicker access too bookmarks with capital letters. Eg with the bookmarks 'HamBurglar' and 'hamhorder' the user can type 'H' and instantly match 'HamBurglar'. Requiring the user to either match all case or none of it feels both fair and easy for the user to understand. Matching things with a partial case matches feels like it will cause too much confusion. For example should typing hamBurglar match 'HamBurglar' and 'hamBurglar'? What about the case when there is only the 'HamBurglar' bookmark should it match it then? Etc.