Change Details

SimpleKCM currently imposes a maximum height of `Kirigami.Units.gridUnit * 20`, which is arbitrary and results in many KCMs opened standalone in kcmshell still getting a scrollbar even when there's plenty of vertical space available. This patch changes the maximum value so that it's based on a fraction of the available screen height, ensuring that tall KCMs will fill the available space as often as possible. CCBUG: 398820

SimpleKCM currently calculates the height of its page incorrectly in a few ways: - `flickable.contentHeight`, which determines the base height, always gets set to 0 - Paddings and headers aren't taken into account - There's an arbitrary maximum height of `Kirigami.Units.gridUnit * 20` This patch takes paddings and headers into account, and changes the maximum height so that it's based on a fraction of the available screen height, ensuring that tall KCMs will fill the available space as often as possible. RFC because `flickable.contentHeight` always evaluates to 0 and I can't figure out why. BUG: 398820 FIXED-IN: 5.58

SimpleKCM currently imposes a maximumcalculates the height of `Kirigami.Units.gridUnit * 20`its page incorrectly in a few ways: - `flickable.contentHeight`, which determines the base height, which isalways gets set to 0 arbitrary- Paddings and results in many KCMs opened standalone in kcmshell still getting a scrollbarheaders aren't taken into account even when there's plenty- There's an arbitrary maximum height of vertical space available.`Kirigami.Units.gridUnit * 20` This patch takes paddings and headers into account, and changes the maximum value height so that it's based on a fraction of the available screen height, ensuring that tall KCMs screen height, ensuring that tall KCMs will fill the available space as often as possible. RFC because `flickable.contentHeight` always evaluates to 0 and I can't figure out why. CCBUG: 398820 FIXED-IN: 5.58