Change Details

In IdealLayout, because of buttonSpacing not being considered while checking if the buttons should be shrinked, D15450 causes division by zero, this commit removes the assumption and checks before dividing. BUG: 398790

Fixed two causes identified for the regression introduced in D15450: - In IdealLayout, buttonSpacing not being considered while checking if a button should be shrinked. Changed this to properly account for spacing. - minimumSize in Ideal Layout calls doVerticalLayout with a height of zero, the property is always 0. Re-implemented (also previously commented as buggy) by accumulating the also newly added `minimumSize` in the IdealToolButton, along with setting the size policy to Preferred for correctness. - Boilerplate to avoid this crash in the future, if the calculation still missed something, or possibly due to some exotic theme settings. BUG: 399025

In IdealLayoutFixed two causes identified for the regression introduced in D15450: - In IdealLayout, buttonSpacing not being considered while checking if a button should be shrinked. Changed this to properly account for spacing. - minimumSize in Ideal Layout calls doVerticalLayout with a height of zero, the property is always 0. Re-implemented (also previously commented as buggy) by accumulating the also newly added `minimumSize` in the IdealToolButton, because of buttonSpacing not being considered whilealong with setting the size policy to Preferred for correctness. checking if the buttons should be shrinked- Boilerplate to avoid this crash in the future, D15450 causes division by zeroif the calculation still missed something, this commit removes the assumption and checks before dividing.or possibly due to some exotic theme settings. BUG: 3987909025