Change Details

see https://bugs.kde.org/show_bug.cgi?id=291835#c57 for background - reading now happens inside a future. should be safe since we don't have any other threads doing anything while we wait. - the future feeds into a buffer from which the main thread will take file segments and write them to disk - buffer has 4 segments and synchronizes the threads via wait conditions - the size of a segment is determined somewhat dynamically between 64kb and 4mb. the larger a file is the more it benefits from larger read requests under perfect conditions this yields approximately mount-level copy performance, unfortunately those are hard to hit so on average it's usually less (somewhere in the range of 10 to 20% depending on the actual file size and server type). compared to the old code this should more or less always be 100% faster for large files. multiple small files should see an equal improvement from what I've seen copying my kio-extras dir around. for some reason gains seem much greater against win10 servers, though that may be because the test systems I've set up are not having equivalent IO capabilities. in general, all of the above only applies to cases where the server's disk output will be able to saturate the request volume.

see https://bugs.kde.org/show_bug.cgi?id=291835#c57 for background - reading now happens inside a future. should be safe since we don't have any other threads doing anything while we wait. - the future feeds into a buffer from which the main thread will take file segments and write them to disk - buffer has 4 segments and synchronizes the threads via wait conditions - the size of a segment is determined somewhat dynamically between 64kb and 4mb. the larger a file is the more it benefits from larger read requests under perfect conditions this yields approximately mount-level copy performance, unfortunately those are hard to hit so on average it's usually less (somewhere in the range of 10 to 20% depending on the actual file size and server type). for many tiny files performance is about where it was before. the larger the files get the greater the gains from this diff though. specifically here's some samples I've taken: - for downloads from windows10 - 1G & 4G file - compared to 20.04 is ~77% faster - within 10% of windows - 8G file - compared to 20.04 is ~79% faster - within 5% of windows - uploads to windows10 - all sizes - compared to 20.04 is ~50% faster - now comparable performance to windows - for remote-to-remote file copies from windows10 to smbd 4.11.6 - 1000 x 5K files - no change, dreadfully slow, likely problem in KIO internals - 1G file - compared to 20.04 is ~45% faster - within 8% of windows - 4G file - compared to 20.04 is ~95% faster - and somehow 18% faster than windows (could be a fluke) I've done transfers for 128M, 256M, 512M, 1G, 4G and partially 8G. Differences not mentioned are either unchanged or negligible.

see https://bugs.kde.org/show_bug.cgi?id=291835#c57 for background - reading now happens inside a future. should be safe since we don't have any other threads doing anything while we wait. - the future feeds into a buffer from which the main thread will take file segments and write them to disk - buffer has 4 segments and synchronizes the threads via wait conditions - the size of a segment is determined somewhat dynamically between 64kb and 4mb. the larger a file is the more it benefits from larger read requests under perfect conditions this yields approximately mount-level copy performance, unfortunately those are hard to hit so on average it's usually less (somewhere in the range of 10 to 20% depending on the actual file size and server type). compared to the old code this should more or less alwayfor many tiny files performance is about where it was be 100% faster forfore. the larger large files.the files get the greater the gains from this diff though. specifically here's some samples I've taken: multiple small files should see an equal improvement from what I've seen- for downloads from windows10 - 1G & 4G file - compared to 20.04 is ~77% faster - within 10% of windows - 8G file - compared to 20.04 is ~79% faster - within 5% of windows - uploads to windows10 - all sizes - compared to 20.04 is ~50% faster - now comparable performance to windows - for remote-to-remote file copies from windows10 to smbd 4.11.6 - 1000 x 5K files - no change, dreadfully slow, likely problem in KIO internals copying my kio-extras dir around. for some reason gains seem much greater against win10 servers, though that - 1G file - compared to 20.04 is ~45% faster may be because the test systems I've set up are not having equivalent IO - within 8% of windows capabilities. in general, all of the above only applies - 4G file - compared to cases where the server's disk20.04 is ~95% faster output will be able to saturate the request volum - and somehow 18% faster than windows (could be a fluke) I've done transfers for 128M, 256M, 512M, 1G, 4G and partially 8G. Differences not mentioned are either unchanged or negligible.