Change Details

KRemoteEncoding::directory() returns the encoded path of the directpry, while Ftp::ftpFolder() takes the un-encoded version. The implicit casting from QByteArray via QString::fromUtf8 to the QString type for the Ftp::ftpFolder() arg blocked the compiler from complaining about that coding mismatch. Possibly also non-latin1 characters being rare with ftp server directory layouts prevented this bug being hit so far.

KRemoteEncoding::directory() returns the encoded path of the directpry, while Ftp::ftpFolder() takes the un-encoded version. The implicit casting from QByteArray via QString::fromUtf8 to the QString type for the Ftp::ftpFolder() arg prevented the compiler from complaining about that coding mismatch. This principle code issue might have been hidden all the years due to non-latin1 characters being rare with ftp server directory layouts. More, most ftp servers are using UTF-8 encoding , so the implicit cast via QString::fromUtf8 by accident was matching what the explicit cast via remoteEncoding()->decode() in such cases is doing. This patch makes the code correct and also working for any theoretical ftp servers which use a non-latin1/utf8 encoding.

KRemoteEncoding::directory() returns the encoded path of the directpry, while Ftp::ftpFolder() takes the un-encoded version. The implicit casting from QByteArray via QString::fromUtf8 to the QString type for the Ftp::ftpFolder() arg blockedprevented the compiler from complaining about that coding mismatch. This principle code issue might have been hidden all the years due to non-latin1 characters being rare with ftp server directory layouts. More, most ftp servers are using UTF-8 encoding , so the implicit cast via QString::fromUtf8 by accident was matching what the explicit cast via remoteEncoding()->decode() that coding mismin such cases is doing. This patch. Possibly also non-latin1 characters being rare with makes the code correct and also working for any theoretical ftp ftp server directory layouts prevented this bug being hit so fars which use a non-latin1/utf8 encoding.