Home
Phabricator
Search
Log In
Transactions
D23106
Change Details
Change Details
Old
New
Diff
{F7205336} {F7208763} What works: - {nav Save} and {nav Save As} for non-JPEG images being saved in non-JPEG formats. No regressions. - {nav Save} or {nav Save As} for JPEG image that is changed in some way (e.g. cropped) - {nav Save As} for non-JPEG image being saved as JPEG What does not yet work: - {nav Save} or {nav Save As} for JPEG image that is not changed in any way before saving -- in this case, `updateRawDataFromImage()` never gets called - Automatically updating thumbnails to reflect the new image quality level
{F7205336} {F7208763} Set JPEG quality to 5% in the config file and test the following use cases: - Non-JPEG image: do {nav Save} or {nav Save As} in non-JPEG formats -> No changes or regressions. - JPEG image: do {nav Save} or {nav Save As} without changing the image format or the image's pixels at all -> No changes; quality level not taken into consideration because these are lossless operations that do not re-compress the image (which is good) - JPEG image: do {nav Save} or {nav Save As} after changing the image's pixels in some way (e.g. a crop operation) -> Image is saved with the user-specified 5% quality level and looks terrible - JPEG image: do {nav Save As} into a non-JPEG file format after changing the image image's pixels in some way, or not -> No changes or regressions (in particular, lossless images like PNG are not hugely ballooned in file size) Set JPEG quality to 90% in the config file and test the following use cases: - Non-JPEG image: do {nav Save As} in non-JPEG formats -> No changes or regressions; dialog box does not show quality spinbox - Non-JPEG image: do {nav Save As} into a JPEG and in the {nav Save As] dialog, change the quality from 90% to 5%-> Image is saved with the user-specified 5% quality level and looks terrible - JPEG image: do {nav Save As} into a non-JPEG file format -> No changes or regressions; dialog box does not show quality spinbox - JPEG image: do {nav Save As} after changing the image's pixels in some way (e.g. a crop operation), and in the {nav Save As] dialog, change the quality from 90% to 5%-> Image is saved with the user-specified 5% quality level and looks terrible
{F7205336} {F7208763}
What works:
Set JPEG quality to 5% in the config file and test the following use cases: - Non-JPEG image: do {nav Save} or {nav Save As} in non-JPEG formats -> No changes or regressions.
-
- JPEG image: do
{nav Save}
and
or
{nav Save As}
for non-JPEG
without changing the
image
s being saved in non-JPEG formats.
format or the image's pixels at all -> No changes;
No regressions.
quality level not taken into consideration because these are lossless operations that do not re-compress the image (which is good)
-
JPEG image: do
{nav Save} or {nav Save As}
for JPEG image that is changed
after changing the image's pixels
in some way (e.g.
cropped)
a crop operation) -> Image is saved with the user-specified 5% quality level and looks terrible
-
{nav Save As} for non-JPEG image being saved as JPEG
JPEG image: do {nav Save As} into a non-JPEG file format after changing the image image's pixels in some way, or not -> No changes or regressions (in particular, lossless images like PNG are not hugely ballooned in file size)
What does not yet work:
Set JPEG quality to 90% in the config file and test the following use cases: - Non-JPEG image: do {nav Save As} in non-JPEG formats -> No changes or regressions; dialog box does not show quality spinbox - Non-JPEG image: do {nav Save As} into a JPEG and in the {nav Save As] dialog, change the quality from 90% to 5%-> Image is saved with the user-specified 5% quality level and looks terrible
- {nav Save} or
- JPEG image: do
{nav Save As}
for
into a non-
JPEG
image that is not
file format -> No
change
d in any way before saving -- in this case,
s or regressions;
`updateRawDataFromImage()` never gets called
dialog box does not show quality spinbox
-
Automatically updating thumbnails to reflect the new image quality level
JPEG image: do {nav Save As} after changing the image's pixels in some way (e.g. a crop operation), and in the {nav Save As] dialog, change the quality from 90% to 5%-> Image is saved with the user-specified 5% quality level and looks terrible
Continue