Change Details

There are two issues: - `QDate::fromJulianDay` and `QDateTime::toSecsSinceEpoch` are static functions which return the result value, so the calls in the code are effectively no-op - It doesn't make sense to add two absolute time values together (what meaningful result would we get by adding the dates of today and tomorrow?) Since they don't really do anything anyway, I suggest changing them to a safe assert check. OT: The real reason I checked is because `QDateTime::toSecsSinceEpoch` is unavailable before Qt 5.8 (we should be targeting Qt 5.9 anyway but my appveyor nightly build is still on Qt 5.6 due to lack of time to update...) that was changed in ecd95612c8972c38678f5bba186fb06971a6fc48

There are two issues: - `QDate::fromJulianDay` and `QDateTime::toSecsSinceEpoch` are static functions which return the result value, so the calls in the code are effectively no-op, so the merged value is replaced with a default-initialized value. - It doesn't make sense to add two absolute time values together (what meaningful result would we get by adding the dates of today and tomorrow?)

There are two issues: - `QDate::fromJulianDay` and `QDateTime::toSecsSinceEpoch` are static functions which return the result value, so the calls in the code are effectively no-op, so the merged value is replaced with a default-initialized value. - It doesn't make sense to add two absolute time values together (what meaningful result would we get by adding the dates of today and tomorrow?) Since they don't really do anything anyway, I suggest changing them to a safe assert check. OT: The real reason I checked is because `QDateTime::toSecsSinceEpoch` is unavailable before Qt 5.8 (we should be targeting Qt 5.9 anyway but my appveyor nightly build is still on Qt 5.6 due to lack of time to update...) that was changed in ecd95612c8972c38678f5bba186fb06971a6fc48