Change Details

If a folder was moved from an unwatched place, `KInotify` will receive an `EventMoveTo` event, which doesn't have an `EventMoveFrom` counterpart, and thus it will emit only `created` signal for the moved directory, but not its contents. Also, it won't install watches for the directory (as it does in `EventCreate`). Instead use FilteredDirIterator to emit created() signal for all the contents as well, and add inotify watch Few side notes: # It's not really realted to symbolic links, we just need to move a folder from excluded place to included. # If we move folder from another device, `Inotify` doesn't create `Move` signal, but `Create` instead, which seems to be handled properly I'm not really sure why, because it smells like a race condition here. Assume user moves `folder/` with `folder/file1` and `folder/file2` files inside it. If the things happen in a following order: # We receive `Create` signal for inotify # `folder/file1` is moved # We add inotify watch for `folder/` # `folder/file2` is moved then we will receive `Create` signal only for `file2`, losing information concerning `file1` completely. BUG: 342224

If a folder was moved from an unwatched place, `KInotify` will receive an `EventMoveTo` event, which doesn't have an `EventMoveFrom` counterpart, and thus it will emit only `created` signal for the moved directory, but not its contents. It also won't install watches for the directory (as it does in `EventCreate`). Instead use FilteredDirIterator to emit created() signal for all the contents as well, and add inotify watches. It should also now handle the race condition if a directory was created and files were moved inside it before an inotify watch for this directory was installed. Note that it's not really realted to symbolic links, one just has to move a folder from excluded place to included. BUG: 342224

If a folder was moved from an unwatched place, `KInotify` will receive an `EventMoveTo` event, which doesn't have an `EventMoveFrom` counterpart, and thus it will emit only `created` signal for the moved directory, but not its contents. Also, it It also won't install watches for the directory (as it does in `EventCreate`). Instead use FilteredDirIterator to emit created() signal for all the contents as well, and add inotify watches. Few side notes: # It's not really realted to symbolic links, we just need to move a folder from excluded place to included. # If we move folder from another device, `Inotify` doesn't create `Move` signal, but `Create` instead, which seems to be handled properly I'm not really sure why, because it smells like a race condition here.It should also now handle the race condition if a directory was created Assume user moves `folder/` with `folder/file1` and `folder/file2` files inside it. If the things happen in a following order: # We receive `Create` signal for inotify # `folder/file1` is moved # We add inotify watch for `folder/` # `folder/file2` is moved then we will receive `Create` signal only for `file2`and files were moved inside it before an inotify watch for this directory was installed. Note that it's not really realted to symbolic links, losing information concerning `file1` completelyone just has to move a folder from excluded place to included. BUG: 342224