Thanks! You can close this now.

@ngraham Done, thank you!

Thanks! This might get a bit more attention if you re-submit it as a merge request at https://invent.kde.org/utilities/yakuake/-/merge_requests, now that KDE has moved patch review to GitLab. Here's some documentation if you're unfamiliar with the workflow: https://community.kde.org/Infrastructure/GitLab

Fix crash when unplugging monitor on which Yakuake is set to open

Fixed a problem in MainWindow::getScreen() due to the fact the list of screens is 0 based while Yakuake stores the screen number starting from 1.

Afraid I don't have HiDPI displays to test with. Glad the issue is finally seeing work though!

Fixed copyright statements.

On a related note, I uploaded another patch that reformats the rest of Yakuake's if statements to match the ones here.

Added copyright statement

@ryanmccoskrie can you provide an email address so we can land this patch with correct attribution? Thanks again for the lovely contribution!

Awesome!

LGTM. @mweepigeon? Since you requested changed, you'll nedd to re-review and change your status to Accepted if you're happy with it now.

Fixed formatting and added comments

• Merge branch 'master' into 154686-Resize_on_title_drag
• * Now conforms to KDE style guidelines
• * C++ dynamic cast instead of C cast
• * renamed parent to window in TitleBar::mouseMoveEvent()
• Merge branch 'master' into 154686-Resize_on_title_drag
• Merge branch 'master' into 154686-Resize_on_title_drag
• TitleBar now uses the vertical-resize cursor
• Fixed titlebar buttons using vertical-size cursor

Dragging and icon seem to be working for me! I think it should be good once you take care of the style change requests

Fixed menu buttons using vertical-size cursor.

The Title Bar now indicates it is resizeable with a vertical size cursor.

In D22227#620201, @ngraham wrote:

@ryanmccoskrie sorry this got lost. Would you be interested in finishing it up so we can get it landed?

@ryanmccoskrie sorry this got lost. Would you be interested in finishing it up so we can get it landed?

Resizing the window works great, and the 'flickering' effect is relatively minor. However, the cursor should change when it is over the titlebar to indicate to the user that they are able to drag to resize it - ideally the vertical double arrow cursor icon

Looks great to me!

@mglb ping

In D25123#607216, @davidre wrote:

If you land this please update the summary before. No need to have all the variants in the commit message it should be about the actual change. Thanks :)

If you land this please update the summary before. No need to have all the variants in the commit message it should be about the actual change. Thanks :)

Huh, I was waiting for @hein :) oh well, here it is - C icon with cleaned up source

@mglb ping! I feel like we're really close for this.

Agreed, C for me too.

In D25123#560491, @ndavis wrote:

I think I prefer C the most now that I've seen it next to other icons. It has a similar level of detail to other Breeze icons.

I think I prefer C the most now that I've seen it next to other icons. It has a similar level of detail to other Breeze icons.

In D25123#558363, @ndavis wrote:

switching to that system means we would need to change many icons.

In D25123#558353, @mglb wrote:

Breaking nice-looking proportions just to fill vertical space is not good IMO. Making the bar a bit higher might make it look more reasonably. Your second proposition (icon C) looks nice though.

In D25123#558205, @ndavis wrote:

I tried seeing how it would look extended down to the bottom margin: