Build SystemOrganization
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Today

cgiboudeaux accepted D18952: new find module for Canberra.

Thanks! just a little thing to fix before pushing

Tue, Feb 19, 8:09 AM · Build System, Frameworks

Yesterday

vkrause added a comment to D19005: android: don't default to gcc anymore.
In D19005#414313, @apol wrote:

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

no, the value is coming from the cache, so that's the one we're setting. What this patch tries to make sure is that we don't forward an empty value (resetting a proper variable to "").

Mon, Feb 18, 5:02 PM · Build System, Frameworks
sitter updated the diff for D18952: new find module for Canberra.

fix bad copy paste in compat setup

Mon, Feb 18, 4:24 PM · Build System, Frameworks
sitter updated the diff for D18952: new find module for Canberra.
  • pkgconfig is now quiet
  • variables are now camelcase
    • old variables are still set for compat
  • new imported target (also sets pkgconfig's cflags, which I presume is the sane thing to do)
  • set package description url & description
Mon, Feb 18, 12:36 PM · Build System, Frameworks
bcooksley added a comment to D19075: Fix FindEGL.

If someone could please trigger all of the Dependency Builds for FreeBSD once this has been landed that would be appreciated: https://build.kde.org/view/Failing/

Mon, Feb 18, 9:55 AM · Build System, Frameworks
apol added a comment to D19005: android: don't default to gcc anymore.

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

Mon, Feb 18, 1:01 AM · Build System, Frameworks
apol accepted D19075: Fix FindEGL.
Mon, Feb 18, 12:16 AM · Build System, Frameworks

Sun, Feb 17

hausmann accepted D19075: Fix FindEGL.

Thank you:)

Sun, Feb 17, 8:47 PM · Build System, Frameworks

Sat, Feb 16

vkrause updated the diff for D18943: Add Fontconfig find modudle.

Search for pkgconfig quietly.

Sat, Feb 16, 11:30 AM · Build System, Frameworks
cgiboudeaux added inline comments to D18943: Add Fontconfig find modudle.
Sat, Feb 16, 11:13 AM · Build System, Frameworks
cgiboudeaux added a comment to D18952: new find module for Canberra.

Yes, imported targets are the future/present :)

Canberra::Canberra sounds good to me as target name

Sat, Feb 16, 11:09 AM · Build System, Frameworks
tcberner updated the diff for D19075: Fix FindEGL.

Simply set NAMES EGL/egl.h and fixup the header version check.

Sat, Feb 16, 10:51 AM · Build System, Frameworks
tcberner added a comment to D19075: Fix FindEGL.

I think that it should be NAMES EGL/egl.h

Sat, Feb 16, 10:47 AM · Build System, Frameworks
hausmann added a comment to D19075: Fix FindEGL.

I think that it should be NAMES EGL/egl.h

Sat, Feb 16, 10:20 AM · Build System, Frameworks
aacid added a comment to D18952: new find module for Canberra.

Yes, imported targets are the future/present :)

Sat, Feb 16, 9:57 AM · Build System, Frameworks
tcberner updated the diff for D19075: Fix FindEGL.

Store the path gathered via pkgconfig in COMPLETE_EGL_INCLUDE_DIR and
use its parent directory for EGL_INCLUDE_DIR.

Sat, Feb 16, 9:57 AM · Build System, Frameworks
hausmann requested changes to D19075: Fix FindEGL.
Sat, Feb 16, 8:12 AM · Build System, Frameworks
hausmann added a comment to D19075: Fix FindEGL.

Yeah I think find_path should use the same style as the test program (EGL/egl.h). It is the style of inclusion as per the specification. I think that’s better than the ../ approach.

Sat, Feb 16, 8:12 AM · Build System, Frameworks
tcberner added a comment to D19075: Fix FindEGL.

Possibly the returend EGL_INCLUDE_DIR should possibly be stripped of the suffix too, as most will proably include 'EGL/egl.h', and not 'egl.h', I guess?

Sat, Feb 16, 7:23 AM · Build System, Frameworks
tcberner added a reviewer for D19075: Fix FindEGL: FreeBSD.
Sat, Feb 16, 7:19 AM · Build System, Frameworks
tcberner added a dependency for D19075: Fix FindEGL: D18960: Add compile check to FindEGL.
Sat, Feb 16, 7:19 AM · Build System, Frameworks
tcberner added a dependent revision for D18960: Add compile check to FindEGL: D19075: Fix FindEGL.
Sat, Feb 16, 7:19 AM · Build System, Frameworks
tcberner requested review of D19075: Fix FindEGL.
Sat, Feb 16, 7:18 AM · Build System, Frameworks
bcooksley added a comment to D18960: Add compile check to FindEGL.
/usr/local/bin/gmake -f CMakeFiles/cmTC_fd24d.dir/build.make CMakeFiles/cmTC_fd24d.dir/build
gmake[1]: Entering directory '/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp'
Building CXX object CMakeFiles/cmTC_fd24d.dir/src.cxx.o
/usr/bin/c++   -I/usr/local/include/EGL  -DHAVE_EGL   -o CMakeFiles/cmTC_fd24d.dir/src.cxx.o -c /usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp/src.cxx
/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp/src.cxx:2:10: fatal error: 'EGL/egl.h' file not found
#include <EGL/egl.h>
         ^~~~~~~~~~~
1 error generated.
gmake[1]: *** [CMakeFiles/cmTC_fd24d.dir/build.make:66: CMakeFiles/cmTC_fd24d.dir/src.cxx.o] Error 1
gmake[1]: Leaving directory '/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp'
gmake: *** [Makefile:121: cmTC_fd24d/fast] Error 2
Sat, Feb 16, 6:17 AM · Build System, Frameworks

Fri, Feb 15

vkrause closed D19016: Update Android toolchain files to reality.
Fri, Feb 15, 1:05 PM · Build System, Frameworks
apol accepted D19016: Update Android toolchain files to reality.

Thanks!

Fri, Feb 15, 12:41 PM · Build System, Frameworks

Thu, Feb 14

vkrause added a comment to D19005: android: don't default to gcc anymore.

In fact none of those seem to work here. D19016 works here though, and I suspect that the 14 -> 21 in there should fix ECM on the CI.

Thu, Feb 14, 5:32 PM · Build System, Frameworks
vkrause requested review of D19016: Update Android toolchain files to reality.
Thu, Feb 14, 5:30 PM · Build System, Frameworks
vkrause added a comment to D19005: android: don't default to gcc anymore.

Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?

Thu, Feb 14, 5:22 PM · Build System, Frameworks
vkrause accepted D19005: android: don't default to gcc anymore.
Thu, Feb 14, 3:35 PM · Build System, Frameworks
apol requested review of D19005: android: don't default to gcc anymore.
Thu, Feb 14, 2:36 PM · Build System, Frameworks
hausmann added a comment to D18960: Add compile check to FindEGL.

Ooops. Could you paste the error from the cmake error output? I'm curious which part of the EGL compile test fails.

Thu, Feb 14, 7:55 AM · Build System, Frameworks

Wed, Feb 13

tcberner added a comment to D18960: Add compile check to FindEGL.

Seems this is sadly breaking something for FreeBSD though, see
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console

Wed, Feb 13, 5:24 PM · Build System, Frameworks
kossebau added a comment to D18960: Add compile check to FindEGL.

Seems this is sadly breaking something for FreeBSD though, see
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.12/21/console

Wed, Feb 13, 5:16 PM · Build System, Frameworks
sitter added a comment to D18952: new find module for Canberra.

Good point, I've also noticed that (all?) our finders now also create an IMPORTED target. Should we maybe add that too? If so I guess Canberra::Canberra would be the preferred target name?

Wed, Feb 13, 8:59 AM · Build System, Frameworks
sitter updated the diff for D18952: new find module for Canberra.

document in rst syntax

Wed, Feb 13, 8:58 AM · Build System, Frameworks
hausmann closed D18960: Add compile check to FindEGL.
Wed, Feb 13, 8:47 AM · Build System, Frameworks

Tue, Feb 12

apol accepted D18960: Add compile check to FindEGL.
Tue, Feb 12, 6:14 PM · Build System, Frameworks
apol added inline comments to D18952: new find module for Canberra.
Tue, Feb 12, 5:43 PM · Build System, Frameworks
vkrause updated the diff for D18943: Add Fontconfig find modudle.

Update indentation, add docs link, remove ancient copy from attic.

Tue, Feb 12, 3:59 PM · Build System, Frameworks
vkrause added a comment to D18960: Add compile check to FindEGL.

+1 This makes sense to me, considering how broken some vendor [E]GL stacks are.

Tue, Feb 12, 3:50 PM · Build System, Frameworks
hausmann requested review of D18960: Add compile check to FindEGL.
Tue, Feb 12, 2:53 PM · Build System, Frameworks
kossebau added a comment to D18943: Add Fontconfig find modudle.

Could the indentation perhaps be turned to be 4 spaces while copying it here? While https://community.kde.org/Policies/CMake_Coding_Style#Indentation allows the choice of 2,3, or 4 spaces, using 4 is more in line with the indentation used in C++ sources, so IMHO more expected to read.

Tue, Feb 12, 2:21 PM · Build System, Frameworks
lbeltrame added a reviewer for D18952: new find module for Canberra: cgiboudeaux.
Tue, Feb 12, 1:09 PM · Build System, Frameworks
sitter requested review of D18952: new find module for Canberra.
Tue, Feb 12, 11:55 AM · Build System, Frameworks
apol added inline comments to D18943: Add Fontconfig find modudle.
Tue, Feb 12, 10:52 AM · Build System, Frameworks
vkrause added inline comments to D18943: Add Fontconfig find modudle.
Tue, Feb 12, 10:47 AM · Build System, Frameworks
apol added inline comments to D18943: Add Fontconfig find modudle.
Tue, Feb 12, 10:44 AM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

I just realized there is a much older version of this in attic/modules already, should that be removed as part of adding this?

Tue, Feb 12, 9:50 AM · Build System, Frameworks
vkrause added a comment to D18943: Add Fontconfig find modudle.

I'm not sure to understand the commit message, does qtbase look for ECM ?

Tue, Feb 12, 9:30 AM · Build System, Frameworks