Thanks! just a little thing to fix before pushing
fix bad copy paste in compat setup
- pkgconfig is now quiet
- variables are now camelcase
- old variables are still set for compat
- new imported target (also sets pkgconfig's cflags, which I presume is the sane thing to do)
- set package description url & description
If someone could please trigger all of the Dependency Builds for FreeBSD once this has been landed that would be appreciated: https://build.kde.org/view/Failing/
Sun, Feb 17
Sat, Feb 16
Search for pkgconfig quietly.
Simply set NAMES EGL/egl.h and fixup the header version check.
I think that it should be NAMES EGL/egl.h
Yes, imported targets are the future/present :)
Store the path gathered via pkgconfig in COMPLETE_EGL_INCLUDE_DIR and
use its parent directory for EGL_INCLUDE_DIR.
Yeah I think find_path should use the same style as the test program (EGL/egl.h). It is the style of inclusion as per the specification. I think that’s better than the ../ approach.
Possibly the returend EGL_INCLUDE_DIR should possibly be stripped of the suffix too, as most will proably include 'EGL/egl.h', and not 'egl.h', I guess?
/usr/local/bin/gmake -f CMakeFiles/cmTC_fd24d.dir/build.make CMakeFiles/cmTC_fd24d.dir/build gmake: Entering directory '/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp' Building CXX object CMakeFiles/cmTC_fd24d.dir/src.cxx.o /usr/bin/c++ -I/usr/local/include/EGL -DHAVE_EGL -o CMakeFiles/cmTC_fd24d.dir/src.cxx.o -c /usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp/src.cxx /usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp/src.cxx:2:10: fatal error: 'EGL/egl.h' file not found #include <EGL/egl.h> ^~~~~~~~~~~ 1 error generated. gmake: *** [CMakeFiles/cmTC_fd24d.dir/build.make:66: CMakeFiles/cmTC_fd24d.dir/src.cxx.o] Error 1 gmake: Leaving directory '/usr/home/jenkins/kwayland/build/CMakeFiles/CMakeTmp' gmake: *** [Makefile:121: cmTC_fd24d/fast] Error 2
Fri, Feb 15
Thu, Feb 14
In fact none of those seem to work here. D19016 works here though, and I suspect that the 14 -> 21 in there should fix ECM on the CI.
Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_value"?
Ooops. Could you paste the error from the cmake error output? I'm curious which part of the EGL compile test fails.
Wed, Feb 13
Seems this is sadly breaking something for FreeBSD though, see
Good point, I've also noticed that (all?) our finders now also create an IMPORTED target. Should we maybe add that too? If so I guess Canberra::Canberra would be the preferred target name?
document in rst syntax
Tue, Feb 12
Update indentation, add docs link, remove ancient copy from attic.
+1 This makes sense to me, considering how broken some vendor [E]GL stacks are.
Could the indentation perhaps be turned to be 4 spaces while copying it here? While https://community.kde.org/Policies/CMake_Coding_Style#Indentation allows the choice of 2,3, or 4 spaces, using 4 is more in line with the indentation used in C++ sources, so IMHO more expected to read.
I just realized there is a much older version of this in attic/modules already, should that be removed as part of adding this?