Build SystemOrganization
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Sun, Sep 17

patrickelectric added a comment to D6103: scan the whole install folder for qml dependencies.

I don't know if is related to this commit, but when compiling my application via kirigami with make create-* and uploading to my cellphone, a white screen appears.
Using adb to debug with logcat, this error took my attention: libatcore-gui.so: qrc:///main.qml:2 ((null)): qrc:///main.qml:2:1: module "QtQuick.Controls" plugin "qtquickcontrols2plugin" not found, and than searching about it, this site took my attention.
I don't know if it's a bug or related to this PR.

Sun, Sep 17, 6:18 PM · Build System, Frameworks
marten updated the diff for D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.

Diff updated to move library target definition after find_package_handle_standard_args.

Sun, Sep 17, 2:18 PM · Build System, Frameworks

Sat, Sep 16

cgiboudeaux added a comment to D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.

Looks good. What's your migration plan ?
if you don't want to bump the ECM requirements for applications looking for pulseaudio, you have to set some compatibility/deprecated vars (eg: kmix uses uppercase variables)

Sat, Sep 16, 3:25 PM · Build System, Frameworks

Fri, Sep 15

marten updated the diff for D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.

Updated as per review comments.

Fri, Sep 15, 8:41 PM · Build System, Frameworks
marten added a comment to D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.

Diff updated.

Fri, Sep 15, 8:40 PM · Build System, Frameworks
cgiboudeaux added inline comments to D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.
Fri, Sep 15, 5:28 PM · Build System, Frameworks
marten updated the diff for D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.

Modules updated with standard header, documentation and copyright; endif() used throughout.

Fri, Sep 15, 4:33 PM · Build System, Frameworks
cgiboudeaux added a comment to D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.

-1. They don't match the ECM coding style and code quality (doc, license, endif(), pkgconfig...)

Fri, Sep 15, 11:02 AM · Build System, Frameworks

Thu, Sep 14

marten added a comment to D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.

It's the same source really - the only differences between those in kdelibs4support and ecm/attic are that the former uses endif(same_as_if) and the latter uses endif().
Nothing else within Frameworks, Plasma or applications uses anything from ecm/attic directly.

Thu, Sep 14, 5:17 PM · Build System, Frameworks
cfeck added a comment to D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.

In other words, your suggestion is not to add it to ecm, but to move it from attic/modules to find-modules.

Thu, Sep 14, 5:13 PM · Build System, Frameworks
marten updated subscribers of D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.
Thu, Sep 14, 4:46 PM · Build System, Frameworks
marten created D7823: Add FindGLIB2.cmake and FindPulseAudio.cmake to ECM.
Thu, Sep 14, 4:45 PM · Build System, Frameworks

Fri, Sep 8

shaheed added a comment to D7736: Not-to-be-merged review of Python bindings generator.

My suggestion would be to focus any review efforts in this order:

Fri, Sep 8, 5:29 PM · Build System, Frameworks
shaheed added inline comments to D7736: Not-to-be-merged review of Python bindings generator.
Fri, Sep 8, 5:26 PM · Build System, Frameworks
shaheed added a comment to D7736: Not-to-be-merged review of Python bindings generator.

My comments here are phrased as if this SIP-based approach was the solution eventually adopted (cppyy might be different). With that said...

Fri, Sep 8, 5:08 PM · Build System, Frameworks
lbeltrame added a comment to D7736: Not-to-be-merged review of Python bindings generator.

A small number of reviews (this thing is huge). One question: would it be possible to have the bindings per-framework, rather than a single, long list? This is also what made PyKDE4 unwieldy. IOW, each Framework should ship their (optional) bindings.
We can put the tooling in ECM so that everything is in place for all the Frameworks. (This is how the current approach works):

Fri, Sep 8, 2:29 PM · Build System, Frameworks
shaheed updated the summary of D7736: Not-to-be-merged review of Python bindings generator.
Fri, Sep 8, 2:20 PM · Build System, Frameworks
shaheed retitled D7736: Not-to-be-merged review of Python bindings generator from Not-to-be-merged review fo Python bindings generator to Not-to-be-merged review of Python bindings generator.
Fri, Sep 8, 2:19 PM · Build System, Frameworks
shaheed updated the summary of D7736: Not-to-be-merged review of Python bindings generator.
Fri, Sep 8, 2:18 PM · Build System, Frameworks
shaheed created D7736: Not-to-be-merged review of Python bindings generator.
Fri, Sep 8, 2:17 PM · Build System, Frameworks

Tue, Sep 5

aacid closed D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing..

Seems you commited this but forgot to close this?

Tue, Sep 5, 8:49 PM · Build System, Frameworks

Sun, Sep 3

arojas closed D7677: Fix python bindings compilation after 7af93dd23873d0b9cdbac192949e7e5114940aa6 by committing R240:8b4033f16c2a: Fix python bindings compilation after 7af93dd23873d0b9cdbac192949e7e5114940aa6.
Sun, Sep 3, 5:26 PM · Build System, Frameworks
dfaure accepted D7677: Fix python bindings compilation after 7af93dd23873d0b9cdbac192949e7e5114940aa6.

Thanks for the fix!

Sun, Sep 3, 5:13 PM · Build System, Frameworks
arojas created D7677: Fix python bindings compilation after 7af93dd23873d0b9cdbac192949e7e5114940aa6.
Sun, Sep 3, 2:21 PM · Build System, Frameworks

Wed, Aug 30

dfaure added a comment to D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing..

Patch for more docu: https://phabricator.kde.org/D7612

Wed, Aug 30, 7:36 AM · Build System, Frameworks
dfaure created D7612: KDECMakeSettings: more docu about the layout of the build dir.
Wed, Aug 30, 7:35 AM · Build System, Frameworks
kossebau reopened D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing..
Wed, Aug 30, 3:00 AM · Build System, Frameworks

Aug 14 2017

elvisangelaccio abandoned D7253: Add build-flatpak target if there is a flatpak recipe around.
In D7253#135251, @apol wrote:

Ugh my bad ^^', I don't know what happened.

The reason why I'm discussing this is that I think one of the advantages of Flatpak

is that it makes it much easier to set up the build environment. Documented dependencies and tooling that integrates it. We need to leverage that rather than hiding it in the current state which while it works it's overly complex and part of a problem to solve.

Aug 14 2017, 4:02 PM · Build System, Frameworks
cgiboudeaux added inline comments to D7253: Add build-flatpak target if there is a flatpak recipe around.
Aug 14 2017, 7:50 AM · Build System, Frameworks

Aug 13 2017

apol added a comment to D7253: Add build-flatpak target if there is a flatpak recipe around.

Ugh my bad ^^', I don't know what happened.

Aug 13 2017, 5:32 PM · Build System, Frameworks

Aug 12 2017

elvisangelaccio added a comment to D7253: Add build-flatpak target if there is a flatpak recipe around.
In D7253#134703, @apol wrote:

Main reason is having a simple way to run flatpak-builder with the proper arguments. Otherwise you have to copy-paste the command from somewhere (which could be error-prone).
One usually already has a build folder around, so the idea is you change some code, build it as usual and then you run this target to quickly test the change in flatpak.

Note that this is forcing that the file is in the root directory, this doesn't need to be necessarily the case. In fact xdg-portal-kde-test has it in a subdir.

This would already do what you're after:
alias fb=flatpak-builder --force-clean --ccache --require-changes --repo=repo app $@

Such an alias/script could go in here: https://cgit.kde.org/kde-dev-scripts.git/

The reason why I'm discussing this is that I think one of the advantages of Flatpak

Aug 12 2017, 8:02 AM · Build System, Frameworks

Aug 11 2017

apol added a comment to D7253: Add build-flatpak target if there is a flatpak recipe around.

Main reason is having a simple way to run flatpak-builder with the proper arguments. Otherwise you have to copy-paste the command from somewhere (which could be error-prone).
One usually already has a build folder around, so the idea is you change some code, build it as usual and then you run this target to quickly test the change in flatpak.

Aug 11 2017, 7:04 PM · Build System, Frameworks
elvisangelaccio added a comment to D7253: Add build-flatpak target if there is a flatpak recipe around.

Main reason is having a simple way to run flatpak-builder with the proper arguments. Otherwise you have to copy-paste the command from somewhere (which could be error-prone).
One usually already has a build folder around, so the idea is you change some code, build it as usual and then you run this target to quickly test the change in flatpak.

Aug 11 2017, 4:52 PM · Build System, Frameworks
apol added a comment to D7253: Add build-flatpak target if there is a flatpak recipe around.

Interesting feature.

Aug 11 2017, 4:40 PM · Build System, Frameworks
elvisangelaccio added reviewers for D7253: Add build-flatpak target if there is a flatpak recipe around: apol, Frameworks.
Aug 11 2017, 4:23 PM · Build System, Frameworks
elvisangelaccio created D7253: Add build-flatpak target if there is a flatpak recipe around.
Aug 11 2017, 4:23 PM · Build System, Frameworks

Aug 10 2017

dfaure added a comment to D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing..

Ooops, sorry. I had heavily tested ... a somewhat different version of the patch :(

Aug 10 2017, 6:50 AM · Build System, Frameworks

Aug 9 2017

cgiboudeaux added a comment to D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing..

Fixed with 7e7b6da

Aug 9 2017, 11:52 PM · Build System, Frameworks
cgiboudeaux added a comment to D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing..

Fixed with 7e7b6da

Aug 9 2017, 11:34 PM · Build System, Frameworks
aacid added a comment to D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing..

You broke all the builds

Aug 9 2017, 10:26 PM · Build System, Frameworks
dfaure closed D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing..
Aug 9 2017, 5:17 PM · Build System, Frameworks
kfunk accepted D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing..

I like the initiative, +1

Aug 9 2017, 12:50 PM · Build System, Frameworks
apol closed D7094: Include a module for finding qml imports as runtime dependencies by committing R240:e5301edf1daf: Include a module for finding qml imports as runtime dependencies.
Aug 9 2017, 11:10 AM · Build System, Frameworks
sitter accepted D7094: Include a module for finding qml imports as runtime dependencies.

Oh it's gorgeous!

Aug 9 2017, 11:04 AM · Build System, Frameworks
apol updated the diff for D7094: Include a module for finding qml imports as runtime dependencies.

if no qmlplugindump

Aug 9 2017, 10:31 AM · Build System, Frameworks
cgiboudeaux accepted D7198: Set CMAKE_*_OUTPUT_DIRECTORY to run tests without installing..
Aug 9 2017, 10:04 AM · Build System, Frameworks
sitter added inline comments to D7094: Include a module for finding qml imports as runtime dependencies.
Aug 9 2017, 8:50 AM · Build System, Frameworks
apol added inline comments to D7094: Include a module for finding qml imports as runtime dependencies.
Aug 9 2017, 2:06 AM · Build System, Frameworks
apol updated the diff for D7094: Include a module for finding qml imports as runtime dependencies.

Address sitter's comments

Aug 9 2017, 2:06 AM · Build System, Frameworks

Aug 8 2017

sitter added a comment to D7094: Include a module for finding qml imports as runtime dependencies.

qmlplugindump not being found needs to be handled somehow. Other than that only minor nitpicks.

Aug 8 2017, 2:12 PM · Build System, Frameworks