Thu, Dec 6
Tue, Dec 4
Mon, Dec 3
Address review comments.
Add the reason for looking for the executable
Sat, Dec 1
Mon, Nov 26
A more complete draft:
Sun, Nov 25
You will notice that I plan to maintain an option to disable the Apple-specific behaviour for anyone who depends on the current behaviour (that includes me, but your script would also continue to work). Cf. the APPLE_FORCE_X11 option
Sat, Nov 24
Fri, Nov 23
Can we set DATAROOTDIR=/Library/Application Support/KDE so that everything remains nicely bundled?
Tue, Nov 20
Good to see you caring for ECM documentation not getting broken with Qt 5.12 :)
Done. kfilemetadata was also changed to use FindLibExiv2.cmake.
Looks good to me.
Mon, Nov 19
If anyone wonders:
This implements and uses my idea of an ecm_add_<lang>_compiler_flags_if_supported function set for C and C++. It uses compiler ID+version conditions to determine if flag(s) are supported when those conditions are known and reliable - otherwise and only then does it resort to querying the compiler.
Sun, Nov 18
Sat, Nov 17
Good find. No idea why it was not like this from the start.
Fri, Nov 16
Looks ok to me, less stuff to set manually is always good.
Something side-ways related: I went down this hole because cmake's generate_export_header failed because of an unsupported flag that was added.
Regardless of how we implement things here, shouldn't there be something like ecm_generate_export_header which empties CMAKE_CXX_FLAGS temporarily because calling CMake's version and then restores the variable? There's no feedback at all in this function, the generated export header just contains dummy EXPORT macros, leaving the user to wonder why the linker fails. Or should the visibility flags also be set conditionally, after setting all other compiler options?
Thus these places need to be turned into: ... if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "3.8") elseif(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "8.1.0")
I don't like the hiding of the if-branches as argument to macro. We shouldn't to this as it makes the code harder to understand.
A simpler version, setting CMAKE_<LANG>_FLAGS directly (also fixes a persistence error in my previous implementation).
Thu, Nov 15
Nov 12 2018
Don't worry, the commit message would have looked like that.
Or rather, it will say