Build SystemOrganization
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Thu, Dec 6

tcberner added inline comments to D17015: Fix the Qt doc creation with Qt 5.12..
Thu, Dec 6, 7:40 PM · Build System, Frameworks

Tue, Dec 4

vkrause closed D16954: Add find module for Google's libphonenumber.
Tue, Dec 4, 4:47 PM · Build System, Frameworks

Mon, Dec 3

cgiboudeaux accepted D16954: Add find module for Google's libphonenumber.
Mon, Dec 3, 6:02 PM · Build System, Frameworks
vkrause updated the diff for D16954: Add find module for Google's libphonenumber.

Address review comments.

Mon, Dec 3, 5:53 PM · Build System, Frameworks
cgiboudeaux added a comment to D17015: Fix the Qt doc creation with Qt 5.12..

Good to see you caring for ECM documentation not getting broken with Qt 5.12 :)

Any idea how we could perhaps deduplicate the FindQHelpGenerator.cmake with the one from find-modules (which is a helper for runtime with the ECMAddQch macro)? No instant idea yet, perhaps also better to have dedicated variants for each purppse? Needs me another round of thinking.

Mon, Dec 3, 11:46 AM · Build System, Frameworks
cgiboudeaux updated the diff for D17015: Fix the Qt doc creation with Qt 5.12..

Add the reason for looking for the executable

Mon, Dec 3, 11:40 AM · Build System, Frameworks

Sat, Dec 1

cgiboudeaux added inline comments to D16954: Add find module for Google's libphonenumber.
Sat, Dec 1, 9:16 PM · Build System, Frameworks
cgiboudeaux added inline comments to D16954: Add find module for Google's libphonenumber.
Sat, Dec 1, 9:11 PM · Build System, Frameworks
vkrause added a comment to D16954: Add find module for Google's libphonenumber.

ping?

Sat, Dec 1, 11:17 AM · Build System, Frameworks

Mon, Nov 26

rjvbb added a comment to T10112: KDEInstallDirs on Mac.

A more complete draft:

Mon, Nov 26, 10:36 PM · Build System

Sun, Nov 25

rjvbb added a comment to T10112: KDEInstallDirs on Mac.

You will notice that I plan to maintain an option to disable the Apple-specific behaviour for anyone who depends on the current behaviour (that includes me, but your script would also continue to work). Cf. the APPLE_FORCE_X11 option

Sun, Nov 25, 11:42 AM · Build System
yurikoles added a comment to T10112: KDEInstallDirs on Mac.
/Library/Application Support/kf5
Sun, Nov 25, 11:32 AM · Build System

Sat, Nov 24

vkrause added reviewers for D16954: Add find module for Google's libphonenumber: Build System, Frameworks.
Sat, Nov 24, 11:31 AM · Build System, Frameworks

Fri, Nov 23

rjvbb added a comment to T10112: KDEInstallDirs on Mac.

Can we set DATAROOTDIR=/Library/Application Support/KDE so that everything remains nicely bundled?

Fri, Nov 23, 1:38 PM · Build System
rjvbb updated subscribers of T10112: KDEInstallDirs on Mac.
Fri, Nov 23, 1:33 PM · Build System
rjvbb created T10112: KDEInstallDirs on Mac.
Fri, Nov 23, 10:00 AM · Build System

Tue, Nov 20

kossebau added a comment to D17015: Fix the Qt doc creation with Qt 5.12..

Good to see you caring for ECM documentation not getting broken with Qt 5.12 :)

Tue, Nov 20, 2:12 PM · Build System, Frameworks
cgiboudeaux added a comment to D17044: Add FindExiv2.cmake to ECM.

Done. kfilemetadata was also changed to use FindLibExiv2.cmake.

Tue, Nov 20, 1:44 PM · Build System, Frameworks
cgiboudeaux added inline comments to D17044: Add FindExiv2.cmake to ECM.
Tue, Nov 20, 1:29 PM · Build System, Frameworks
kossebau added inline comments to D17044: Add FindExiv2.cmake to ECM.
Tue, Nov 20, 1:26 PM · Build System, Frameworks
cgiboudeaux added a reviewer for D17015: Fix the Qt doc creation with Qt 5.12.: kossebau.
Tue, Nov 20, 12:29 PM · Build System, Frameworks
cgiboudeaux closed D17044: Add FindExiv2.cmake to ECM.
Tue, Nov 20, 12:28 PM · Build System, Frameworks
apol accepted D17044: Add FindExiv2.cmake to ECM.

Looks good to me.

Tue, Nov 20, 12:14 PM · Build System, Frameworks
rempt added a comment to D17044: Add FindExiv2.cmake to ECM.

Wow...

Tue, Nov 20, 11:59 AM · Build System, Frameworks
cgiboudeaux requested review of D17044: Add FindExiv2.cmake to ECM.
Tue, Nov 20, 11:42 AM · Build System, Frameworks
cgiboudeaux abandoned D17043: Fix the Qt doc creation with Qt 5.12..
Tue, Nov 20, 11:29 AM · Build System, Frameworks
cgiboudeaux requested review of D17043: Fix the Qt doc creation with Qt 5.12..
Tue, Nov 20, 11:19 AM · Build System, Frameworks

Mon, Nov 19

apol closed D16930: Android: improve clang support.
Mon, Nov 19, 3:16 PM · Build System, Frameworks
cgiboudeaux added a comment to D17015: Fix the Qt doc creation with Qt 5.12..

If anyone wonders:

Mon, Nov 19, 1:39 PM · Build System, Frameworks
cgiboudeaux requested review of D17015: Fix the Qt doc creation with Qt 5.12..
Mon, Nov 19, 1:33 PM · Build System, Frameworks
rjvbb set the repository for D16894: [ECM] use a macro to add compiler flags conditionally to R240 Extra CMake Modules.
Mon, Nov 19, 9:51 AM · Build System, Frameworks
rjvbb updated the diff for D16894: [ECM] use a macro to add compiler flags conditionally.

This implements and uses my idea of an ecm_add_<lang>_compiler_flags_if_supported function set for C and C++. It uses compiler ID+version conditions to determine if flag(s) are supported when those conditions are known and reliable - otherwise and only then does it resort to querying the compiler.

Mon, Nov 19, 9:50 AM · Build System, Frameworks

Sun, Nov 18

pino closed D16938: FindQHelpGenerator: try to find Qt5Help instead of Qt5Core.
Sun, Nov 18, 8:57 AM · Build System, Frameworks

Sat, Nov 17

kossebau accepted D16938: FindQHelpGenerator: try to find Qt5Help instead of Qt5Core.

Good find. No idea why it was not like this from the start.

Sat, Nov 17, 4:24 PM · Build System, Frameworks
vkrause requested review of D16954: Add find module for Google's libphonenumber.
Sat, Nov 17, 11:10 AM · Build System, Frameworks
pino requested review of D16938: FindQHelpGenerator: try to find Qt5Help instead of Qt5Core.
Sat, Nov 17, 8:01 AM · Build System, Frameworks

Fri, Nov 16

vkrause accepted D16930: Android: improve clang support.

Looks ok to me, less stuff to set manually is always good.

Fri, Nov 16, 6:26 PM · Build System, Frameworks
apol requested review of D16930: Android: improve clang support.
Fri, Nov 16, 6:19 PM · Build System, Frameworks
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

Something side-ways related: I went down this hole because cmake's generate_export_header failed because of an unsupported flag that was added.
Regardless of how we implement things here, shouldn't there be something like ecm_generate_export_header which empties CMAKE_CXX_FLAGS temporarily because calling CMake's version and then restores the variable? There's no feedback at all in this function, the generated export header just contains dummy EXPORT macros, leaving the user to wonder why the linker fails. Or should the visibility flags also be set conditionally, after setting all other compiler options?

Fri, Nov 16, 2:48 PM · Build System, Frameworks
rjvbb added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
Thus these places need to be turned into:

  ...
  if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "3.8")
  elseif(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "8.1.0")
Fri, Nov 16, 12:58 PM · Build System, Frameworks
kfunk requested changes to D16894: [ECM] use a macro to add compiler flags conditionally.

I don't like the hiding of the if-branches as argument to macro. We shouldn't to this as it makes the code harder to understand.

Fri, Nov 16, 11:37 AM · Build System, Frameworks
rjvbb updated the test plan for D16894: [ECM] use a macro to add compiler flags conditionally.
Fri, Nov 16, 9:49 AM · Build System, Frameworks
rjvbb set the repository for D16894: [ECM] use a macro to add compiler flags conditionally to R240 Extra CMake Modules.
Fri, Nov 16, 9:47 AM · Build System, Frameworks
rjvbb updated the diff for D16894: [ECM] use a macro to add compiler flags conditionally.

A simpler version, setting CMAKE_<LANG>_FLAGS directly (also fixes a persistence error in my previous implementation).

Fri, Nov 16, 9:47 AM · Build System, Frameworks

Thu, Nov 15

rjvbb added inline comments to D16894: [ECM] use a macro to add compiler flags conditionally.
Thu, Nov 15, 1:39 PM · Build System, Frameworks
apol added inline comments to D16894: [ECM] use a macro to add compiler flags conditionally.
Thu, Nov 15, 1:03 PM · Build System, Frameworks
rjvbb requested review of D16894: [ECM] use a macro to add compiler flags conditionally.
Thu, Nov 15, 12:08 PM · Build System, Frameworks

Nov 12 2018

rjvbb closed D16816: ECM: standardise clang detection.
Nov 12 2018, 10:21 AM · Frameworks, Build System
rjvbb added a comment to D16816: ECM: standardise clang detection.

Don't worry, the commit message would have looked like that.
Or rather, it will say

Nov 12 2018, 10:15 AM · Frameworks, Build System
rjvbb added a comment to D16816: ECM: standardise clang detection.

Don't worry, the commit message would have looked like that.

Nov 12 2018, 10:15 AM · Frameworks, Build System