Build SystemOrganization
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Mon, Oct 1

bruns updated the diff for D15070: Bindings: Support using sys paths for python install directory.

Add documentation, remove leftover GPB_PYTHON${pyversion}_SITEARCH

Mon, Oct 1, 9:54 PM · Build System, Frameworks
bruns added inline comments to D15070: Bindings: Support using sys paths for python install directory.
Mon, Oct 1, 11:52 AM · Build System, Frameworks
cgiboudeaux added inline comments to D15070: Bindings: Support using sys paths for python install directory.
Mon, Oct 1, 7:31 AM · Build System, Frameworks
bruns updated the diff for D15070: Bindings: Support using sys paths for python install directory.

Update summary/test plan

Mon, Oct 1, 12:55 AM · Build System, Frameworks
bruns added a comment to D15070: Bindings: Support using sys paths for python install directory.

Thanks to arc for throwing my commit message away ...

Mon, Oct 1, 12:46 AM · Build System, Frameworks
bruns added a dependent revision for D15867: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding: D15070: Bindings: Support using sys paths for python install directory.
Mon, Oct 1, 12:42 AM · Build System, Frameworks
bruns added a dependency for D15070: Bindings: Support using sys paths for python install directory: D15867: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding.
Mon, Oct 1, 12:42 AM · Build System, Frameworks
bruns requested review of D15867: Bindings: Remove INSTALL_DIR_SUFFIX from ecm_generate_python_binding.
Mon, Oct 1, 12:41 AM · Build System, Frameworks
bruns updated the diff for D15070: Bindings: Support using sys paths for python install directory.

Use same pattern as KDE_INSTALL_USE_QT_SYS_PATHS

Mon, Oct 1, 12:40 AM · Build System, Frameworks

Sun, Sep 30

arojas closed D15091: Compile python bindings with the same sip flags used by PyQt.
Sun, Sep 30, 8:47 PM · Build System, Frameworks
bruns accepted D15091: Compile python bindings with the same sip flags used by PyQt.

Confirmed to work with PyQt 5.10.1 and Qt 5.11.1

Sun, Sep 30, 8:42 PM · Build System, Frameworks
bruns planned changes to D15070: Bindings: Support using sys paths for python install directory.
Sun, Sep 30, 3:23 PM · Build System, Frameworks
bruns updated the diff for D15070: Bindings: Support using sys paths for python install directory.

rebase

Sun, Sep 30, 3:23 PM · Build System, Frameworks

Sat, Sep 29

apol closed D15643: Android: Allow passing a relative path as the apk dir.
Sat, Sep 29, 12:40 AM · Build System, Frameworks

Fri, Sep 28

jjazeix accepted D15643: Android: Allow passing a relative path as the apk dir.

works fine, sorry for the doubt, I probably badly applied it last time.

Fri, Sep 28, 4:59 PM · Build System, Frameworks
apol updated the diff for D15643: Android: Allow passing a relative path as the apk dir.

Rebased

Fri, Sep 28, 2:03 PM · Build System, Frameworks
apol added a comment to D15643: Android: Allow passing a relative path as the apk dir.

Are you sure you applied the patch properly? You are getting the warning that we are guarding against.

Fri, Sep 28, 2:03 PM · Build System, Frameworks

Thu, Sep 27

dinoh added inline comments to D15795: Fix warnings about deprecated install dirs.
Thu, Sep 27, 3:33 PM · Build System, Frameworks
ltoscano added inline comments to D15795: Fix warnings about deprecated install dirs.
Thu, Sep 27, 12:21 PM · Build System, Frameworks
dinoh added reviewers for D15795: Fix warnings about deprecated install dirs: apol, bruns, dfaure.
Thu, Sep 27, 12:13 PM · Build System, Frameworks
dinoh requested review of D15795: Fix warnings about deprecated install dirs.
Thu, Sep 27, 12:06 PM · Build System, Frameworks

Mon, Sep 24

apol closed D14529: Android: Make sure Qm translations get loaded.
Mon, Sep 24, 10:58 AM · Build System, Frameworks
apol closed D15685: Fix Android builds using cmake 3.12.1.
Mon, Sep 24, 10:58 AM · Build System, Frameworks
vkrause accepted D15685: Fix Android builds using cmake 3.12.1.
Mon, Sep 24, 10:55 AM · Build System, Frameworks

Sat, Sep 22

mlaurent closed D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags.
Sat, Sep 22, 5:07 PM · Build System, Frameworks
dfaure accepted D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags.
Sat, Sep 22, 1:52 PM · Build System, Frameworks
mlaurent added a comment to D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags.

Ping?

Sat, Sep 22, 1:21 PM · Build System, Frameworks
apol requested review of D15685: Fix Android builds using cmake 3.12.1.
Sat, Sep 22, 12:20 AM · Build System, Frameworks

Fri, Sep 21

arojas updated the diff for D15091: Compile python bindings with the same sip flags used by PyQt.

Rebase

Fri, Sep 21, 10:35 PM · Build System, Frameworks
jjazeix added a comment to D15643: Android: Allow passing a relative path as the apk dir.

Unfortunately, this does not work. The tmpAndroid folder is created in the build folder after running cmake, so it's not available before:

Cannot find tmpAndroid//AndroidManifest.xml according to ANDROID_APK_DIR.
tmpAndroid/ GCompris

Call Stack (most recent call first):

/opt/cmake/share/cmake-3.11/Modules/CMakeDetermineSystem.cmake:94 (include)
CMakeLists.txt:4 (project)
Fri, Sep 21, 5:54 PM · Build System, Frameworks
jjazeix added a comment to D15643: Android: Allow passing a relative path as the apk dir.

Seems good to me at first sight, I'll try it as soon as possible

Fri, Sep 21, 12:15 PM · Build System, Frameworks
apol requested review of D15643: Android: Allow passing a relative path as the apk dir.
Fri, Sep 21, 10:36 AM · Build System, Frameworks

Thu, Sep 20

bruns requested changes to D15091: Compile python bindings with the same sip flags used by PyQt.
Thu, Sep 20, 12:32 PM · Build System, Frameworks
bruns added a comment to D15091: Compile python bindings with the same sip flags used by PyQt.

Can you rebase, please?
And upload the patch with arc diff, to have the full context available.

Thu, Sep 20, 12:32 PM · Build System, Frameworks
bruns closed D15559: Python bindings: use cmake_parse_arguments, fix documentation.
Thu, Sep 20, 12:23 PM · Build System, Frameworks
dfaure accepted D15559: Python bindings: use cmake_parse_arguments, fix documentation.

This is technically not 100% source compatible, but since the callers were already passing "TARGET" (and others) as documented, I guess it's fine.

Thu, Sep 20, 7:29 AM · Build System, Frameworks

Wed, Sep 19

bruns updated the diff for D15559: Python bindings: use cmake_parse_arguments, fix documentation.

Fix parentheses

Wed, Sep 19, 11:14 PM · Build System, Frameworks
bruns added a reviewer for D15559: Python bindings: use cmake_parse_arguments, fix documentation: dfaure.
Wed, Sep 19, 10:42 PM · Build System, Frameworks
bruns updated the summary of D15559: Python bindings: use cmake_parse_arguments, fix documentation.
Wed, Sep 19, 9:16 PM · Build System, Frameworks

Mon, Sep 17

mlaurent added a comment to D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags.

I fixed 2 repos.
Otherwise all compiles fine (ok I don't test on windows/mac and perhaps some module is not compiles on my computer)

Mon, Sep 17, 11:45 AM · Build System, Frameworks
dfaure added a comment to D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags.

Do all frameworks build with this change?

Mon, Sep 17, 7:28 AM · Build System, Frameworks
mlaurent added a reviewer for D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags: dfaure.
Mon, Sep 17, 5:39 AM · Build System, Frameworks
mlaurent requested review of D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags.
Mon, Sep 17, 5:38 AM · Build System, Frameworks

Sun, Sep 16

bruns planned changes to D15070: Bindings: Support using sys paths for python install directory.

Postponed this to do some cleanup first: D15558, D15559

Sun, Sep 16, 10:21 PM · Build System, Frameworks
bruns requested review of D15559: Python bindings: use cmake_parse_arguments, fix documentation.
Sun, Sep 16, 7:46 PM · Build System, Frameworks

Sep 14 2018

bruns closed D15068: Bindings: Correct handling of sources containing utf-8.
Sep 14 2018, 12:45 PM · Build System, Frameworks
bruns added a comment to D15068: Bindings: Correct handling of sources containing utf-8.

The code itself looks fine to me - the change on line 752 is to allow handling of macOS / Windows line endings in addition to just Unix line endings I presume?

Sep 14 2018, 12:28 PM · Build System, Frameworks
bruns added a comment to D15068: Bindings: Correct handling of sources containing utf-8.

Another solution (not tested here but used in other projects) could be to use
with open(source, "r", encoding="utf-8") as f:
(or if the file could contain the aberration BOM, you could use "utf-8-sig")

Sep 14 2018, 12:24 PM · Build System, Frameworks
lbeltrame accepted D15068: Bindings: Correct handling of sources containing utf-8.

LGTM.

Sep 14 2018, 12:21 PM · Build System, Frameworks
bcooksley added a comment to D15068: Bindings: Correct handling of sources containing utf-8.

The code itself looks fine to me - the change on line 752 is to allow handling of macOS / Windows line endings in addition to just Unix line endings I presume?

Sep 14 2018, 8:31 AM · Build System, Frameworks