Build SystemOrganization
ActivePublic

Recent Activity

Mon, Jun 29

jriddell added a comment to T13344: Clarify usage of BSD-3-Clause license with (CMake) code.

Ade makes an interesting point, if Kitware wants to add the 3rd clause then they can just add it to the BSD-2-clause code which has been sent upstream. But adding in 3rd clause BSD in places could limit where it gets used. And if we use the wrong name for the author then it's incompatible anyway and blocks use.

Mon, Jun 29, 3:02 PM · Build System
adridg added a comment to T13344: Clarify usage of BSD-3-Clause license with (CMake) code.
  • If we allow BSD-3-Clause, it should be a separate explicit entry in the alternative-licenses list.
  • The official SPDX text has "3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission." where the italics indicate that variants exist; the sample text is pretty generic IMO.
  • CMake upstream specifically instructs "We do not require any formal copyright assignment or contributor license agreement. Any contributions intentionally sent upstream are presumed to be offered under terms of the OSI-approved BSD 3-clause License. See Copyright.txt for details." (here)
Mon, Jun 29, 2:56 PM · Build System
jriddell added a comment to T13344: Clarify usage of BSD-3-Clause license with (CMake) code.

I'm not a fan of BSD 3 clause because it often includes the name of the copyright holder, and that can get complex when new copyright holders come along or if you don't care much and just want to copy and paste.

Mon, Jun 29, 9:48 AM · Build System

Sun, Jun 28

kossebau created T13344: Clarify usage of BSD-3-Clause license with (CMake) code.
Sun, Jun 28, 1:32 PM · Build System

Sun, Jun 21

elvisangelaccio abandoned D21695: Add FindTaglib.cmake.
Sun, Jun 21, 9:17 PM · Build System, Frameworks
elvisangelaccio commandeered D21695: Add FindTaglib.cmake.
Sun, Jun 21, 9:17 PM · Build System, Frameworks

Thu, Jun 11

elvisangelaccio added a comment to D21695: Add FindTaglib.cmake.

New attempt at https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/6

Thu, Jun 11, 10:34 PM · Build System, Frameworks

Mon, Jun 8

davidedmundson added a comment to D28355: Introduce function ecm_install_configured_file.

Moved to invent.

Mon, Jun 8, 2:31 PM · Build System, Frameworks
davidedmundson closed D28355: Introduce function ecm_install_configured_file.
Mon, Jun 8, 2:30 PM · Build System, Frameworks

May 29 2020

kossebau added a comment to D29051: Add ecm_generate_dbus_service_file.

A unit test would be good to have. The test for ECMGeneratePkgConfigFile might be a sample for this.

May 29 2020, 10:22 AM · Build System, Frameworks

May 22 2020

broulik updated the diff for D29051: Add ecm_generate_dbus_service_file.
  • Clarify docs
May 22 2020, 8:17 AM · Build System, Frameworks

May 13 2020

kossebau closed D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED().
May 13 2020, 4:07 PM · Build System, Frameworks

May 11 2020

nicolasfella closed D29631: [android] Allow specifying APK install location.
May 11 2020, 4:58 PM · Build System, Frameworks
apol accepted D29631: [android] Allow specifying APK install location.
May 11 2020, 3:31 PM · Build System, Frameworks
nicolasfella updated the diff for D29631: [android] Allow specifying APK install location.
  • Rename variable
May 11 2020, 1:48 PM · Build System, Frameworks
apol added a comment to D29631: [android] Allow specifying APK install location.

+1 overall, good idea.

May 11 2020, 1:41 PM · Build System, Frameworks
apol added inline comments to D29631: [android] Allow specifying APK install location.
May 11 2020, 1:41 PM · Build System, Frameworks
nicolasfella added a comment to D29631: [android] Allow specifying APK install location.

This is used in https://invent.kde.org/sysadmin/ci-tooling/-/merge_requests/68

May 11 2020, 1:31 PM · Build System, Frameworks
nicolasfella requested review of D29631: [android] Allow specifying APK install location.
May 11 2020, 1:22 PM · Build System, Frameworks

May 9 2020

kossebau added a dependent revision for D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED(): D29574: Use KSERVICE_DEPRECATED_VERSION_BELATED.
May 9 2020, 8:11 PM · Build System, Frameworks
dfaure accepted D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED().

So many things to take care of :-)

May 9 2020, 8:04 PM · Build System, Frameworks
kossebau requested review of D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED().
May 9 2020, 7:55 PM · Build System, Frameworks

May 8 2020

dfaure closed D29524: ECMGeneratePriFile: fix for ECM_MKSPECS_INSTALL_DIR being absolute.
May 8 2020, 11:01 AM · Build System, Frameworks
cgiboudeaux accepted D29524: ECMGeneratePriFile: fix for ECM_MKSPECS_INSTALL_DIR being absolute.

tested successfully with the openSUSE package which uses absolute paths

May 8 2020, 10:54 AM · Build System, Frameworks
dfaure requested review of D29524: ECMGeneratePriFile: fix for ECM_MKSPECS_INSTALL_DIR being absolute.
May 8 2020, 9:59 AM · Build System, Frameworks
dfaure closed D29274: ECMGeneratePriFile: make the pri files relocatable.
May 8 2020, 9:13 AM · Build System, Frameworks
vkrause accepted D29274: ECMGeneratePriFile: make the pri files relocatable.
May 8 2020, 9:12 AM · Build System, Frameworks

May 4 2020

xuetianweng closed D29396: Suppress find_package_handle_standard_args package name mismatch warning..
May 4 2020, 3:35 PM · Build System, Frameworks
apol accepted D29396: Suppress find_package_handle_standard_args package name mismatch warning..

This will make our configure steps readable again. Thanks!

May 4 2020, 2:20 AM · Build System, Frameworks
xuetianweng requested review of D29396: Suppress find_package_handle_standard_args package name mismatch warning..
May 4 2020, 1:27 AM · Build System, Frameworks

Apr 30 2020

ablu abandoned D29096: Prefix includes and libs dir with QT_SYSROOT.
Apr 30 2020, 8:21 AM · Build System, Frameworks
ablu added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

Ah, right. If you are using a normal sysroot for system libs, but conan for some libs then it makes sense!

Apr 30 2020, 7:51 AM · Build System, Frameworks
dfaure added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

I'm using conan, not doing cross compilation.

Apr 30 2020, 7:47 AM · Build System, Frameworks
ablu added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

Though... How does it come that you do not have SYSROOT set in your case? Won't that break in other cases?

Apr 30 2020, 5:14 AM · Build System, Frameworks
ablu added a comment to D29274: ECMGeneratePriFile: make the pri files relocatable.

The Build worked. So this solves the issue for me!

Apr 30 2020, 5:13 AM · Build System, Frameworks

Apr 29 2020

dfaure added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

Thanks for the quick test!

Apr 29 2020, 3:56 PM · Build System, Frameworks
ablu added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

looks good! yours is probably a bit more "CMakeish"! So feel free to continue with that one and close this.

Apr 29 2020, 3:14 PM · Build System, Frameworks
dfaure updated the diff for D29274: ECMGeneratePriFile: make the pri files relocatable.

Fix error: regex "[^/]*" matched an empty string.

Apr 29 2020, 2:45 PM · Build System, Frameworks
ablu added a comment to D29274: ECMGeneratePriFile: make the pri files relocatable.

My reason is basically the same. Will try this version too.

Apr 29 2020, 2:41 PM · Build System, Frameworks
ablu added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

Hi @dfaure. It looks pretty much the same and I think it should work for us. I will kick off a build to confirm.

Apr 29 2020, 2:39 PM · Build System, Frameworks
dfaure added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

Could you test if my patch in D29274 solves your problem? By making these lines relative to the location of the .pri file, it should work very well in a sysroot context as well.

Apr 29 2020, 2:13 PM · Build System, Frameworks
kossebau added a comment to D29274: ECMGeneratePriFile: make the pri files relocatable.

D29096 also wants to touch those entries, for different reasons. You may want to align here.

Apr 29 2020, 1:28 PM · Build System, Frameworks
dfaure requested review of D29274: ECMGeneratePriFile: make the pri files relocatable.
Apr 29 2020, 1:19 PM · Build System, Frameworks

Apr 28 2020

apol closed D29079: android: include the architecture on the apk name.
Apr 28 2020, 11:16 PM · Build System, Frameworks
nicolasfella accepted D29079: android: include the architecture on the apk name.
Apr 28 2020, 8:42 PM · Build System, Frameworks

Apr 23 2020

kossebau added a comment to D29051: Add ecm_generate_dbus_service_file.

Any chance for a simple unit test to check the generation does what is expected (or catches bad input)? :)

Apr 23 2020, 1:20 PM · Build System, Frameworks
kossebau added a comment to D28355: Introduce function ecm_install_configured_file.

A bit unsure if the arg name "TEMPLATES" is good, or if perhaps should be renamed to "INPUT". Just mentioning, not preferring one over the other. So far have not found existing samples to take as lead for consistent argument naming.

Apr 23 2020, 12:06 PM · Build System, Frameworks
ablu added a comment to D29096: Prefix includes and libs dir with QT_SYSROOT.

Not having done much cross-compilation-library-setups naively I would have thought that when building a library which uses ECMGeneratePriFile and preparing it for cross-compilation, the installation prefix would be hardcoded into the generated artifacts.. Seems that instead files are relocated sometimes, changing their path & prefix, or tools snipping of some things?

Apr 23 2020, 11:35 AM · Build System, Frameworks
kossebau added a reviewer for D28355: Introduce function ecm_install_configured_file: Build System.
Apr 23 2020, 11:04 AM · Build System, Frameworks
kossebau added reviewers for D29096: Prefix includes and libs dir with QT_SYSROOT: Build System, apol, vkrause, kfunk.
Apr 23 2020, 10:54 AM · Build System, Frameworks