Build SystemOrganization
ActivePublic

Recent Activity

Today

kossebau added a comment to D28355: Introduce function ecm_install_configured_file.

A .rst file in the docs/module/ directory is needed, otherwise the documentation generation will not pick up this, as it runs only over docs/.
Please enable the documentation generation in your ecm build and check for yourself, by e.g. ensuring BUILD_HTML_DOCS is ON and browsing the generated html in the build dir.

Sat, Mar 28, 5:56 AM · Build System, Frameworks

Yesterday

pino added inline comments to D28355: Introduce function ecm_install_configured_file.
Fri, Mar 27, 11:58 PM · Build System, Frameworks
davidedmundson added inline comments to D28355: Introduce function ecm_install_configured_file.
Fri, Mar 27, 11:10 PM · Build System, Frameworks
pino added a comment to D28355: Introduce function ecm_install_configured_file.

Nice one! I cannot test right now though, I might do it over the weekend (do not hold on me though).

Fri, Mar 27, 6:42 PM · Build System, Frameworks
davidedmundson updated the diff for D28355: Introduce function ecm_install_configured_file.

Good idea. Done

Fri, Mar 27, 6:29 PM · Build System, Frameworks
pino added a comment to D28355: Introduce function ecm_install_configured_file.

Can you please adapt it so _template can be an absolute path?

Fri, Mar 27, 5:18 PM · Build System, Frameworks
davidedmundson requested review of D28355: Introduce function ecm_install_configured_file.
Fri, Mar 27, 5:00 PM · Build System, Frameworks

Tue, Mar 24

kossebau closed D28253: ECMPoQmToolsTest: have separate moc files for tr_thread_test 1 & 2.
Tue, Mar 24, 7:48 PM · Build System, Frameworks
dfaure accepted D28253: ECMPoQmToolsTest: have separate moc files for tr_thread_test 1 & 2.

Thanks!

Tue, Mar 24, 7:42 PM · Build System, Frameworks
kossebau requested review of D28253: ECMPoQmToolsTest: have separate moc files for tr_thread_test 1 & 2.
Tue, Mar 24, 7:17 PM · Build System, Frameworks

Tue, Mar 3

vkrause closed D26749: Support NDK r20 and Qt 5.14.
Tue, Mar 3, 6:47 PM · Build System, Frameworks

Mon, Mar 2

vkrause retitled D26749: Support NDK r20 and Qt 5.14 from WIP: Support NDK r20 and Qt 5.14 to Support NDK r20 and Qt 5.14.
Mon, Mar 2, 5:20 PM · Build System, Frameworks

Sun, Mar 1

vkrause added a comment to D26749: Support NDK r20 and Qt 5.14.
In D26749#620142, @apol wrote:

Seems ready to land to me.

Sun, Mar 1, 9:29 AM · Build System, Frameworks
apol added inline comments to D26749: Support NDK r20 and Qt 5.14.
Sun, Mar 1, 12:52 AM · Build System, Frameworks
apol accepted D26749: Support NDK r20 and Qt 5.14.

Seems ready to land to me.

Sun, Mar 1, 12:51 AM · Build System, Frameworks

Fri, Feb 28

kossebau added a comment to D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.

You have ommited to update the minimum ECM version in all cases AFAICS.

Fri, Feb 28, 10:36 PM · Build System, Frameworks
bruns added a comment to D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.

@kossebau - you have pushed commits depending on this change to several repositories, sometimes without waiting for acceptance, sometimes even bypassing Phabricator review completely.

Fri, Feb 28, 10:34 PM · Build System, Frameworks

Feb 26 2020

vkrause added inline comments to D26749: Support NDK r20 and Qt 5.14.
Feb 26 2020, 5:15 PM · Build System, Frameworks
vkrause closed D27596: Load QM files from assets: URLs on Android.
Feb 26 2020, 5:09 PM · Build System, Frameworks

Feb 24 2020

apol accepted D27596: Load QM files from assets: URLs on Android.

They used to work back when I added the code for it. Maybe it broke over time. If it works for you, go for it.

Feb 24 2020, 5:57 PM · Build System, Frameworks
vkrause added a comment to D27596: Load QM files from assets: URLs on Android.
In D27596#616554, @apol wrote:

Don't we need an if Qt 5.13 elseif Qt 5.14?

In other Qt versions it won't be in the assets...

Feb 24 2020, 5:29 PM · Build System, Frameworks
sitter accepted D24641: Collect more information from version control systems.

I guess nobody has further input then.
LGTM. Ship it.

Feb 24 2020, 4:03 PM · Build System, Frameworks

Feb 23 2020

apol added a comment to D27596: Load QM files from assets: URLs on Android.

Don't we need an if Qt 5.13 elseif Qt 5.14?

Feb 23 2020, 11:33 PM · Build System, Frameworks
vkrause added a task to D27596: Load QM files from assets: URLs on Android: T12520: Qt 5.14.
Feb 23 2020, 4:27 PM · Build System, Frameworks
vkrause requested review of D27596: Load QM files from assets: URLs on Android.
Feb 23 2020, 12:42 PM · Build System, Frameworks

Feb 15 2020

apol added a comment to D26749: Support NDK r20 and Qt 5.14.

Patch makes sense to me overall, we could consider landing it.

Feb 15 2020, 9:41 PM · Build System, Frameworks

Feb 10 2020

kossebau closed D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.
Feb 10 2020, 11:22 PM · Build System, Frameworks
sitter added a comment to D24641: Collect more information from version control systems.

The WARNING tags should be removed or changed to AUTHOR_WARNING I think. A stray call to one of the functions here isn't really something a user building a tarball, for example, can do anything about, so WARNING seems wrong.

Feb 10 2020, 12:24 PM · Build System, Frameworks

Feb 9 2020

kossebau added a dependent revision for D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category: D27270: Use ecm_qt_install_logging_categories over manual categories files.
Feb 9 2020, 8:13 PM · Build System, Frameworks
kossebau added a dependent revision for D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category: D27269: Use ecm_qt_install_logging_categories over manual categories file.
Feb 9 2020, 8:03 PM · Build System, Frameworks
kossebau updated the diff for D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.

Add support for also generating renamecategories files

Feb 9 2020, 8:01 PM · Build System, Frameworks
kossebau added a comment to D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.

Yep you need to create a file name "foo.renamecategories" where you change the categorie name

  1. old module name<space>new module name

    for example "log_mailfilteragent org.kde.pim.mailfilteragent" in kmail

Does kdebugsettings also support multiple renames? Like log1 > log2 > log3?

Perhaps :) I will test it next week

Feb 9 2020, 7:25 PM · Build System, Frameworks
mlaurent added a comment to D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.

Yep you need to create a file name "foo.renamecategories" where you change the categorie name

  1. old module name<space>new module name

    for example "log_mailfilteragent org.kde.pim.mailfilteragent" in kmail

Does kdebugsettings also support multiple renames? Like log1 > log2 > log3?

Feb 9 2020, 5:55 PM · Build System, Frameworks
kossebau added a comment to D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.

Yep you need to create a file name "foo.renamecategories" where you change the categorie name

  1. old module name<space>new module name

    for example "log_mailfilteragent org.kde.pim.mailfilteragent" in kmail
Feb 9 2020, 5:43 PM · Build System, Frameworks
cullmann abandoned D8281: Allow to use IcoTool for Windows icons.
Feb 9 2020, 12:01 PM · Build System, Frameworks
cullmann commandeered D8281: Allow to use IcoTool for Windows icons.

I reviewed the current state and there is now already icotool support in our extra-cmake-modules stuff => closing this.

Feb 9 2020, 12:01 PM · Build System, Frameworks
cullmann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

For the lambda issue, I think we can add:

# keep lambda formatting multi-line if not empty
AllowShortLambdasOnASingleLine: Empty

see https://clang.llvm.org/docs/ClangFormatStyleOptions.html

That fixes for me the issue with the collapsed lambda.

For the comments, as said, we can remove

AlignTrailingComments: true

For the generic issue of stuff folded in one line, one can play with the ColumnLimit, but as said, that will still arbitrarily pack stuff as long as it fits the limit.

Kai, could you try the two changes (for lambda and comments) by just temporarily changing that in the .clang-format file locally and rerunning make clang-format?

Feb 9 2020, 11:45 AM · Build System, Frameworks
mlaurent added a comment to D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.

Yep you need to create a file name "foo.renamecategories" where you change the categorie name

  1. old module name<space>new module name
Feb 9 2020, 8:47 AM · Build System, Frameworks

Feb 8 2020

kossebau added a comment to D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.

@mlaurent Wasn't there also something which tells kdebugsettings about renamed categories? Is that documented anywhere? Could that be supported by some additional macro or adaption of the existing/new ones?

Feb 8 2020, 10:49 PM · Build System, Frameworks
kossebau added a comment to D26394: ECMGeneratePriFile: Fix static configurations.

Pushed a8c3ab79912fcb25d7e59a04c08752a9252a5f08 as hotfix for now.

Feb 8 2020, 10:21 PM · Build System, Frameworks
kossebau added inline comments to D26394: ECMGeneratePriFile: Fix static configurations.
Feb 8 2020, 9:55 PM · Build System, Frameworks
lbeltrame updated subscribers of D26394: ECMGeneratePriFile: Fix static configurations.

This breaks stuff in PIM:

Feb 8 2020, 8:38 AM · Build System, Frameworks

Feb 7 2020

kossebau added a comment to D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.

Good. So will land this next Tuesday, Feb 11th then, so other people will have had 7 days of feedback opportunity.

Feb 7 2020, 2:38 PM · Build System, Frameworks
kfunk closed D26394: ECMGeneratePriFile: Fix static configurations.
Feb 7 2020, 11:03 AM · Build System, Frameworks

Feb 6 2020

mlaurent added a comment to D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.

I don't see other case. For me your macro works for all case that we can implement.

Feb 6 2020, 2:56 PM · Build System, Frameworks
kossebau added a comment to D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.

@mlaurent Thanks for review :)
Do you happen to know any more complex usages of ecm_qt_declare_logging_category and/or manual category definitions which can and should be checked for how these new methods would work out?
I have not really researched bigger parts of KDE code for if the currently proposed method calls will be sufficient to cover all use cases. So far it's mainly based on KDevelop, kcoreaddons, kservice & sonnet use-cases.
So far it was mainly: @broulik complained on irc, a day later I accidentally found another approach to the target-based hack we had in kdevelop, changed kdevelop cmake code, then pulled out the core logic and turned into this patch, after trying to port kcoreaddons, kservice & sonnet :)
Thus also hesitating to merge on first positive review, as I am not sure myself yet, still thinking of this as prototype to get feedback on.

Feb 6 2020, 2:40 PM · Build System, Frameworks
mlaurent accepted D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.

Seems ok for me :)

Feb 6 2020, 7:17 AM · Build System, Frameworks

Feb 5 2020

kossebau added a dependent revision for D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category: D27178: Use ecm_qt_install_logging_categories over manual categories file.
Feb 5 2020, 9:16 PM · Build System, Frameworks
kossebau updated the diff for D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category.

in doc also be explicit that ecm_qt_install_logging_categories can be in
another directory, just needs to be called last

Feb 5 2020, 9:16 PM · Build System, Frameworks
vkrause added a comment to D26749: Support NDK r20 and Qt 5.14.

Excellent news! Could you post your Kirigami patch somewhere maybe? Makes this easier to test here :)

Feb 5 2020, 8:18 AM · Build System, Frameworks