Build SystemOrganization
ActivePublic

Recent Activity

Sat, Sep 14

kossebau closed D23791: ECMAddQch: add INCLUDE_DIRS argument.
Sat, Sep 14, 11:53 PM · Build System, Frameworks
kossebau added a comment to D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API.

Quick update:
Currently still busy trying to get unit tests done, half-way through that. ETA begin of upcoming week.
Next plan: see how only having the 3-arg-FOO_DEPRECATED_VERSION(major. minor, message) would work by using that in the experimental patches done for some KF repos.

Sat, Sep 14, 11:58 AM · Build System, Frameworks
dfaure accepted D23791: ECMAddQch: add INCLUDE_DIRS argument.

I don't know doxygen very well, but the cmake change seems sensible.

Sat, Sep 14, 11:16 AM · Build System, Frameworks

Fri, Sep 13

dfaure added inline comments to D21695: Add FindTaglib.cmake.
Fri, Sep 13, 1:01 PM · Build System, Frameworks
ngraham added a comment to D21695: Add FindTaglib.cmake.

Can we move forward on this?

Fri, Sep 13, 12:57 PM · Build System, Frameworks

Wed, Sep 11

dfaure added a comment to D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API.

I wouldn't offer both variants, but rather recommend always adding a hint. At worse that hint can be "See method documentation" or an empty string. I think we're just over-complicating things otherwise, for no actual gain, since providing a hint is good practice anyway.

Wed, Sep 11, 5:12 PM · Build System, Frameworks
kossebau added inline comments to D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API.
Wed, Sep 11, 3:58 PM · Build System, Frameworks
kossebau updated the diff for D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API.
  • reword documentation based on dfaure's comments
  • bump since-version to 5.64.0, as currently targetted introduction version
Wed, Sep 11, 3:57 PM · Build System, Frameworks
kossebau added a comment to D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API.

@dfaure Thanks for first in-detail feedback, good to get a feeling this is not totally insane over-engineered stuff to other people'e eyes :)

Wed, Sep 11, 1:33 PM · Build System, Frameworks

Tue, Sep 10

dfaure added a comment to D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API.

Great work. Not really easy to grasp at first sight (because it handles BC for no-compat builds of the lib itself, which we never did before) but this is certainly quite comprehensive.

Tue, Sep 10, 8:11 PM · Build System, Frameworks
kossebau added a comment to D23791: ECMAddQch: add INCLUDE_DIRS argument.

Would push upcoming WE if there are no objections.
And then also adapt all KF modules to make use of this new argument, for better results and less need for predefined macros.

Tue, Sep 10, 12:34 PM · Build System, Frameworks

Mon, Sep 9

kossebau retitled D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API from WIP: Add ECMGenerateExportHeaders, for improved handling of deprecated API to RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API.
Mon, Sep 9, 5:07 PM · Build System, Frameworks
kossebau added a dependent revision for D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API: D23802: RFC: Use ECMGenerateExportHeader to manage deprecated API better.
Mon, Sep 9, 4:31 PM · Build System, Frameworks
kossebau added a dependent revision for D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API: D23800: RFC: Use ECMGenerateExportHeader to manage deprecated API better.
Mon, Sep 9, 4:06 PM · Build System, Frameworks
kossebau updated the diff for D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API.
  • change BEFORE to BEFORE_AND_AT, to match actual Qt behaviour (though do not copy confusing name, but be more precise using AND_AT
  • add NO_DEFINITION_EXPORT_TO_BUILD_INTERFACE option
Mon, Sep 9, 3:27 PM · Build System, Frameworks
kossebau added a comment to D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API.

Tests needed :)

Mon, Sep 9, 12:15 PM · Build System, Frameworks

Sun, Sep 8

kossebau requested review of D23791: ECMAddQch: add INCLUDE_DIRS argument.
Sun, Sep 8, 4:15 PM · Build System, Frameworks
cgiboudeaux added a comment to D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API.

Tests needed :)

Sun, Sep 8, 4:10 PM · Build System, Frameworks
kossebau added a comment to D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API.

Current version works already quite well, developed against applying it to a few tier-1 and tier-2 KDE Frameworks modules.
A few corner casess still need care, but otherwise already pretty much a prototype which is not too far from a production version.

Sun, Sep 8, 3:39 PM · Build System, Frameworks
kossebau requested review of D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API.
Sun, Sep 8, 3:24 PM · Build System, Frameworks

Fri, Sep 6

kossebau closed D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg.
Fri, Sep 6, 8:39 PM · Build System, Frameworks
kossebau added a comment to D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg.

Given ECM 5.62 will be tagged this WE and thus the API of the new macro ecm_qtdesignerplugin_widget being frozen, and no-one really gave feedback on the initial API, would take the responsibility and push tonight, unless there is last minute discussion. Only users of the arguments changed here is Okteta (by what lxr.kde.org reports), which are my changes as well and partial motivation for this change.

Fri, Sep 6, 3:14 PM · Build System, Frameworks
kossebau updated the diff for D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg.

For convenience still enable CONSTRUCTOR_ARGS_CODE, usually simple string
without ";"

Fri, Sep 6, 3:04 PM · Build System, Frameworks

Wed, Sep 4

kossebau added a dependent revision for D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg: D23726: Designer plugin: adapt to pre-release API change of ECMAddQtDesignerPlugin.
Wed, Sep 4, 11:07 PM · Build System, Frameworks
kossebau requested review of D23725: ECMAddQtDesignerPlugin: pass code sample indirectly via variable name arg.
Wed, Sep 4, 11:05 PM · Build System, Frameworks

Thu, Aug 29

bcooksley updated subscribers of D23262: disable autouic again - it breaks builds.
Thu, Aug 29, 7:14 PM · Build System, Frameworks
fusitter added a comment to D22805: set autorcc and autouic by default.

[spam comment removed by sysadmin]

Thu, Aug 29, 3:57 PM · Build System, Frameworks
fusitter added a comment to D23262: disable autouic again - it breaks builds.
Thu, Aug 29, 3:57 PM · Build System, Frameworks
fsitter added a comment to D23552: ECM: remove set_package_properties from FindCanberra.

[spam comment removed by sysadmin]

Thu, Aug 29, 3:49 PM · Build System, Frameworks
dfaure abandoned D23552: ECM: remove set_package_properties from FindCanberra.

Ah, I didn't realize there was no warning if calling set_package_properties with different properties.

Thu, Aug 29, 7:46 AM · Build System, Frameworks
cgiboudeaux added a comment to D23552: ECM: remove set_package_properties from FindCanberra.

I'd do the opposite, remove DESCRIPTION and URL from knotification's CMakeLists.txt and only leave the PURPOSE line.

Thu, Aug 29, 5:59 AM · Build System, Frameworks

Wed, Aug 28

kossebau added a comment to D23552: ECM: remove set_package_properties from FindCanberra.

Compare though all the

Ideally this is set already directly in the Find-module.

for DESCRIPTION and URL properties in the docs https://cmake.org/cmake/help/latest/module/FeatureSummary.html

Wed, Aug 28, 11:51 PM · Build System, Frameworks
sitter added a comment to D23552: ECM: remove set_package_properties from FindCanberra.

No objections from me. This was explicitly suggested during review though, so I'd like @cgiboudeaux to approve this.

Wed, Aug 28, 11:49 PM · Build System, Frameworks
dfaure requested review of D23552: ECM: remove set_package_properties from FindCanberra.
Wed, Aug 28, 11:29 PM · Build System, Frameworks
arojas closed D23497: Keep 'lib' as default libdir on Arch Linux based systems.
Wed, Aug 28, 5:45 AM · Build System, Frameworks
apol accepted D23497: Keep 'lib' as default libdir on Arch Linux based systems.
Wed, Aug 28, 12:05 AM · Build System, Frameworks

Tue, Aug 27

arojas requested review of D23497: Keep 'lib' as default libdir on Arch Linux based systems.
Tue, Aug 27, 3:12 PM · Build System, Frameworks

Sun, Aug 25

ngraham added a comment to D21695: Add FindTaglib.cmake.

@heikobecker ping!

Sun, Aug 25, 3:13 PM · Build System, Frameworks

Thu, Aug 22

daandemeyer abandoned D22699: Support passing target to ecm_qt_declare_logging_category.

KF6 is a long time out so I'm abandoning this.

Thu, Aug 22, 7:53 AM · Build System, Frameworks
daandemeyer abandoned D22709: Support passing target to ecm_add_app_icon..

KF6 is a long time out so I'm abandoning this.

Thu, Aug 22, 7:53 AM · Frameworks, Build System

Aug 20 2019

sitter added a comment to D23262: disable autouic again - it breaks builds.

https://gitlab.kitware.com/cmake/cmake/issues/19615

Aug 20 2019, 9:01 AM · Build System, Frameworks

Aug 19 2019

sitter closed D23262: disable autouic again - it breaks builds.
Aug 19 2019, 2:30 PM · Build System, Frameworks
apol accepted D23262: disable autouic again - it breaks builds.

Thanks!

Aug 19 2019, 2:29 PM · Build System, Frameworks
sitter abandoned D22805: set autorcc and autouic by default.

D23262

Aug 19 2019, 2:02 PM · Build System, Frameworks
sitter requested review of D23262: disable autouic again - it breaks builds.
Aug 19 2019, 2:01 PM · Build System, Frameworks
cullmann added a comment to D22805: set autorcc and autouic by default.

Yep, KTextEditor is broken for me, too.

Aug 19 2019, 1:52 PM · Build System, Frameworks
nicolasfella requested changes to D22805: set autorcc and autouic by default.
Aug 19 2019, 1:26 PM · Build System, Frameworks
nicolasfella reopened D22805: set autorcc and autouic by default.

This seems to cause the build of sonnet to fail: https://invent.kde.org/snippets/394

Aug 19 2019, 1:26 PM · Build System, Frameworks
sitter closed D22805: set autorcc and autouic by default.
Aug 19 2019, 1:04 PM · Build System, Frameworks
apol accepted D22805: set autorcc and autouic by default.

LGTM

Aug 19 2019, 12:35 PM · Build System, Frameworks