Tue, Jun 19
Mon, Jun 18
Thu, Jun 7
Tue, Jun 5
@cgiboudeaux maybe you can accept the patch?
Thu, May 31
Wed, May 30
Interesting! This is probably a better way to solve the problem than the CMAKE_EXE_LINKER_FLAGS workaround we are doing currently.
http://doc.qt.io/qt-5/deployment-android.html at the bottom of the page there is an example of usage scenario for qmake project:
Mention on the documentation that we don't change the lib/ value on flatpak
Tue, May 29
Fri, May 25
Please update the doc above.
May 14 2018
Sadly the commit went without the GIT_SILENT, sorry about that. I did:
git commit -amend # to add the GIT_SILENT
I guess that the arc land called another arc amend.
Please use the GIT_SILENT keyword for typo fixes.
Please let me know if it's okay to land this kind of changes directly.
Apr 17 2018
Apr 14 2018
Apr 13 2018
For Qt < 5.12 this is ok as a temporary solution I think, but with the new androiddeployqt I'd rather add -android-dependencies.xml files for the libraries needing plugins (simple example: https://github.com/KDAB/GammaRay/blob/master/probe/gammaray_probe-android-dependencies.xml, more complex ones are part of Qt itself). Then you'll only get the plugins included that a library you (indirectly) use actually needs. That's much cleaner IMHO.
I very much like that direction. I always found the need to specify platform-independent build properties explicitly on the command line weird, so anything moving towards being able to just write that into CMakeLists.txt is good :)
A module with cmake functions you call instead will then also make it easier to control apk generation in more detail by specifying additional parameters, so we can eventually disable the full copying of share and lib/qml.
Apr 12 2018
Just tested that my 64bit host nm can also consume 32bit ARM binaries, seems to work, so not using the corresponding toolchain nm is probably fine here.
Apr 11 2018
Is this going to fail on my translated nm output?
Builds fine here, and moving closer to the Android cmake files makes sense IMHO.
Apr 10 2018
Apr 7 2018
Reference: https://build.kde.org/view/Frameworks/job/Frameworks%20ki18n%20kf5-qt5%20SUSEQt5.10/24/testReport/(root)/TestSuite/ki18n_install/ but also reproducible locally.
This broke the unittest :
Apr 6 2018