A .rst file in the docs/module/ directory is needed, otherwise the documentation generation will not pick up this, as it runs only over docs/.
Please enable the documentation generation in your ecm build and check for yourself, by e.g. ensuring BUILD_HTML_DOCS is ON and browsing the generated html in the build dir.
Nice one! I cannot test right now though, I might do it over the weekend (do not hold on me though).
Good idea. Done
Can you please adapt it so _template can be an absolute path?
Tue, Mar 24
Tue, Mar 3
Mon, Mar 2
Sun, Mar 1
Seems ready to land to me.
Fri, Feb 28
@kossebau - you have pushed commits depending on this change to several repositories, sometimes without waiting for acceptance, sometimes even bypassing Phabricator review completely.
Feb 26 2020
Feb 24 2020
They used to work back when I added the code for it. Maybe it broke over time. If it works for you, go for it.
I guess nobody has further input then.
LGTM. Ship it.
Feb 23 2020
Don't we need an if Qt 5.13 elseif Qt 5.14?
Feb 15 2020
Patch makes sense to me overall, we could consider landing it.
Feb 10 2020
The WARNING tags should be removed or changed to AUTHOR_WARNING I think. A stray call to one of the functions here isn't really something a user building a tarball, for example, can do anything about, so WARNING seems wrong.
Feb 9 2020
Add support for also generating renamecategories files
I reviewed the current state and there is now already icotool support in our extra-cmake-modules stuff => closing this.
Yep you need to create a file name "foo.renamecategories" where you change the categorie name
- old module name<space>new module name
Feb 8 2020
@mlaurent Wasn't there also something which tells kdebugsettings about renamed categories? Is that documented anywhere? Could that be supported by some additional macro or adaption of the existing/new ones?
Pushed a8c3ab79912fcb25d7e59a04c08752a9252a5f08 as hotfix for now.
This breaks stuff in PIM:
Feb 7 2020
Good. So will land this next Tuesday, Feb 11th then, so other people will have had 7 days of feedback opportunity.
Feb 6 2020
I don't see other case. For me your macro works for all case that we can implement.
@mlaurent Thanks for review :)
Do you happen to know any more complex usages of ecm_qt_declare_logging_category and/or manual category definitions which can and should be checked for how these new methods would work out?
I have not really researched bigger parts of KDE code for if the currently proposed method calls will be sufficient to cover all use cases. So far it's mainly based on KDevelop, kcoreaddons, kservice & sonnet use-cases.
So far it was mainly: @broulik complained on irc, a day later I accidentally found another approach to the target-based hack we had in kdevelop, changed kdevelop cmake code, then pulled out the core logic and turned into this patch, after trying to port kcoreaddons, kservice & sonnet :)
Thus also hesitating to merge on first positive review, as I am not sure myself yet, still thinking of this as prototype to get feedback on.
Seems ok for me :)
Feb 5 2020
in doc also be explicit that ecm_qt_install_logging_categories can be in
another directory, just needs to be called last