Jan 17 2019
https://phabricator.kde.org/D17860 has been committed.
Jan 1 2019
Updated. I'm not using arcanist... I suppose I should bug the mailing list every so often?
Dec 29 2018
Also, it is extremely unpractical to get a review through a task - they are not meant for this. Please close this and send a review.
I'd really suggest to use arcanist and send a patch. Commit to the local repository, arc diff, and that's it, the kdegames mailing list will be notified.
Dec 20 2018
diff --git a/cellitem.cpp b/cellitem.cpp index b4e3060..443b743 100644 --- a/cellitem.cpp +++ b/cellitem.cpp @@ -33,6 +33,17 @@ CellItem::CellItem(KGameRenderer* renderer, QGraphicsItem* parent) reset(); }
Not really sure how to use all your tooling (way, way too complicated, doesn't work/breaks).
Oct 21 2018
Sep 24 2018
Removed the uncessary localization update since that has been fixed elsewhere and renamed the revision to make it clear it's just about OARS now
Sep 21 2018
(this specific change is going to be only about adding the oars tag)
But then the commit message should be fixed, and also the german change removed.
The german translation part should go to @kde-i18n-de. Will reach out.
Sep 4 2018
No need for being sorry :) it's just that the unified issue tracker is there.
Tasks can be created later from bugs, depending on the team.
Thanks for reporting the issue.
On it - but this should have been a bugs on bugs.kde.org, not a task here.
May 22 2018
Sigh, could have thought of this. Yeah, I'll open a ticket.
Problem is that now continuous integration fails because the lib is not available.
Thanks, Fabian, and - you are welcome!
Oh well, time to get this merged. I didn't get *too* strong objection from the mailing list, so I intend to merge this as is. Thank you very much @shlomif for your patience and your code contribution.
May 16 2018
Yeah, sure, I'll send the mail.
May 14 2018
@fabiank : from what I seem to recall, that new file was derived from an existing one that carried that copyright. I on my part disclaim any ownership for my modifications to this file.
Sorry, I technically reviewed it already, but forgot to hit submit :-(. I'm happy with the current state of the code (sans that one copyright line), and the solver does a better job than the current one.
May 13 2018
hi! Can you please review the second (and the latest) patch?
Apr 24 2018
Update to the master branch and apply commentary from the reviewers - no iostream, no kDebug, precanned solving themes, etc.
Apr 23 2018
Considering that currently no one (including me, the de-facto maintainer) really knows what the solver is doing exactly and how the numbers for the search in it were derived, I appreciate outsourcing the logic to a library. However, like @aacid said, it would be nice to have either some numbers how the solver compares.
Do you have a game number we can use to compare how this is better than the existing code?
Apr 21 2018
Jan 20 2018
Pushed to master and Applications/17.12
Jan 17 2018
Jan 14 2018
Jan 11 2018
Jan 10 2018
I just realzied this is not how you use QMEsasgebox critical.
fix diff ... hopefully