KDE GamesProject
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Jan 20 2018

helfferich closed D9790: Fix slowdown issue.

Pushed to master and Applications/17.12

Jan 20 2018, 8:29 PM · KDE Games

Jan 17 2018

aacid accepted D9790: Fix slowdown issue.
Jan 17 2018, 5:29 PM · KDE Games

Jan 14 2018

schwarzer closed D9805: Show error message to the user.
Jan 14 2018, 10:40 PM · KDE Games

Jan 11 2018

aacid accepted D9805: Show error message to the user.
Jan 11 2018, 7:15 PM · KDE Games
schwarzer updated the diff for D9805: Show error message to the user.
Jan 11 2018, 6:51 PM · KDE Games
schwarzer updated the diff for D9805: Show error message to the user.
Jan 11 2018, 6:49 PM · KDE Games

Jan 10 2018

schwarzer added a comment to D9805: Show error message to the user.
In D9805#189154, @aacid wrote:

I just realzied this is not how you use QMEsasgebox critical.

Since it's static you just do QMessageBox::critical(...)

Jan 10 2018, 11:35 PM · KDE Games
aacid added a comment to D9805: Show error message to the user.

I just realzied this is not how you use QMEsasgebox critical.

Jan 10 2018, 10:31 PM · KDE Games
schwarzer updated the diff for D9805: Show error message to the user.

fix diff ... hopefully

Jan 10 2018, 10:10 PM · KDE Games
schwarzer added a comment to D9805: Show error message to the user.
In D9805#189130, @aacid wrote:

Is phabricator being silly or are your patches missing some stuff?

Like it says
...\nPlease install the
and ends there

Jan 10 2018, 10:09 PM · KDE Games
aacid added a comment to D9790: Fix slowdown issue.

Looks sensible, only minor comment is that you should be using === instead of == in JavaScript code since it's marginally faster, but not that it matters much.

Jan 10 2018, 10:01 PM · KDE Games
aacid added a comment to D9805: Show error message to the user.

Is phabricator being silly or are your patches missing some stuff?

Jan 10 2018, 9:57 PM · KDE Games
schwarzer added a comment to D9790: Fix slowdown issue.

Do you mean switching the interval/substeps/speed? Or switching from a change in timer interval to the substeps?

I'll try to explain:

  1. Why change the interval? The basic loop is: Move ball -> Check for collisions -> Change direction, perform actions, according to collisions, etc. -> Move ball -> ... The speed determines how far the ball is moved during the "Move ball". If the ball is moved too far, the collision detection might be inaccurate (E.g. the extreme case is the ball moving through a brick with no detected collision). To avoid such bugs, we move the ball only half the distance, but twice as often.
  2. Why use substeps now? In the original code, this was done by cutting the gameTimer interval in half. However, this broke during the port to QML, because QML timer have a minimum interval of 16ms. Cutting it in half to 8ms does not have any effect. The alternative approach is to keep the gameTimer interval, but perform the basic loop twice.
Jan 10 2018, 9:39 PM · KDE Games
helfferich added a comment to D9790: Fix slowdown issue.

Do you mean switching the interval/substeps/speed? Or switching from a change in timer interval to the substeps?

Jan 10 2018, 7:20 PM · KDE Games
helfferich updated the diff for D9790: Fix slowdown issue.

Thanks for catching the typo. About the comment: You are of course perfectly right :D.

Jan 10 2018, 7:08 PM · KDE Games
schwarzer added a comment to D9790: Fix slowdown issue.

OK, tested it and it works as in the ball does not slow down anymore.
I cannot really argue about the implementation because I did not understand why this switching is needed in the first place. :D

Jan 10 2018, 5:52 PM · KDE Games
schwarzer added a comment to D9790: Fix slowdown issue.

Thanks for picking up the topic with a patch. :)
I might be able to test this tonight but not sure.
Anyway, here are just some things I saw while scrolling over the patch.

Jan 10 2018, 12:58 PM · KDE Games

Aug 25 2017

starbuck closed T6675: New categories for few games as Resolved.
Aug 25 2017, 8:21 AM · KDE Games, KDE Store
starbuck added a comment to T6675: New categories for few games.

Your welcome! If there are any more issues, just open a new ticket or re-open this one.

Aug 25 2017, 8:20 AM · KDE Games, KDE Store

Aug 24 2017

ltoscano added a comment to T6675: New categories for few games.

Thanks for the API reference to the list of the categories.

Aug 24 2017, 9:48 PM · KDE Games, KDE Store
starbuck added a comment to T6675: New categories for few games.

I checked and see the categories listed live here:
https://api.kde-look.org/ocs/v1/content/categories

Aug 24 2017, 2:18 PM · KDE Games, KDE Store
starbuck added a comment to T6675: New categories for few games.

Isn't it https://autoconfig.kde.org/ocs/providers.xml nowadays (not sure about what is the prefered URL)?
Also, where do you get the error with what request?

Aug 24 2017, 2:16 PM · KDE Games, KDE Store
ltoscano added a comment to T6675: New categories for few games.

Ok, but then, what happened with the new categories? Just to name one, I fixed kdiamond according the name which is shown, but I see an error about non-existing category:

Aug 24 2017, 12:38 PM · KDE Games, KDE Store
starbuck added a comment to T6675: New categories for few games.

Yeah, that could be.
KNS/GHNS unfortunately has the habit to look for a hardcoded category name, so to make it work backwards compatible, I would need to know the exact string each program tries to match and add it as "legacy name" internally.

Aug 24 2017, 10:24 AM · KDE Games, KDE Store

Aug 23 2017

ltoscano added a comment to T6675: New categories for few games.

Thank you. Another question: is it possible that the name shown does not match the internal name? I see messages from knewstuff saying that the categories do not exists.

Aug 23 2017, 10:23 PM · KDE Games, KDE Store
starbuck added a comment to T6675: New categories for few games.

Since knewstuff is now retired (and from my understanding didnt feature an account management?) the best would be

  1. ask the authors to create an account and re-publish them.
Aug 23 2017, 8:17 AM · KDE Games, KDE Store

Aug 22 2017

ltoscano added a comment to T6675: New categories for few games.

Thanks! Did you see also my question about the possibility of sending contents from someone who is not the author?

Aug 22 2017, 7:57 PM · KDE Games, KDE Store
starbuck added a comment to T6675: New categories for few games.

All Categories have bveen added: https://store.kde.org/browse/cat/355/ord/latest/

Aug 22 2017, 1:39 PM · KDE Games, KDE Store

Aug 21 2017

ltoscano updated subscribers of T6675: New categories for few games.

Gently ping @starbuck

Aug 21 2017, 9:46 AM · KDE Games, KDE Store

Jul 29 2017

ltoscano added a comment to T6675: New categories for few games.

Also, another category:

Jul 29 2017, 1:36 PM · KDE Games, KDE Store
ltoscano added a comment to T6380: Ensure that KNewStuff works.

Also, another category:

Jul 29 2017, 1:35 PM · KDE Games
ltoscano renamed T6675: New categories for few games from New categories for to New categories for few games.
Jul 29 2017, 1:22 PM · KDE Games, KDE Store
ltoscano created T6675: New categories for few games.
Jul 29 2017, 1:22 PM · KDE Games, KDE Store
ltoscano reopened T6380: Ensure that KNewStuff works as "Open".

It turns out the the web server on the machines hosting newstuff.kde.org was restarted by accident when I tested the applications few days ago. So the testing worked just by pure chance.
Reopening, few applications need categories on store.kde.org:

Jul 29 2017, 12:57 PM · KDE Games

Jul 23 2017

ltoscano closed T6380: Ensure that KNewStuff works as Resolved.
Jul 23 2017, 9:54 AM · KDE Games
ltoscano added a comment to T6380: Ensure that KNewStuff works.

Apparently the issues was temporary or it has been solved somehow. As today (2017-07-23) all knsrc files in kdegames/ which has a corresponding GUI can load something (or at least not error out). Closing then.

Jul 23 2017, 9:54 AM · KDE Games

Jun 23 2017

ltoscano created T6380: Ensure that KNewStuff works.
Jun 23 2017, 7:10 AM · KDE Games

May 2 2017

ltoscano added a comment to T5997: KSudoku: print without waiting for more schemas/for quit.

Maybe changing the value is fine. Or the print dialog could have a button (if it's possible to extend it, not sure with Qt5 and its incomplete state) that says "Print immediately". Whatever is easier.
About wasting paper: if you are going to print, how many schemas are you going to print?

May 2 2017, 10:06 PM · KDE Games
ouwerkerk added a comment to T5997: KSudoku: print without waiting for more schemas/for quit.

In that case, maybe you'd simply want to flip the default value of the setting "When printing, try to fit more than one puzzle on a page" instead?
That way ksudoku will print just the one puzzle, wasting paper, but it will print it right away.

May 2 2017, 9:36 PM · KDE Games
ltoscano added a comment to T5997: KSudoku: print without waiting for more schemas/for quit.

Or simply print immediately :)

May 2 2017, 9:26 PM · KDE Games
ouwerkerk added a comment to T5997: KSudoku: print without waiting for more schemas/for quit.

I take it you mean you want a different UX for the printing feature. Something more like the following, perhaps?

May 2 2017, 9:23 PM · KDE Games
ouwerkerk moved T5980: Sudoku: port dbo* statements/calls to qCDebug from Backlog to In progress on the KDE Games board.
May 2 2017, 6:15 AM · KDE Games
ouwerkerk claimed T5980: Sudoku: port dbo* statements/calls to qCDebug.
May 2 2017, 6:15 AM · KDE Games

May 1 2017

ouwerkerk closed T5981: Sudoku: fix segfault when generating a puzzle from improperly loaded game variants as Resolved by committing R417:817ad710b3e5: Fix segfault when attempting to generate or enter in an invalid game variant..
May 1 2017, 6:26 PM · KDE Games

Apr 30 2017

ltoscano added a comment to T5980: Sudoku: port dbo* statements/calls to qCDebug.

Possible issue which requires some thinking: some of those dbo calls write a formatted text (like a game schema), so it should be investigated whether this is still required, or if some overload of the << operator are required.

Apr 30 2017, 10:20 PM · KDE Games
ouwerkerk added a revision to T5981: Sudoku: fix segfault when generating a puzzle from improperly loaded game variants: D5671: Fix segfault when attempting to generate or enter in an invalid game variant..
Apr 30 2017, 4:54 PM · KDE Games
ouwerkerk claimed T5981: Sudoku: fix segfault when generating a puzzle from improperly loaded game variants.
Apr 30 2017, 4:51 PM · KDE Games
ouwerkerk moved T5981: Sudoku: fix segfault when generating a puzzle from improperly loaded game variants from Backlog to In progress on the KDE Games board.
Apr 30 2017, 4:51 PM · KDE Games
ouwerkerk closed T5977: Sudoku: use QFileInfoList in KSudoku::updateShapesList() as Resolved.

This change has landed.

Apr 30 2017, 3:52 PM · KDE Games
ltoscano created T5997: KSudoku: print without waiting for more schemas/for quit.
Apr 30 2017, 3:38 PM · KDE Games