KDE GamesProject
ActivePublic

Watchers

  • This project does not have any watchers.

Recent Activity

Mon, Sep 24

ltoscano accepted D15641: Add OARS to Kubrick.

Thanks!

Mon, Sep 24, 9:18 AM · KDE Games
nickrichards updated the diff for D15641: Add OARS to Kubrick.

Removed the uncessary localization update since that has been fixed elsewhere and renamed the revision to make it clear it's just about OARS now

Mon, Sep 24, 9:07 AM · KDE Games

Fri, Sep 21

ltoscano added a comment to D15641: Add OARS to Kubrick.

(this specific change is going to be only about adding the oars tag)

Fri, Sep 21, 10:03 AM · KDE Games
ltoscano requested changes to D15641: Add OARS to Kubrick.

But then the commit message should be fixed, and also the german change removed.

Fri, Sep 21, 10:02 AM · KDE Games
nickrichards added a comment to D15641: Add OARS to Kubrick.

Thanks!

Fri, Sep 21, 9:53 AM · KDE Games
apol accepted D15641: Add OARS to Kubrick.

The german translation part should go to @kde-i18n-de. Will reach out.

Fri, Sep 21, 9:51 AM · KDE Games
nickrichards requested review of D15641: Add OARS to Kubrick.
Fri, Sep 21, 9:49 AM · KDE Games

Sep 4 2018

ltoscano added a comment to T9621: Klickety - install the appdata.

No need for being sorry :) it's just that the unified issue tracker is there.
Tasks can be created later from bugs, depending on the team.
Thanks for reporting the issue.

Sep 4 2018, 7:51 PM · KDE Games
ltoscano closed T9621: Klickety - install the appdata as Resolved by committing R401:d1fbba470ff1: Install the appdata files and fix few metadata.
Sep 4 2018, 7:49 PM · KDE Games
nickrichards added a comment to T9621: Klickety - install the appdata.

Apologies.

Sep 4 2018, 7:44 PM · KDE Games
ltoscano claimed T9621: Klickety - install the appdata.

On it - but this should have been a bugs on bugs.kde.org, not a task here.

Sep 4 2018, 6:44 PM · KDE Games
nickrichards created T9621: Klickety - install the appdata.
Sep 4 2018, 11:47 AM · KDE Games

May 22 2018

fabiank added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

Sigh, could have thought of this. Yeah, I'll open a ticket.

May 22 2018, 7:37 PM · KDE Games
aacid added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

Problem is that now continuous integration fails because the lib is not available.

May 22 2018, 7:34 PM · KDE Games
shlomif added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

Thanks, Fabian, and - you are welcome!

May 22 2018, 7:29 PM · KDE Games
fabiank closed D12415: Use Freecell Solver for FreeCell and Simple Simon.
May 22 2018, 6:50 PM · KDE Games
fabiank accepted D12415: Use Freecell Solver for FreeCell and Simple Simon.
May 22 2018, 6:50 PM · KDE Games
fabiank added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

Oh well, time to get this merged. I didn't get *too* strong objection from the mailing list, so I intend to merge this as is. Thank you very much @shlomif for your patience and your code contribution.

May 22 2018, 6:49 PM · KDE Games

May 16 2018

fabiank added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

Yeah, sure, I'll send the mail.

May 16 2018, 5:10 PM · KDE Games

May 14 2018

aacid added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.
@aacid :  Do you know anyone from the distro side who could chime in if adding the library would  pose an issue?
May 14 2018, 11:15 PM · KDE Games
shlomif added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

@fabiank : from what I seem to recall, that new file was derived from an existing one that carried that copyright. I on my part disclaim any ownership for my modifications to this file.

May 14 2018, 10:03 AM · KDE Games
fabiank added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

Sorry, I technically reviewed it already, but forgot to hit submit :-(. I'm happy with the current state of the code (sans that one copyright line), and the solver does a better job than the current one.

May 14 2018, 9:14 AM · KDE Games

May 13 2018

shlomif added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

hi! Can you please review the second (and the latest) patch?

May 13 2018, 1:12 PM · KDE Games

Apr 24 2018

shlomif updated the diff for D12415: Use Freecell Solver for FreeCell and Simple Simon.

Update to the master branch and apply commentary from the reviewers - no iostream, no kDebug, precanned solving themes, etc.

Apr 24 2018, 2:59 PM · KDE Games
shlomif added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

Hi all!

Apr 24 2018, 12:26 PM · KDE Games

Apr 23 2018

fabiank added a comment to D12415: Use Freecell Solver for FreeCell and Simple Simon.

Considering that currently no one (including me, the de-facto maintainer) really knows what the solver is doing exactly and how the numbers for the search in it were derived, I appreciate outsourcing the logic to a library. However, like @aacid said, it would be nice to have either some numbers how the solver compares.

Apr 23 2018, 9:22 PM · KDE Games
aacid added a reviewer for D12415: Use Freecell Solver for FreeCell and Simple Simon: fabiank.

Do you have a game number we can use to compare how this is better than the existing code?

Apr 23 2018, 8:45 PM · KDE Games

Apr 21 2018

shlomif requested review of D12415: Use Freecell Solver for FreeCell and Simple Simon.
Apr 21 2018, 4:27 PM · KDE Games

Jan 20 2018

helfferich closed D9790: Fix slowdown issue.

Pushed to master and Applications/17.12

Jan 20 2018, 8:29 PM · KDE Games

Jan 17 2018

aacid accepted D9790: Fix slowdown issue.
Jan 17 2018, 5:29 PM · KDE Games

Jan 14 2018

schwarzer closed D9805: Show error message to the user.
Jan 14 2018, 10:40 PM · KDE Games

Jan 11 2018

aacid accepted D9805: Show error message to the user.
Jan 11 2018, 7:15 PM · KDE Games
schwarzer updated the diff for D9805: Show error message to the user.
Jan 11 2018, 6:51 PM · KDE Games
schwarzer updated the diff for D9805: Show error message to the user.
Jan 11 2018, 6:49 PM · KDE Games

Jan 10 2018

schwarzer added a comment to D9805: Show error message to the user.
In D9805#189154, @aacid wrote:

I just realzied this is not how you use QMEsasgebox critical.

Since it's static you just do QMessageBox::critical(...)

Jan 10 2018, 11:35 PM · KDE Games
aacid added a comment to D9805: Show error message to the user.

I just realzied this is not how you use QMEsasgebox critical.

Jan 10 2018, 10:31 PM · KDE Games
schwarzer updated the diff for D9805: Show error message to the user.

fix diff ... hopefully

Jan 10 2018, 10:10 PM · KDE Games
schwarzer added a comment to D9805: Show error message to the user.
In D9805#189130, @aacid wrote:

Is phabricator being silly or are your patches missing some stuff?

Like it says
...\nPlease install the
and ends there

Jan 10 2018, 10:09 PM · KDE Games
aacid added a comment to D9790: Fix slowdown issue.

Looks sensible, only minor comment is that you should be using === instead of == in JavaScript code since it's marginally faster, but not that it matters much.

Jan 10 2018, 10:01 PM · KDE Games
aacid added a comment to D9805: Show error message to the user.

Is phabricator being silly or are your patches missing some stuff?

Jan 10 2018, 9:57 PM · KDE Games
schwarzer added a comment to D9790: Fix slowdown issue.

Do you mean switching the interval/substeps/speed? Or switching from a change in timer interval to the substeps?

I'll try to explain:

  1. Why change the interval? The basic loop is: Move ball -> Check for collisions -> Change direction, perform actions, according to collisions, etc. -> Move ball -> ... The speed determines how far the ball is moved during the "Move ball". If the ball is moved too far, the collision detection might be inaccurate (E.g. the extreme case is the ball moving through a brick with no detected collision). To avoid such bugs, we move the ball only half the distance, but twice as often.
  2. Why use substeps now? In the original code, this was done by cutting the gameTimer interval in half. However, this broke during the port to QML, because QML timer have a minimum interval of 16ms. Cutting it in half to 8ms does not have any effect. The alternative approach is to keep the gameTimer interval, but perform the basic loop twice.
Jan 10 2018, 9:39 PM · KDE Games
helfferich added a comment to D9790: Fix slowdown issue.

Do you mean switching the interval/substeps/speed? Or switching from a change in timer interval to the substeps?

Jan 10 2018, 7:20 PM · KDE Games
helfferich updated the diff for D9790: Fix slowdown issue.

Thanks for catching the typo. About the comment: You are of course perfectly right :D.

Jan 10 2018, 7:08 PM · KDE Games
schwarzer added a comment to D9790: Fix slowdown issue.

OK, tested it and it works as in the ball does not slow down anymore.
I cannot really argue about the implementation because I did not understand why this switching is needed in the first place. :D

Jan 10 2018, 5:52 PM · KDE Games
schwarzer added a comment to D9790: Fix slowdown issue.

Thanks for picking up the topic with a patch. :)
I might be able to test this tonight but not sure.
Anyway, here are just some things I saw while scrolling over the patch.

Jan 10 2018, 12:58 PM · KDE Games

Aug 25 2017

starbuck closed T6675: New categories for few games as Resolved.
Aug 25 2017, 8:21 AM · KDE Games, KDE Store
starbuck added a comment to T6675: New categories for few games.

Your welcome! If there are any more issues, just open a new ticket or re-open this one.

Aug 25 2017, 8:20 AM · KDE Games, KDE Store

Aug 24 2017

ltoscano added a comment to T6675: New categories for few games.

Thanks for the API reference to the list of the categories.

Aug 24 2017, 9:48 PM · KDE Games, KDE Store
starbuck added a comment to T6675: New categories for few games.

I checked and see the categories listed live here:
https://api.kde-look.org/ocs/v1/content/categories

Aug 24 2017, 2:18 PM · KDE Games, KDE Store
starbuck added a comment to T6675: New categories for few games.

Isn't it https://autoconfig.kde.org/ocs/providers.xml nowadays (not sure about what is the prefered URL)?
Also, where do you get the error with what request?

Aug 24 2017, 2:16 PM · KDE Games, KDE Store