The KDE Education Project
Changes made to CMakeLists.txt in GCompris-qt and GCompris-qt/src/core. Please review.
Wed, Feb 21
Tue, Feb 20
Fix looks good to me.
For the letter to guess, I would put it above the bar on right side to have the same as other activities.
I think we can also reduce its height to the letter height plus some margin
LGTM. Didn't check if these are all necessary changes.
Mon, Feb 19
@jjazeix Hi, please review the changes here.
Changed the position of OK button to top of bar.
Reduced the height of the progress bar to "progressbarText.height" .
Progress bar remains on top of the bar always.
Sun, Feb 18
I did fixes and I commited in https://commits.kde.org/gcompris/6a66cd44106015bd369616574d656a8dd19d15be
Please check them.
Basically, I fixed the overriding between the text to find (when letters are represented by underscores) and the score.
I changed the OK button size to a fixed size not relative to the screen width.
I also reduced the width of the score, no need to have it too big.
commited in https://commits.kde.org/gcompris/f545a44927fe79eb7e20a1acf89f889990f20cfa
The ok button that appears when you finish the level is behind the bar, can you please move it too?
You can reduce the height of the progress bar to "progressbarText.height" to gain some space.
I woudl let the progressbar above the bar even in horizontal mode: https://pasteboard.co/H8ekZD0.png
Sat, Feb 17
Fri, Feb 16
commited in https://commits.kde.org/gcompris/2fa566006d1242b34f52029b3a431bd2e9a8afcd with a small change for days column anchoring
missing space added
Wed, Feb 14
To view the OK button, you have to either enter the correct text to win, or exhaust your chances to lose, after which the OK button will show up above the scoreBox. Please review.
Hiding of progress bar avoided
Changed size and position of animals such none of them hides behind the bar
The progress bar still hides behind the bar:
Tue, Feb 13
Mon, Feb 12
If noone disagrees i'll accept this revision in two weeks :)
- Replace parleys version string with KDE Applications version
changed position of animals such that none of them is hidden
Please review and let me know if the changes were as intended.
Sun, Feb 11
It's almost good!
https://pasteboard.co/H7cjARY.png as you can see the underscore may override the score. Can you take a look to make it not happen? I guess you can use Text.Fit for GCText "hidden" and "guessedText"
Thank you for your reply, Albert.
I would prefer using KDE_APPLICATIONS_VERSION directly and drop parleys version completely.
Since parleys version is written to its KVTML files and hypothetical there would be changes of the file format somewhere in future, it would be easy to detect because the recent KDE Apps version is bigger than parleys current version 2.1.0.
I will update the patch soon.
Sat, Feb 10
OK I see.
Committed in https://cgit.kde.org/gcompris.git/commit/?id=1df9ddf5a6a976e884e59eeb628f666b0f13414a (with small coding rules changes)
thanks for cleaning the code, it's committed.
Thanks, committing it :)
Looks good to go
Fri, Feb 9
Can you please have a look at the "Bugzilla versions" part because otherwise all those bugs are going to end up in the "undefined" version category when reported through about->report bug or drkonqui
Hi, this is my mail id : email@example.com
github handle : parth-p
@parthpartani Hi. It would be convenient for me if I could get alternate ways to contact you, like your github username, or your IRC nick. We will be working together on this activity at https://github.com/mouri11/GCompris-qt/tree/maze-3D. I already created the branch and basic files. You can send a pull request, or mail me a patch at firstname.lastname@example.org. Looking forward to working with you. :)