KDE EduUmbrella
ActivePublic

Details

Description

The KDE Education Project

Recent Activity

Today

TallFurryMan added a comment to D14965: Improve Scheduler robustness against INDI disconnections.

So, tested with regular remote indiserver, and result is not that positive, but not negative neither.

Tue, Aug 21, 8:55 PM · KDE Edu
lancaster updated the diff for D14939: Making more recommended xplanet changes and fixing bugs:.
  • Making more xplanet fixes. UInt options, case corrections, i18n, labels, fd rename, contractions, timer, qbound, fileDialog, enum, and initialization
Tue, Aug 21, 6:45 PM · KDE Edu
lancaster added inline comments to D14939: Making more recommended xplanet changes and fixing bugs:.
Tue, Aug 21, 6:38 PM · KDE Edu
arojas closed D14962: Fix build with julia 1.0.
Tue, Aug 21, 6:35 PM · KDE Edu
sirgienko accepted D14962: Fix build with julia 1.0.
Tue, Aug 21, 6:24 PM · KDE Edu
lancaster added inline comments to D14939: Making more recommended xplanet changes and fixing bugs:.
Tue, Aug 21, 6:24 PM · KDE Edu
arojas updated the diff for D14962: Fix build with julia 1.0.

Escape semicolon

Tue, Aug 21, 6:09 PM · KDE Edu
arojas added a comment to D14962: Fix build with julia 1.0.

Hi, @arojas
First, Thanks!
Second, I couldn't found julia 1.0.0. As I see, there are problems with JULIA_LIBDL_COMMAND: cmake drop ; symbol (I don't see the symbol in message output).
I add escaping for this symbol (\) and all start works fine.
Do you haven't problem with version 1.0.0?

Tue, Aug 21, 6:07 PM · KDE Edu
sirgienko added a comment to D14962: Fix build with julia 1.0.

Hi, @arojas
First, Thanks!
Second, I couldn't found julia 1.0.0. As I see, there are problems with JULIA_LIBDL_COMMAND: cmake drop ; symbol (I don't see the symbol in message output).
I add escaping for this symbol (\) and all start works fine.
Do you haven't problem with version 1.0.0?

Tue, Aug 21, 5:26 PM · KDE Edu
wreissenberger requested review of D14977: Bugfix for #397650 flat creation failed.
Tue, Aug 21, 5:25 PM · KDE Edu
TallFurryMan added a comment to D14965: Improve Scheduler robustness against INDI disconnections.

The clear duplication of code is intentional, so that we can refactor at a later step. There are certainly other locations that could benefit from that scheme and that I did not spot yet.

Tue, Aug 21, 3:38 PM · KDE Edu
mutlaqja added inline comments to D14939: Making more recommended xplanet changes and fixing bugs:.
Tue, Aug 21, 3:13 PM · KDE Edu
mutlaqja added a comment to D14965: Improve Scheduler robustness against INDI disconnections.

When the scheduler attempts to connect to INDI again after a disconnection, is indiConnectionFailureCount reset? Will scheduler stop after it exhausts attempts MAX_FAILURE_ATTEMPTS or keeps looping forever?

Tue, Aug 21, 3:04 PM · KDE Edu
sirgienko added a comment to D14738: Add the markdown entry.

Do you talk about acceptRichText function?

Yes. My opinion is to override it and let it return false.
Take Bold for example. When the user selects a string (e.g. text) and clicks the button Bold, he/she may expect that the string becomes **text**, which is difficult to implement in the current architecture of Cantor, I think.

Tue, Aug 21, 1:39 PM · KDE Edu
kqwyf added a comment to D14738: Add the markdown entry.

Do you talk about acceptRichText function?

Tue, Aug 21, 1:18 PM · KDE Edu
sirgienko added a comment to D14738: Add the markdown entry.

There may not be an elegant solution (without refactoring) to make the rich text action list support the markdown entry... One solution is to disable the action list for markdown entry. Is that okay?

Tue, Aug 21, 12:13 PM · KDE Edu
TallFurryMan added a comment to D14941: Proper silencing for the switch-case fall-through warning.

Oh well. I don't think having a #ifdef there will be that nice. Please revert that change.

Tue, Aug 21, 10:11 AM · KDE Edu
wreissenberger added a comment to D14941: Proper silencing for the switch-case fall-through warning.

Q_FALLTHROUGH() was introduced in Qt 5.8, but kstars supports Qt >= 5.4.0. Building on Raspbian Stretch (Debian 9) fails.

Tue, Aug 21, 9:36 AM · KDE Edu
TallFurryMan requested review of D14965: Improve Scheduler robustness against INDI disconnections.
Tue, Aug 21, 7:16 AM · KDE Edu
arojas updated the diff for D14962: Fix build with julia 1.0.

Use correct version

Tue, Aug 21, 6:43 AM · KDE Edu
arojas updated the diff for D14962: Fix build with julia 1.0.

Fix indentation

Tue, Aug 21, 6:42 AM · KDE Edu
arojas updated the diff for D14962: Fix build with julia 1.0.

Use QT_VERSION_CHECK macro

Tue, Aug 21, 6:40 AM · KDE Edu
pino added inline comments to D14962: Fix build with julia 1.0.
Tue, Aug 21, 4:58 AM · KDE Edu
pino requested changes to D14939: Making more recommended xplanet changes and fixing bugs:.
Tue, Aug 21, 4:56 AM · KDE Edu
mutlaqja accepted D14939: Making more recommended xplanet changes and fixing bugs:.
Tue, Aug 21, 12:35 AM · KDE Edu

Yesterday

lancaster updated the diff for D14939: Making more recommended xplanet changes and fixing bugs:.
  • Updating XPlanet with Jasem's Comments: Using uint for timeout' const for string using m_ for member objects changing obj to objectIndex
Mon, Aug 20, 11:15 PM · KDE Edu
arojas requested review of D14962: Fix build with julia 1.0.
Mon, Aug 20, 11:11 PM · KDE Edu
mutlaqja closed D14961: Add telescope joystick controls to KStars Lite.
Mon, Aug 20, 10:25 PM · KDE Edu
mutlaqja accepted D14961: Add telescope joystick controls to KStars Lite.
Mon, Aug 20, 10:22 PM · KDE Edu
ckertesz requested review of D14961: Add telescope joystick controls to KStars Lite.
Mon, Aug 20, 10:19 PM · KDE Edu
mutlaqja added inline comments to D14939: Making more recommended xplanet changes and fixing bugs:.
Mon, Aug 20, 9:45 PM · KDE Edu
lancaster added inline comments to D14939: Making more recommended xplanet changes and fixing bugs:.
Mon, Aug 20, 9:31 PM · KDE Edu
lancaster updated the diff for D14939: Making more recommended xplanet changes and fixing bugs:.
  • More recommended xplanet changes: changing timeout from string to int in config Making the QFutureWatcher simpler by using the signal
Mon, Aug 20, 9:30 PM · KDE Edu
lancaster added inline comments to D14939: Making more recommended xplanet changes and fixing bugs:.
Mon, Aug 20, 8:06 PM · KDE Edu
lancaster added inline comments to D14939: Making more recommended xplanet changes and fixing bugs:.
Mon, Aug 20, 7:55 PM · KDE Edu
TallFurryMan added inline comments to D14942: Connect new-image event to Scheduler imaging time estimator..
Mon, Aug 20, 7:34 PM · KDE Edu
TallFurryMan updated the diff for D14942: Connect new-image event to Scheduler imaging time estimator..

Changed setCaptureState for updateCaptureState to homogeneize naming.

Mon, Aug 20, 7:32 PM · KDE Edu
mutlaqja closed D14941: Proper silencing for the switch-case fall-through warning.
Mon, Aug 20, 7:26 PM · KDE Edu
mutlaqja accepted D14941: Proper silencing for the switch-case fall-through warning.
Mon, Aug 20, 7:25 PM · KDE Edu
TallFurryMan updated the diff for D14941: Proper silencing for the switch-case fall-through warning.

Changed fall-through comment for Q_FALLTHROUGH (thanks @broulik).

Mon, Aug 20, 7:14 PM · KDE Edu
filipesaraiva added a comment to D14738: Add the markdown entry.

Well, I really don't like the behaviour of Cantor processing LaTeX and text together in a same text entry. For me it is a very confuse behaviour, mainly for now when we have Markdown options for rendering too.

Mon, Aug 20, 1:58 PM · KDE Edu
filipesaraiva added a comment to D14945: Fix sagemath backend with sagemath 8.3.

Nice, thanks again!

Mon, Aug 20, 12:02 PM · KDE Edu
arojas added a comment to D14945: Fix sagemath backend with sagemath 8.3.

Thanks @arojas, do you know if this change break the compatibility with previous versions of Sage?

Mon, Aug 20, 12:00 PM · KDE Edu
filipesaraiva added a comment to D14945: Fix sagemath backend with sagemath 8.3.

Thanks @arojas, do you know if this change break the compatibility with previous versions of Sage?

Mon, Aug 20, 11:56 AM · KDE Edu
arojas closed D14945: Fix sagemath backend with sagemath 8.3.
Mon, Aug 20, 11:24 AM · KDE Edu
sirgienko accepted D14945: Fix sagemath backend with sagemath 8.3.

Thanks!

Mon, Aug 20, 11:21 AM · KDE Edu
arojas requested review of D14945: Fix sagemath backend with sagemath 8.3.
Mon, Aug 20, 10:12 AM · KDE Edu
arojas closed D14935: Support julia>=0.7.
Mon, Aug 20, 9:58 AM · KDE Edu
sirgienko accepted D14935: Support julia>=0.7.
Mon, Aug 20, 9:50 AM · KDE Edu
sirgienko added a comment to D14935: Support julia>=0.7.

I have tested this revision, all works fine, so, I think, you can push this patch.

Mon, Aug 20, 9:50 AM · KDE Edu