KDE EduUmbrella
ActivePublic

Details

Description

The KDE Education Project

Recent Activity

Today

rohitdas updated the diff for D10403: Porting of 3D-maze activity(ref: T1518).

Changes made to CMakeLists.txt in GCompris-qt and GCompris-qt/src/core. Please review.

Sat, Feb 24, 7:17 PM · GCompris: Activities, KDE Edu

Wed, Feb 21

asagtani updated the diff for D10615: Planegame, fixed clouds propogation behind bar.

Fixed letter to guess position and dimensions.
For vertical mode --> https://cdn.pbrd.co/images/H8BU1Nh.png
For horizontal mode --> https://cdn.pbrd.co/images/H8BVeBd.png

Wed, Feb 21, 4:05 AM · GCompris, KDE Edu

Tue, Feb 20

jjazeix added a comment to D10615: Planegame, fixed clouds propogation behind bar.

Fix looks good to me.
For the letter to guess, I would put it above the bar on right side to have the same as other activities.
I think we can also reduce its height to the letter height plus some margin

Tue, Feb 20, 9:49 PM · GCompris, KDE Edu
aspotashev accepted D9057: Fixing File Filters.

LGTM. Didn't check if these are all necessary changes.

Tue, Feb 20, 4:19 PM · KDE Edu
apol added a comment to D9057: Fixing File Filters.

Please land?

Tue, Feb 20, 2:37 PM · KDE Edu

Mon, Feb 19

rohitdas added a comment to D9360: Adding feature to change letters to capital and back (Ref: T5936).

@jjazeix Hi, please review the changes here.

Mon, Feb 19, 6:28 PM · KDE Edu
rohitdas added a comment to D10004: Reposition score box in hangman activity(ref: T7777).

Ok thanks.

Mon, Feb 19, 6:24 PM · KDE Edu, GCompris: Improvements
ganeshredcobra updated the diff for D9644: Explore activities: Fix progress bar overriding on resizing.

Changed the position of OK button to top of bar.
Reduced the height of the progress bar to "progressbarText.height" .
Progress bar remains on top of the bar always.

Mon, Feb 19, 2:04 AM · GCompris: Improvements, KDE Edu

Sun, Feb 18

jjazeix closed D10004: Reposition score box in hangman activity(ref: T7777).
Sun, Feb 18, 9:02 PM · KDE Edu, GCompris: Improvements
jjazeix accepted D10004: Reposition score box in hangman activity(ref: T7777).

I did fixes and I commited in https://commits.kde.org/gcompris/6a66cd44106015bd369616574d656a8dd19d15be
Please check them.
Basically, I fixed the overriding between the text to find (when letters are represented by underscores) and the score.
I changed the OK button size to a fixed size not relative to the screen width.
I also reduced the width of the score, no need to have it too big.

Sun, Feb 18, 9:02 PM · KDE Edu, GCompris: Improvements
jjazeix closed D10350: Improved settings mode names.

commited in https://commits.kde.org/gcompris/f545a44927fe79eb7e20a1acf89f889990f20cfa
Thank you

Sun, Feb 18, 4:14 PM · GCompris: Improvements, KDE Edu
jjazeix accepted D10350: Improved settings mode names.
Sun, Feb 18, 4:13 PM · GCompris: Improvements, KDE Edu
jjazeix added a comment to D9644: Explore activities: Fix progress bar overriding on resizing.

The ok button that appears when you finish the level is behind the bar, can you please move it too?
You can reduce the height of the progress bar to "progressbarText.height" to gain some space.
I woudl let the progressbar above the bar even in horizontal mode: https://pasteboard.co/H8ekZD0.png

Sun, Feb 18, 4:01 PM · GCompris: Improvements, KDE Edu

Sat, Feb 17

asagtani requested review of D10615: Planegame, fixed clouds propogation behind bar.
Sat, Feb 17, 8:03 PM · GCompris, KDE Edu

Fri, Feb 16

jjazeix closed D10216: Calendar, fixed calendar dimensions for vertical screens.

commited in https://commits.kde.org/gcompris/2fa566006d1242b34f52029b3a431bd2e9a8afcd with a small change for days column anchoring

Fri, Feb 16, 7:18 PM · GCompris: Improvements, KDE Edu
jjazeix accepted D10216: Calendar, fixed calendar dimensions for vertical screens.
Fri, Feb 16, 7:17 PM · GCompris: Improvements, KDE Edu
ganeshredcobra updated the diff for D9644: Explore activities: Fix progress bar overriding on resizing.

missing space added

Fri, Feb 16, 3:09 PM · GCompris: Improvements, KDE Edu
amankumargupta added inline comments to D9644: Explore activities: Fix progress bar overriding on resizing.
Fri, Feb 16, 11:35 AM · GCompris: Improvements, KDE Edu

Wed, Feb 14

rohitdas updated the diff for D10004: Reposition score box in hangman activity(ref: T7777).

To view the OK button, you have to either enter the correct text to win, or exhaust your chances to lose, after which the OK button will show up above the scoreBox. Please review.

Wed, Feb 14, 3:22 PM · KDE Edu, GCompris: Improvements
ganeshredcobra updated the diff for D9644: Explore activities: Fix progress bar overriding on resizing.

Hiding of progress bar avoided
Changed size and position of animals such none of them hides behind the bar

Wed, Feb 14, 3:01 PM · GCompris: Improvements, KDE Edu
filipesaraiva closed D8547: R Backend highlighter.
Wed, Feb 14, 1:14 PM · Cantor, KDE Edu
filipesaraiva accepted D8547: R Backend highlighter.
Wed, Feb 14, 1:13 PM · Cantor, KDE Edu
filipesaraiva reopened D8547: R Backend highlighter.
Wed, Feb 14, 1:13 PM · Cantor, KDE Edu
This revision was not accepted when it landed; it landed in state Needs Review.
Wed, Feb 14, 1:11 PM · Cantor, KDE Edu
amankumargupta added a comment to D9644: Explore activities: Fix progress bar overriding on resizing.

The progress bar still hides behind the bar:
https://pasteboard.co/H7yWT8Vw.png

Wed, Feb 14, 6:43 AM · GCompris: Improvements, KDE Edu

Tue, Feb 13

asagtani added a comment to D10004: Reposition score box in hangman activity(ref: T7777).

@rohitdas scoreboard still overrides bar buttons (https://cdn.pbrd.co/images/H7uENcT.png)

Tue, Feb 13, 8:05 PM · KDE Edu, GCompris: Improvements
asagtani added inline comments to D10004: Reposition score box in hangman activity(ref: T7777).
Tue, Feb 13, 7:37 PM · KDE Edu, GCompris: Improvements
rohitdas updated the diff for D10004: Reposition score box in hangman activity(ref: T7777).

Please review.

Tue, Feb 13, 10:36 AM · KDE Edu, GCompris: Improvements

Mon, Feb 12

aacid added a comment to D10394: Replace parleys version string with KDE Applications version.

If noone disagrees i'll accept this revision in two weeks :)

Mon, Feb 12, 9:45 PM · KDE Edu
hriesenbeck updated the diff for D10394: Replace parleys version string with KDE Applications version.
  • Replace parleys version string with KDE Applications version
Mon, Feb 12, 8:37 PM · KDE Edu
ganeshredcobra updated the diff for D9644: Explore activities: Fix progress bar overriding on resizing.

changed position of animals such that none of them is hidden

Mon, Feb 12, 5:05 PM · GCompris: Improvements, KDE Edu
jjazeix added inline comments to D10004: Reposition score box in hangman activity(ref: T7777).
Mon, Feb 12, 4:48 PM · KDE Edu, GCompris: Improvements
rohitdas updated the diff for D10004: Reposition score box in hangman activity(ref: T7777).

Please review and let me know if the changes were as intended.

Mon, Feb 12, 2:12 PM · KDE Edu, GCompris: Improvements

Sun, Feb 11

jjazeix added a comment to D10004: Reposition score box in hangman activity(ref: T7777).

It's almost good!
https://pasteboard.co/H7cjARY.png as you can see the underscore may override the score. Can you take a look to make it not happen? I guess you can use Text.Fit for GCText "hidden" and "guessedText"

Sun, Feb 11, 9:09 PM · KDE Edu, GCompris: Improvements
hriesenbeck added a comment to D10394: Replace parleys version string with KDE Applications version.

Thank you for your reply, Albert.
I would prefer using KDE_APPLICATIONS_VERSION directly and drop parleys version completely.
Since parleys version is written to its KVTML files and hypothetical there would be changes of the file format somewhere in future, it would be easy to detect because the recent KDE Apps version is bigger than parleys current version 2.1.0.
I will update the patch soon.

Sun, Feb 11, 8:37 PM · KDE Edu

Sat, Feb 10

aacid updated subscribers of D10394: Replace parleys version string with KDE Applications version.

OK I see.

Since cmake wants the version string in this format: VERSION <major>[.<minor>[.<patch>[.<tweak>]]], a more complex version string, which include both, parleys version string and the complete KDE Applications version string, is not practicable. Using the KDE Apps micro version as extension to parleys version, as shown in the guide as example, seems to be no advantage to me. Since the micro version repeats every release.

So I see only two ways. Leave it as it is or use only the KDE Apps version string.

I lean towards the second way. But may there is a third way, which I do not see...
What do you think?

Sat, Feb 10, 11:26 PM · KDE Edu
hriesenbeck added a comment to D10394: Replace parleys version string with KDE Applications version.

OK I see.

Sat, Feb 10, 4:13 PM · KDE Edu
jjazeix closed D9509: T7609:Click on me: fix layout for vertical screens.
Sat, Feb 10, 3:42 PM · KDE Edu, GCompris: Improvements
jjazeix accepted D9509: T7609:Click on me: fix layout for vertical screens.

Committed in https://cgit.kde.org/gcompris.git/commit/?id=1df9ddf5a6a976e884e59eeb628f666b0f13414a (with small coding rules changes)

Sat, Feb 10, 3:40 PM · KDE Edu, GCompris: Improvements
jjazeix closed D10368: nine_men_morris, prevent changing level when tutorial is going on..
Sat, Feb 10, 2:20 PM · KDE Edu, GCompris: Improvements
jjazeix accepted D10368: nine_men_morris, prevent changing level when tutorial is going on..

thanks for cleaning the code, it's committed.

Sat, Feb 10, 2:20 PM · KDE Edu, GCompris: Improvements
amankumargupta abandoned D10419: Fit long texts in Button..
Sat, Feb 10, 11:54 AM · GCompris: Improvements, KDE Edu
amankumargupta added a comment to D10419: Fit long texts in Button..

Committed here: https://cgit.kde.org/gcompris.git/commit/?id=33267059ff1689db50a08e120097ade13df598a5

Sat, Feb 10, 11:54 AM · GCompris: Improvements, KDE Edu
amankumargupta added a comment to D10419: Fit long texts in Button..

Thanks, committing it :)

Sat, Feb 10, 11:39 AM · GCompris: Improvements, KDE Edu
timotheegiet accepted D10419: Fit long texts in Button..

Looks good to go

Sat, Feb 10, 11:36 AM · GCompris: Improvements, KDE Edu

Fri, Feb 9

amankumargupta added a task to D10419: Fit long texts in Button.: T7935: Fit long texts in Button..
Fri, Feb 9, 11:34 PM · GCompris: Improvements, KDE Edu
amankumargupta requested review of D10419: Fit long texts in Button..
Fri, Feb 9, 11:34 PM · GCompris: Improvements, KDE Edu
aacid added a comment to D10394: Replace parleys version string with KDE Applications version.

Can you please have a look at the "Bugzilla versions" part because otherwise all those bugs are going to end up in the "undefined" version category when reported through about->report bug or drkonqui

Fri, Feb 9, 9:53 PM · KDE Edu
parthpartani added a comment to D10403: Porting of 3D-maze activity(ref: T1518).

Hi, this is my mail id : parthpartani9724@gmail.com
github handle : parth-p

Fri, Feb 9, 2:40 PM · GCompris: Activities, KDE Edu
rohitdas added a comment to D10403: Porting of 3D-maze activity(ref: T1518).

@parthpartani Hi. It would be convenient for me if I could get alternate ways to contact you, like your github username, or your IRC nick. We will be working together on this activity at https://github.com/mouri11/GCompris-qt/tree/maze-3D. I already created the branch and basic files. You can send a pull request, or mail me a patch at rohit.das950@gmail.com. Looking forward to working with you. :)

Fri, Feb 9, 2:28 PM · GCompris: Activities, KDE Edu