KWinProject
ActivePublic

Details

Description

Wayland Compositor and X11 Window Manager

Recent Activity

Today

romangg added inline comments to D23618: Use nullptr everywhere.
Thu, Sep 19, 2:54 PM · KWin
zzag added inline comments to D23618: Use nullptr everywhere.
Thu, Sep 19, 2:51 PM · KWin
zzag closed D23618: Use nullptr everywhere.
Thu, Sep 19, 2:50 PM · KWin
romangg accepted D23618: Use nullptr everywhere.

Let's get it in 5.17 beta branch then as well. Tested it on X11 and Wayland and no related compile warnings.

Thu, Sep 19, 2:18 PM · KWin
davidedmundson added dependencies for D24084: Migrate kwin animation speed to kdeglobals: D22887: Load animation speed from new global animation speed controller, D24075: [kcmkwin/compositing] Hide animation speed slider on Plasma.
Thu, Sep 19, 1:48 PM · KWin
davidedmundson added a dependent revision for D22887: Load animation speed from new global animation speed controller: D24084: Migrate kwin animation speed to kdeglobals.
Thu, Sep 19, 1:48 PM · KWin
davidedmundson added a dependent revision for D24075: [kcmkwin/compositing] Hide animation speed slider on Plasma: D24084: Migrate kwin animation speed to kdeglobals.
Thu, Sep 19, 1:48 PM · KWin
davidedmundson requested review of D24084: Migrate kwin animation speed to kdeglobals.
Thu, Sep 19, 1:47 PM · KWin
davidedmundson updated the summary of D22887: Load animation speed from new global animation speed controller.
Thu, Sep 19, 1:08 PM · KWin
davidedmundson requested review of D24075: [kcmkwin/compositing] Hide animation speed slider on Plasma.
Thu, Sep 19, 1:04 PM · KWin
davidedmundson updated the diff for D22887: Load animation speed from new global animation speed controller.

Rebase

Thu, Sep 19, 1:03 PM · KWin
zzag added a comment to D23618: Use nullptr everywhere.

I have to admit in hindsight that I was maybe wrong on this one not being in 5.17. Since only having the change on master but not in the 5.17 branch could complicate porting back bug fixes. Would you guys agree to that? And since we are still at the beginning of beta phase shall we apply it also to 5.17 branch?

Thu, Sep 19, 12:35 PM · KWin
romangg added a comment to D23618: Use nullptr everywhere.

I have to admit in hindsight that I was maybe wrong on this one not being in 5.17. Since only having the change on master but not in the 5.17 branch could complicate porting back bug fixes. Would you guys agree to that? And since we are still at the beginning of beta phase shall we apply it also to 5.17 branch?

Thu, Sep 19, 12:34 PM · KWin
zzag updated the diff for D23618: Use nullptr everywhere.

Rebase.

Thu, Sep 19, 12:27 PM · KWin
bshah closed D24051: [platforms/drm] introduce env var to select GPU.
Thu, Sep 19, 9:33 AM · KWin
davidedmundson added a comment to D22887: Load animation speed from new global animation speed controller.

At this point, no.

Thu, Sep 19, 8:19 AM · KWin

Yesterday

zzag added a comment to D22887: Load animation speed from new global animation speed controller.

@davidedmundson Is this 5.17 stuff?

Wed, Sep 18, 3:18 PM · KWin
zzag closed D24044: Emphasize minimization in MinimizeAll script.
Wed, Sep 18, 3:12 PM · KWin
smerkov retitled D24044: Emphasize minimization in MinimizeAll script from MinimizeAll wrong behaviour to Emphasize minimization in MinimizeAll script.
Wed, Sep 18, 3:07 PM · KWin
smerkov added a comment to D24044: Emphasize minimization in MinimizeAll script.
In D24044#534012, @zzag wrote:

Sorry but i don't know how to do it. Can you commit?

Can you provide your real name and email address for commit authorship information?

Wed, Sep 18, 3:06 PM · KWin
zzag added a comment to D24044: Emphasize minimization in MinimizeAll script.

Sorry but i don't know how to do it. Can you commit?

Wed, Sep 18, 3:03 PM · KWin
ngraham updated the summary of D24044: Emphasize minimization in MinimizeAll script.
Wed, Sep 18, 3:00 PM · KWin
smerkov added a comment to D24044: Emphasize minimization in MinimizeAll script.
In D24044#533973, @zzag wrote:

Do you have commit access?

Wed, Sep 18, 2:57 PM · KWin
zzag added a comment to D24044: Emphasize minimization in MinimizeAll script.

Nitpick: please use imperative mood in the subject line.

Wed, Sep 18, 2:50 PM · KWin
zzag accepted D24044: Emphasize minimization in MinimizeAll script.

Do you have commit access?

Wed, Sep 18, 2:45 PM · KWin
smerkov updated the diff for D24044: Emphasize minimization in MinimizeAll script.

I changed my version to version of zzag, because his code is more simple. I have tested both versions.

Wed, Sep 18, 2:40 PM · KWin
fvogt added inline comments to D22571: Allow blacklisting some wayland interfaces.
Wed, Sep 18, 2:36 PM · KWin
zzag closed D24045: Port away from deprecated QString::sprintf.
Wed, Sep 18, 1:29 PM · KWin
zzag closed D24042: Port away from deprecated qVariantFromValue.
Wed, Sep 18, 1:29 PM · KWin
zzag added a comment to D24051: [platforms/drm] introduce env var to select GPU.

I'm ok with having this as a short-term fix but long-term this env var should go away again and be replaced with a better selection mechanism. So no guarantee that it will be available after 5.18 LTS.

Wed, Sep 18, 1:21 PM · KWin
romangg added a comment to D24051: [platforms/drm] introduce env var to select GPU.

env var should be called KWIN_DRM_DEVICE_NODE

Wed, Sep 18, 1:21 PM · KWin
romangg accepted D24051: [platforms/drm] introduce env var to select GPU.

I'm ok with having this as a short-term fix but long-term this env var should go away again and be replaced with a better selection mechanism. So no guarantee that it will be available after 5.18 LTS.

Wed, Sep 18, 1:20 PM · KWin
bshah requested review of D24051: [platforms/drm] introduce env var to select GPU.
Wed, Sep 18, 1:13 PM · KWin
apol accepted D24045: Port away from deprecated QString::sprintf.
Wed, Sep 18, 11:04 AM · KWin
romangg added a comment to D24044: Emphasize minimization in MinimizeAll script.

Please more verbose summary.

Wed, Sep 18, 11:03 AM · KWin
zzag added a reviewer for D24044: Emphasize minimization in MinimizeAll script: KWin.

What about simplifying it a bit as well? e.g.

Wed, Sep 18, 11:00 AM · KWin
davidedmundson accepted D24042: Port away from deprecated qVariantFromValue.
Wed, Sep 18, 8:50 AM · KWin
zzag requested review of D24045: Port away from deprecated QString::sprintf.
Wed, Sep 18, 8:46 AM · KWin
smerkov added a reviewer for D24044: Emphasize minimization in MinimizeAll script: colomar.
Wed, Sep 18, 8:33 AM · KWin
smerkov requested review of D24044: Emphasize minimization in MinimizeAll script.
Wed, Sep 18, 8:31 AM · KWin
zzag requested review of D24042: Port away from deprecated qVariantFromValue.
Wed, Sep 18, 8:09 AM · KWin

Tue, Sep 17

zzag closed D24018: Keep things sorted alphabetically in CMakeLists.txt.
Tue, Sep 17, 8:43 AM · KWin
gladhorn accepted D24018: Keep things sorted alphabetically in CMakeLists.txt.
Tue, Sep 17, 8:20 AM · KWin
zzag requested review of D24018: Keep things sorted alphabetically in CMakeLists.txt.
Tue, Sep 17, 8:08 AM · KWin
zzag added a comment to D23909: Pass area by const reference to placeFoo methods.

Please next time besides a title add a meaningful description if you push a patch with more than a trivial change and without review. I assume it was just a mistake that you also didn't link back to the review in the commit bccbb8f3a5f8.

Tue, Sep 17, 7:45 AM · KWin
romangg added a comment to D23909: Pass area by const reference to placeFoo methods.

Please next time besides a title add a meaningful description if you push a patch with more than a trivial change and without review. I assume it was just a mistake that you also didn't link back to the review in the commit bccbb8f3a5f8.

Tue, Sep 17, 7:40 AM · KWin
zzag closed D23909: Pass area by const reference to placeFoo methods.
Tue, Sep 17, 7:31 AM · KWin
gladhorn accepted D23909: Pass area by const reference to placeFoo methods.
Tue, Sep 17, 7:30 AM · KWin

Mon, Sep 16

romangg moved T4688: Support surface and output scaling from Work In Progress to Done on the Plasma on Wayland board.
Mon, Sep 16, 8:41 PM · KWin, Plasma on Wayland
ngraham added a comment to D21875: Add KInfoCenter module for Support Information.

I still think this is a great idea.

Mon, Sep 16, 3:54 PM · KWin