KWinProject
ActivePublic

Details

Description

Wayland Compositor and X11 Window Manager

Recent Activity

Today

iasensio added a comment to D29791: [kcm/kwinrules] Detect also window complete class.

ping on this?

Tue, May 26, 6:09 PM · KWin
davidedmundson closed D29705: Correctly align natural layout in present windows.
Tue, May 26, 9:52 AM · KWin
davidedmundson closed D29332: [xwl] Update to kwaylandserver changes.
Tue, May 26, 9:13 AM · KWin
bport updated the diff for D29272: Add support to keyboard shortcuts inhibitor.

Remove unused include

Tue, May 26, 8:04 AM · KWin

Yesterday

apol added a comment to T12863: Use PipeWire for screen casting.

The biggest problem with sharing the dmabuf buffers it that its memory management becomes quite complex (and I'm unsure it's really doable).
PipeWire has mechanisms to create the buffers it's going to need, juggling this with passing the buffer from the app/output and making sure it stays relevant feels messy and error-prone.
Copying from dmabuf->dmabuf shouldn't be very expensive though, as it shouldn't go through the buses (AFAIK, that is).

Mon, May 25, 1:05 PM · Plasma on Wayland, KWin
zzag added inline comments to D29272: Add support to keyboard shortcuts inhibitor.
Mon, May 25, 10:04 AM · KWin
zzag added inline comments to D29272: Add support to keyboard shortcuts inhibitor.
Mon, May 25, 10:03 AM · KWin
zzag added inline comments to D29272: Add support to keyboard shortcuts inhibitor.
Mon, May 25, 10:02 AM · KWin

Sat, May 23

niccolove added a comment to D27439: Replaced isDock check with !hasDecoration.

Moved and finished (now works) here: https://invent.kde.org/plasma/kwin/-/merge_requests/17

Sat, May 23, 2:32 PM · KWin

Fri, May 22

ndavis added a comment to D29477: Change CommandAllKey to Meta.

Resuming this on invent

link ?

Fri, May 22, 10:29 PM · KWin
abetts added a comment to D29459: Scripting: Make client.activities writable.

Hey man, can you join our vdg team on Telegram? Here is the link: https://t.me/vdgmainroom

Fri, May 22, 6:41 PM · KWin
meven accepted D29683: screenshot: use QImage to decode the received screenshot image.
Fri, May 22, 2:45 PM · KWin
apol added a comment to D29683: screenshot: use QImage to decode the received screenshot image.

Ping?

Fri, May 22, 2:44 PM · KWin
ngraham closed D29263: Position OSD a bit farther down.
Fri, May 22, 2:38 PM · KWin
zzag accepted D29263: Position OSD a bit farther down.
Fri, May 22, 2:37 PM · KWin
zzag added inline comments to D29263: Position OSD a bit farther down.
Fri, May 22, 2:37 PM · KWin
ngraham updated the diff for D29263: Position OSD a bit farther down.

don't need to include cmath anymore

Fri, May 22, 2:37 PM · KWin
ngraham updated the diff for D29263: Position OSD a bit farther down.

Address review feedback

Fri, May 22, 2:36 PM · KWin
broulik updated the diff for D29035: Install service files for kwin.
  • Use After instead of Wants
Fri, May 22, 9:23 AM · KWin

Thu, May 21

zzag added a comment to D29263: Position OSD a bit farther down.

The existing magic number is also totally random, and does not even match

Thu, May 21, 6:50 AM · KWin
zzag closed D29786: Scripting: Provides methods to create and remove virtual desktops.
Thu, May 21, 6:16 AM · KWin
zzag accepted D29786: Scripting: Provides methods to create and remove virtual desktops.
Thu, May 21, 5:50 AM · KWin

Wed, May 20

tcorreabr updated the diff for D29786: Scripting: Provides methods to create and remove virtual desktops.

Zero based position parameters.

Wed, May 20, 10:48 PM · KWin
kkofler added a comment to T13026: Port kwin to new kwaylandserver repo.

And the actual rationale appears to be: https://mail.kde.org/pipermail/kde-frameworks-devel/2020-March/105081.html

Wed, May 20, 5:09 PM · KWin
kkofler added a comment to T13026: Port kwin to new kwaylandserver repo.

If, like me, you land here (after discovering the new dependency) and miss the rationale, see:

Wed, May 20, 5:00 PM · KWin
ngraham added a comment to D29263: Position OSD a bit farther down.
In D29263#673249, @zzag wrote:

In the absence of a way for the Global Theme or (proposed-but-not-yet-existing OSD themes) to set a custom OSD position, are KWin people okay with this patch to improve the positioning of the new OSD?

Speaking for myself, I'm not. I don't like 0.37 because it's not based on anything. Why not 0.39 or 0.4242?

Wed, May 20, 3:17 PM · KWin
zzag added a comment to D29263: Position OSD a bit farther down.

In the absence of a way for the Global Theme or (proposed-but-not-yet-existing OSD themes) to set a custom OSD position, are KWin people okay with this patch to improve the positioning of the new OSD?

Wed, May 20, 3:04 PM · KWin
meven added a comment to D29263: Position OSD a bit farther down.

LGTM :)

Wed, May 20, 2:56 PM · KWin
ndavis accepted D29263: Position OSD a bit farther down.
Wed, May 20, 2:43 PM · KWin
ngraham added a comment to D28781: Allow configuring click behavior in Desktop Grid effect.

You can update users' config filed with a kconf update script (see https://techbase.kde.org/Development/Tools/Using_kconf_update) or avoid changing the config file key names in the first place.

Wed, May 20, 1:43 PM · KWin
meven added a comment to D29407: ScreenshotEffect: Use Service Property to authorize screenshot without confirmation.

So this should be good for merging @apol after spectacle D29408 has been rebased and D29487 has landed

Wed, May 20, 10:00 AM · KWin
meven added a comment to D29263: Position OSD a bit farther down.

In the absence of a way for the Global Theme or (proposed-but-not-yet-existing OSD themes) to set a custom OSD position, are KWin people okay with this patch to improve the positioning of the new OSD?

Wed, May 20, 9:24 AM · KWin
meven added a comment to D29477: Change CommandAllKey to Meta.

Resuming this on invent

Wed, May 20, 9:07 AM · KWin
filipf added a comment to D29263: Position OSD a bit farther down.

I'm a bit confused. Aren't we changing the size for third party global themes as well? Do all global themes set their size?

Wed, May 20, 7:02 AM · KWin
ksmanis added inline comments to D28781: Allow configuring click behavior in Desktop Grid effect.
Wed, May 20, 6:28 AM · KWin
niccolove added a comment to D29263: Position OSD a bit farther down.

I'm a bit confused. Aren't we changing the size for third party global themes as well? Do all global themes set their size?

Wed, May 20, 6:10 AM · KWin

Tue, May 19

ndavis requested changes to D29263: Position OSD a bit farther down.
Tue, May 19, 9:06 PM · KWin
ngraham added a comment to D29263: Position OSD a bit farther down.

In the absence of a way for the Global Theme or (proposed-but-not-yet-existing OSD themes) to set a custom OSD position, are KWin people okay with this patch to improve the positioning of the new OSD?

Non-Breeze OSDs will be affected? If so, that seems bad.

Tue, May 19, 9:00 PM · KWin
ndavis added a comment to D29263: Position OSD a bit farther down.

It might be best not to change anything about the position until we can come up with a significantly better solution.

Tue, May 19, 8:57 PM · KWin
niccolove added a comment to D29263: Position OSD a bit farther down.

How do you think about putting it horizontally centered at the top of the screen? Maybe even avoiding panels, if possible?
I'd be fine both with "floating a bit under the panel" and "merged with screen/panel top" like krunner.

Tue, May 19, 8:55 PM · KWin
ndavis added a comment to D29263: Position OSD a bit farther down.

In the absence of a way for the Global Theme or (proposed-but-not-yet-existing OSD themes) to set a custom OSD position, are KWin people okay with this patch to improve the positioning of the new OSD?

Tue, May 19, 8:52 PM · KWin
ngraham added a comment to D29263: Position OSD a bit farther down.

In the absence of a way for the Global Theme or (proposed-but-not-yet-existing OSD themes) to set a custom OSD position, are KWin people okay with this patch to improve the positioning of the new OSD?

Tue, May 19, 8:33 PM · KWin
ngraham added inline comments to D29263: Position OSD a bit farther down.
Tue, May 19, 8:30 PM · KWin
cblack abandoned D29685: Grant keyboard focus to popups on popup.
Tue, May 19, 7:53 PM · KWin
ndavis abandoned D29477: Change CommandAllKey to Meta.

Resuming this on invent

Tue, May 19, 7:52 PM · KWin
ndavis added inline comments to D29263: Position OSD a bit farther down.
Tue, May 19, 6:57 PM · KWin
ndavis accepted D29263: Position OSD a bit farther down.
Tue, May 19, 6:55 PM · KWin
ngraham added a comment to D29263: Position OSD a bit farther down.

I'm feeling pretty lukewarm about this idea. It's maybe slightly better in some situations, but with the smaller size, I think it'll also be easier to miss if it's not in the center. Since the OSD is smaller, being exactly in the center isn't such a huge problem either. Although, I suppose it would still get in the way of crosshairs if the user was playing a shooter game.

Tue, May 19, 6:44 PM · KWin
ndavis added a comment to D29263: Position OSD a bit farther down.

I'm feeling pretty lukewarm about this idea. It's maybe slightly better in some situations, but with the smaller size, I think it'll also be easier to miss if it's not in the center. Since the OSD is smaller, being exactly in the center isn't such a huge problem either. Although, I suppose it would still get in the way of crosshairs if the user was playing a shooter game.

Tue, May 19, 6:27 PM · KWin
ngraham added a comment to D29263: Position OSD a bit farther down.

Ping. I think this is a mild improvement

Tue, May 19, 6:17 PM · KWin