KWinProject
ActivePublic

Details

Description

Wayland Compositor and X11 Window Manager

Recent Activity

Today

zzag closed D25457: [kcmkwin/tabbox] Use an enum for role names.
Fri, Nov 22, 7:38 PM · KWin
apol accepted D25457: [kcmkwin/tabbox] Use an enum for role names.
Fri, Nov 22, 5:27 PM · KWin
davidedmundson added a reviewer for D14536: [scripting] Port ScriptedEffects to QJSEngine: carewolf.
Fri, Nov 22, 3:21 PM · KWin
ngraham added a comment to D25457: [kcmkwin/tabbox] Use an enum for role names.

+1

Fri, Nov 22, 1:10 PM · KWin
zzag retitled D25457: [kcmkwin/tabbox] Use an enum for role names from [kcmkwin/tabbox] Use enums for roles to [kcmkwin/tabbox] Use an enum for role names.
Fri, Nov 22, 10:53 AM · KWin
zzag requested review of D25457: [kcmkwin/tabbox] Use an enum for role names.
Fri, Nov 22, 10:41 AM · KWin

Yesterday

meven added a comment to D25427: [WIP][Wayland] Allow to take full resolution screenshot when scaling is used.

GLRenderTarget::virtualScreenScale() is currently only set to screen->scale during the paint method.

Thu, Nov 21, 2:14 PM · KWin
meven updated the diff for D25427: [WIP][Wayland] Allow to take full resolution screenshot when scaling is used.

Rename variable to proper name

Thu, Nov 21, 10:52 AM · KWin

Wed, Nov 20

davidedmundson added a comment to D25427: [WIP][Wayland] Allow to take full resolution screenshot when scaling is used.

On has a scaling of two and the other not. Would then one side of the image be double the size than the other one because we want the full resolution? Or would you scale the lower resolution half of the image up?

Wed, Nov 20, 7:55 PM · KWin
davidre added a comment to D25427: [WIP][Wayland] Allow to take full resolution screenshot when scaling is used.

This approach will probably fail when the geometry stretches across multiple outputs with different scales.

I am well aware, this a naive and basic approach to gather some learning feedback.
And Those changes are only needed for Wayland.
I need to break the geometry by screen get their scale and then put all together in a virtualScreenGeometry according to the passed Geometry.
But I need to learn how to get there, dig in the code and/or ask questions if I may.
I have a two screens system at home to test this.

Wed, Nov 20, 7:30 PM · KWin
meven added a comment to D25427: [WIP][Wayland] Allow to take full resolution screenshot when scaling is used.

This approach will probably fail when the geometry stretches across multiple outputs with different scales.

Wed, Nov 20, 6:53 PM · KWin
davidre added a comment to D25427: [WIP][Wayland] Allow to take full resolution screenshot when scaling is used.

This approach will probably fail when the geometry stretches across multiple outputs with different scales.

Wed, Nov 20, 6:33 PM · KWin
meven requested review of D25427: [WIP][Wayland] Allow to take full resolution screenshot when scaling is used.
Wed, Nov 20, 6:22 PM · KWin

Mon, Nov 18

ngraham added a comment to D18000: Tweak slidingpopups effect to make animation smoother.

@sefaeyeoglu thanks for this patch. We have a set of emerging guidelines for animations in D25343. Can you address the inline comments so we can push this forward?

Mon, Nov 18, 4:35 PM · KWin
ngraham added a comment to D25338: Changed sliding popup easing curve to In and Out cubic.

yeah, let's do this in D18000.

Mon, Nov 18, 4:34 PM · KWin
zzag closed D25366: Fix the order of arguments passed to changeMaximize method.
Mon, Nov 18, 2:07 PM · KWin
davidedmundson added a comment to D25366: Fix the order of arguments passed to changeMaximize method.

Later is fine, there's no rush.

Mon, Nov 18, 1:52 PM · KWin
zzag updated the summary of D25366: Fix the order of arguments passed to changeMaximize method.
Mon, Nov 18, 1:46 PM · KWin
zzag added a comment to D25366: Fix the order of arguments passed to changeMaximize method.

Urgh, I'm sure this is the second case I've seen of this at least.

Mon, Nov 18, 1:08 PM · KWin
davidedmundson accepted D25366: Fix the order of arguments passed to changeMaximize method.

Urgh, I'm sure this is the second case I've seen of this at least.

Mon, Nov 18, 12:50 PM · KWin
zzag updated the summary of D25366: Fix the order of arguments passed to changeMaximize method.
Mon, Nov 18, 12:41 PM · KWin
zzag requested review of D25366: Fix the order of arguments passed to changeMaximize method.
Mon, Nov 18, 12:34 PM · KWin
mart closed D25146: try to enforce borders settings from KWin.
Mon, Nov 18, 10:34 AM · KWin
zzag closed D25365: [libkwineffects] Restore GL_DRAW_FRAMEBUFFER binding in GLTexture::clear.
Mon, Nov 18, 10:29 AM · KWin
davidedmundson accepted D25365: [libkwineffects] Restore GL_DRAW_FRAMEBUFFER binding in GLTexture::clear.
Mon, Nov 18, 10:19 AM · KWin
zzag added a comment to D25365: [libkwineffects] Restore GL_DRAW_FRAMEBUFFER binding in GLTexture::clear.

Test plan:

Mon, Nov 18, 10:10 AM · KWin
zzag added a comment to D25365: [libkwineffects] Restore GL_DRAW_FRAMEBUFFER binding in GLTexture::clear.

I'm targeting 5.17.X and perhaps 5.12.X.

Mon, Nov 18, 10:06 AM · KWin
zzag requested review of D25365: [libkwineffects] Restore GL_DRAW_FRAMEBUFFER binding in GLTexture::clear.
Mon, Nov 18, 10:00 AM · KWin
zzag closed D25092: [tabbox] Drop TabBoxClient::window() method.
Mon, Nov 18, 8:43 AM · KWin
zzag added a comment to D23114: [perf] Introduce ftrace marker.

This still looks slightly over-engineered. You could put everything in one class and add a few convenience methods to make it a bit easier to use the new class.

Mon, Nov 18, 8:01 AM · KWin
zzag added inline comments to D25300: [platforms/x11/standalone] Use intel swap events by default.
Mon, Nov 18, 7:42 AM · KWin

Sun, Nov 17

davidedmundson added a comment to D24281: Add default shortcut to switch to the desktop to the left/right/top/bottom.

Purely as an observation this will break any user that has:
https://github.com/lingtjien/Grid-Tiling-Kwin

Sun, Nov 17, 10:26 PM · KWin
niccolove added a comment to D18000: Tweak slidingpopups effect to make animation smoother.

+1, should we land this while HIG animation page and easing curves are being discussed?

Sun, Nov 17, 9:32 PM · KWin
filipf added a comment to D25338: Changed sliding popup easing curve to In and Out cubic.

There is already a patch trying to change this, I would be good to involve Sefa as well: D18000

Sun, Nov 17, 8:59 PM · KWin
thiagosueto added a comment to D24281: Add default shortcut to switch to the desktop to the left/right/top/bottom.

One thing of note that is set by default on both XFCE and GNOME is Ctrl+Alt+arrows for moving between workspaces: in GNOME Ctrl+Alt+Up/Down switches between workspaces vertically and XFCE uses Ctrl+Alt+Up/Down/Left/Right to switch between workspaces both vertically and horizontally. Since we're switching to Meta as default for system/shell/desktop shortcuts, could Ctrl+Alt+arrows be set as an alternative (as Plasma allows for two keyboard shortcuts for the same action through the GUI)?

Sun, Nov 17, 7:08 PM · KWin
ngraham added a comment to D25338: Changed sliding popup easing curve to In and Out cubic.

While D25343 is being discussed, we can change the effect to Quad from Sine so it's already more consistent, eventually change to cubic if there's agreement on that in the future.

Sun, Nov 17, 6:45 PM · KWin
niccolove added a comment to D25338: Changed sliding popup easing curve to In and Out cubic.

While D25343 is being discussed, we can change the effect to Quad from Sine so it's already more consistent, eventually change to cubic if there's agreement on that in the future.

Sun, Nov 17, 5:24 PM · KWin
niccolove updated the diff for D25338: Changed sliding popup easing curve to In and Out cubic.

Changed sliding popup easing curve to In and Out cubic

Sun, Nov 17, 5:23 PM · KWin

Sat, Nov 16

davidedmundson added a comment to D25338: Changed sliding popup easing curve to In and Out cubic.

I agree on the In/Out changes
Cubic seems random. I grepped plasma, 95% is quad.

Sat, Nov 16, 6:50 PM · KWin
ngraham accepted D25338: Changed sliding popup easing curve to In and Out cubic.

I gave this a try yesterday when it was first brought up in the VDG room and have been using it since then. I quite like it. It makes popups open and close a bit faster, and the effect is subtle and tasteful IMO.

Sat, Nov 16, 5:25 PM · KWin
niccolove added reviewers for D25338: Changed sliding popup easing curve to In and Out cubic: KWin, VDG.
Sat, Nov 16, 5:00 PM · KWin
niccolove requested review of D25338: Changed sliding popup easing curve to In and Out cubic.
Sat, Nov 16, 4:59 PM · KWin
anthonyfieroni added inline comments to D22418: WIP [wayland] make automatic backend selection truly automatic.
Sat, Nov 16, 1:35 PM · KWin
alexeymin added a comment to D22418: WIP [wayland] make automatic backend selection truly automatic.

not convinced that removing the ifdef is the solution

Sat, Nov 16, 1:13 PM · KWin
alexeymin updated the diff for D22418: WIP [wayland] make automatic backend selection truly automatic.
  • remove unwanted change in translated string
Sat, Nov 16, 12:42 PM · KWin
alexeymin updated the diff for D22418: WIP [wayland] make automatic backend selection truly automatic.
  • Link kwin_wayland with Wayland::Client
  • Platform: add canLoad() function and implement in all backends
  • Add autoLoadPriority to wayland backends plugins JSON metadata
  • main_wayland: sort loaded plugins by autoLoadPriority
  • main_wayland: automatic backend selection based on their priority
Sat, Nov 16, 12:32 PM · KWin

Fri, Nov 15

ngraham added a comment to T12040: "Resolution Dependent" cursor setting: fix it or delete it?.

If I understand it, the angry bug report came from the fact that we were actually setting new defaults ourselves, overriding the system-provided defaults, if any. For this, could we just remove the "Resolution Dependent" setting in the UI and make the state when $XCURSOR_WHATEVER isn't set effectively evaluate to a 24px cursor size (or whatever)?

Fri, Nov 15, 6:21 PM · KWin
davidedmundson added a comment to T12040: "Resolution Dependent" cursor setting: fix it or delete it?.

I specifically chose that example as it got at least one angry bug report as soon as we removed it.

Fri, Nov 15, 6:04 PM · KWin
ngraham added a comment to T12040: "Resolution Dependent" cursor setting: fix it or delete it?.

We changed that to make specific values effectively be the default font anti-aliasing settings, for similar reasons (it was buggy and confusing). Could we do the same thing for the Cursors KCM?

Fri, Nov 15, 5:22 PM · KWin

Thu, Nov 14

davidedmundson added a comment to T12040: "Resolution Dependent" cursor setting: fix it or delete it?.

Edit! Of course I do.

Thu, Nov 14, 11:44 PM · KWin