KWinProject
ActivePublic

Details

Description

Wayland Compositor and X11 Window Manager

Recent Activity

Today

zzag updated the summary of D21302: [tabbox] Use xkb to determine depressed modifiers on X11.
Mon, May 20, 12:44 PM · KWin
zzag requested review of D21302: [tabbox] Use xkb to determine depressed modifiers on X11.
Mon, May 20, 11:52 AM · KWin

Fri, May 17

apol added inline comments to D21262: Fix memory leak.
Fri, May 17, 10:44 PM · KWin
davidedmundson added inline comments to D21262: Fix memory leak.
Fri, May 17, 10:42 PM · KWin
davidedmundson accepted D21263: Don't call << in a temporary vector.
Fri, May 17, 10:37 PM · KWin
apol added inline comments to D21262: Fix memory leak.
Fri, May 17, 7:46 PM · KWin
tcanabrava requested review of D21263: Don't call << in a temporary vector.
Fri, May 17, 7:42 PM · KWin
tcanabrava requested review of D21262: Fix memory leak.
Fri, May 17, 7:37 PM · KWin
ngraham removed a dependent revision for D13276: Display "No Borders" by default: D13278: Keep default border value in line with KWin's setting.
Fri, May 17, 4:59 PM · KWin
ngraham added a comment to D13284: [decorations] Let KDecoration plugins recommend a border size per default.

Plasma 5.16 has now branched, so if this is land-able, we could do it now/soon and have lots of testing time before 5.17.

Fri, May 17, 4:57 PM · KWin
arojas closed D21254: Move knsrc files to the new location.
Fri, May 17, 4:57 PM · KWin
ngraham added a task to D13480: kconfig_update for auto border size introduction: T8707: Window borders.
Fri, May 17, 4:56 PM · KWin
ngraham removed a task from D13276: Display "No Borders" by default: T8707: Window borders.
Fri, May 17, 4:56 PM · KWin
ngraham accepted D21254: Move knsrc files to the new location.

Stable branch please!

Fri, May 17, 4:41 PM · KWin
arojas requested review of D21254: Move knsrc files to the new location.
Fri, May 17, 4:38 PM · KWin
zzag closed D19000: Send axis_source, axis_discrete, and axis_stop.
Fri, May 17, 9:07 AM · KWin
zzag closed D21116: Keep internal clients in the unmanaged layer.
Fri, May 17, 8:45 AM · KWin
davidedmundson added a comment to D21076: ICC Color Correction Effect.

Yeah, you're right. Under their scheme the relevant app is meant to do it, not the compositor.
Thanks for the link.

Fri, May 17, 12:04 AM · KWin

Thu, May 16

vitaliyf added a comment to D21076: ICC Color Correction Effect.

It being impossible would certainly be a very compelling reason to do it at this layer instead. I would support something along these lines if that's the case.

Though your comment doesn't match the docs I've seen on the colord site. I'll poke a Mutter dev and see what they're doing.

Thu, May 16, 11:45 PM · KWin
davidedmundson added a comment to D21076: ICC Color Correction Effect.

They only load 1-dimensional LUTs ("VCGT" tag, Video Card Gamma Table) into the video card.

Thu, May 16, 11:36 PM · KWin
davidedmundson accepted D21116: Keep internal clients in the unmanaged layer.
Thu, May 16, 11:11 PM · KWin

Wed, May 15

skadinna moved T9996: Improve Thumbnail Aside effect from Incoming - All new tasks and ideas go here to Done on the KDE Promo board.
Wed, May 15, 3:39 PM · KDE Promo, VDG, KWin
ngraham added a comment to D21083: [effects/presentwindows] Allow closing windows on middle-click.
In D21083#465601, @zzag wrote:

We still maintain the present windows effect, we still fix bugs, but not extend it.

Wed, May 15, 1:56 PM · KWin
davidedmundson added a comment to D21083: [effects/presentwindows] Allow closing windows on middle-click.

On the other note, I don't like that the new option is off by default. It will definitely have discoverability problems!

Wed, May 15, 1:51 PM · KWin
zzag added a comment to D21083: [effects/presentwindows] Allow closing windows on middle-click.

Before merging this feature I urge you to look through the support information attached to our bug reports and check how many users actually change anything in the effects.

Wed, May 15, 1:47 PM · KWin
zzag requested changes to D21083: [effects/presentwindows] Allow closing windows on middle-click.

So let's rewrite it

Wed, May 15, 1:44 PM · KWin
zzag closed D21224: [effects/thumbnailaside] Specify screen projection matrix.
Wed, May 15, 9:35 AM · KWin
davidedmundson accepted D21224: [effects/thumbnailaside] Specify screen projection matrix.
Wed, May 15, 9:22 AM · KWin
zzag retitled D21224: [effects/thumbnailaside] Specify screen projection matrix from [effects/thumbnailaside] Specify projection matrix to [effects/thumbnailaside] Specify screen projection matrix.
Wed, May 15, 9:14 AM · KWin
zzag requested review of D21224: [effects/thumbnailaside] Specify screen projection matrix.
Wed, May 15, 9:11 AM · KWin
zzag closed D20987: Compute correct boundaries in checkWorkspacePosition.
Wed, May 15, 8:07 AM · KWin
zzag closed D21217: Port away from deprecated qFind.
Wed, May 15, 8:03 AM · KWin

Tue, May 14

davidedmundson accepted D21217: Port away from deprecated qFind.
Tue, May 14, 3:36 PM · KWin
apol accepted D21217: Port away from deprecated qFind.
Tue, May 14, 3:27 PM · KWin
zzag requested review of D21217: Port away from deprecated qFind.
Tue, May 14, 3:23 PM · KWin
ngraham added a comment to D21083: [effects/presentwindows] Allow closing windows on middle-click.

Ping? Can we get this done?

Tue, May 14, 3:20 PM · KWin
zzag added inline comments to D20890: Close screen grabbing effect when screensaver starts.
Tue, May 14, 12:48 PM · KWin
davidedmundson accepted D20987: Compute correct boundaries in checkWorkspacePosition.
Tue, May 14, 11:41 AM · KWin
hpereiradacosta added a comment to D13284: [decorations] Let KDecoration plugins recommend a border size per default.

So, how does that work when user select a specific size, and then change decoration ? Is his choice erased by the default of the new decoration ? Or is his choice maintained (in which case he never gets a chance to actually see the "preferred" width of the new decoration ? And then, if erased by the new default, does that mean that if I switch from decoration A (with custom setting) to decoration B, and then back to A, my custom setting is lost ?

Best,

Hugo

Default is to use the recommended sizes of decorations (falls back to Normal if decoration does not recommend one). User might opt in to specifiy a border size manually instead. This choice is being remembered even if he changes to another decoration. But in this configuration screen he can also opt out to automatic border size again.

Tue, May 14, 5:12 AM · KWin

Mon, May 13

ngraham added a comment to D20890: Close screen grabbing effect when screensaver starts.

Do we have consensus on this?

Mon, May 13, 9:35 PM · KWin
davidedmundson added a comment to D19867: [X11] Force glXSwapBuffers to block with NVIDIA driver.

(shall we just move this discussion there going forward?)

Mon, May 13, 9:00 PM · KWin
ekurzinger added a comment to D19867: [X11] Force glXSwapBuffers to block with NVIDIA driver.

I posted a comment on the bug (shall we just move this discussion there going forward?) with a bit more explanation, but in summary David's patch seems to only prevent the hang the first time a QtQuick window is displayed. However, I think this might be more of a Qt issue that might be worth fixing upstream, although maybe it can be worked around in KWin as well. I'm not sure to what extend Qt and KDE development is coordinated?

Mon, May 13, 8:59 PM · KWin
romangg updated subscribers of D13284: [decorations] Let KDecoration plugins recommend a border size per default.

So, how does that work when user select a specific size, and then change decoration ? Is his choice erased by the default of the new decoration ? Or is his choice maintained (in which case he never gets a chance to actually see the "preferred" width of the new decoration ? And then, if erased by the new default, does that mean that if I switch from decoration A (with custom setting) to decoration B, and then back to A, my custom setting is lost ?

Best,

Hugo

Mon, May 13, 8:46 PM · KWin
hpereiradacosta added a comment to D13284: [decorations] Let KDecoration plugins recommend a border size per default.

So, how does that work when user select a specific size, and then change decoration ? Is his choice erased by the default of the new decoration ? Or is his choice maintained (in which case he never gets a chance to actually see the "prefered" width of the new decoration ? And then, if erased by the new default, does that mean that if I switch from decoration A (with custom setting) to decoration B, and then back to A, my custom setting is lost ?

Mon, May 13, 6:47 PM · KWin
vitaliyf updated the diff for D21076: ICC Color Correction Effect.
Mon, May 13, 4:22 PM · KWin
vitaliyf added inline comments to D21076: ICC Color Correction Effect.
Mon, May 13, 4:22 PM · KWin
zzag added inline comments to D13284: [decorations] Let KDecoration plugins recommend a border size per default.
Mon, May 13, 2:30 PM · KWin
vitaliyf added a comment to D21076: ICC Color Correction Effect.

If we are going to do all windows, what does this offer over xcalib?

Mon, May 13, 1:42 PM · KWin
davidedmundson added a comment to D21076: ICC Color Correction Effect.

Lets evaluate the concept before we fuss over code details, otherwise we're doing it in the wrong order.

Mon, May 13, 11:45 AM · KWin
anthonyfieroni added inline comments to D21076: ICC Color Correction Effect.
Mon, May 13, 11:38 AM · KWin