Wayland Compositor and X11 Window Manager
ping on this?
Remove unused include
The biggest problem with sharing the dmabuf buffers it that its memory management becomes quite complex (and I'm unsure it's really doable).
PipeWire has mechanisms to create the buffers it's going to need, juggling this with passing the buffer from the app/output and making sure it stays relevant feels messy and error-prone.
Copying from dmabuf->dmabuf shouldn't be very expensive though, as it shouldn't go through the buses (AFAIK, that is).
Sat, May 23
Moved and finished (now works) here: https://invent.kde.org/plasma/kwin/-/merge_requests/17
Fri, May 22
Hey man, can you join our vdg team on Telegram? Here is the link: https://t.me/vdgmainroom
don't need to include cmath anymore
Address review feedback
- Use After instead of Wants
Thu, May 21
Wed, May 20
Zero based position parameters.
And the actual rationale appears to be: https://mail.kde.org/pipermail/kde-frameworks-devel/2020-March/105081.html
If, like me, you land here (after discovering the new dependency) and miss the rationale, see:
You can update users' config filed with a kconf update script (see https://techbase.kde.org/Development/Tools/Using_kconf_update) or avoid changing the config file key names in the first place.
I'm a bit confused. Aren't we changing the size for third party global themes as well? Do all global themes set their size?
Tue, May 19
It might be best not to change anything about the position until we can come up with a significantly better solution.
How do you think about putting it horizontally centered at the top of the screen? Maybe even avoiding panels, if possible?
I'd be fine both with "floating a bit under the panel" and "merged with screen/panel top" like krunner.
In the absence of a way for the Global Theme or (proposed-but-not-yet-existing OSD themes) to set a custom OSD position, are KWin people okay with this patch to improve the positioning of the new OSD?
Resuming this on invent
I'm feeling pretty lukewarm about this idea. It's maybe slightly better in some situations, but with the smaller size, I think it'll also be easier to miss if it's not in the center. Since the OSD is smaller, being exactly in the center isn't such a huge problem either. Although, I suppose it would still get in the way of crosshairs if the user was playing a shooter game.