DocumentationOrganization
ActivePublic

Recent Activity

Tue, Aug 11

dfaure accepted D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).
Tue, Aug 11, 8:33 AM · Documentation
rrosch added a comment to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

I didn't have an assert before though, should I replace the if statement with a Q_ASSERT then?

Yes I still believe you should.

I thought that was just to catch errors

Yes, it is. If everything works as intended, this method will never be called with canToggleShowHiddenFolders == false.
And if() makes people think that it can, which is just not true.

but since this is just an option

What is an option?

(and hence shouldn't cause problems when false)

Confusing code is a problem.

Tue, Aug 11, 6:11 AM · Documentation

Mon, Aug 10

rrosch updated the diff for D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

Q_ASSERT instead of redundant if(), as suggested

Mon, Aug 10, 9:14 PM · Documentation

Thu, Aug 6

dfaure added a comment to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

I didn't have an assert before though, should I replace the if statement with a Q_ASSERT then?

Thu, Aug 6, 8:31 AM · Documentation

Wed, Aug 5

rrosch added a comment to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

Argh, sorry about that.

Wed, Aug 5, 8:54 PM · Documentation
dfaure added a comment to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

A bunch of fixes got reverted. The dead code is back. The assert is gone. The docu improvement is gone....

Wed, Aug 5, 8:18 PM · Documentation
rrosch updated the diff for D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

Latest round of modifications according to review notes.

Wed, Aug 5, 7:29 PM · Documentation
dfaure added inline comments to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).
Wed, Aug 5, 3:50 PM · Documentation
dfaure added inline comments to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).
Wed, Aug 5, 3:47 PM · Documentation
rrosch updated the diff for D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

Removing unnecessary comment.

Wed, Aug 5, 4:32 AM · Documentation
rrosch updated the diff for D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

Added changes as requested.

Wed, Aug 5, 4:28 AM · Documentation
rrosch added inline comments to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).
Wed, Aug 5, 4:22 AM · Documentation
rrosch added inline comments to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).
Wed, Aug 5, 3:52 AM · Documentation

Sat, Aug 1

dfaure added inline comments to D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).
Sat, Aug 1, 8:26 PM · Documentation

Wed, Jul 29

rrosch updated the test plan for D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).
Wed, Jul 29, 7:53 AM · Documentation
rrosch updated the diff for D29871: Enable option to show hidden folders in sidebar, plus small sidebar code fixes (eg: scrollbar display).

Added the context menu code.

Wed, Jul 29, 7:48 AM · Documentation

Sun, Jul 19

ltoscano closed T13382: populate_documentation.sh: use the gitlab tarball instead to git archive as Resolved.

After a few days of usage, it seems everything is working as expected.

Sun, Jul 19, 9:53 PM · Localization, Documentation

Jul 13 2020

ltoscano added a comment to T13382: populate_documentation.sh: use the gitlab tarball instead to git archive.

https://websvn.kde.org/?view=revision&revision=1574284

Jul 13 2020, 10:16 PM · Localization, Documentation

Jul 9 2020

ltoscano updated the task description for T13382: populate_documentation.sh: use the gitlab tarball instead to git archive.
Jul 9 2020, 12:46 PM · Localization, Documentation
ltoscano updated the task description for T13382: populate_documentation.sh: use the gitlab tarball instead to git archive.
Jul 9 2020, 12:44 PM · Localization, Documentation
ltoscano created T13382: populate_documentation.sh: use the gitlab tarball instead to git archive.
Jul 9 2020, 11:11 AM · Localization, Documentation

Jun 4 2020

yurchor abandoned D25229: Update docs to the new annotation toolbar.

Moved:

Jun 4 2020, 6:32 PM · Documentation, Okular

Jun 3 2020

spage closed D29837: Use "Editing" instead of Edition in doc.
Jun 3 2020, 1:36 AM · Documentation

Jun 2 2020

ltoscano closed D29838: Improve Operations list documentation.
Jun 2 2020, 10:18 AM · Documentation
spage updated the diff for D29837: Use "Editing" instead of Edition in doc.

Fixed two capitalizations

Jun 2 2020, 9:45 AM · Documentation

Jun 1 2020

yurchor accepted D29837: Use "Editing" instead of Edition in doc.

Thanks.

Jun 1 2020, 8:13 AM · Documentation
yurchor accepted D29838: Improve Operations list documentation.

Thanks.

Jun 1 2020, 8:12 AM · Documentation
spage requested review of D29838: Improve Operations list documentation.
Jun 1 2020, 7:51 AM · Documentation
spage added a reviewer for D29837: Use "Editing" instead of Edition in doc: smankowski.

I'm not sure who should review Skrooge doc changes. I did not rebuild the Skrooge Handbook to test, sorry.

Jun 1 2020, 6:42 AM · Documentation
spage requested review of D29837: Use "Editing" instead of Edition in doc.
Jun 1 2020, 6:40 AM · Documentation

May 31 2020

gengisdave abandoned D26291: rework of keyboard widgets focus.

Moving to Gitlab

May 31 2020, 12:58 PM · Krusader, Documentation

May 30 2020

nmel added a comment to D26291: rework of keyboard widgets focus.

Thanks Toni, I missed that.

May 30 2020, 6:06 AM · Krusader, Documentation

May 28 2020

asensi requested changes to D26291: rework of keyboard widgets focus.

Ctrl+Up and Ctrl+Down would stop working 😔 and IIRC Davide was trying to solve that.

May 28 2020, 8:49 AM · Krusader, Documentation
nmel added a comment to D26291: rework of keyboard widgets focus.

@gengisdave , I don't see this merged. Forgotten?

May 28 2020, 7:51 AM · Krusader, Documentation

May 19 2020

meven added a comment to T13073: Documentation for runner syntaxes.

Yeah KRunner lack discoverability.

May 19 2020, 4:41 PM · Documentation
alex added a comment to T13073: Documentation for runner syntaxes.

Any thoughts?

May 19 2020, 1:25 PM · Documentation
kossebau closed D29797: Unbreak generation with dep diagrams with Python 3 (break Py2).
May 19 2020, 12:51 PM · Documentation, Frameworks
kossebau updated the summary of D29797: Unbreak generation with dep diagrams with Python 3 (break Py2).
May 19 2020, 11:12 AM · Documentation, Frameworks
kossebau added a comment to D29797: Unbreak generation with dep diagrams with Python 3 (break Py2).

Patch worked fine also on real server run the last two nights. So going to push later today once at my respective development setup. Will push as is, given safe_load() is now also used without any conditions for the new invent.kde.org git helper :) so doing as the real Python developers do.

May 19 2020, 11:07 AM · Documentation, Frameworks
dvratil added a task to D29723: Adapt KMail to MessageComposer SendLater API changes: T13172: kdepim-apps-libs cleanup.
May 19 2020, 9:17 AM · Documentation, KDE PIM
dvratil added a task to D29724: SendLaterAgent: merge libKF5SendLater library into the agent: T13172: kdepim-apps-libs cleanup.
May 19 2020, 9:17 AM · Documentation, KDE PIM
dvratil closed D29724: SendLaterAgent: merge libKF5SendLater library into the agent.
May 19 2020, 8:46 AM · Documentation, KDE PIM
dvratil closed D29723: Adapt KMail to MessageComposer SendLater API changes.
May 19 2020, 8:45 AM · Documentation, KDE PIM
mlaurent accepted D29724: SendLaterAgent: merge libKF5SendLater library into the agent.
May 19 2020, 5:08 AM · Documentation, KDE PIM

May 18 2020

dvratil added inline comments to D29724: SendLaterAgent: merge libKF5SendLater library into the agent.
May 18 2020, 1:06 PM · Documentation, KDE PIM
dvratil updated the diff for D29724: SendLaterAgent: merge libKF5SendLater library into the agent.
  • Remove useless include
May 18 2020, 1:05 PM · Documentation, KDE PIM

May 17 2020

kossebau added reviewers for D29797: Unbreak generation with dep diagrams with Python 3 (break Py2): winterz, francescorios.
May 17 2020, 11:40 AM · Documentation, Frameworks
kossebau added a comment to D29797: Unbreak generation with dep diagrams with Python 3 (break Py2).

Bah, I patched the wrong kapidox on the server, so last nights run still failed. Oh well... not sure I will have time in the evening for processing this patch, but at least now getting the diff applied also on the right kapidox, so next server check tomorrow.

May 17 2020, 11:37 AM · Documentation, Frameworks

May 16 2020

kossebau added a comment to D29797: Unbreak generation with dep diagrams with Python 3 (break Py2).

I just applied the diff as-is to the working checkout of kapidox on the server, to see if the patch also works for the setup of the nightly run, other than my separate testing which might have missed any special environment setup. So tomorrow before noon CEST we should have proof this patch catches all issues.
So no immediate pressure to get this patch out ASAP to also get api.kde.org running again :)

May 16 2020, 7:52 PM · Documentation, Frameworks
ognarb added a comment to D29797: Unbreak generation with dep diagrams with Python 3 (break Py2).

Thanks for the (first) review :)

Open questions I have are these:
a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a fallback to load() otherwise? It was only introduced at a certain version of pyyaml

May 16 2020, 7:27 PM · Documentation, Frameworks