Tue, Jul 16
Ah, looks like Dolphin conditionally adds the zoom actions to the main menu in dolphinmainwindow.cpp (lines 984-988). That's where you should add the new action. Then I guess you don't need to touch the rc files.
I have added the action in .rc files still I can not see them added in the menu.
Add action to View menu
Mon, Jul 15
Please use a descriptive commit message: https://community.kde.org/Policies/Commit_Policy#Always_add_descriptive_log_messages
Cool, it works and the code is looking pretty good. Now I think the new action needs to be added to the View menu too, between the zoom in and zoom out menu items. The place where you've added it in dolphinui.rc doesn't actually do that.
Get default icon size
Sun, Jul 14
use default value
There is nothing like "default"
Sat, Jul 13
The new design looks great!
The dark mode is certainly a nice addition, but I feel the "Note" Box feels a bit out of place there with its dark text on a light green background. I think the box would look nicer in dark mode if you used the same color palette as inline notifications in Plasma with the Breeze Dark theme. I'll try to find a screenshot as I'm on mobile right now.
Set zoom to 5px
In general +1 on the concept, but needs revision before it can go in.
Add / atend of action name in .rc
Looks great overall!
I just want to nitpick that the top-right search bar doesn't align with the sidebar. Adding the class "mr-3" to the form and setting the .form-control width to 255px seems to have aligned them for me but that is maybe not the right solution.
Userbase is now updated https://carlschwan.eu/2019/07/12/new-userbase.html
Fri, Jul 12
Nice! Thx Harald!
Wed, Jul 10
Apologize for the long delay. It looks like that the fix still applies and works according the comment.
Mon, Jul 8
I made the visited link a bit darker. And added a dark mode ;)
Great work! Two small things:
- I would suggest either removing the "Information" and "Note" titles in the boxes or to format them differently than the body text. Right now, there is no clear separation between the content and these words, which feels a bit akward.
- In my opinion the visited links look a bit too "washed out"/bright - there isn't a lot of contrast anymore. Maybe tone down the brightness a bit, or even make them darker than the unvisited links? (Probably something for our VDG group...)
I think the dropdown menu for the language selection might be too hard to spot if an unknown language is displayed.
Can we propose some design changes ?
Like remove the icons from the "note" box and add some additional margin and padding to the list on the right side ?
Sun, Jul 7
Thanks one less thing to worry about ;)
It looks fine for me. Export works as expected. No issues found except for the above-mentioned ones.