KirigamiProject
ActivePublic

Recent Activity

Today

ndavis added a comment to T12567: Reduce code/effort duplication around color scheme support.

QML can use C++ functions right? Would we still need to make property bindings for all the colors if we had color() functions?

Tue, Jan 21, 7:13 PM · KF6, Kirigami, Plasma, Frameworks
mlaurent closed D26790: Remove unused variable (probabilities) + make it compile without deprecated method: reverseDist is already a QMultiHash.

Done in 2 commits.

Tue, Jan 21, 5:49 AM · Kirigami

Yesterday

ndavis updated the task description for T12567: Reduce code/effort duplication around color scheme support.
Mon, Jan 20, 11:20 PM · KF6, Kirigami, Plasma, Frameworks
ndavis updated subscribers of T12567: Reduce code/effort duplication around color scheme support.
Mon, Jan 20, 10:35 PM · KF6, Kirigami, Plasma, Frameworks
ndavis updated subscribers of T12567: Reduce code/effort duplication around color scheme support.
Mon, Jan 20, 10:34 PM · KF6, Kirigami, Plasma, Frameworks
ndavis added a project to T12567: Reduce code/effort duplication around color scheme support: KF6.
Mon, Jan 20, 10:14 PM · KF6, Kirigami, Plasma, Frameworks
ndavis created T12567: Reduce code/effort duplication around color scheme support.
Mon, Jan 20, 10:14 PM · KF6, Kirigami, Plasma, Frameworks
apol accepted D26790: Remove unused variable (probabilities) + make it compile without deprecated method: reverseDist is already a QMultiHash.
Mon, Jan 20, 4:44 PM · Kirigami
apol added a comment to D26790: Remove unused variable (probabilities) + make it compile without deprecated method: reverseDist is already a QMultiHash.

Clearly 2 separate changes and too long line on the commit message. Please split when landing.

Mon, Jan 20, 4:44 PM · Kirigami
ndavis closed D26746: Add active, link, visited, negative, neutral and positive background colors.
Mon, Jan 20, 4:00 PM · Kirigami, Plasma
ndavis closed D26743: Add active, link, visited, negative, neutral and positive background colors.
Mon, Jan 20, 3:58 PM · Kirigami
mlaurent requested review of D26790: Remove unused variable (probabilities) + make it compile without deprecated method: reverseDist is already a QMultiHash.
Mon, Jan 20, 12:34 PM · Kirigami
mart accepted D26746: Add active, link, visited, negative, neutral and positive background colors.
Mon, Jan 20, 9:56 AM · Kirigami, Plasma
mart accepted D26743: Add active, link, visited, negative, neutral and positive background colors.
Mon, Jan 20, 9:56 AM · Kirigami
mart requested changes to D26743: Add active, link, visited, negative, neutral and positive background colors.

This is ok, but is missing a piece.
this should be reflected also in
qqc2-desktop-style/kirigami-plasmadesktop-integration/plasmadeksotptheme.cpp or it won't actually follow the configured color scheme.

Mon, Jan 20, 9:50 AM · Kirigami

Sun, Jan 19

ngraham moved T9126: Breeze scrollbar look-and-feel unification from VDG Discussion to Apps Implementation on the Goal: Consistency board.
Sun, Jan 19, 3:11 AM · KDE Applications, Plasma, Breeze, Kirigami, Goal: Consistency, VDG
ngraham closed T9126: Breeze scrollbar look-and-feel unification as Resolved.

Welp, this is done now!

Sun, Jan 19, 3:11 AM · KDE Applications, Plasma, Breeze, Kirigami, Goal: Consistency, VDG

Sat, Jan 18

ndavis added a dependent revision for D26743: Add active, link, visited, negative, neutral and positive background colors: D26746: Add active, link, visited, negative, neutral and positive background colors.
Sat, Jan 18, 2:44 AM · Kirigami
ndavis added a dependency for D26746: Add active, link, visited, negative, neutral and positive background colors: D26743: Add active, link, visited, negative, neutral and positive background colors.
Sat, Jan 18, 2:44 AM · Kirigami, Plasma
ndavis added a dependent revision for D26743: Add active, link, visited, negative, neutral and positive background colors: D26745: Add active, link, visited, negative, neutral and positive background colors.
Sat, Jan 18, 2:43 AM · Kirigami
ndavis requested review of D26746: Add active, link, visited, negative, neutral and positive background colors.
Sat, Jan 18, 2:43 AM · Kirigami, Plasma
ndavis added a reviewer for D26743: Add active, link, visited, negative, neutral and positive background colors: Plasma.
Sat, Jan 18, 2:39 AM · Kirigami
ndavis updated the summary of D26743: Add active, link, visited, negative, neutral and positive background colors.
Sat, Jan 18, 1:44 AM · Kirigami
ndavis requested review of D26743: Add active, link, visited, negative, neutral and positive background colors.
Sat, Jan 18, 1:41 AM · Kirigami

Wed, Jan 15

ngraham added a revision to T9126: Breeze scrollbar look-and-feel unification: D26685: Make the scrollbar always thick.
Wed, Jan 15, 2:36 PM · KDE Applications, Plasma, Breeze, Kirigami, Goal: Consistency, VDG

Tue, Jan 14

ngraham added a comment to T9126: Breeze scrollbar look-and-feel unification.

This is happening; see the linked patches. Here's what's happening:

  • On the desktop, scrollbars return to their prior thickness and are always visible in a separated track regardless of the toolkit (QTWidgets, bare QQC2 on desktop, Kirigami on desktop
  • On mobile with Kirigami or bare QQC2, scrollbars are always overlay style with no layout hacks, which means they can cover the content while in use. When not in use, they flatten out and hug the edge, remaining (barely) visible to serve as an indication of scroll position without getting in anyone's way
Tue, Jan 14, 4:00 PM · KDE Applications, Plasma, Breeze, Kirigami, Goal: Consistency, VDG
ngraham added a revision to T9126: Breeze scrollbar look-and-feel unification: D26655: show a thin separator between view and scrollbar.
Tue, Jan 14, 3:46 PM · KDE Applications, Plasma, Breeze, Kirigami, Goal: Consistency, VDG
ngraham added a revision to T9126: Breeze scrollbar look-and-feel unification: D26654: support mobile mode scrollbar.
Tue, Jan 14, 3:45 PM · KDE Applications, Plasma, Breeze, Kirigami, Goal: Consistency, VDG
ahiemstra closed D25943: Expose ActionToolBar's overflow button icon name.
Tue, Jan 14, 11:58 AM · Kirigami
ahiemstra closed D26656: Use QQC2 Page as base for Kirigami Page.
Tue, Jan 14, 11:57 AM · Kirigami
mart accepted D26656: Use QQC2 Page as base for Kirigami Page.
Tue, Jan 14, 11:04 AM · Kirigami
ahiemstra requested review of D26656: Use QQC2 Page as base for Kirigami Page.
Tue, Jan 14, 11:03 AM · Kirigami

Mon, Jan 13

apol closed D26632: Fix warning on ScrollablePage.
Mon, Jan 13, 3:58 PM · Kirigami
mart accepted D26632: Fix warning on ScrollablePage.
Mon, Jan 13, 3:51 PM · Kirigami
apol requested review of D26632: Fix warning on ScrollablePage.
Mon, Jan 13, 3:49 PM · Kirigami
apol closed D26630: Fix warning.
Mon, Jan 13, 3:30 PM · Kirigami
apol closed D26628: Specify where the code is coming from as the URL.
Mon, Jan 13, 3:30 PM · Kirigami
mart accepted D26628: Specify where the code is coming from as the URL.

<3

Mon, Jan 13, 3:29 PM · Kirigami
mart accepted D26630: Fix warning.
Mon, Jan 13, 3:29 PM · Kirigami
apol updated the diff for D26628: Specify where the code is coming from as the URL.

consistency

Mon, Jan 13, 3:28 PM · Kirigami
apol requested review of D26630: Fix warning.
Mon, Jan 13, 3:25 PM · Kirigami
apol requested review of D26628: Specify where the code is coming from as the URL.
Mon, Jan 13, 3:22 PM · Kirigami
mart added a comment to D24192: WIP: Active page follow the focus.

any update on it?

Mon, Jan 13, 1:11 PM · Kirigami

Fri, Jan 10

ngraham added a comment to D26354: Introduce ActionRow widget.
In D26354#591264, @mart wrote:

needed probably a graphical way to make it obvious that this will trigger on release rather than just showing the action

Fri, Jan 10, 1:34 PM · Kirigami
apol closed D26538: Don't anchor AbstractApplicationHeader blindly.
Fri, Jan 10, 12:38 PM · Kirigami
mart accepted D26538: Don't anchor AbstractApplicationHeader blindly.
Fri, Jan 10, 11:46 AM · Kirigami
mart added a comment to D26354: Introduce ActionRow widget.
In D26354#590815, @mart wrote:

SwipeListItem should just trigger when there is only one action, really (and that one doesn't conflict because the swipe is from the screen edge)

Hey yeah, that could work.

Fri, Jan 10, 11:20 AM · Kirigami

Thu, Jan 9

ngraham added a comment to D26354: Introduce ActionRow widget.
In D26354#590815, @mart wrote:

SwipeListItem should just trigger when there is only one action, really (and that one doesn't conflict because the swipe is from the screen edge)

Thu, Jan 9, 2:39 PM · Kirigami
mart added a comment to D26354: Introduce ActionRow widget.
In D26354#589352, @mart wrote:

also a component like that back then was chosen to not be added by purpose in part because gesture-wise conflicts with the navigate back of pagerow

Personally I don't find Kirigami's swipe-left-and-right-to-navigate-through-the-stack gestures to be very useful. You generally only ever use a swipe to go

Thu, Jan 9, 1:12 PM · Kirigami
apol requested review of D26538: Don't anchor AbstractApplicationHeader blindly.
Thu, Jan 9, 1:46 AM · Kirigami