@ngraham: this is a feature for the weekly report. What is the proposed way to ping you for things to blog about?

Looks good to me know. Thanks for this patch, it's a pretty cool feature, especially for the "Unified mailboxes" agent 👍

• addressed comment from dvratil and also from mlaurent (made in accidentially added revision D29779)

Abandon the other one and try updating this one again. You can use arc diff --update D29602 to make sure it updates this one.

Sorry, something went wrong. I did a "arc diff" and despite "arc which" states the matching revision is D29602 it created a new revision D29779. Any advice how I should proceed?

Tried it locally and it's pretty cool. Just some nitpicks in the recent changes.

Optimised hash look-up

Thanks for the changes. One more change/optimization, please.

Added folder name hashing, removed trailing slash

collectionForId is a good name, I think.

Maybe "StorageModel::collectionFromId()" rather than "StorageModel::collectionForId()" would be better?

Now using the actual (and not the virtual) collection to obtain the message folder

You could still do it but it's a bit more complex: you can use Item::storageCollectionId() to get ID of the real parent collection. You would then need to use the ID against EntityTreeModel to resolve the /actual/ Collection with displayName populated.

I just noticed that my original goal, showing the "real" folder of an item inside a smart list or search, does not work like this. As the the "parentCollection" actually is the smart list/search, it will not show the original folder :-(

In D17822#387035, @nicolasfella wrote:

I'd like to also land this in stable since otherwise a broken feature is exposed. Is that ok?

I'd like to also land this in stable since otherwise a broken feature is exposed. Is that ok?

First it was an error to told you that we don't need to install WigetBase.
So we need to install it and we need to use camelcase headers.
So indeed I will close this one.

Updating patch.

In D11508#231341, @mlaurent wrote:

No as we use this include in MessageList/Widget

So we need to install it.

No as we use this include in MessageList/Widget

Second version of the patch, just don't install widgetbase.h

In D11508#230506, @mlaurent wrote:

"... because the KDE CI is like Superman, with X-Ray vision. A god made of bits. And of course if a problem isn't catched by the KDE CI, that problem simply doesn't exist."
We can try all wierd configuration for sure but with KDE CI we use standard configuration.

So after that ubuntu likes wierd configuration it's your choice :)

I removed some bad include in 18.04 so perhaps it will help you in your wierd config

"... because the KDE CI is like Superman, with X-Ray vision. A god made of bits. And of course if a problem isn't catched by the KDE CI, that problem simply doesn't exist."
We can try all wierd configuration for sure but with KDE CI we use standard configuration.

In D11508#229863, @mlaurent wrote:

We don't have this problem in KDE CI...

We don't have this problem in KDE CI...
I will not install not useful class as it's internal.