- Add check for mdadm tool
I am still working on this.
There are some procedures missing in this test. First, you need to look if mdadm is installed in the system before testing RAID. Then, you need to test the creation of a RAID device and check if it was successfully created. After that, you can try to create partitions on it and test if it exists.
@stikonas Does the rest looks sensible?
Thu, May 23
Add condition in whihc partition size can not be computed
Wed, May 22
Remove extra line
Sun, May 19
Do not remove qca-qt5 from CMakeLists.txt
Sat, May 18
Fri, May 17
Shift common code to filesystem class
Also in general, I think we should create a bool variable where we store data, so that we only run this
I assume it is not required anymore.
Well, in principle both mean exactly the same thing, so I don't have strong opinion on this. I probably use them interchangeably anyway. Well, it's auto, so we don't care what type it is... So based on that I would say no need to make a commit. Other parts of KDE codebase also don't have unified style here. Just checked kwin, it has both auto and auto *
@stikonas any comments?
Yesterday I tried for putting theses revisions over gitLab. but could not succeed. I tried doing git push origin master and it said access denied. So what should I do now to push it remote and the merge? Thanks
I have commit access, but It says access denied. Remember you had said it is hosted on remote server.
oh ok, that's fine then.
Oh, I do by running kdesrc-build script, which takes care of removing old build directory.
please test that it builds in a clean build dir.
I do not know what do you mean? tests?
Do not remove <memory>
We also don't need this. Q_SLOTS are needed with old style Qt syntax where SIGNAL and SLOTS are used. With the new Qt5 connect syntax, you can just connect to any function, so no need to involve moc on this function.
The other include (#include "externalcommandhelper.h") I think can still go away but please test that it builds in a clean build dir.
It is needed by std::unique_ptr and std::unordered_set. We shouldn't rely on header being pulled in by some other header.
More redundant include