KDE Partition ManagerProject
ActivePublic

Recent Activity

Today

shubham updated the diff for D21340: [RFC]Add unit test for RAID.
  1. Add check for mdadm tool

I am still working on this.

Sat, May 25, 2:39 PM · KDE Partition Manager

Yesterday

stikonas added a comment to D21340: [RFC]Add unit test for RAID.

There are some procedures missing in this test. First, you need to look if mdadm is installed in the system before testing RAID. Then, you need to test the creation of a RAID device and check if it was successfully created. After that, you can try to create partitions on it and test if it exists.

Fri, May 24, 5:23 PM · KDE Partition Manager
cjlcarvalho added a comment to D21340: [RFC]Add unit test for RAID.

There are some procedures missing in this test. First, you need to look if mdadm is installed in the system before testing RAID. Then, you need to test the creation of a RAID device and check if it was successfully created. After that, you can try to create partitions on it and test if it exists.

Fri, May 24, 2:53 PM · KDE Partition Manager
cjlcarvalho requested changes to D21340: [RFC]Add unit test for RAID.
Fri, May 24, 2:52 PM · KDE Partition Manager
shubham added inline comments to D21340: [RFC]Add unit test for RAID.
Fri, May 24, 2:53 AM · KDE Partition Manager
shubham added a comment to D21340: [RFC]Add unit test for RAID.

@stikonas Does the rest looks sensible?

Fri, May 24, 2:51 AM · KDE Partition Manager

Thu, May 23

stikonas requested changes to D21340: [RFC]Add unit test for RAID.
Thu, May 23, 11:16 PM · KDE Partition Manager
stikonas accepted D21340: [RFC]Add unit test for RAID.
Thu, May 23, 11:16 PM · KDE Partition Manager
shubham updated the diff for D21340: [RFC]Add unit test for RAID.

Add condition in whihc partition size can not be computed

Thu, May 23, 11:12 AM · KDE Partition Manager

Wed, May 22

shubham updated the diff for D21340: [RFC]Add unit test for RAID.
Wed, May 22, 5:06 PM · KDE Partition Manager
shubham updated the diff for D21340: [RFC]Add unit test for RAID.

Remove extra line

Wed, May 22, 2:17 PM · KDE Partition Manager
shubham added a project to D21340: [RFC]Add unit test for RAID: KDE Partition Manager.
Wed, May 22, 2:16 PM · KDE Partition Manager

Sun, May 19

shubham closed D21275: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough.
Sun, May 19, 5:23 PM · KDE Partition Manager
stikonas accepted D21275: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough.
Sun, May 19, 5:22 PM · KDE Partition Manager
shubham updated the diff for D21275: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough.

Do not remove qca-qt5 from CMakeLists.txt

Sun, May 19, 2:38 PM · KDE Partition Manager

Sat, May 18

shubham added a project to D21275: Scrap Public Key Cryptography code based on QCA as QDbus is secure enough: KDE Partition Manager.
Sat, May 18, 6:53 PM · KDE Partition Manager
shubham closed D21272: Remove superflous variables.
Sat, May 18, 1:24 PM · KDE Partition Manager
stikonas accepted D21272: Remove superflous variables.
Sat, May 18, 1:20 PM · KDE Partition Manager
shubham added a project to D21272: Remove superflous variables: KDE Partition Manager.
Sat, May 18, 1:16 PM · KDE Partition Manager

Fri, May 17

shubham updated the diff for D21261: Prevent resizing read-only mounted file systems.

Shift common code to filesystem class

Fri, May 17, 7:58 PM · KDE Partition Manager
stikonas added a comment to D21261: Prevent resizing read-only mounted file systems.

Also in general, I think we should create a bool variable where we store data, so that we only run this

Fri, May 17, 7:37 PM · KDE Partition Manager
stikonas requested changes to D21261: Prevent resizing read-only mounted file systems.
Fri, May 17, 7:31 PM · KDE Partition Manager
shubham added a project to D21261: Prevent resizing read-only mounted file systems: KDE Partition Manager.
Fri, May 17, 7:31 PM · KDE Partition Manager
shubham abandoned D21244: Make it a pointer since memory is allocated on heap.

I assume it is not required anymore.

Fri, May 17, 5:55 PM · KDE Partition Manager
stikonas added a comment to D21244: Make it a pointer since memory is allocated on heap.

Well, in principle both mean exactly the same thing, so I don't have strong opinion on this. I probably use them interchangeably anyway. Well, it's auto, so we don't care what type it is... So based on that I would say no need to make a commit. Other parts of KDE codebase also don't have unified style here. Just checked kwin, it has both auto and auto *

Fri, May 17, 5:52 PM · KDE Partition Manager
shubham added a comment to D21244: Make it a pointer since memory is allocated on heap.

@stikonas any comments?

Fri, May 17, 5:42 PM · KDE Partition Manager
shubham closed D21241: Simplify test conditions.
Fri, May 17, 5:33 PM · KDE Partition Manager
shubham closed D21251: Remove redundant include.
Fri, May 17, 5:31 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

Yesterday I tried for putting theses revisions over gitLab. but could not succeed. I tried doing git push origin master and it said access denied. So what should I do now to push it remote and the merge? Thanks

Fri, May 17, 5:14 PM · KDE Partition Manager
shubham added a comment to D21251: Remove redundant include.

Yesterday I tried for putting theses revisions over gitLab. but could not succeed. I tried doing git push origin master and it said access denied. So what should I do now to push it remote and the merge? Thanks

Fri, May 17, 5:11 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

I have commit access, but It says access denied. Remember you had said it is hosted on remote server.

Fri, May 17, 5:08 PM · KDE Partition Manager
shubham added a comment to D21251: Remove redundant include.

I have commit access, but It says access denied. Remember you had said it is hosted on remote server.

Fri, May 17, 5:07 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

Oh, I do by running kdesrc-build script, which takes care of removing old build directory.
Please push this and the other revision on my behalf : )

Fri, May 17, 5:06 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

oh ok, that's fine then.

Fri, May 17, 5:06 PM · KDE Partition Manager
shubham added a comment to D21251: Remove redundant include.

Oh, I do by running kdesrc-build script, which takes care of removing old build directory.

Fri, May 17, 5:05 PM · KDE Partition Manager
stikonas accepted D21251: Remove redundant include.
Fri, May 17, 5:04 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

please test that it builds in a clean build dir.

I do not know what do you mean? tests?

Fri, May 17, 5:04 PM · KDE Partition Manager
shubham added a comment to D21251: Remove redundant include.

please test that it builds in a clean build dir.

I do not know what do you mean? tests?

Fri, May 17, 5:02 PM · KDE Partition Manager
shubham updated the diff for D21251: Remove redundant include.

Do not remove <memory>

Fri, May 17, 5:01 PM · KDE Partition Manager
shubham abandoned D21258: Move slot under Q_SLOTS.
Fri, May 17, 4:57 PM · KDE Partition Manager
stikonas requested changes to D21258: Move slot under Q_SLOTS.
Fri, May 17, 4:55 PM · KDE Partition Manager
stikonas added a comment to D21258: Move slot under Q_SLOTS.

We also don't need this. Q_SLOTS are needed with old style Qt syntax where SIGNAL and SLOTS are used. With the new Qt5 connect syntax, you can just connect to any function, so no need to involve moc on this function.

Fri, May 17, 4:55 PM · KDE Partition Manager
stikonas added a comment to D21251: Remove redundant include.

The other include (#include "externalcommandhelper.h") I think can still go away but please test that it builds in a clean build dir.

Fri, May 17, 4:53 PM · KDE Partition Manager
shubham added a project to D21258: Move slot under Q_SLOTS: KDE Partition Manager.
Fri, May 17, 4:52 PM · KDE Partition Manager
stikonas requested changes to D21251: Remove redundant include.

It is needed by std::unique_ptr and std::unordered_set. We shouldn't rely on header being pulled in by some other header.

Fri, May 17, 4:45 PM · KDE Partition Manager
shubham updated the diff for D21251: Remove redundant include.

More redundant include

Fri, May 17, 3:57 PM · KDE Partition Manager
shubham added a project to D21251: Remove redundant include: KDE Partition Manager.
Fri, May 17, 3:33 PM · KDE Partition Manager
shubham added inline comments to D21244: Make it a pointer since memory is allocated on heap.
Fri, May 17, 5:18 AM · KDE Partition Manager

Thu, May 16

cjlcarvalho added inline comments to D21244: Make it a pointer since memory is allocated on heap.
Thu, May 16, 8:13 PM · KDE Partition Manager
shubham added a project to D21244: Make it a pointer since memory is allocated on heap: KDE Partition Manager.
Thu, May 16, 7:57 PM · KDE Partition Manager