sorry, no need for acknowledgement.
If you insist, do it under luzpaz <email@example.com>
Kunda, did you get my message ? Can you mail me your full name / email adress so that I can acknowledge you in the commit?
Fri, Jan 18
Speed issue solved with Build #56. Thanks
Thu, Jan 17
Applied, thanks a lot
The waveform visibility is in Adobe Premiere mutch more better.
I introduced a typo in the previous patch. Fixed now.
Ok...re-rolled a patch on top of refractoring_timeline
Please test it out
I'll take a look at the refactoring_timeline branch and report back.
I am sorry for my silence on this issue. The main reason I didn't merge is that since 2 years, all the work went in the refactoring_timeline branch.
At this point I am not sure we can successfully merge back into master so we might need to make a forced push.
Do audio clips normally only show one side of the waveform? If so, that might make it more difficult to spot phase related issues.
nvm, I re-rolled the patch omitting the 3rd party libs
ugh, not sure but I don't think src/lib/external/kiss_fft/* files should be in the patch but I added them by mistake. Should I remove them or can you manually omit it?
Wed, Jan 16
unfortunately doesn't seem to apply anymore.
I would make the:
- video track bit more light blue
- audio track more light green
Speed effect failed. Build #54
clip on timeline -> change speed to 200% -> save project -> close and open Kdenliven -> load project -> change speed to 100% -> failed in audio tack.
Individual colors for each clip should be possible (for a 2nd timeline with "pre-selected" clips). Other basis color for video and audio should possible as well (for a 2nd or 3th timeline).
But we can switch off colors as well.
Speed issue fixed, thanks
Here is the current state after the first changes to the code.
Tue, Jan 15
So I started implementing colors in the timeline. I agree that we should ideally use variations of the theme's original colors, in our case mostly breeze dark: https://community.kde.org/KDE_Visual_Design_Group/HIG/BreezeDark
In the current scenario, proxy settings are defined also in Settings -> Configure Kdenlive -> Project Defaults, where values are saved and are provided whenever a new Project is made (truly as the name goes, "Project Defaults"). I believe all default values need to be saved here for a project whereas Project -> Project Settings is meant specifically for a project and are consequently not saved for a new project so IMHO saving settings in "Project Settings" would render "Project Defaults" effectively useless.
Mon, Jan 14
OK, now I got your point :-) I misunderstood that the timeline will only show either one.
Thank you for the tip. That helps a lot.
committed now in git, thanks
So, as I said, in the refactoring branch yo will not have a mixed audio and video clip. Audio and video will be always split.
In the settings, I can hide the thumbnail of the clip, see screenshot
Maybe a new setting "Selected audio only" :-)
Sun, Jan 13
I found a Bug with the "Change Speed" function. If save a project with a clip in the timeline, that uses speed changes and reopen it again the speed change will not be load correct.
First the speed of the clip is changed correct, BUT the label doesn't show the Value (as it did before reopen the file) and if you open the dialog by right clicking and choose "Change Speed" also this value is wrong (100%).
I think the screen cast will make it easier to understand:
(Version 19.03.70 - self build from the refactor_timeline branch)
Sat, Jan 12
I've created a diff that changes the way to reset from middle button to right button: https://phabricator.kde.org/D18214