Setting "Done" stuff to Resolved. (PS: Sorry if this generates email spam..)

Setting "Done" stuff to Resolved. (PS: Sorry if this generates email spam..)

Setting "Done" stuff to Resolved. (PS: Sorry if this generates email spam..)

In D3192#59769, @antlarr wrote:

@hpereiradacosta thanks for reviewing this. Can you cherry-pick the commit for Plasma/5.8?

@hpereiradacosta thanks for reviewing this. Can you cherry-pick the commit for Plasma/5.8?

Thanks !

• Increase width by MenuButton_IndicatorWidth+2 instead of adding a new enum entry

Hi,
I am fine with the commit (especially since it fixes a bug which I have had no time to reproduce)
Now since indeed 2 more pixels are needed on top of the ones from the MenuButton_IndicatorWidth, I would be inclided to just change
size.rwidth() += Metrics::ComboBox_IndicatorWidth into
size.rwidth() += Metrics::MenuButton_IndicatorWidth+2 (with a comment)
rather than adding a new enum in Metrics.
The idea with this enum is that you can in principle change all the values without breaking anything, which is not the case here.
The alternative would be to make the enum be:
ComboBox_IndicatorWidth = MenuButton_IndicatorWidth+2

I will assume this task is done now... or is there more?

Added a secondary suggestion for OSD icons.

On the other hand, we could open in the overlay mode for the single connected display when there's only one screen. When another screen gets attached, we remove the overlay and show the overview with positioning. I haven't made up my mind about that, but maybe it's a viable option down the road, so that's just a first shot.

On the other hand, we could open in the overlay mode for the single connected display when there's only one screen. When another screen gets attached, we remove the overlay and show the overview with positioning. I haven't made up my mind about that, but maybe it's a viable option down the road, so that's just a first shot.

@mart The upside of that would certainly be a clean appearance, but the downside would be that what sebas described as a typical usecase - You only have one screen and want to change its resolution - would then be two clicks instead of one.

Is the design idea to be more simple and straight forward?

I've updated the main mock.
Changes:

• Disabled displays are now in a separate box. Rationale: A disabled screen cannot ever be part of the screen setup anyway
• Rotation is now done via rotate left/right buttons
• Setting Primary display is done via positioning it in a box in the center. Rationale is that in most cases, the primary display will be in the center of the physical setup as well. Of course one can decide to e.g. only put further screens to the right of the primary screen if one does not want the center screen to be the primary one
• Advanced section removed
• Refresh rate setting removed, is now integrated in resolution