KDE PIM: Junior JobsTag
ActivePublic

Recent Activity

Mon, Nov 19

dvratil added a comment to T9420: [KOrganizer] Improve event display.

There's Prefs::createNewColor() in eventviews/src/prefs.cpp, looks like that might be it?

Mon, Nov 19, 11:17 AM · KDE PIM: Junior Jobs, KDE PIM

Thu, Nov 15

ognarb added a comment to T9420: [KOrganizer] Improve event display.

Sory for the delay, I distro hopped from arch to openSuSe and I have some trouble with building from source with openSuSe (libkleo and some other dependencies don't want to build). And I also have trouble finding where the color is generated (the calendar is generated in korganizer:src/akonadicollectionview.cpp, but I have trouble finding when and where the color is set).

Thu, Nov 15, 11:07 PM · KDE PIM: Junior Jobs, KDE PIM

Nov 9 2018

ognarb added a comment to T9420: [KOrganizer] Improve event display.

BTW, here is the official Breeze color palette: https://hig.kde.org/style/color/default.html

Nov 9 2018, 11:51 PM · KDE PIM: Junior Jobs, KDE PIM
ngraham added a comment to T9420: [KOrganizer] Improve event display.

BTW, here is the official Breeze color palette: https://hig.kde.org/style/color/default.html

Nov 9 2018, 11:50 PM · KDE PIM: Junior Jobs, KDE PIM
ognarb added a comment to T9420: [KOrganizer] Improve event display.

Ok I will look into that :)

Nov 9 2018, 11:29 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil added a comment to T9420: [KOrganizer] Improve event display.

@ognarb uh, sorry, I haven't seen the notification about your last comment. Yeah, going for some more pastel color to better fit Plasma/Breeze color theme would be nice. Maybe the entire default color generator could be improved - I honestly don't know much about where the colors come from in KOrganizer :-)

Nov 9 2018, 11:20 PM · KDE PIM: Junior Jobs, KDE PIM

Nov 4 2018

ognarb added a comment to T9420: [KOrganizer] Improve event display.

@dvratil Do you have some other improvement suggestion? I was thinking about changing the default color to a pastel green color (#BAED91) but otherwise I don't know that can be improved anymore.

Nov 4 2018, 4:18 PM · KDE PIM: Junior Jobs, KDE PIM

Nov 3 2018

ognarb added a revision to T9420: [KOrganizer] Improve event display: D16624: Improve contrast in header from agendaitem.
Nov 3 2018, 12:09 AM · KDE PIM: Junior Jobs, KDE PIM

Oct 30 2018

ognarb added a comment to T9428: [Akonadi Console] Alphabetical sorting.

I was looking at this task to learn how akonadi work and akonadiconsole crash directly after choosing a instance. It is a know bug? Should I create a bug report?

Oct 30 2018, 8:04 PM · KDE PIM: Junior Jobs, KDE PIM

Oct 27 2018

dkurz added a member for KDE PIM: Junior Jobs: dkurz.
Oct 27 2018, 5:36 PM

Oct 23 2018

ognarb added a revision to T9420: [KOrganizer] Improve event display: D16393: Add the config to use the system color in Korganizer (see D16377).
Oct 23 2018, 10:50 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil added a comment to T9420: [KOrganizer] Improve event display.

I would say let's treat the HiDPI problem as a standalone issue, the painting code should probably take font metrics into account, instead of hardcoded arbitrary constants :)

Oct 23 2018, 9:16 PM · KDE PIM: Junior Jobs, KDE PIM
ognarb added a comment to T9420: [KOrganizer] Improve event display.

@repinc interesting, but I don't have a HiDPI screen to test. I read in the internet that using QRectF,QPointF instead of QRect and QPoint should improve the situation. So I'm changing most of the occurence of QRect and QPoint. I also found out that the item height is hardcoded in function of MonthCell::topMargin to an height of 18px, but I have not idea how to access the pixel ratio.

Oct 23 2018, 6:48 PM · KDE PIM: Junior Jobs, KDE PIM

Oct 22 2018

repinc added a comment to T9420: [KOrganizer] Improve event display.

@dvratil here is the screenshot

Oct 22 2018, 9:49 PM · KDE PIM: Junior Jobs, KDE PIM
ognarb added a comment to T9420: [KOrganizer] Improve event display.

@dvratil Ok, it's very much VIP but I have some visual D16377

Oct 22 2018, 8:13 PM · KDE PIM: Junior Jobs, KDE PIM
ognarb added a revision to T9420: [KOrganizer] Improve event display: D16377: Using the system palette for drawing the month- and agendaitem..
Oct 22 2018, 8:12 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil added a comment to T9420: [KOrganizer] Improve event display.

@ognarb That sounds like a good idea: you can use it to get information about background and foreground colors and calculate some reasonable color palette from that.

Oct 22 2018, 3:02 PM · KDE PIM: Junior Jobs, KDE PIM
ognarb added a comment to T9420: [KOrganizer] Improve event display.

@dvratil Do you think, it's a good idea to use QStyle for the color. Because for the moment it's difficult to choose a color palette that look good with breeze, breeze dark and some other themes. And then add button to activate this feature, so that someone can also choose the color manually like before.

Oct 22 2018, 2:43 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil added a comment to T9420: [KOrganizer] Improve event display.

@repinc, could you please attach a screenshot?

Oct 22 2018, 8:31 AM · KDE PIM: Junior Jobs, KDE PIM

Oct 21 2018

repinc added a comment to T9420: [KOrganizer] Improve event display.

There is another thing to look into with with month view rendering. It looks like it does not respect the DPI and does not look quite right on HiDPI screens. The bars ae just too narrow and height does not react to larger font size.

Oct 21 2018, 8:36 AM · KDE PIM: Junior Jobs, KDE PIM

Oct 17 2018

ngraham added a comment to T9420: [KOrganizer] Improve event display.

OK, thanks!

Oct 17 2018, 10:38 PM · KDE PIM: Junior Jobs, KDE PIM
ognarb added a comment to T9420: [KOrganizer] Improve event display.

@dvratil I not really good with choosing color. But with some input from the VDG, I can probably change the default color. I will first work on the day/hour lines.

Oct 17 2018, 8:23 AM · KDE PIM: Junior Jobs, KDE PIM
dvratil added a comment to T9420: [KOrganizer] Improve event display.

Flat items and less rounded corners are already in git master (for 18.12). We can wait for the improvements in the color palette to be done first, then blog about the whole task if you want.

Oct 17 2018, 8:13 AM · KDE PIM: Junior Jobs, KDE PIM
ngraham added a comment to T9420: [KOrganizer] Improve event display.

How much of this has already landed? I only blog about things that are actually in.

Oct 17 2018, 1:34 AM · KDE PIM: Junior Jobs, KDE PIM

Oct 16 2018

dvratil updated subscribers of T9420: [KOrganizer] Improve event display.

Month and agenda items in KOrganizer are now flat with less-rounded corners, thanks to @ognarb! The work has landed on master (for 18.12 release)

Oct 16 2018, 1:55 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil updated the task description for T9420: [KOrganizer] Improve event display.
Oct 16 2018, 1:46 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil closed D16013: Rewrite the painting of an month item.
Oct 16 2018, 1:45 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil accepted D16013: Rewrite the painting of an month item.

I think it's perfect now, so from my side, this is good to go. I don't think this kind of change belongs to a bugfix release, so I'll push this to master (for 18.12 release).

Oct 16 2018, 1:43 PM · KDE PIM: Junior Jobs, KDE PIM
ognarb updated the diff for D16013: Rewrite the painting of an month item.

I fixed it :)

Oct 16 2018, 12:01 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil added inline comments to D16013: Rewrite the painting of an month item.
Oct 16 2018, 11:25 AM · KDE PIM: Junior Jobs, KDE PIM
ognarb updated the diff for D16013: Rewrite the painting of an month item.

Small fix

Oct 16 2018, 9:16 AM · KDE PIM: Junior Jobs, KDE PIM
ognarb updated the diff for D16013: Rewrite the painting of an month item.
  • remove border for begin and end of weeks
Oct 16 2018, 9:11 AM · KDE PIM: Junior Jobs, KDE PIM

Oct 15 2018

ognarb added a comment to D16013: Rewrite the painting of an month item.

No worries, hope your exams went well :)

Oct 15 2018, 7:59 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil added a comment to D16013: Rewrite the painting of an month item.

No worries, hope your exams went well :)

Oct 15 2018, 8:35 AM · KDE PIM: Junior Jobs, KDE PIM

Oct 14 2018

ognarb added a comment to D16013: Rewrite the painting of an month item.

Sorry for the late update, I had exams. So I rewrote this differential a little bit and removed some change.

Oct 14 2018, 3:24 PM · KDE PIM: Junior Jobs, KDE PIM
ognarb updated the diff for D16013: Rewrite the painting of an month item.

Fix some code

Oct 14 2018, 3:19 PM · KDE PIM: Junior Jobs, KDE PIM
ognarb updated the diff for D16013: Rewrite the painting of an month item.

Revert some change

Oct 14 2018, 3:11 PM · KDE PIM: Junior Jobs, KDE PIM

Oct 11 2018

dkurz added a comment to T9429: [Akonadi Console] DB Console improvements.

Discoverability trumps ;-)

Oct 11 2018, 2:58 PM · KDE PIM: Junior Jobs, KDE PIM

Oct 9 2018

dkurz added a task to D16013: Rewrite the painting of an month item: T9420: [KOrganizer] Improve event display.
Oct 9 2018, 5:56 PM · KDE PIM: Junior Jobs, KDE PIM
dkurz added a revision to T9420: [KOrganizer] Improve event display: D16013: Rewrite the painting of an month item.
Oct 9 2018, 5:56 PM · KDE PIM: Junior Jobs, KDE PIM
dkurz added a comment to D16013: Rewrite the painting of an month item.

Another thing I just noticed: You use border width 1 unconditionally, when it was 2 unconditionally before.

Oct 9 2018, 5:56 PM · KDE PIM: Junior Jobs, KDE PIM

Oct 8 2018

dvratil added a comment to D16013: Rewrite the painting of an month item.

I think Denis has explained it better than I did - the margin and borders on 21st and 22nd break the effect of the continuous event - that's what I was concerned about.

Oct 8 2018, 9:08 PM · KDE PIM: Junior Jobs, KDE PIM
dkurz added a comment to D16013: Rewrite the painting of an month item.

The margin helps to immediately grasp that the event starts/ends on that day, just like the radius. I think there should be a margin iff there is a radius.

Oct 8 2018, 6:56 PM · KDE PIM: Junior Jobs, KDE PIM
ognarb added a comment to D16013: Rewrite the painting of an month item.

I think it would be easier if we change the meaning and/or name of isBeginItem and isEndItem. So that:

Oct 8 2018, 6:34 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil added a comment to D16013: Rewrite the painting of an month item.

The smaller radius and bigger margin looked better, I'd revert to that.

Oct 8 2018, 6:23 PM · KDE PIM: Junior Jobs, KDE PIM
ognarb added a comment to D16013: Rewrite the painting of an month item.

Thanks. With the small radius, it still feels like it's hard to distinguish between an event that ends on Sunday and an event that continues to next week - could you try removing them in this case, so that the event seemingly goes out of the screen to make it more obvious that it spans multiple days?

Oct 8 2018, 6:07 PM · KDE PIM: Junior Jobs, KDE PIM
ognarb updated the diff for D16013: Rewrite the painting of an month item.

Fix some margin problem

Oct 8 2018, 5:57 PM · KDE PIM: Junior Jobs, KDE PIM
dvratil added a comment to D16013: Rewrite the painting of an month item.

Thanks. With the small radius, it still feels like it's hard to distinguish between an event that ends on Sunday and an event that continues to next week - could you try removing the margin in this case, so that the event seemingly goes out of the screen to make it more obvious that it spans multiple days?

Oct 8 2018, 5:38 PM · KDE PIM: Junior Jobs, KDE PIM
ognarb updated the diff for D16013: Rewrite the painting of an month item.

fix const

Oct 8 2018, 5:36 PM · KDE PIM: Junior Jobs, KDE PIM
ognarb added a comment to D16013: Rewrite the painting of an month item.

There seems to be a regression compared to the previous version when drawing events that span multiple weeks - in the original version the event is not rounded on week end and week start, while on your screenshot it appears the event has round corners on Sunday and Monday. Can you look into it?

Oct 8 2018, 5:32 PM · KDE PIM: Junior Jobs, KDE PIM