I guess with D28162: [calendar] Implement SyncToken for Calendar service and D28560: [resources] Add a unified Google Groupware Resource this is fixed now.

Thanks for the fix. Since this is a bugfix, please land this patch to the Applications/19.08 branch, then merge the branch to master.

Well spotted! Thanks

Regarding point 1, mea culpa 😬

Sounds like there might be a problem with exports or some symbol name duplication that leads to some weird behavior during LTO.

Fixed minor nitpicks

Just minor nitpicks. Fix those and you can commit the patch. Thanks!

Remove debug info from permissions example.

@dvratil I rechecked if Permission was complete and added missing attributes. Also added an example.

Added parameter default values to member initialization.

Thanks for the fix. Could you also modify the constructors so that the class members are initialized using the fooDefault constants as well, so that we really only have a single place in the entire file where the default value is defined?

That sounds like a better way of handling defaults, I'll keep it in mind when touching other Jobs.

Nice, thanks for the patch.

Added missing derived class access-specifier to PermissionDeleteJob.

@barchiesi This commit broke the kio-gdrive build (CanCreateTeamDrives no longer existing).

Nice trick! :)

• Silence Team Drive deprecation warnings for examples and tests.

@dvratil this seems like a possible solution, what do you think?

It's fine to leave it in and ignore the warnings - I think there's some way to disable deprecation warnings internally, but I can't find it now.

In D21838#480527, @barchiesi wrote:

• Deprecate Teamdrive fetch/create/modify/delete jobs.
  
  I added KGAPIDRIVE_DEPRECATED_EXPORT to the create/delete/modify/fetch jobs and afterwards all tests and the teamdrive example show warnings. Is that correct? Or should I delete tests/examples?

Looks good, thanks a lot!

Fixing previous edit mistakes (not sure what happened, still trying to understand arc).

• Added canCreateDrives attribute to About.

Renamed wrong attributes in Drives::Capabilities.

In D20843#468955, @dvratil wrote:

Sorry, I must have overlooked this one :( You should be able to commit it for yourself now (arc land).

Sorry, I must have overlooked this one :( You should be able to commit it for yourself now (arc land).

Changed (wrong) commit email address.

All changes have been covered by other differentials, this can be abandoned.