BalooProject
ActivePublic

Recent Activity

Today

meven requested review of D22529: Do not display a buggy filesize for non local files.
Thu, Jul 18, 11:35 AM · Baloo

Yesterday

poboiko added a comment to D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders.

The correct fix is to check the returned/calculated ID in the IndexCleaner, otherwise its racy.

Wed, Jul 17, 5:53 PM · Baloo, Frameworks
bruns requested changes to D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders.
Wed, Jul 17, 2:49 PM · Baloo, Frameworks
bruns added a comment to D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders.

The correct fix is to check the returned/calculated ID in the IndexCleaner, otherwise its racy.

Wed, Jul 17, 2:49 PM · Baloo, Frameworks
poboiko requested review of D22502: [FileIndexerConfig] skip invalid entries from included/excludedFolders.
Wed, Jul 17, 9:18 AM · Baloo, Frameworks

Tue, Jul 16

ngraham added a comment to D21672: [PowerStateMonitor] Be conservative when determining power state.

Let's not argue but investigate and fix why this seemingly innocent patch caused the behavior described.

Tue, Jul 16, 5:46 PM · Baloo, Frameworks
romangg added a comment to D21672: [PowerStateMonitor] Be conservative when determining power state.

The bug report was online for two weeks and it was categorized as Baloo bug. You had more than enough time to notice it.

Tue, Jul 16, 11:38 AM · Baloo, Frameworks
bruns added a comment to D21672: [PowerStateMonitor] Be conservative when determining power state.

Why don't you notify the relevant people first

He kinda did by writing a bug report, but let's not argue but investigate and fix why this seemingly innocent patch caused the behavior described.

Tue, Jul 16, 10:22 AM · Baloo, Frameworks
broulik added a comment to D21672: [PowerStateMonitor] Be conservative when determining power state.

Why don't you notify the relevant people first

Tue, Jul 16, 10:18 AM · Baloo, Frameworks
bruns added a comment to D21672: [PowerStateMonitor] Be conservative when determining power state.

Reverted by d6d86cb86c on master. See https://bugs.kde.org/show_bug.cgi?id=409405 for more info. Possibly a critical problem in released 5.60 @bruns.

Tue, Jul 16, 10:15 AM · Baloo, Frameworks
romangg added a comment to D21672: [PowerStateMonitor] Be conservative when determining power state.

Reverted by d6d86cb86c on master. See https://bugs.kde.org/show_bug.cgi?id=409405 for more info. Possibly a critical problem in released 5.60 @bruns.

Tue, Jul 16, 9:40 AM · Baloo, Frameworks

Sun, Jul 14

poboiko added a comment to D21427: Always skip trailing slashes in FilderedDirIterator.

Ping!

Apparently, it does fix bug 409257, which is pretty serious one (db corruption, after all).

The DB corruption is already fixed in KF5.60.

Sun, Jul 14, 3:43 PM · Baloo, Frameworks
astippich abandoned D17302: Add test for adding properties to result.
Sun, Jul 14, 2:15 PM · Baloo, Frameworks

Sat, Jul 13

astippich added a comment to D17500: Get mobipocket extractor up-to-date, but keep disabled.

since this code is not compiled, I will merge it next week if noone objects

Sat, Jul 13, 11:08 AM · Baloo, Frameworks
astippich updated the diff for D17500: Get mobipocket extractor up-to-date, but keep disabled.
  • rebase
Sat, Jul 13, 11:07 AM · Baloo, Frameworks

Thu, Jul 11

bruns added a comment to D21427: Always skip trailing slashes in FilderedDirIterator.

Ping!

Apparently, it does fix bug 409257, which is pretty serious one (db corruption, after all).

Thu, Jul 11, 12:48 PM · Baloo, Frameworks
poboiko requested review of D22392: [balooctl/baloo_file_extractor] Consolidate code that performs actual indexing.
Thu, Jul 11, 8:07 AM · Baloo, Frameworks
poboiko added a comment to D21427: Always skip trailing slashes in FilderedDirIterator.

Apparently, it does fix bug 409257, which is pretty serious one (db corruption, after all).

Thu, Jul 11, 7:05 AM · Baloo, Frameworks
poboiko updated the summary of D21427: Always skip trailing slashes in FilderedDirIterator.
Thu, Jul 11, 7:04 AM · Baloo, Frameworks

Tue, Jul 9

ngraham added a comment to D18890: Add button to reset index database and repair Baloo crashing.

I'd like to revisit this. Can we get back to it and fix the outstanding issues?

Tue, Jul 9, 8:55 PM · Baloo, Plasma

Sun, Jul 7

astippich closed D22192: remove foreach.
Sun, Jul 7, 5:41 PM · Baloo
bruns accepted D22192: remove foreach.
Sun, Jul 7, 4:56 PM · Baloo
astippich updated the diff for D22192: remove foreach.
  • remove extra space
Sun, Jul 7, 4:48 PM · Baloo
bruns added inline comments to D22192: remove foreach.
Sun, Jul 7, 4:22 PM · Baloo
astippich updated the diff for D22192: remove foreach.
  • code style
Sun, Jul 7, 2:15 PM · Baloo

Fri, Jul 5

astippich closed D20526: Fix extracting of some properties to match what was written.
Fri, Jul 5, 8:08 PM · Baloo, Frameworks
bruns added inline comments to D22192: remove foreach.
Fri, Jul 5, 8:08 PM · Baloo
astippich added a comment to D20526: Fix extracting of some properties to match what was written.

thanks

Fri, Jul 5, 8:08 PM · Baloo, Frameworks
bruns accepted D20526: Fix extracting of some properties to match what was written.
Fri, Jul 5, 7:56 PM · Baloo, Frameworks

Thu, Jul 4

kossebau resigned from D15503: Show photo orientation as icon.

No maintainer here, also no opinion :) Thus resigning to not keep wrong hopes for feedback from me.

Thu, Jul 4, 2:04 PM · Baloo
astippich added a comment to D20526: Fix extracting of some properties to match what was written.

friendly ping, I would like to get this into 5.60

Thu, Jul 4, 9:48 AM · Baloo, Frameworks

Mon, Jul 1

astippich requested review of D22192: remove foreach.
Mon, Jul 1, 4:31 PM · Baloo
astippich closed D22159: Check for DQT_NO_CAST_FROM_BYTEARRAY.
Mon, Jul 1, 4:24 PM · Baloo

Sun, Jun 30

bruns accepted D22159: Check for DQT_NO_CAST_FROM_BYTEARRAY.
Sun, Jun 30, 7:27 PM · Baloo
astippich updated the summary of D22159: Check for DQT_NO_CAST_FROM_BYTEARRAY.
Sun, Jun 30, 6:01 PM · Baloo
astippich added inline comments to D22159: Check for DQT_NO_CAST_FROM_BYTEARRAY.
Sun, Jun 30, 6:00 PM · Baloo
astippich updated the diff for D22159: Check for DQT_NO_CAST_FROM_BYTEARRAY.
  • bring back openly coded counting
Sun, Jun 30, 5:59 PM · Baloo
poboiko added a comment to D22166: [AdvancedQueryParser] Introduce support for phrase queries.

Note that it somewhat duplicates work done inside QueryParser. Which is almost not used anywhere - most of the parsing is done by AdvancedQueryParser.

Sun, Jun 30, 3:43 PM · Baloo, Frameworks
poboiko requested review of D22166: [AdvancedQueryParser] Introduce support for phrase queries.
Sun, Jun 30, 3:38 PM · Baloo, Frameworks
poboiko updated the summary of D21427: Always skip trailing slashes in FilderedDirIterator.
Sun, Jun 30, 12:09 PM · Baloo, Frameworks
poboiko added a reviewer for D21427: Always skip trailing slashes in FilderedDirIterator: ngraham.

Not entirely sure, but bug 409257 might be caused by that (at least in my case, it looked the same).

Sun, Jun 30, 12:08 PM · Baloo, Frameworks
bruns added inline comments to D22159: Check for DQT_NO_CAST_FROM_BYTEARRAY.
Sun, Jun 30, 10:57 AM · Baloo
astippich added inline comments to D22159: Check for DQT_NO_CAST_FROM_BYTEARRAY.
Sun, Jun 30, 7:11 AM · Baloo
astippich requested review of D22159: Check for DQT_NO_CAST_FROM_BYTEARRAY.
Sun, Jun 30, 7:10 AM · Baloo
astippich closed D22157: Use debugging category in taglib extractor/writer.
Sun, Jun 30, 6:45 AM · Baloo, Frameworks

Sat, Jun 29

astippich closed D22096: Check for DQT_NO_CAST_FROM_ASCII.
Sat, Jun 29, 7:09 PM · Baloo
bruns accepted D22157: Use debugging category in taglib extractor/writer.
Sat, Jun 29, 6:40 PM · Baloo, Frameworks
astippich updated the diff for D22157: Use debugging category in taglib extractor/writer.
  • adjust writer cmake
Sat, Jun 29, 6:30 PM · Baloo, Frameworks
astippich updated the diff for D22157: Use debugging category in taglib extractor/writer.
  • use separate debug src
Sat, Jun 29, 6:29 PM · Baloo, Frameworks
astippich added inline comments to D20526: Fix extracting of some properties to match what was written.
Sat, Jun 29, 6:27 PM · Baloo, Frameworks