FalkonProject
ActivePublic

Recent Activity

Jun 3 2020

shubham abandoned D19008: Add context menu entry to copy link text.
Jun 3 2020, 8:28 AM · Falkon

May 25 2020

alva abandoned D29719: Fix white flashes in new tabs.

Will submit an improved version on GitLab instead.

May 25 2020, 8:01 PM · Falkon

May 16 2020

drosca added a comment to D29007: Make wheel-event fixup version dependent.

I for some reason can't land this change. It says "hook declined". Feel free to land it for me.

May 16 2020, 12:23 PM · Falkon

May 13 2020

alva requested review of D29719: Fix white flashes in new tabs.
May 13 2020, 3:58 PM · Falkon

May 5 2020

carewolf added a comment to D29007: Make wheel-event fixup version dependent.

I for some reason can't land this change. It says "hook declined". Feel free to land it for me.

May 5 2020, 11:28 AM · Falkon

Apr 29 2020

puneethchanda updated subscribers of D26869: Fix Crash when "remember password" is clicked..

@drosca can you check this once.

Apr 29 2020, 12:45 PM · Falkon

Apr 20 2020

drosca accepted D29007: Make wheel-event fixup version dependent.
Apr 20 2020, 9:58 AM · Falkon
carewolf added a reviewer for D29007: Make wheel-event fixup version dependent: drosca.
Apr 20 2020, 9:58 AM · Falkon
carewolf requested review of D29007: Make wheel-event fixup version dependent.
Apr 20 2020, 9:57 AM · Falkon

Apr 11 2020

puneethchanda updated the diff for D28661: Enable user to add keywords when saving bookmarks.

keyword gets updated in the bookmark widget and organize bookmarks.

Apr 11 2020, 9:26 PM · Falkon
dfaure added a comment to D28550: Optimize Firefox bookmark import query and fix to include folders.

No idea, I'm not a Falkon developer.

Apr 11 2020, 8:39 AM · Falkon

Apr 9 2020

puneethchanda added a comment to D28661: Enable user to add keywords when saving bookmarks.

The other thing is:
This popup window can recognize if the site is already bookmarked or not.
In case it is already bookmarked it would be good to display keywords in keyword field.

Apr 9 2020, 5:45 PM · Falkon
puneethchanda updated the diff for D28661: Enable user to add keywords when saving bookmarks.

fix the size of bookmark widget.

Apr 9 2020, 5:44 PM · Falkon
SGOrava added a comment to D28661: Enable user to add keywords when saving bookmarks.

The other thing is:
This popup window can recognize if the site is already bookmarked or not.
In case it is already bookmarked it would be good to display keywords in keyword field.

Apr 9 2020, 5:41 PM · Falkon
puneethchanda updated the diff for D28661: Enable user to add keywords when saving bookmarks.

Update Placeholder

Apr 9 2020, 5:16 PM · Falkon
abogical updated the diff for D28550: Optimize Firefox bookmark import query and fix to include folders.

Improve query filter

Apr 9 2020, 3:07 AM · Falkon

Apr 7 2020

abogical updated subscribers of D28550: Optimize Firefox bookmark import query and fix to include folders.

@drosca @dfaure @SGOrava
Do I need to add subscribers other than falkon? I have 3 other differentials that needs review but no response is made for some time, unless I mention by name.

Apr 7 2020, 9:50 PM · Falkon
SGOrava added inline comments to D28661: Enable user to add keywords when saving bookmarks.
Apr 7 2020, 6:25 PM · Falkon
puneethchanda requested review of D28661: Enable user to add keywords when saving bookmarks.
Apr 7 2020, 4:32 PM · Falkon
puneethchanda added a watcher for Falkon: puneethchanda.
Apr 7 2020, 10:35 AM

Apr 4 2020

abogical updated the diff for D28550: Optimize Firefox bookmark import query and fix to include folders.

Comment grammar correction

Apr 4 2020, 6:18 AM · Falkon
abogical updated the test plan for D28550: Optimize Firefox bookmark import query and fix to include folders.
Apr 4 2020, 6:16 AM · Falkon
abogical requested review of D28550: Optimize Firefox bookmark import query and fix to include folders.
Apr 4 2020, 6:15 AM · Falkon
abogical requested review of D28549: Describe error when querying Firefox places.sqlite for bookmarks.
Apr 4 2020, 3:07 AM · Falkon

Mar 30 2020

allknow updated the diff for D28240: special character shown in warning dialog.
  • I fixed "if"
Mar 30 2020, 11:22 PM · Falkon
jachin added inline comments to D28240: special character shown in warning dialog.
Mar 30 2020, 10:48 PM · Falkon
abogical added inline comments to D28240: special character shown in warning dialog.
Mar 30 2020, 7:46 PM · Falkon

Mar 28 2020

abogical updated the diff for D27655: Open all URLs in command line arguments.

Done requested change

Mar 28 2020, 4:45 PM · Falkon
dfaure added inline comments to D27655: Open all URLs in command line arguments.
Mar 28 2020, 10:13 AM · Falkon

Mar 25 2020

abogical added inline comments to D27655: Open all URLs in command line arguments.
Mar 25 2020, 1:27 PM · Falkon
abogical updated the diff for D27655: Open all URLs in command line arguments.

Use qAsConst

Mar 25 2020, 1:23 PM · Falkon
allknow updated the diff for D28240: special character shown in warning dialog.

Okay I fixed. thank you

Mar 25 2020, 1:16 PM · Falkon
drosca requested changes to D27655: Open all URLs in command line arguments.
Mar 25 2020, 6:20 AM · Falkon
drosca requested changes to D28198: QFile is open but not closed.

QFile is closed in the destructor, this is not needed.

Mar 25 2020, 6:19 AM · Falkon
drosca requested changes to D28240: special character shown in warning dialog.

It should be <br/> instead.

Mar 25 2020, 6:18 AM · Falkon

Mar 24 2020

jachin accepted D28240: special character shown in warning dialog.

https://forum.qt.io/topic/66191/new-line-n-doesn-t-work
As like this article, maybe dialog.setText(tr("...")) messages are translated in C type character type.
'\r\n' also would be works.
And checked with build source.

Mar 24 2020, 10:19 PM · Falkon
allknow updated subscribers of D28240: special character shown in warning dialog.
Mar 24 2020, 10:08 PM · Falkon
allknow added a comment to D28240: special character shown in warning dialog.

Mar 24 2020, 2:25 PM · Falkon
allknow requested review of D28240: special character shown in warning dialog.
Mar 24 2020, 2:23 PM · Falkon

Mar 22 2020

abogical updated the diff for D27655: Open all URLs in command line arguments.

Used range loop as requested.

Mar 22 2020, 9:40 PM · Falkon
dfaure added inline comments to D27655: Open all URLs in command line arguments.
Mar 22 2020, 7:51 PM · Falkon
abogical updated the diff for D27655: Open all URLs in command line arguments.

Using QString reference as requested.

Mar 22 2020, 6:33 PM · Falkon
abogical added inline comments to D27655: Open all URLs in command line arguments.
Mar 22 2020, 6:07 PM · Falkon
dfaure added inline comments to D27655: Open all URLs in command line arguments.
Mar 22 2020, 1:31 PM · Falkon
allknow added a comment to D28198: QFile is open but not closed.

Sorry ... It's my mistake .. I'll study hard more..

Mar 22 2020, 11:33 AM · Falkon
SGOrava added a comment to D28198: QFile is open but not closed.

According to documentation it should be closed by Qt.
https://doc.qt.io/qt-5/qfile.html#dtor.QFile

Mar 22 2020, 11:30 AM · Falkon
davidre added a comment to D28198: QFile is open but not closed.

The destructor of QFile will close it, doesn't it?

Mar 22 2020, 11:25 AM · Falkon
allknow updated the summary of D28198: QFile is open but not closed.
Mar 22 2020, 11:22 AM · Falkon
allknow requested review of D28198: QFile is open but not closed.
Mar 22 2020, 11:21 AM · Falkon

Mar 21 2020

malibushko updated the diff for D28153: BUG 414295.

I tested it a little bit, and found out that the problem was not caused by 'name' attribute, but by 'key' - it is empty if an appropriate attribute is not present.
Now to check enter to https://my.amfoss.in/login (enter somethink and click save) and see there is not input
Then you can check it at any site (I choosed phabricator) - it should be autocompleted automatically

Mar 21 2020, 5:17 PM · Falkon