Calligra: 3.0Project
ActivePublic

Recent Activity

Mon, Jan 13

rjvbb added a comment to D26050: Fix build with poppler 82.
I am a firm +1 on splitting Calligra
Mon, Jan 13, 3:28 PM · Calligra: 3.0
awilcox added a comment to D26050: Fix build with poppler 82.

See Poppler's site for what distros/OSes have which versions. I think dropping pre-62 may be safe. Definitely not 72.

Mon, Jan 13, 11:46 AM · Calligra: 3.0

Thu, Jan 9

mphilippov added a comment to D25423: Fill table cells with color for ODS and XLSX files.

Do you mean this "if ()" part of code? If there is no style "graphic" and inner "if" will not execute. Do you mean it'll be better to handle it in this part of code...or what?

The main question was how should the three attributes play together. But another question: why isn't setBackgroundColor enough for the background color?

Thu, Jan 9, 8:52 AM · Calligra: 3.0

Tue, Jan 7

pvuorela added a comment to D25423: Fill table cells with color for ODS and XLSX files.

Do you mean this "if ()" part of code? If there is no style "graphic" and inner "if" will not execute. Do you mean it'll be better to handle it in this part of code...or what?

Tue, Jan 7, 11:07 AM · Calligra: 3.0
mphilippov added a comment to D25423: Fill table cells with color for ODS and XLSX files.

loadTableCellProperties() is a method for applying styles for table cells, i.e. cell background. There is no handling for cell background in the place you mentioned.

I'm talking about handling in that particular method. It will already set background brush in that method later. Why is that not enough?

Tue, Jan 7, 9:59 AM · Calligra: 3.0
pvuorela added a comment to D25423: Fill table cells with color for ODS and XLSX files.

loadTableCellProperties() is a method for applying styles for table cells, i.e. cell background. There is no handling for cell background in the place you mentioned.

Tue, Jan 7, 9:38 AM · Calligra: 3.0
mphilippov added a comment to D25423: Fill table cells with color for ODS and XLSX files.

Not sure about all the details but two things look suspicious here:

  1. Above this there's handling for transparent and now the handling isn't symmetric for background brush.
  2. There's some handling on the file for KoXmlNs::draw / style-name & KoXmlNs::calligra / fill-style-name which do background brush setting. What's the relation between these three?
Tue, Jan 7, 7:19 AM · Calligra: 3.0

Fri, Jan 3

pvuorela added a comment to D25422: Handle custom-shapes to display text in ODP files.

Don't know this shape stuff that well, but text shape plugin handling custom-shape feels suspicious.

Fri, Jan 3, 2:12 PM · Calligra: 3.0
pvuorela added a comment to D25423: Fill table cells with color for ODS and XLSX files.

Not sure about all the details but two things look suspicious here:

Fri, Jan 3, 1:16 PM · Calligra: 3.0
pvuorela added a comment to D24852: Remove list style from headings.

Actually seems to now revert that one line as it was before commit fc7b878f206fb / https://bugs.kde.org/show_bug.cgi?id=306141

Fri, Jan 3, 1:10 PM · Calligra: 3.0

Tue, Dec 31

pvuorela closed D25715: Use RTF default color as default Qt format.
Tue, Dec 31, 2:13 PM · Calligra: 3.0
davidllewellynjones accepted D25715: Use RTF default color as default Qt format.

This looks good to me, and certainly gave better results for me using files with the 'auto' colour.

Tue, Dec 31, 1:55 PM · Calligra: 3.0
pvuorela added inline comments to D25715: Use RTF default color as default Qt format.
Tue, Dec 31, 1:28 PM · Calligra: 3.0
pvuorela added inline comments to D25715: Use RTF default color as default Qt format.
Tue, Dec 31, 1:22 PM · Calligra: 3.0
pvuorela closed D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls..
Tue, Dec 31, 1:14 PM · Calligra: 3.0
davidllewellynjones added inline comments to D25715: Use RTF default color as default Qt format.
Tue, Dec 31, 12:55 PM · Calligra: 3.0
mphilippov requested review of D26328: Calculate and display proper number for headings started with lower level for DOC, DOCX and ODT..
Tue, Dec 31, 12:34 PM · Calligra: 3.0
denexter added inline comments to D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls..
Tue, Dec 31, 11:17 AM · Calligra: 3.0
denexter updated the diff for D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls..
Tue, Dec 31, 11:15 AM · Calligra: 3.0
pvuorela accepted D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls..

Seems to work and big impact indeed. Approving already.

Tue, Dec 31, 10:25 AM · Calligra: 3.0

Mon, Dec 30

pvuorela added inline comments to D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls..
Mon, Dec 30, 3:13 PM · Calligra: 3.0

Sat, Dec 28

dcaliste added a comment to D26050: Fix build with poppler 82.

I like the idea of trying to move away from the monolythic release. Not that my opinion matters much, but I'm willing to help in the endeavor. I'll try to participate in tasks in that direction as much as my free time will allow it.

Sat, Dec 28, 8:25 PM · Calligra: 3.0

Fri, Dec 27

ognarb updated the diff for D26221: Use QQC2 Dialog.
  • Center the loading animation
Fri, Dec 27, 10:39 AM · Calligra: 3.0

Thu, Dec 26

ognarb added a comment to D26050: Fix build with poppler 82.

Maybe we can drop 62, but not 72.

If this is for master I don't see why we could keep anything pre-0.79. Distros already have to patch the hell out of 3.1.0 which has led to diverging code because several changes are conflicting. That one needs a point release to settle that.

And meanwhile master needs a fix for 0.83 too.

What about releasing Calligra as a part of the Release Service (a release every 4 months with some Bugfix release between)? The latest release was almost 2 years ago, and we have more than 500 commits in master.

To go with this, i'm starting to think that it would perhaps not be the worst thing to have Calligra's engine explicitly split out, to allow it to be released as a proper Framework, and the applications to be applications based on that framework... It would seem like something that'd be worth trying to aim for for KF6, because while Calligra might have slowed down, that particular reason for Calligra's existence is still a thing, and the monolithic nature of the current layout of the codebase does not allow people to use it in the way it is intended. So... yup, going to have to spend some time considering this and making a formal proposal, but thought i would mention it here and get the idea out in the open.

Thu, Dec 26, 7:25 PM · Calligra: 3.0
anthonyfieroni added a comment to D26050: Fix build with poppler 82.

I'm pretty sure Krita devs think about when they split application out of Calligra repo and make its own copy of libs, flakes, etc. So beneficial of splitting libs in their own release plan will be for all applications. That will a huge work pretty underrated by all users.

Thu, Dec 26, 3:38 PM · Calligra: 3.0
leinir added a comment to D26050: Fix build with poppler 82.

Maybe we can drop 62, but not 72.

If this is for master I don't see why we could keep anything pre-0.79. Distros already have to patch the hell out of 3.1.0 which has led to diverging code because several changes are conflicting. That one needs a point release to settle that.

And meanwhile master needs a fix for 0.83 too.

What about releasing Calligra as a part of the Release Service (a release every 4 months with some Bugfix release between)? The latest release was almost 2 years ago, and we have more than 500 commits in master.

Thu, Dec 26, 2:28 PM · Calligra: 3.0
leinir added a comment to D26221: Use QQC2 Dialog.

That's looking pretty good, really :) Also code reduction is certainly good ;)

Thu, Dec 26, 2:22 PM · Calligra: 3.0

Dec 25 2019

asturmlechner added a comment to D26050: Fix build with poppler 82.

Maybe we can drop 62, but not 72.

If this is for master I don't see why we could keep anything pre-0.79. Distros already have to patch the hell out of 3.1.0 which has led to diverging code because several changes are conflicting. That one needs a point release to settle that.

And meanwhile master needs a fix for 0.83 too.

What about releasing Calligra as a part of the Release Service (a release every 4 months with some Bugfix release between)? The latest release was almost 2 years ago, and we have more than 500 commits in master.

Dec 25 2019, 11:38 PM · Calligra: 3.0
ognarb added a comment to D26050: Fix build with poppler 82.

Maybe we can drop 62, but not 72.

If this is for master I don't see why we could keep anything pre-0.79. Distros already have to patch the hell out of 3.1.0 which has led to diverging code because several changes are conflicting. That one needs a point release to settle that.

And meanwhile master needs a fix for 0.83 too.

Dec 25 2019, 11:15 PM · Calligra: 3.0
asturmlechner added a comment to D26050: Fix build with poppler 82.

Maybe we can drop 62, but not 72.

Dec 25 2019, 9:55 PM · Calligra: 3.0
ognarb updated the test plan for D26221: Use QQC2 Dialog.
Dec 25 2019, 5:18 PM · Calligra: 3.0
ognarb updated the diff for D26221: Use QQC2 Dialog.

Update look

Dec 25 2019, 5:18 PM · Calligra: 3.0
ognarb added reviewers for D26221: Use QQC2 Dialog: Calligra: 3.0, leinir.
Dec 25 2019, 4:33 PM · Calligra: 3.0
ognarb requested review of D26221: Use QQC2 Dialog.
Dec 25 2019, 4:32 PM · Calligra: 3.0
ognarb added a comment to D26050: Fix build with poppler 82.

Doesn't compile for me with Poppler 81. So I created a small patch on top of your patch

Dec 25 2019, 2:36 PM · Calligra: 3.0

Dec 16 2019

anthonyfieroni added a comment to D26050: Fix build with poppler 82.

Maybe we can drop 62, but not 72.

Dec 16 2019, 4:19 PM · Calligra: 3.0
tcanabrava added a reviewer for D26050: Fix build with poppler 82: Calligra: 3.0.
Dec 16 2019, 4:08 PM · Calligra: 3.0
tcanabrava requested review of D26050: Fix build with poppler 82.
Dec 16 2019, 4:08 PM · Calligra: 3.0
guoyunhe closed D7946: CSV characters should not be translated.
Dec 16 2019, 8:28 AM · Calligra: 3.0

Dec 10 2019

pvuorela added a reviewer for D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls.: leinir.
Dec 10 2019, 8:01 AM · Calligra: 3.0

Dec 7 2019

ognarb added a member for Calligra: 3.0: ognarb.
Dec 7 2019, 2:50 PM

Dec 6 2019

denexter requested review of D25779: Ad a readOnly property to the QtQuick2 Document type which disables the loading of editor UI controls..
Dec 6 2019, 3:29 AM · Calligra: 3.0

Dec 4 2019

ognarb retitled D25714: [WIP]: Port away from deprecated KHtml from Port away from deprecated KHtml to [WIP]: Port away from deprecated KHtml.
Dec 4 2019, 2:05 PM · Calligra: 3.0
leinir added a comment to D25714: [WIP]: Port away from deprecated KHtml.

Just a quick tip, when posting things that are a work in progress as a diff (which, incidentally, is a great idea, both in general, and this!), adding "[WIP]" to the beginning of the diff's title is very handy, both for your own tracking, and for those going through the review lists :) (also just realised who you are, so i'm thinking you proooobably already know that ;) )

Dec 4 2019, 1:57 PM · Calligra: 3.0

Dec 3 2019

dcaliste added a comment to D25715: Use RTF default color as default Qt format.

@pvuorela as you prefer, anyway, it's a question of taste, I find it myself easier to follow if the information is on one variable only. But your solution is good also, the file is small and is kept small so easy to follow.

Dec 3 2019, 7:06 PM · Calligra: 3.0
pvuorela added inline comments to D25715: Use RTF default color as default Qt format.
Dec 3 2019, 4:26 PM · Calligra: 3.0
dcaliste added a comment to D25715: Use RTF default color as default Qt format.

Just a suggestion to avoid adding a variable which meaning may be redundant with the state of an already existing one. Otherwise LGTM.

Dec 3 2019, 4:00 PM · Calligra: 3.0
pvuorela added reviewers for D25715: Use RTF default color as default Qt format: davidllewellynjones, dcaliste.
Dec 3 2019, 3:10 PM · Calligra: 3.0
pvuorela requested review of D25715: Use RTF default color as default Qt format.
Dec 3 2019, 3:06 PM · Calligra: 3.0
ognarb added a reviewer for D25714: [WIP]: Port away from deprecated KHtml: Calligra: 3.0.
Dec 3 2019, 2:00 PM · Calligra: 3.0