Mon, Jan 13
I am a firm +1 on splitting Calligra
See Poppler's site for what distros/OSes have which versions. I think dropping pre-62 may be safe. Definitely not 72.
Thu, Jan 9
Tue, Jan 7
Do you mean this "if ()" part of code? If there is no style "graphic" and inner "if" will not execute. Do you mean it'll be better to handle it in this part of code...or what?
loadTableCellProperties() is a method for applying styles for table cells, i.e. cell background. There is no handling for cell background in the place you mentioned.
Fri, Jan 3
Don't know this shape stuff that well, but text shape plugin handling custom-shape feels suspicious.
Not sure about all the details but two things look suspicious here:
Tue, Dec 31
This looks good to me, and certainly gave better results for me using files with the 'auto' colour.
Seems to work and big impact indeed. Approving already.
Mon, Dec 30
Sat, Dec 28
I like the idea of trying to move away from the monolythic release. Not that my opinion matters much, but I'm willing to help in the endeavor. I'll try to participate in tasks in that direction as much as my free time will allow it.
Fri, Dec 27
- Center the loading animation
Thu, Dec 26
I'm pretty sure Krita devs think about when they split application out of Calligra repo and make its own copy of libs, flakes, etc. So beneficial of splitting libs in their own release plan will be for all applications. That will a huge work pretty underrated by all users.
That's looking pretty good, really :) Also code reduction is certainly good ;)
Dec 25 2019
Doesn't compile for me with Poppler 81. So I created a small patch on top of your patch
Dec 16 2019
Maybe we can drop 62, but not 72.
Dec 10 2019
Dec 7 2019
Dec 6 2019
Dec 4 2019
Just a quick tip, when posting things that are a work in progress as a diff (which, incidentally, is a great idea, both in general, and this!), adding "[WIP]" to the beginning of the diff's title is very handy, both for your own tracking, and for those going through the review lists :) (also just realised who you are, so i'm thinking you proooobably already know that ;) )
Dec 3 2019
@pvuorela as you prefer, anyway, it's a question of taste, I find it myself easier to follow if the information is on one variable only. But your solution is good also, the file is small and is kept small so easy to follow.
Just a suggestion to avoid adding a variable which meaning may be redundant with the state of an already existing one. Otherwise LGTM.