btw For such small fixes we don't usually require review
Thu, Jun 20
I saw filters does not compile when it compile only Karbon, i should correct that, but i have much time now.
Jun 10 2019
Jun 7 2019
Jun 6 2019
Now we have insert page, but we don't exports them :) If you think that's ok for now go for it.
Add dependence on LIB_KOPAGEAPP
Jun 5 2019
I have been pondering why we disagreed so much on the background color, and I *think* I have an answer.
My take is it's because we have not been talking about quite the same thing:
I have looked at karbon as an *odg* editor, since it uses odg as its native file format.
Since odg is wysiwyg nothing outside the doc should in any way affect the way it is presented, hence a background that is not saved to file doesn't make sence.
Apparently it has a problem, when we compile only Karbon, as i done now, KoPAView is in pageapp, which is not compile-able in Karbon, right?
Full cmake command
cmake .. -DCMAKE_INSTALL_PREFIX=/usr -DCMAKE_INSTALL_LIBDIR=lib -DKDE_INSTALL_PLUGINDIR=/usr/lib/qt5/plugins -DKDE_INSTALL_USE_QT_SYS_PATHS=ON -DBUILD_TESTING=FALSE -DPACKAGERS_BUILD=true -DBUILD_UNMAINTAINED=TRUE -DPRODUCTSET=APP_KARBON
Jun 4 2019
code wise looks good
Someone test it, code wise looks good, i plan to test it soon.
In flavor of D20400
In flavor of D20400
Jun 3 2019
First of all, thanks for the work. Some things are passing through my mind, especially regarding classical Hangul and half-completed Hangul characters.
Apr 26 2019
Second ping for this.
Apr 9 2019
(Sorry for the inconvinience, I've never been very friendly with arc/phab)
Ooops, this didn't work as expected. This should have been a revision of D19327.
There is only small changes:
- Updated commit message.
- In karbon/ui/KarbonFactory.cpp: Loading of the calligra/pageapp tools.
- In karbon/data/karbon.rc: Removal of the "format" menu (not used) and adding the "format_pagelayout" action to "settings" menu (where it was originally).
Apr 4 2019
Ping, how about this one? The behavior change, or lack of it, should be mostly visible around qgraphicswidget_p.h -> attributeToBitIndex() & setAttribute().
Mar 27 2019
If memory serves, we'll need to do a fair bit of work to get the DropBox code to work properly again. DropBox has turned off the V1 API support, and we'll need to work against the V2 stuff now, which... Well, it might be trivial, but i have no time to look at it, i'm afraid. Be really good to get it back, though.
Mar 26 2019
Mar 25 2019
Yes, looks sane, I'll deal with it.
I think this should be ok
Mar 22 2019
Ping this looks sane, anyone ?
Mar 21 2019
Mar 20 2019
Yes, sorry, as you say better done separatly.
The directory README also states "Temporary local copy of Brad Hards' rtf-qt library.", though as upstream hasn't had changes since 2011, it seems like a permanent one by now.