Calligra: 3.0Project
ActivePublic

Recent Activity

Fri, Apr 26

pvuorela added a comment to D19759: Remove unsupported attributes from QGraphicsWidgets.

Second ping for this.

Fri, Apr 26, 3:01 PM · Calligra: 3.0

Apr 9 2019

rjvbb added a comment to D20400: Karbon: Enable multi page capability.
(Sorry for the inconvinience, I've never been very friendly with arc/phab)
Apr 9 2019, 8:31 AM · Calligra: 3.0
danders added a comment to D20400: Karbon: Enable multi page capability.

Ooops, this didn't work as expected. This should have been a revision of D19327.
There is only small changes:

  1. Updated commit message.
  2. In karbon/ui/KarbonFactory.cpp: Loading of the calligra/pageapp tools.
  3. In karbon/data/karbon.rc: Removal of the "format" menu (not used) and adding the "format_pagelayout" action to "settings" menu (where it was originally).
Apr 9 2019, 7:05 AM · Calligra: 3.0
danders requested review of D20400: Karbon: Enable multi page capability.
Apr 9 2019, 6:40 AM · Calligra: 3.0

Apr 4 2019

pvuorela closed D19943: Small cleanups for qml components.
Apr 4 2019, 9:48 AM · Calligra: 3.0
pvuorela closed D19944: Migrate away from deprecated interfaces in gemini dropbox parts.
Apr 4 2019, 9:48 AM · Calligra: 3.0
pvuorela added a comment to D19759: Remove unsupported attributes from QGraphicsWidgets.

Ping, how about this one? The behavior change, or lack of it, should be mostly visible around qgraphicswidget_p.h -> attributeToBitIndex() & setAttribute().

Apr 4 2019, 9:18 AM · Calligra: 3.0

Mar 27 2019

leinir accepted D19943: Small cleanups for qml components.
Mar 27 2019, 1:28 PM · Calligra: 3.0
pvuorela added inline comments to D19943: Small cleanups for qml components.
Mar 27 2019, 1:23 PM · Calligra: 3.0
leinir accepted D19944: Migrate away from deprecated interfaces in gemini dropbox parts.

If memory serves, we'll need to do a fair bit of work to get the DropBox code to work properly again. DropBox has turned off the V1 API support, and we'll need to work against the V2 stuff now, which... Well, it might be trivial, but i have no time to look at it, i'm afraid. Be really good to get it back, though.

Mar 27 2019, 12:45 PM · Calligra: 3.0
leinir added inline comments to D19943: Small cleanups for qml components.
Mar 27 2019, 12:40 PM · Calligra: 3.0

Mar 26 2019

dcaliste closed D19973: MsooXmlCommonRead: protect member for double free.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19941: Avoid deprecated setSupportedDragActions.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19938: Avoid deprecated QRegion::subtract().
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19761: Remove obsolete syncX() workaround.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19760: Support Qt <5.7 on KoShape flag usage.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19885: Implement logging category for excel plugins.
Mar 26 2019, 9:47 AM · Calligra: 3.0
dcaliste closed D19912: Implement logging category for rtf-qt.
Mar 26 2019, 9:47 AM · Calligra: 3.0

Mar 25 2019

danders closed D11971: Use same keyword separator for read and write.
Mar 25 2019, 1:49 PM · Calligra: 3.0
danders added a comment to D11971: Use same keyword separator for read and write.

Yes, looks sane, I'll deal with it.

Mar 25 2019, 9:08 AM · Calligra: 3.0
danders accepted D19884: Avoid deprecated QAbstractItemModel::reset().

I think this should be ok

Mar 25 2019, 8:58 AM · Calligra: 3.0
danders accepted D19973: MsooXmlCommonRead: protect member for double free.
Mar 25 2019, 8:53 AM · Calligra: 3.0

Mar 22 2019

anthonyfieroni added a comment to D11971: Use same keyword separator for read and write.

Ping this looks sane, anyone ?

Mar 22 2019, 1:22 PM · Calligra: 3.0
pvuorela requested review of D19973: MsooXmlCommonRead: protect member for double free.
Mar 22 2019, 1:09 PM · Calligra: 3.0
danders accepted D19941: Avoid deprecated setSupportedDragActions.
Mar 22 2019, 8:14 AM · Calligra: 3.0

Mar 21 2019

pvuorela requested review of D19944: Migrate away from deprecated interfaces in gemini dropbox parts.
Mar 21 2019, 3:27 PM · Calligra: 3.0
pvuorela requested review of D19943: Small cleanups for qml components.
Mar 21 2019, 3:24 PM · Calligra: 3.0
pvuorela requested review of D19941: Avoid deprecated setSupportedDragActions.
Mar 21 2019, 1:33 PM · Calligra: 3.0
danders accepted D19938: Avoid deprecated QRegion::subtract().
Mar 21 2019, 12:22 PM · Calligra: 3.0
pvuorela requested review of D19938: Avoid deprecated QRegion::subtract().
Mar 21 2019, 11:12 AM · Calligra: 3.0

Mar 20 2019

danders added a comment to D19912: Implement logging category for rtf-qt.

Strange indents, could you fix it?

That's what I commented on the summary. On some parts rtf-qt uses plain spaces for indentation and those parts look good. Then in the same file other methods might have a hard tab or a hard tab followed by spaces. If you really want, I can try to retain the old whitespace, but it's indentation-wise more or less broken already anyway :) Alternatively could run astyle for the subdirectory, though maybe best done as separate commit.

Yes, sorry, as you say better done separatly.

The directory README also states "Temporary local copy of Brad Hards' rtf-qt library.", though as upstream hasn't had changes since 2011, it seems like a permanent one by now.

Probably.

Mar 20 2019, 12:39 PM · Calligra: 3.0
pvuorela added a comment to D19912: Implement logging category for rtf-qt.

Strange indents, could you fix it?

Mar 20 2019, 11:54 AM · Calligra: 3.0
danders accepted D19912: Implement logging category for rtf-qt.

Strange indents, could you fix it?
Otherwise ok.

Mar 20 2019, 11:32 AM · Calligra: 3.0
pvuorela requested review of D19912: Implement logging category for rtf-qt.
Mar 20 2019, 11:21 AM · Calligra: 3.0
danders added inline comments to D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 20 2019, 10:57 AM · Calligra: 3.0
danders accepted D19885: Implement logging category for excel plugins.
Mar 20 2019, 10:31 AM · Calligra: 3.0
pvuorela added inline comments to D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 20 2019, 9:59 AM · Calligra: 3.0

Mar 19 2019

dcaliste added inline comments to D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 19 2019, 7:15 PM · Calligra: 3.0
pvuorela updated the diff for D19885: Implement logging category for excel plugins.

Eliminated one unintended #ifdef SWINDER_XLS2RAW removal from the patch.

Mar 19 2019, 4:09 PM · Calligra: 3.0
pvuorela updated the diff for D19759: Remove unsupported attributes from QGraphicsWidgets.

Updated to remove also WA_StaticContents in addition to earlier WA_InputMethodEnabled.

Mar 19 2019, 3:03 PM · Calligra: 3.0
pvuorela requested review of D19885: Implement logging category for excel plugins.
Mar 19 2019, 2:56 PM · Calligra: 3.0
pvuorela requested review of D19884: Avoid deprecated QAbstractItemModel::reset().
Mar 19 2019, 2:51 PM · Calligra: 3.0

Mar 15 2019

danders added a reviewer for D19759: Remove unsupported attributes from QGraphicsWidgets: boemann.
Mar 15 2019, 7:56 AM · Calligra: 3.0
danders accepted D19760: Support Qt <5.7 on KoShape flag usage.
Mar 15 2019, 7:43 AM · Calligra: 3.0
danders accepted D19761: Remove obsolete syncX() workaround.
Mar 15 2019, 7:39 AM · Calligra: 3.0

Mar 14 2019

pvuorela requested review of D19761: Remove obsolete syncX() workaround.
Mar 14 2019, 2:49 PM · Calligra: 3.0
pvuorela requested review of D19760: Support Qt <5.7 on KoShape flag usage.
Mar 14 2019, 2:47 PM · Calligra: 3.0
pvuorela requested review of D19759: Remove unsupported attributes from QGraphicsWidgets.
Mar 14 2019, 2:42 PM · Calligra: 3.0

Mar 7 2019

anthonyfieroni added inline comments to D19327: Karbon: Enable multi page capability.
Mar 7 2019, 6:33 PM · Calligra: 3.0