DigikamProject
ActivePublic

Recent Activity

May 2 2019

dsam82 added a comment to D20842: Colors Histogram Channel in Editor-Curves tool.

digiKam is crashing when Colors channel is selected and we change the curve type.
I have tried other methods also like (channel < ColorChannels) in setCurveType function but it doesn't work.
What is the issue?

May 2 2019, 9:13 PM · Digikam
mqualmann accepted D20966: BQM: lensfun: Find lens for fixed-lens cameras BUG: 407157 FIXED-IN: 6.2.0.

I think that my image should fail. If it works with you with the original image from the camera it is fine. If a lens is present in the metadata (wherever she comes from) if only a lens in the list, should only come out with a partial match.
For me, the patch is fine.

May 2 2019, 7:42 PM · Digikam
mqualmann added a comment to D20966: BQM: lensfun: Find lens for fixed-lens cameras BUG: 407157 FIXED-IN: 6.2.0.

digikam.dimg: Search for camera "SONY" - "DSC-RX100M4" ==> true
digikam.dimg: Camera maker : "Sony"
digikam.dimg: Camera model : "DSC-RX100M4"
digikam.dimg: * Check for lens by direct query ( "Sony 24-70mm F1.8-2.8" : 0 )
digikam.dimg: * Check for no maker lens ( "Sony 24-70mm F1-2" : 0 )
digikam.dimg: lens matches : NOT FOUND
digikam.dimg: Focal Length : 25.7
digikam.dimg: Aperture : 5.6
digikam.dimg: Subject dist. : NOT FOUND : Use default value.
digikam.dimg: Subject dist. : 1000
digikam.dimg: Metadata match : "Partial Match"

May 2 2019, 7:31 PM · Digikam
mforstner added a comment to D20966: BQM: lensfun: Find lens for fixed-lens cameras BUG: 407157 FIXED-IN: 6.2.0.

I only used a test sample from the web of the camera for the test, there is also only one lens in the list. But the BQM fails here despite patch because of missing lens.

Maik

May 2 2019, 6:28 PM · Digikam
mqualmann added a comment to D20966: BQM: lensfun: Find lens for fixed-lens cameras BUG: 407157 FIXED-IN: 6.2.0.

I only used a test sample from the web of the camera for the test, there is also only one lens in the list. But the BQM fails here despite patch because of missing lens.

May 2 2019, 6:13 PM · Digikam
mforstner added a project to D20966: BQM: lensfun: Find lens for fixed-lens cameras BUG: 407157 FIXED-IN: 6.2.0: Digikam.
May 2 2019, 4:32 PM · Digikam

Apr 27 2019

dsam82 added a comment to D20840: Auto Delay Presentation Off.

If the checkbox is activated, the control widget in the upper right corner shows that it is in play mode. Pressing the play/pause button does not change anything.

What should happen if the user clicks on the play/pause button when the checkbox is activated?
Since the user doesn't want the animations, I think the control widget should be in pause mode or are there any other functionality to implement?

Apr 27 2019, 8:09 PM · Digikam

Apr 26 2019

mqualmann requested changes to D20842: Colors Histogram Channel in Editor-Curves tool.

Patch works but we still have to polish something.
Please use if (... not if(...
NUM_CHANNELS == 5, look again at line 1158 of imagecurves.cpp

Apr 26 2019, 9:05 PM · Digikam
mqualmann requested changes to D20840: Auto Delay Presentation Off.

As I wrote here (https://bugs.kde.org/show_bug.cgi?id=124788#c5) I find the solution with the CheckBox not so good.

  • When the CheckBox is enabled, the time can no longer be set for the Ken Burns effect (a stand-alone OpenGL widget and effect). The Ken Burns effect lives only through the movement.
  • If the checkbox is activated, the control widget in the upper right corner shows that it is in play mode. Pressing the play / pause button does not change anything.
  • When I use the mouse wheel, the control widget is always displayed.
Apr 26 2019, 8:46 PM · Digikam
dsam82 requested review of D20842: Colors Histogram Channel in Editor-Curves tool.
Apr 26 2019, 1:07 PM · Digikam
dsam82 requested review of D20840: Auto Delay Presentation Off.
Apr 26 2019, 12:44 PM · Digikam

Apr 19 2019

dkreuter removed a watcher for Digikam: dkreuter.
Apr 19 2019, 1:02 PM
cgilles closed D20681: Fix build with QtWebEngine 5.6.
Apr 19 2019, 12:56 PM · Digikam
cgilles accepted D20681: Fix build with QtWebEngine 5.6.

https://commits.kde.org/digikam/27b90c533f99cd4f67f99ef5c506f80db6c012af

Apr 19 2019, 12:56 PM · Digikam
wbauer added a comment to D20681: Fix build with QtWebEngine 5.6.

PS: I just now found the same in core/dplugins/generic/webservices/unified/wizard/wsauthenticationpage.cpp, but that isn't compiled currently.

Apr 19 2019, 10:05 AM · Digikam
wbauer updated the test plan for D20681: Fix build with QtWebEngine 5.6.
Apr 19 2019, 8:51 AM · Digikam
wbauer requested review of D20681: Fix build with QtWebEngine 5.6.
Apr 19 2019, 8:50 AM · Digikam

Apr 17 2019

cgilles closed D20632: Fix build with Qt 5.6.
Apr 17 2019, 9:24 AM · Digikam
cgilles accepted D20632: Fix build with Qt 5.6.

Fix applied with commit : https://commits.kde.org/digikam/dbc7b17f4d61fda327f273e30a85c8d59c913a16

Apr 17 2019, 9:23 AM · Digikam
wbauer requested review of D20632: Fix build with Qt 5.6.
Apr 17 2019, 9:01 AM · Digikam

Mar 16 2019

ashwind removed a watcher for Digikam: ashwind.
Mar 16 2019, 3:43 AM

Mar 7 2019

tpasch created T10579: digiKam flatpak: Please include mysql driver (for using an external mysql db).
Mar 7 2019, 7:17 AM · Flatpak, Digikam

Jan 17 2019

raghavendravijaya added a member for Digikam: raghavendravijaya.
Jan 17 2019, 6:43 PM
raghavendravijaya added a watcher for Digikam: raghavendravijaya.
Jan 17 2019, 6:43 PM

Jan 9 2019

ashwind added a watcher for Digikam: ashwind.
Jan 9 2019, 5:58 PM

Dec 1 2018

mqualmann added a comment to D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.

Ok, thank you, I confused the review board and phabricator.

Dec 1 2018, 5:05 PM · Digikam
wbauer abandoned D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.

Close with REVIEW: D17276 was not successful.

remote: https://commits.kde.org/digikam/60721615dd9af2b81dacce06adaa7e31d56eee32
remote: ERROR - Communication problem with Reviewboard. Please contact the KDE sysadmins.
remote: INFO - Please report the following:
remote: INFO - Request URL: https://git.reviewboard.kde.org/api/review-requests/17276/
remote: INFO - Status code: 404

Maik

Dec 1 2018, 3:47 PM · Digikam
mqualmann added a comment to D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.

Close with REVIEW: D17276 was not successful.

Dec 1 2018, 3:43 PM · Digikam
wbauer added a comment to D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.

No, welcome page view is not present in Showfoto. Only the geolocation view. So the patch must be applied too to Showfoto::main().

Dec 1 2018, 3:20 PM · Digikam
wbauer updated the diff for D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.

Apply the same change to showfoto as well.

Dec 1 2018, 2:55 PM · Digikam
mqualmann requested changes to D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.

In Showfoto the problem may not occur well, but I will try to solve the problem in another way.

Dec 1 2018, 1:23 PM · Digikam
cgilles added a comment to D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.

No, welcome page view is not present in Showfoto. Only the geolocation view. So the patch must be applied too to Showfoto::main().

Dec 1 2018, 1:14 PM · Digikam
mqualmann accepted D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.

I can reproduce the problem, although I always use QWebEngine, I had never noticed it before.
The patch works fine, also with the geolocation.

Dec 1 2018, 11:35 AM · Digikam
wbauer added a comment to D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.

Did you test this king of patch with the geolocation view, in GoogleMaps mode which use also QWebEngine ?

Dec 1 2018, 11:07 AM · Digikam
cgilles added a comment to D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.

Note : you patch the digiKam main(). Showfoto main() need also to be patched as it can show the Geolocation view in GoogleMaps mode.

Dec 1 2018, 10:14 AM · Digikam
cgilles updated subscribers of D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.
Dec 1 2018, 10:11 AM · Digikam
cgilles added a comment to D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.

Did you test this king of patch with the geolocation view, in GoogleMaps mode which use also QWebEngine ?

Dec 1 2018, 10:11 AM · Digikam
wbauer updated the test plan for D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.
Dec 1 2018, 9:21 AM · Digikam
wbauer requested review of D17276: Set AA_DontCreateNativeWidgetSiblings when using QtWebEngine.
Dec 1 2018, 9:20 AM · Digikam

Nov 9 2018

kapustakrzysztof updated the diff for D16723: FEATURE: 400777 Group by timelapse / burst.

Removed dependency on QStringView

Nov 9 2018, 2:30 AM · Digikam

Nov 7 2018

kapustakrzysztof updated the diff for D16723: FEATURE: 400777 Group by timelapse / burst.

Updated diff to the newest master

Nov 7 2018, 7:30 PM · Digikam
kapustakrzysztof retitled D16723: FEATURE: 400777 Group by timelapse / burst from FEATURE: 400777 to FEATURE: 400777 Group by timelapse / burst.
Nov 7 2018, 3:02 AM · Digikam
kapustakrzysztof requested review of D16723: FEATURE: 400777 Group by timelapse / burst.
Nov 7 2018, 3:00 AM · Digikam

Oct 12 2018

ngraham renamed T9226: Unify icon/folder views from Unifiy folder views to Unify icon/folder views.
Oct 12 2018, 11:39 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma

Oct 6 2018

ngraham triaged T9226: Unify icon/folder views as Wishlist priority.
Oct 6 2018, 11:06 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
ngraham added a comment to T9226: Unify icon/folder views.
In T9226#151961, @rkflx wrote:

@nicolasfella Speaking for Gwenview: That sounds just like an idea I had a couple of months ago (I might even have mentioned it here and there). However, in the meantime I read more of the codebase and realized it's not as easy as it sounds.

From a high-level view it makes sense, but once you dig into the interaction details and also how tightly this integrates with the rest of the codebase (thumbnailing, custom sorting and filtering models, optimized image grid, integration with the data models used in other parts, reuse for the thumbnail strip etc.), you'll find that there are features unique to Gwenview. It's not just Dolphin with thumbnails turned on and a darker background.

Oct 6 2018, 11:06 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma

Jul 18 2018

rkflx added a comment to T9226: Unify icon/folder views.

@nicolasfella Speaking for Gwenview: That sounds just like an idea I had a couple of months ago (I might even have mentioned it here and there). However, in the meantime I read more of the codebase and realized it's not as easy as it sounds.

Jul 18 2018, 10:49 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
nicolasfella updated the task description for T9226: Unify icon/folder views.
Jul 18 2018, 3:01 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
ngraham added a project to T9226: Unify icon/folder views: Frameworks.
Jul 18 2018, 2:55 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma
ngraham updated the task description for T9226: Unify icon/folder views.
Jul 18 2018, 2:55 PM · Frameworks, VDG, Digikam, Gwenview, Dolphin, Plasma