May 2 2019
digiKam is crashing when Colors channel is selected and we change the curve type.
I have tried other methods also like (channel < ColorChannels) in setCurveType function but it doesn't work.
What is the issue?
I think that my image should fail. If it works with you with the original image from the camera it is fine. If a lens is present in the metadata (wherever she comes from) if only a lens in the list, should only come out with a partial match.
For me, the patch is fine.
digikam.dimg: Search for camera "SONY" - "DSC-RX100M4" ==> true
digikam.dimg: Camera maker : "Sony"
digikam.dimg: Camera model : "DSC-RX100M4"
digikam.dimg: * Check for lens by direct query ( "Sony 24-70mm F1.8-2.8" : 0 )
digikam.dimg: * Check for no maker lens ( "Sony 24-70mm F1-2" : 0 )
digikam.dimg: lens matches : NOT FOUND
digikam.dimg: Focal Length : 25.7
digikam.dimg: Aperture : 5.6
digikam.dimg: Subject dist. : NOT FOUND : Use default value.
digikam.dimg: Subject dist. : 1000
digikam.dimg: Metadata match : "Partial Match"
I only used a test sample from the web of the camera for the test, there is also only one lens in the list. But the BQM fails here despite patch because of missing lens.
Apr 27 2019
If the checkbox is activated, the control widget in the upper right corner shows that it is in play mode. Pressing the play/pause button does not change anything.
What should happen if the user clicks on the play/pause button when the checkbox is activated?
Since the user doesn't want the animations, I think the control widget should be in pause mode or are there any other functionality to implement?
Apr 26 2019
Patch works but we still have to polish something.
Please use if (... not if(...
NUM_CHANNELS == 5, look again at line 1158 of imagecurves.cpp
As I wrote here (https://bugs.kde.org/show_bug.cgi?id=124788#c5) I find the solution with the CheckBox not so good.
- When the CheckBox is enabled, the time can no longer be set for the Ken Burns effect (a stand-alone OpenGL widget and effect). The Ken Burns effect lives only through the movement.
- If the checkbox is activated, the control widget in the upper right corner shows that it is in play mode. Pressing the play / pause button does not change anything.
- When I use the mouse wheel, the control widget is always displayed.
Apr 19 2019
PS: I just now found the same in core/dplugins/generic/webservices/unified/wizard/wsauthenticationpage.cpp, but that isn't compiled currently.
Apr 17 2019
Fix applied with commit : https://commits.kde.org/digikam/dbc7b17f4d61fda327f273e30a85c8d59c913a16
Mar 16 2019
Mar 7 2019
Jan 17 2019
Jan 9 2019
Dec 1 2018
Ok, thank you, I confused the review board and phabricator.
Close with REVIEW: D17276 was not successful.
Apply the same change to showfoto as well.
In Showfoto the problem may not occur well, but I will try to solve the problem in another way.
No, welcome page view is not present in Showfoto. Only the geolocation view. So the patch must be applied too to Showfoto::main().
I can reproduce the problem, although I always use QWebEngine, I had never noticed it before.
The patch works fine, also with the geolocation.
Note : you patch the digiKam main(). Showfoto main() need also to be patched as it can show the Geolocation view in GoogleMaps mode.
Did you test this king of patch with the geolocation view, in GoogleMaps mode which use also QWebEngine ?
Nov 9 2018
Removed dependency on QStringView
Nov 7 2018
Updated diff to the newest master
Oct 12 2018
Oct 6 2018
Jul 18 2018
@nicolasfella Speaking for Gwenview: That sounds just like an idea I had a couple of months ago (I might even have mentioned it here and there). However, in the meantime I read more of the codebase and realized it's not as easy as it sounds.