May 30 2020
Respective merge requests are created now here:
May 29 2020
Great, thanks Friedrich.
@staniek Ah, missed your reply, somehow phabricator did not send me a noticiation.
May 27 2020
Hi Freidrich. That's a good news to me!
Hi @staniek . While I am currently doing some work to keep api.kde.org alive and cleaning up legacy docs where possible, I remembered this task and would be available to complete it these days :)
May 17 2020
May 16 2020
Updated required version of ECM to use ECMSetupQtPluginMacroNames. It is now
based on master (3.3) instead of the 3.2 branch
May 9 2020
Nice, but question, would it be possible to use ecm_setup_qtplugin_macro_names() ? https://api.kde.org/ecm/module/ECMSetupQtPluginMacroNames.html
Apr 25 2020
Apr 22 2020
Amazing to have someone using my work, can I ask what app you are using it in?
Apr 20 2020
Improve wording, remove use of QLatinString/QStringLiteral, and make code follow conventions better
BTW, while creating reviews please add at least me and KReport maintainer Adam as reviewers. Thanks!
Good job, some notes added.
Apr 18 2020
Fix wording, and remove improper use of auto and pointer validity according to coding style
Reviewed until line 475.
Apr 17 2020
Apr 16 2020
Updated text according to Jarosław’s notes
Thanks, reviewed first 200 lines. Good job!
Apr 14 2020
Very nice, I will review this.
Apr 13 2020
Apr 11 2020
BTW @jfita, I propose adding the following line to the description, to help us creating change logs:
Good job, thanks!
Landed in 3.2.
Apr 10 2020
If we want it in the stable 3.2 release, it needs to land in the 3.2 branch.
Nov 4 2019
Nov 1 2019
Jan 23 2019
Jun 25 2018
note that I can already push patches on my own
Thanks for the approval -- note that I can already push patches on my own ;-)
You can apply it also to a stable branch, because, if I'm not mistaken, the change only removes translations. Removing translated strings is not a problem.
(landed to master (3.2) as translations are affected)