KMyMoneyProject
ActivePublic

Details

Description

the BEST Personal Finance Manager for FREE Users, full stop.

The ultimate objectives of KMyMoney are...

  • Accuracy. Using time tested double entry accounting principles KMyMoney can help ensure that your finances are kept in correct order.
  • Ease of use. KMyMoney strives to be the easiest open source personal finance manager to use, especially for the non-technical user.
  • Familiar Features. KMyMoney intends to provide all important features found in the commercially-available, personal finance managers. The current release is closer than ever to that goal and more improvements are already planned or being tested.

Recent Activity

Yesterday

wojnilowicz requested review of D13615: Move encryption settings to XML storage plugin.
Tue, Jun 19, 5:01 PM · KMyMoney

Sun, Jun 17

wojnilowicz requested review of D13581: Prepare for XML storage separation.
Sun, Jun 17, 1:12 PM · KMyMoney

Tue, Jun 12

tbaumgart added a comment to D13465: Fix xml file saving on Windows.

@ostroffjh you answered the Windows part yourself already. In fact, I am thinking we should stabilize 5.1 and release it next. It has some improvements regarding the plugins so that is probably worth it. Nevertheless, I planned to cherry-pick onto the 5.0 branch once it landed. @ocoole Do you have write access to the repo or shall I land it?

Tue, Jun 12, 7:47 AM · KMyMoney

Mon, Jun 11

ostroffjh added a comment to D13465: Fix xml file saving on Windows.

Sorry - I see this is only supposed to affect Windows, so questions about Linux are unnecessary.

Mon, Jun 11, 9:59 PM · KMyMoney
ostroffjh added a comment to D13465: Fix xml file saving on Windows.

Question regarding backporting: Is it correct that this does not affect 4.8 branch at all, or just not the Windows build? I don't know if any Linux distros will need another 4.8 release before being able to fully migrate to 5.x Also, does this need backporting to 5.0 branch or will next release be 5,1 and not 5.0.2?

Mon, Jun 11, 9:57 PM · KMyMoney
habacker added a comment to D13465: Fix xml file saving on Windows.

(I also used kmm 4.8.0 (not the latest 4.8.2 though) on Windows—which seems to work fine.)

4.8.2 is also not affected, see D13465#276986

Mon, Jun 11, 8:28 AM · KMyMoney
habacker added a comment to D13465: Fix xml file saving on Windows.

I added habackeras subscriber so that he may check if this also needs to be backported to the 4.8 branch.

4.8 branch is not affected - It uses KTemporaryFile for the temporary file and KIO to copy the file to the destination (see https://cgit.kde.org/kmymoney.git/tree/kmymoney/views/kmymoneyview.cpp?h=4.8#n1275)

Mon, Jun 11, 8:19 AM · KMyMoney

Sun, Jun 10

wojnilowicz closed D13408: Refactor file menu.
Sun, Jun 10, 3:24 PM · KMyMoney
wojnilowicz closed D13409: Remove redundant CMake statements.
Sun, Jun 10, 3:24 PM · KMyMoney
wojnilowicz closed D13295: Enable foreign keys support in SQLite.
Sun, Jun 10, 3:24 PM · KMyMoney
tbaumgart accepted D13408: Refactor file menu.

I have done some more testing and I think this is now good to go into the repo. The remaining issues I found are not related to this patch and can be fixed on the fly.

Sun, Jun 10, 3:03 PM · KMyMoney
ocoole added a comment to D13465: Fix xml file saving on Windows.

Thanks Thomas! (I actually thought I should have discovered this earlier; apparently I didn't test it out very comprehensively back then.)

Sun, Jun 10, 2:30 PM · KMyMoney
tbaumgart accepted D13465: Fix xml file saving on Windows.

Said behavior of MS-Windows based operating systems is a PITA and known for many moons. Nevertheless, we always get caught by it. I added habackeras subscriber so that he may check if this also needs to be backported to the 4.8 branch.

Sun, Jun 10, 1:53 PM · KMyMoney
tbaumgart updated subscribers of D13465: Fix xml file saving on Windows.
Sun, Jun 10, 1:37 PM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.
Sun, Jun 10, 12:39 PM · KMyMoney
ocoole requested review of D13465: Fix xml file saving on Windows.
Sun, Jun 10, 12:20 PM · KMyMoney
ocoole added a comment to D13408: Refactor file menu.

Dear Thomas / Łukasz:

Could you try and see if you could reproduce this:
...

I cannot reproduce this. ... Anyhow I changed xmlstorage.cpp:271 a little bit so you can observe backtrace and exception messages better.

Sun, Jun 10, 11:08 AM · KMyMoney
christiand accepted D13295: Enable foreign keys support in SQLite.
Sun, Jun 10, 10:24 AM · KMyMoney
tbaumgart requested changes to D13408: Refactor file menu.
Sun, Jun 10, 8:43 AM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.
Sun, Jun 10, 5:20 AM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.

Fixed issues with Select All Transactions and Update All Accounts.

Sun, Jun 10, 5:16 AM · KMyMoney

Sat, Jun 9

tbaumgart added a comment to D13408: Refactor file menu.

Here's another weirdness: Start KMyMoney which opens the last selected file. Select the categories view and select one category (anyone should do). Close the file with Ctrl-W. Accounts/Update all accounts is still enabled and crashes. Transaction/Select allis also enabled when file is closed.

Sat, Jun 9, 7:53 PM · KMyMoney
wojnilowicz added a comment to D13408: Refactor file menu.
  • Category/New Category is never enabled

I did not change this behaviour. Category/New Category activates on categories view if you select one of the categories.

Then it might be a leftover from one of your recent changes. Anyway, it needs to be fixed. Otherwise you will not be able to create the first category ever in a new file (except loading templates). And this is new user experience.

Sat, Jun 9, 3:46 PM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.

Fixed icalendar crash.

Sat, Jun 9, 3:45 PM · KMyMoney
tbaumgart requested changes to D13408: Refactor file menu.
  • Category/New Category is never enabled

I did not change this behaviour. Category/New Category activates on categories view if you select one of the categories.

Then it might be a leftover from one of your recent changes. Anyway, it needs to be fixed. Otherwise you will not be able to create the first category ever in a new file (except loading templates). And this is new user experience.

Sat, Jun 9, 3:34 PM · KMyMoney
tbaumgart accepted D13409: Remove redundant CMake statements.

We'll see if we might have to add them at a later point in time for specific environments. So far, we don't know and don't see a necessity.

Sat, Jun 9, 2:45 PM · KMyMoney
tbaumgart added a comment to D13408: Refactor file menu.
  • When KMyMoney is started without options to open the last loaded storage
    • File/Close or Ctrl+W don't work anymore. They show an error (see also message on CLI)

I cannot reproduce this. If you open KMM without a file, then Ctrl+W shouldn't be available.

I stated, that you need to open a recent file and then close it. Activate all plugins (the iCalendar one is causing the crash) and also make sure to compile with ENABLE_UNFINISHEDFEATURES set to ON and you will be able to reproduce this and maybe find others.

Sat, Jun 9, 2:41 PM · KMyMoney
wojnilowicz updated subscribers of D13408: Refactor file menu.

Dear Thomas / Łukasz:

Could you try and see if you could reproduce this:

I opened an existing kmy/xml file, made some changes to it, and pressed Save.
It throws an error: "Unable to write changes to '[/path/to/file]' [...]\kmymoney\plugins\xml\xmlstorage.cpp:271"

(Interestingly when I hit Save a second time, the second time succeeds)

IMO this would really be a show stopper indeed coz file saving seems to be, in a sense, broken.

(Many thanks both of you for your efforts!) (I've nothing further to add regarding this patch)

Sat, Jun 9, 1:13 PM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.
Sat, Jun 9, 1:11 PM · KMyMoney
ocoole added a comment to D13408: Refactor file menu.

Dear Thomas / Łukasz:

Sat, Jun 9, 12:21 PM · KMyMoney
ocoole added inline comments to D13408: Refactor file menu.
Sat, Jun 9, 11:41 AM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.
Sat, Jun 9, 9:12 AM · KMyMoney
wojnilowicz added a comment to D13408: Refactor file menu.
  • When KMyMoney is started with the -n command line option
    • File export/Schedules to iCalendar is still available (you need to have this plugin enabled)
Sat, Jun 9, 9:12 AM · KMyMoney
ocoole added inline comments to D13408: Refactor file menu.
Sat, Jun 9, 9:06 AM · KMyMoney
tbaumgart added a comment to D13408: Refactor file menu.
  • When KMyMoney is started with the -n command line option
    • File export/Schedules to iCalendar is still available (you need to have this plugin enabled)
Sat, Jun 9, 8:18 AM · KMyMoney
wojnilowicz updated the diff for D13409: Remove redundant CMake statements.
Sat, Jun 9, 5:53 AM · KMyMoney
wojnilowicz updated the diff for D13408: Refactor file menu.

Fixed all reported deficiencies.

Sat, Jun 9, 5:51 AM · KMyMoney
wojnilowicz added a comment to D13408: Refactor file menu.

Here are my findings:

    • I needed to apply the following patch to compile it:

      ` diff --git a/kmymoney/kmymoney.cpp b/kmymoney/kmymoney.cpp index a334f7df..c48b4157 100644
    • a/kmymoney/kmymoney.cpp +++ b/kmymoney/kmymoney.cpp @@ -1990,7 +1990,7 @@ void KMyMoneyApp::slotShowAllAccounts() #ifdef KMM_DEBUG void KMyMoneyApp::slotFileFileInfo() {
  • if (!d->m_fileOpen) { + if (!d->m_fileInfo.isOpened) { KMessageBox::information(this, i18n("No KMyMoneyFile open")); return; } `
    • When the backend is closed via File/Close or Ctrl+W:
      • the File/Import and File/Export menus and their entries are not disabled. Selecting them crashes the application.
      • the New credit transfer button is not disabled. Pressing it crashes the application
      • the Update all accounts button is not disabled. Pressing it crashes the application
      • the Tools/Performance test option is not disabled. Selecting it crashes the application
    • Having one XML file (GZIP) open and using File/Open recent to select another XML (GPG encrypted) shows the message Cannot open file as requested. Error was: No storage object attached to MyMoneyFile /home/thb/devel/kmymoney/kmymoney/mymoney/mymoneyfile.cpp:214 This maybe just a special case, see next entry.
    • Opening GPG encrypted files does not work at all. I started from the CLI with a filename provided. It always shows the message mentioned in the previous line. This is a show stopper!!
    • Open an XML file. Make changes. Don't save. Open another file and press Cancel on the Save changes dialog. This will result in the message Cannot open file as requested. Error was: Storage already attached /home/thb/devel/kmymoney/kmymoney/mymoney/mymoneyfile.cpp:335 It should just stop the action without message.
Sat, Jun 9, 5:50 AM · KMyMoney

Fri, Jun 8

ocoole added inline comments to D13408: Refactor file menu.
Fri, Jun 8, 5:45 PM · KMyMoney
ocoole added a comment to D13408: Refactor file menu.

Apologies that I'll add one more finding (in addition to Thomas's observations):

Fri, Jun 8, 5:25 PM · KMyMoney
ocoole added a comment to D13408: Refactor file menu.

(Thomas's comments make perfect sense to me. I respectfully agree.)
Just one nitpick from me (in terms of user experience): is there a way to 'default' (if present) to kmy/xml files in the open dialog file filter?
(Maybe I'm on Windows) but right now when I click File, Open, it defaults to "GnuCash files" since it's top in the filter list.
Is there a way to push "KMyMoney files" to top of the list (when available)?
(Otherwise this patch's not bad at all—Of course Thomas's points do are legitimate concerns that require revision.)

Fri, Jun 8, 4:27 PM · KMyMoney
tbaumgart requested changes to D13408: Refactor file menu.

Here are my findings:

Fri, Jun 8, 3:08 PM · KMyMoney
wojnilowicz added a comment to D13409: Remove redundant CMake statements.

What about the target_compile_features in kmyoney/settings/CMakeLists.txt? Why were those instructions added in the first place? Are they possibly required on some platform? Did you check all of them?

Fri, Jun 8, 1:43 PM · KMyMoney
tbaumgart added a comment to D13409: Remove redundant CMake statements.

What about the target_compile_features in kmyoney/settings/CMakeLists.txt? Why were those instructions added in the first place? Are they possibly required on some platform? Did you check all of them?

Fri, Jun 8, 1:34 PM · KMyMoney
tbaumgart updated the summary of D13414: Format reports headers according to the KDE guidelines.
Fri, Jun 8, 8:03 AM · KMyMoney
tbaumgart updated the summary of D13413: Format widget headers according to the KDE guidelines.
Fri, Jun 8, 8:00 AM · KMyMoney

Thu, Jun 7

wojnilowicz requested review of D13414: Format reports headers according to the KDE guidelines.
Thu, Jun 7, 5:49 PM · KMyMoney
wojnilowicz requested review of D13413: Format widget headers according to the KDE guidelines.
Thu, Jun 7, 5:48 PM · KMyMoney
jefferyq added a watcher for KMyMoney: jefferyq.
Thu, Jun 7, 4:08 PM
wojnilowicz requested review of D13409: Remove redundant CMake statements.
Thu, Jun 7, 3:49 PM · KMyMoney