OkularProject
ActivePublic

Details

Description

KDE Document Viewer

Recent Activity

Today

ngraham added a reviewer for D21910: Preferences dialog is resized from its default size, such that the complete content is visible.: Okular.
Wed, Jun 19, 5:39 PM · Okular
ngraham requested changes to D21910: Preferences dialog is resized from its default size, such that the complete content is visible..

While this sort of works, now it makes the dialog way too tall, and I don't think it's the right approach to the problem. We should figure out what's causing the default size to be wrong and fix that, rather than leaving it broken and working around it in the proposed way.

Wed, Jun 19, 5:38 PM · Okular
mayankchoudhary requested review of D21910: Preferences dialog is resized from its default size, such that the complete content is visible..
Wed, Jun 19, 4:55 PM · Okular

Yesterday

simgunz updated the task description for T8076: Fix design of annotation toolbar.
Tue, Jun 18, 6:13 AM · VDG, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Tue, Jun 18, 6:05 AM · VDG, Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Tue, Jun 18, 6:04 AM · VDG, Okular
simgunz added a comment to D15580: New annotation toolbar.

Don’t have UI feedback that asks for action already in this patch. :)

  • Maybe the 4 left buttons should indicate that they require further action (drawing). Currently they look like buttons in a word processor, where you have to select the text first. *1) Using the existing dynamic annotation icons might look better, as soon as someone made them more low-resolution friently.
Tue, Jun 18, 6:03 AM · Okular

Mon, Jun 17

davidhurka added a comment to D15580: New annotation toolbar.

Don’t have UI feedback that asks for action already in this patch. :)

Mon, Jun 17, 7:16 PM · Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Fix and simplify width action
  • Fix and simplify opacity action
  • Fix annotation tools actions
  • Rename color action
  • Formatting
Mon, Jun 17, 6:51 PM · Okular
davidhurka updated the summary of D21195: [RFC] Create a Change Colors menu (with toolbar button).
Mon, Jun 17, 6:46 PM · Okular
simgunz added a comment to D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.

Currently I am using ToolAction in the new annotation toolbar to selected among different geometrical annotation. [...]
For this purpose I need that the action are checkable, and that the ToggleActionMenu is checkable displaying the selected action (exaclty as ToolAction).

[...] For my use case, I would probably need to be able to display tooltips for each action in the ToggleActionMenu, to describe what they are.

[...] I need to use it for Geometrical annotations and for the Stamp annotation. For this last one I would need to display the different available stamps, so each action in the ToggleActionMenu should just be a checkable action with a full width image and no text. [...]

Maybe it’s better to use a KSelectAction directly? Not sure whether it shows the current selection on the toolbar button, but probably it does so in combobox mode.

For the stamps, you probably need a combobox with a custom item view.

Mon, Jun 17, 5:43 PM · Okular
davidhurka updated the diff for D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.
  • Add license headers
Mon, Jun 17, 5:17 PM · Okular
davidhurka updated the test plan for D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.
Mon, Jun 17, 5:01 PM · Okular
davidhurka added a comment to D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.

Currently I am using ToolAction in the new annotation toolbar to selected among different geometrical annotation. [...]
For this purpose I need that the action are checkable, and that the ToggleActionMenu is checkable displaying the selected action (exaclty as ToolAction).

[...] For my use case, I would probably need to be able to display tooltips for each action in the ToggleActionMenu, to describe what they are.

[...] I need to use it for Geometrical annotations and for the Stamp annotation. For this last one I would need to display the different available stamps, so each action in the ToggleActionMenu should just be a checkable action with a full width image and no text. [...]

Mon, Jun 17, 4:47 PM · Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Mon, Jun 17, 3:10 PM · VDG, Okular
simgunz added a comment to D15580: New annotation toolbar.

Favorite annotations:
The Star adds the currently selected tool to the favorite list, the bookmark symbol displays the list of the favorite tools:

Mon, Jun 17, 2:58 PM · Okular
simgunz added a comment to D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.

From my point of view, this is complete now. 3 TODOs left (see revision description at the top).

ToolAction used its own tooltip for the toolbar buttons. Tell me if that is still needed.

@simgunz you just told that you will use ToolAction? If you show me your implementation, it’s ok for me to use that instead. Otherwise you can tell me what you need (tooltips?). :)

Mon, Jun 17, 2:50 PM · Okular

Sun, Jun 16

davidhurka updated subscribers of D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.

From my point of view, this is complete now. 3 TODOs left (see revision description at the top).

Sun, Jun 16, 8:03 PM · Okular
davidhurka updated the test plan for D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.
Sun, Jun 16, 7:58 PM · Okular
davidhurka updated the diff for D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.
  • Remove accidentally inserted #include
  • remove repeated calls to QToolButton::setMenu()
  • Update class documentation
Sun, Jun 16, 7:54 PM · Okular
davidhurka added a comment to D15580: New annotation toolbar.

For now I am more interested in feedback on the UI/UX

Sun, Jun 16, 7:40 PM · Okular
simgunz updated the diff for D15580: New annotation toolbar.

Added the favorite tools.

Sun, Jun 16, 7:27 PM · Okular
simgunz added inline comments to D15580: New annotation toolbar.
Sun, Jun 16, 6:37 PM · Okular
davidhurka updated the diff for D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.
  • Work arround connection problem by using QPointer
Sun, Jun 16, 5:31 PM · Okular
davidhurka updated the summary of D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.
Sun, Jun 16, 5:26 PM · Okular
davidhurka added a comment to D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.

I couldn’t find a reason why disconnecting my slot at destruction fails, but it indeed fails.

Sun, Jun 16, 5:22 PM · Okular
davidhurka added inline comments to D15580: New annotation toolbar.
Sun, Jun 16, 5:02 PM · Okular
fbampaloukas added a watcher for Okular: fbampaloukas.
Sun, Jun 16, 9:07 AM

Sat, Jun 15

sander updated the summary of D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode.
Sat, Jun 15, 9:55 PM · Okular
sander requested review of D21836: Mind the devicePixelRatio when drawing on-screen in presentation mode.
Sat, Jun 15, 9:54 PM · Okular

Fri, Jun 14

davidhurka added inline comments to D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.
Fri, Jun 14, 4:44 PM · Okular
ngraham accepted D21759: Hold zoom center below center/mouse position.

Interactivity is great, a big improvement! Code looks sane to me too but I'd like a review from a Okular person before we land this.

Fri, Jun 14, 4:33 PM · Okular
simgunz updated the task description for T8076: Fix design of annotation toolbar.
Fri, Jun 14, 10:23 AM · VDG, Okular
simgunz updated the diff for D15580: New annotation toolbar.
  • Added opacity action
  • Cleaned width action
  • Big code refactor:
    • m_toolDefinition is now a QDomDocument, so that the toolElement are not randomly deleted when the associated QDomDocument goes out of scope.
    • AnnotationActionHandler acts directly on PageViewAnnotator instead of emitting signals
  • Further code cleaning in pageview.cpp
  • Annotations work only in Normal mouse mode, and switch to it when they are selected
Fri, Jun 14, 10:22 AM · Okular
simgunz added inline comments to D15580: New annotation toolbar.
Fri, Jun 14, 5:49 AM · Okular

Thu, Jun 13

aacid added inline comments to D15580: New annotation toolbar.
Thu, Jun 13, 9:38 PM · Okular
aacid added inline comments to D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.
Thu, Jun 13, 9:07 PM · Okular
davidhurka added a comment to D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.

Theoretically works, but signal-slot is tricking me.

Thu, Jun 13, 7:14 PM · Okular
steffenh updated the diff for D21759: Hold zoom center below center/mouse position.

Use initial cursor position for middle-button-drag zooming

Thu, Jun 13, 2:22 PM · Okular

Wed, Jun 12

davidhurka added a comment to D21734: [WIP] Improve class documentation for PageView and PageViewItem.

Oh, does someone know any intended purpose division between setupActions(), setupViewerActions(), and setupBaseActions()?

someone does yes.

it has to do with part's m_embedMode check part.cpp it's actually pretty easy to see the use case for them

Wed, Jun 12, 9:58 PM · Okular
davidhurka added a comment to D21759: Hold zoom center below center/mouse position.

Using cursor position for Ctrl+Scroll, but not for Ctrl+Plus/Minus makes sense to me.

Wed, Jun 12, 9:52 PM · Okular
davidhurka updated the diff for D21734: [WIP] Improve class documentation for PageView and PageViewItem.
  • De-rename parameter out_pagenumber
Wed, Jun 12, 9:44 PM · Okular
davidhurka added inline comments to D21734: [WIP] Improve class documentation for PageView and PageViewItem.
Wed, Jun 12, 9:43 PM · Okular
davidhurka updated the diff for D21734: [WIP] Improve class documentation for PageView and PageViewItem.

Looked over the whole patch again.

Wed, Jun 12, 9:21 PM · Okular
ngraham updated the summary of D21759: Hold zoom center below center/mouse position.
Wed, Jun 12, 2:53 PM · Okular
steffenh requested review of D21759: Hold zoom center below center/mouse position.
Wed, Jun 12, 9:00 AM · Okular
simgunz added inline comments to D15580: New annotation toolbar.
Wed, Jun 12, 6:34 AM · Okular

Tue, Jun 11

aacid added inline comments to D15580: New annotation toolbar.
Tue, Jun 11, 10:40 PM · Okular
davidhurka added a comment to D21734: [WIP] Improve class documentation for PageView and PageViewItem.

Thanks for your comments, I will look over my patch soon.

Tue, Jun 11, 10:24 PM · Okular
davidhurka added inline comments to D21755: [WIP] Replace ToolAction by a more universal “ToggleActionMenu”.
Tue, Jun 11, 10:09 PM · Okular