OkularProject
ActivePublic

Details

Description

KDE Document Viewer

Recent Activity

Yesterday

aacid added a comment to D20678: Ensure compatibility with Qt <5.10.

Thanks :)

Sat, Apr 20, 9:56 AM · Okular
aacid closed D20678: Ensure compatibility with Qt <5.10.
Sat, Apr 20, 9:56 AM · Okular
aacid accepted D20678: Ensure compatibility with Qt <5.10.
Sat, Apr 20, 9:56 AM · Okular

Thu, Apr 18

awilcox requested review of D20678: Ensure compatibility with Qt <5.10.
Thu, Apr 18, 11:25 PM · Okular

Tue, Apr 16

ngraham added a comment to D18744: Add action in Edit menu to select the text on current page.

You've already got my approval. :)

Tue, Apr 16, 12:51 PM · Documentation, Okular
shubham added a comment to D18744: Add action in Edit menu to select the text on current page.

@ngraham @aacid Ping?

Tue, Apr 16, 6:39 AM · Documentation, Okular

Mon, Apr 15

michaelweghorn added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.

OK, let's go for it!

@michaelweghorn I hope you know this means you're on the hook to fix any bugs that crop up, right? :)

Mon, Apr 15, 6:26 AM · Okular
ngraham closed D18179: PDF: Implement scaling options for non-rasterized printing.
Mon, Apr 15, 3:11 AM · Okular
ngraham added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.

OK, let's go for it!

Mon, Apr 15, 3:10 AM · Okular

Sun, Apr 14

aacid added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.

i have not tested it, if you think it works, i guess it's ok from the pure code point of view.

Sun, Apr 14, 10:33 PM · Okular
joaonetto added a comment to D19717: Search function fails to find phrases split over two lines.

Ping on this.

Sun, Apr 14, 9:17 PM · Okular
aacid added a comment to D20437: Make selection scrolling go at 60 fps.

It's the first time after years and dozen of contributions to dozen of projects that I see such a fuss about my internet name

@aacid if I put my relicensing preferences on the kde dev script repo, will you consider the patch?

Sun, Apr 14, 4:42 PM · Okular
aacid added a comment to D20437: Make selection scrolling go at 60 fps.

Still has a fake name attached to it?

If so i'll refrain from looking at the code and getting tainted by it.

Can you clarify how reviewing this patch would taint you?

Sun, Apr 14, 4:39 PM · Okular

Sat, Apr 13

aacid added a comment to D20488: Fix build with poppler <0.58.

Thanks for landing.

Not sure how common that poppler version still is, but do you think it's worth a respin for 19.04?

Sat, Apr 13, 9:14 AM · Okular
heikobecker added a comment to D20488: Fix build with poppler <0.58.

Thanks for landing.

Sat, Apr 13, 8:18 AM · Okular

Fri, Apr 12

aacid closed D20488: Fix build with poppler <0.58.
Fri, Apr 12, 10:06 PM · Okular
aacid accepted D20488: Fix build with poppler <0.58.

Awesome thanks.

Fri, Apr 12, 9:59 PM · Okular
ngraham accepted D20437: Make selection scrolling go at 60 fps.

Out of deference to @aacid, I'll wait to commit this until the mailing list thread has come to a conclusion we can all agree with, or at least graciously accept without complaining about it later. :)

Fri, Apr 12, 8:09 PM · Okular
heikobecker requested review of D20488: Fix build with poppler <0.58.
Fri, Apr 12, 11:31 AM · Okular

Thu, Apr 11

kezik added a comment to D20437: Make selection scrolling go at 60 fps.

1000/60 yields a floating-point value. Is it acceptable that std::chrono::milliseconds can be a non-integer value?

Thu, Apr 11, 9:59 PM · Okular
ngraham added a comment to D20437: Make selection scrolling go at 60 fps.

1000/60 yields a floating-point value. Is it acceptable that std::chrono::milliseconds can be a non-integer value?

Thu, Apr 11, 9:47 PM · Okular
kezik updated the diff for D20437: Make selection scrolling go at 60 fps.

Even more clear

Thu, Apr 11, 9:21 PM · Okular
joaonetto updated the task description for T8553: Improve review side panel.
Thu, Apr 11, 8:04 PM · Okular
ngraham added a comment to D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

Ok, well seeing as @kezik is continuing to submit patches (see D20437), I guess your options are to:

  1. re-open the discussion on a mailing list or phab task

I don't know what makes you think *I* should be the one re-open the discussion on a mailing list or phab task, AFAIR *you* are the first person ever to commit hard to trace commits to Okular repo, so it's on *you* to show why we have to agree to such tainting.

Thu, Apr 11, 6:01 PM · Okular
ahmedbilal added a reviewer for D20405: Make preview(dashed rectangle) of rectangle annotation colorful: sander.
Thu, Apr 11, 5:46 PM · Okular
ahmedbilal removed a reviewer for D20405: Make preview(dashed rectangle) of rectangle annotation colorful: sander.
Thu, Apr 11, 5:46 PM · Okular
ngraham added inline comments to D20437: Make selection scrolling go at 60 fps.
Thu, Apr 11, 4:05 PM · Okular
sander accepted D20437: Make selection scrolling go at 60 fps.
Thu, Apr 11, 3:12 PM · Okular
sander added a comment to D20437: Make selection scrolling go at 60 fps.

Thanks! I am happy with these comments (except maybe that people may read the "/ 60 fps" in line 3770 as a division).

Thu, Apr 11, 3:11 PM · Okular
kezik added a comment to D20437: Make selection scrolling go at 60 fps.

Oh, and by the way, the _actual_ speed of the page is set by how far you move the mouse outside the viewport, that constant really doesn't matter, it's only set to a nice value

Thu, Apr 11, 3:07 PM · Okular
kezik updated the diff for D20437: Make selection scrolling go at 60 fps.

As requested I explain what the "arbitrary constant" does

Thu, Apr 11, 3:05 PM · Okular
kezik added a comment to D20437: Make selection scrolling go at 60 fps.

Well, before my patch the hardcoded constant was "100", (the time between each page update)
Now I put an universal constant there (16, as in milliseconds to create a 60fps animation), and moved the hardcoded constant elsewhere

Thu, Apr 11, 2:55 PM · Okular
sander added a comment to D20437: Make selection scrolling go at 60 fps.

Hi Kezi, I don't have a good answer to all that, I am just a bit distrustful regarding hard-coded constants like '6'. But I acknowledge that there are situations where they cannot be avoided.

Thu, Apr 11, 2:49 PM · Okular
kezik added a comment to D20437: Make selection scrolling go at 60 fps.

How did you determine the value of the damping variable? You write

With this patch this automatic scrolling goes at 60 fps instead of 10, I made it so that the speed of the scroll is the same.

If somebody in the future changes the scroll speed, will you have to update your patch? Wouldn't it be better to have only one constant that determines the speed of both regular scrolling and automatic scrolling?

Thu, Apr 11, 2:45 PM · Okular
sander added a comment to D20437: Make selection scrolling go at 60 fps.

How did you determine the value of the damping variable? You write

Thu, Apr 11, 2:28 PM · Okular
kezik added a comment to D20437: Make selection scrolling go at 60 fps.

It's the first time after years and dozen of contributions to dozen of projects that I see such a fuss about my internet name

Thu, Apr 11, 10:24 AM · Okular
ngraham added a comment to D20437: Make selection scrolling go at 60 fps.

Still has a fake name attached to it?

If so i'll refrain from looking at the code and getting tainted by it.

Thu, Apr 11, 12:51 AM · Okular

Wed, Apr 10

aacid added a comment to D20437: Make selection scrolling go at 60 fps.

Still has a fake name attached to it?

Wed, Apr 10, 9:29 PM · Okular
aacid added a comment to D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

Ok, well seeing as @kezik is continuing to submit patches (see D20437), I guess your options are to:

  1. re-open the discussion on a mailing list or phab task
Wed, Apr 10, 9:28 PM · Okular
ngraham added a reviewer for D20437: Make selection scrolling go at 60 fps: aacid.

Looks awesome. @aacid?

Wed, Apr 10, 6:16 PM · Okular
ahmedbilal added a comment to D20437: Make selection scrolling go at 60 fps.

Selection scrolling look super cool.

Wed, Apr 10, 6:15 PM · Okular
ahmedbilal abandoned D20351: Improve Legibility of preview of rectangle annotation.
Wed, Apr 10, 6:02 PM · Okular
kezik added a comment to D20437: Make selection scrolling go at 60 fps.

Wed, Apr 10, 5:45 PM · Okular
ngraham added a comment to D16519: Set Qt::AA_CompressTabletEvents attribute to avoid latency when scrolling with a tablet.

Ok, well seeing as @kezik is continuing to submit patches (see D20437), I guess your options are to:

  1. Try to convince him/her to provide a real name and re-open the discussion on a mailing list or phab task
  2. Gracefully accept a conclusion you don't agree with
  3. Throw away the contributions
Wed, Apr 10, 3:03 PM · Okular
kezik requested review of D20437: Make selection scrolling go at 60 fps.
Wed, Apr 10, 2:57 PM · Okular

Tue, Apr 9

ngraham accepted D20405: Make preview(dashed rectangle) of rectangle annotation colorful.

I think this is fine.

Tue, Apr 9, 3:07 PM · Okular
ahmedbilal retitled D20351: Improve Legibility of preview of rectangle annotation from Improve Legibility of preview of rectangle annotation and make it same color as resulting rectangle to Improve Legibility of preview of rectangle annotation.
Tue, Apr 9, 1:23 PM · Okular
ahmedbilal added a comment to D20405: Make preview(dashed rectangle) of rectangle annotation colorful.

@sander I have added you as reviewer and subscriber.

Tue, Apr 9, 1:06 PM · Okular
ahmedbilal added a reviewer for D20405: Make preview(dashed rectangle) of rectangle annotation colorful: sander.
Tue, Apr 9, 1:05 PM · Okular
ahmedbilal updated the summary of D20405: Make preview(dashed rectangle) of rectangle annotation colorful.
Tue, Apr 9, 1:05 PM · Okular