OkularProject
ActivePublic

Details

Description

KDE Document Viewer

Recent Activity

Yesterday

ngraham added a comment to D21971: Replace ToolAction by ToggleActionMenu.

Needs a rebase for sure

Thu, Dec 12, 8:27 AM · Okular

Wed, Dec 11

aacid added a comment to D21971: Replace ToolAction by ToggleActionMenu.

Is it me or this thing doesn't compile?

Wed, Dec 11, 11:05 PM · Okular

Mon, Dec 9

ahmadsamir abandoned D25684: [core/*] replace foreach, deprecated, with range-for.

Created a pull request on invent.kde.org. https://invent.kde.org/kde/okular/merge_requests/73

Mon, Dec 9, 11:57 AM · Okular
ahmadsamir added a comment to D25684: [core/*] replace foreach, deprecated, with range-for.

Trying to land this diff I get these errors:

Mon, Dec 9, 11:35 AM · Okular

Sun, Dec 8

aacid accepted D25684: [core/*] replace foreach, deprecated, with range-for.
Sun, Dec 8, 10:27 PM · Okular
ahmadsamir added a comment to D25684: [core/*] replace foreach, deprecated, with range-for.

Ping

Sun, Dec 8, 2:08 PM · Okular

Sat, Dec 7

simgunz accepted D21971: Replace ToolAction by ToggleActionMenu.

The class has the features needed for both D15580 and D21195 and I do not see evident bugs. For me, this revision is good enough for now, and in case we can fix it later (it used in few places so it should not be hard to adapt the code if needed).

Sat, Dec 7, 10:53 AM · Okular

Thu, Dec 5

broulik abandoned D23911: Port SearchLineWidget to use KBusyIndicatorWidget.

Moved to GitLab: https://invent.kde.org/kde/okular/merge_requests/71

Thu, Dec 5, 10:22 PM · Okular
ngraham added a comment to D21971: Replace ToolAction by ToggleActionMenu.

Sorry, this technical discussion is beyond me. :)

Thu, Dec 5, 8:54 PM · Okular
ngraham closed D22118: Shifts focus to the document when collapsing a sidebar view.

This was moved to invent at https://invent.kde.org/kde/okular/merge_requests/22

Thu, Dec 5, 8:13 PM · Okular
ahmadsamir updated the diff for D25684: [core/*] replace foreach, deprecated, with range-for.

Rebase.

Thu, Dec 5, 10:55 AM · Okular
ahmadsamir added a comment to D25684: [core/*] replace foreach, deprecated, with range-for.

Please rebase your patch on current master, since it will fail to merge properly, i prefer you do the work and not me ^_^

Thu, Dec 5, 10:53 AM · Okular

Wed, Dec 4

aacid added a comment to D25684: [core/*] replace foreach, deprecated, with range-for.

Please rebase your patch on current master, since it will fail to merge properly, i prefer you do the work and not me ^_^

Wed, Dec 4, 10:30 PM · Okular
ahmadsamir added inline comments to D25684: [core/*] replace foreach, deprecated, with range-for.
Wed, Dec 4, 5:49 AM · Okular
ahmadsamir updated the diff for D25684: [core/*] replace foreach, deprecated, with range-for.

::distanceSqr() is going to be made const, so qAsConst isn't needed
It's cheaper to copy basic types than reference them
qAsConst isn't needed when iterating over member variable containers in const methods

Wed, Dec 4, 5:47 AM · Okular

Tue, Dec 3

aacid added a comment to D25684: [core/*] replace foreach, deprecated, with range-for.

Thanks for the patch!

Tue, Dec 3, 11:22 PM · Okular
bdbai abandoned D25484: Enable closing a tab by middle click.

Moved to https://invent.kde.org/kde/okular/merge_requests/69 .

Tue, Dec 3, 4:21 AM · Okular
ngraham added a comment to D25484: Enable closing a tab by middle click.

Since you've moved it over there, you can Abandon this from the Add Action... menu.

Tue, Dec 3, 3:12 AM · Okular
bdbai added a comment to D25484: Enable closing a tab by middle click.

An MR is drafted at invent, see https://invent.kde.org/kde/okular/merge_requests/69 .

Tue, Dec 3, 2:01 AM · Okular

Mon, Dec 2

steffenh added a comment to D21759: Hold zoom center below center/mouse position.

Yes, I have found this, if okular is build / using new poppler versions, but I don't know why. (poppler version poppler-0.77.0 and poppler-0.62.0 is working)

Mon, Dec 2, 6:35 PM · Okular
ngraham added a comment to D21759: Hold zoom center below center/mouse position.

Behaviorally this works great, but visually there's now a big regression: the content itself is no longer visible during the zoom operation; the view blanks out and displays the default white background.

Mon, Dec 2, 6:07 PM · Okular
ahmadsamir requested review of D25684: [core/*] replace foreach, deprecated, with range-for.
Mon, Dec 2, 2:58 PM · Okular
steffenh updated the diff for D21759: Hold zoom center below center/mouse position.

rebase

Mon, Dec 2, 1:28 PM · Okular

Sun, Dec 1

yurchor abandoned D25647: Set the default font family for EPub's according to the user preference.

Moved to gitlab.

Sun, Dec 1, 7:02 PM · Okular
ngraham added a comment to D25647: Set the default font family for EPub's according to the user preference.

Can you put this on invent instead?

Sun, Dec 1, 6:47 PM · Okular
yurchor updated the test plan for D25647: Set the default font family for EPub's according to the user preference.
Sun, Dec 1, 10:26 AM · Okular
yurchor requested review of D25647: Set the default font family for EPub's according to the user preference.
Sun, Dec 1, 10:23 AM · Okular

Sat, Nov 30

yegori added a comment to D25628: FEATURE: 414688 Add support for alternative scrolling method (prototype).

Hey Yegor, I like this idea.

Hi @davidhurka, thank you

Sat, Nov 30, 7:21 PM · Okular
davidhurka added a comment to D25628: FEATURE: 414688 Add support for alternative scrolling method (prototype).

Hey Yegor, I like this idea. I’m not sure what you mean with adding visual controls.

Sat, Nov 30, 6:25 PM · Okular
yegori updated the summary of D25628: FEATURE: 414688 Add support for alternative scrolling method (prototype).
Sat, Nov 30, 6:24 PM · Okular
ndavis added a comment to D25628: FEATURE: 414688 Add support for alternative scrolling method (prototype).

It took me a while to realize what the feature was, but now that I do, I might prefer to using it.

Sat, Nov 30, 3:47 PM · Okular
ndavis added a reviewer for D25628: FEATURE: 414688 Add support for alternative scrolling method (prototype): Okular.
Sat, Nov 30, 3:43 PM · Okular
yegori added a reviewer for D25628: FEATURE: 414688 Add support for alternative scrolling method (prototype): VDG.
Sat, Nov 30, 2:35 PM · Okular
yegori requested review of D25628: FEATURE: 414688 Add support for alternative scrolling method (prototype).
Sat, Nov 30, 2:35 PM · Okular
vkrause closed D25553: Port away from deprecated Bar|Desktop|SmallIcon methods.
Sat, Nov 30, 10:04 AM · Okular

Thu, Nov 28

aacid accepted D25553: Port away from deprecated Bar|Desktop|SmallIcon methods.
Thu, Nov 28, 10:01 PM · Okular
vkrause added a reviewer for D25553: Port away from deprecated Bar|Desktop|SmallIcon methods: aacid.
Thu, Nov 28, 6:22 PM · Okular

Wed, Nov 27

bdbai updated the diff for D25484: Enable closing a tab by middle click.

Fixed code styles

Wed, Nov 27, 12:26 AM · Okular

Tue, Nov 26

vkrause added a task to D25553: Port away from deprecated Bar|Desktop|SmallIcon methods: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API.
Tue, Nov 26, 5:57 PM · Okular
vkrause requested review of D25553: Port away from deprecated Bar|Desktop|SmallIcon methods.
Tue, Nov 26, 5:57 PM · Okular
ngraham added a comment to D25484: Enable closing a tab by middle click.

Thanks, this looks great. It works just fine and the UI seems sane to me. I have some code comments:

Tue, Nov 26, 5:34 PM · Okular
bdbai updated the diff for D25484: Enable closing a tab by middle click.
  • Added "undo tab close"
  • Added a test
Tue, Nov 26, 2:05 PM · Okular

Mon, Nov 25

ngraham added a comment to D25484: Enable closing a tab by middle click.

I think we can assume that, but check in the code. I don't think we necessarily need to save anything in memory except the URL for the document shown in the closed tab.

Mon, Nov 25, 5:39 PM · Okular
bdbai added a comment to D25484: Enable closing a tab by middle click.

Yes this helps the case that @pino brings up, but it handles a different use case. Most of the time a tab won't have unsaved changes because Okular is primarily a reading app. An "Undo last closed tab" feature is for these other cases.

Mon, Nov 25, 4:24 PM · Okular
ngraham added a comment to D25484: Enable closing a tab by middle click.
In D25484#566490, @pino wrote:

...

The solution to accidentally clicks is not disabling it by default and making it configurable, but providing the functionality to "restore" a tab after closing it accidentally. Dolphin and Chrome allow me to restore the last closed tab with Ctrl+Shift+T.

And this "solution" does not always work, for example when a page was the result of a form submission, redirection, or other kind of interactivity.

@ngraham In Okular, when a tab with unsaved changes is about to close, the user will be prompted first. Does this help?

Mon, Nov 25, 3:05 PM · Okular
bdbai added a comment to D25484: Enable closing a tab by middle click.
In D25484#566490, @pino wrote:

...

The solution to accidentally clicks is not disabling it by default and making it configurable, but providing the functionality to "restore" a tab after closing it accidentally. Dolphin and Chrome allow me to restore the last closed tab with Ctrl+Shift+T.

And this "solution" does not always work, for example when a page was the result of a form submission, redirection, or other kind of interactivity.

Mon, Nov 25, 8:16 AM · Okular
ngraham added a comment to D25484: Enable closing a tab by middle click.

The KDE Community is transitioning away from Phabricator and towards GitLab. The transition is not yet complete, which is why the documentation still points you towards Phab. Individual apps--such as Okular--have already made the jump as "early adopters", so to speak.

Mon, Nov 25, 5:32 AM · Okular
bdbai added a comment to D25484: Enable closing a tab by middle click.

...
Also please remember to use invent.kde.org and not phabricator for okular merge requests

Mon, Nov 25, 1:31 AM · Okular

Sun, Nov 24

aacid added a comment to D25484: Enable closing a tab by middle click.

As a sidenote i don't think this makes sense at all, but i don't think allowing tabs in okular makes sense either and i let them in so i'll just say it and then go back to my cave

Sun, Nov 24, 9:50 PM · Okular
aacid added a comment to D25484: Enable closing a tab by middle click.

Remember any UI change as this should have it's UI autotest to make sure things don't break in the future.

Sun, Nov 24, 9:50 PM · Okular