OkularProject
ActivePublic

Details

Description

KDE Document Viewer

Recent Activity

Today

simgunz added a comment to D15580: [WIP] New annotation toolbar.

Some thoughts:

  • Instead of using a horizontal toolbar below the main toolbar, instead I might experiment with a vertical toolbar like the one shown in Gwenview's View mode. We could make the toolbar live inside the Reviews tab, which already shows a list of all annotations (and then we should unify the terminology vis-a-vis "reviews" vs "annotations." REASON: cramming everything into a horizontal toolbar seems impossible for a feature this rich; using a vertical toolbar provides us enough horizontal space to show labels for everything, and enough vertical space to easily hold everything. Also we re-use an existing UI element that's currently rather bare.
Sun, Aug 18, 6:33 AM · Okular
simgunz updated the summary of D15580: [WIP] New annotation toolbar.
Sun, Aug 18, 6:28 AM · Okular

Yesterday

ngraham added a comment to D15580: [WIP] New annotation toolbar.

Some thoughts:

These thoughts sound good to me.

  • Show a button on the toolbar by default that holds the list of favorite annotations, [...] "Quick annotations". At the bottom of the list, add an entry that says something like, "Show advanced annotation settings" that will display the full vertical toolbar in the Reviews tab.

You mean a menu button in the main toolbar, with an entry that simply opens the Reviews tab? Or can the annotation toolbar itself be shown/hidden in the Reviews tab?

Sat, Aug 17, 7:35 PM · Okular
davidhurka added a comment to D15580: [WIP] New annotation toolbar.

Some thoughts:

Sat, Aug 17, 11:45 AM · Okular
ngraham added a comment to D15580: [WIP] New annotation toolbar.

Some thoughts:

  • Instead of using a horizontal toolbar below the main toolbar, instead I might experiment with a vertical toolbar like the one shown in Gwenview's View mode. We could make the toolbar live inside the Reviews tab, which appears to be somewhat mis-named and already shows a list of all annotations. REASON: cramming everything into a horizontal toolbar seems impossible for a feature this rich; using a vertical toolbar provides us enough horizontal space to show labels for everything, and enough vertical space to easily hold everything. Also we re-use an existing UI element that's currently rather bare.
Sat, Aug 17, 3:23 AM · Okular

Fri, Aug 16

ngraham added a comment to D15580: [WIP] New annotation toolbar.

Thanks, I was indeed not seeing the latest version. After deleting the necessary config files, I see the latest version in its own toolbar below the main one. This is a lot better than the current one already, but I think we can polish it even more. I have a lot of thoughts percolating and it may take me a few days to get them all written down. But I will do so soon!

Fri, Aug 16, 8:12 PM · Okular

Thu, Aug 15

aacid closed D23164: Improve testPrintD.
Thu, Aug 15, 3:08 PM · Okular
adridg requested review of D23164: Improve testPrintD.
Thu, Aug 15, 12:09 AM · Okular

Sun, Aug 11

aacid closed D13171: Add support for form text formatting.
Sun, Aug 11, 3:48 PM · Okular

Sat, Aug 10

nhiga added a comment to D23037: Add support for cb7 comic book archives.
Sat, Aug 10, 10:04 AM · Okular
jbbgameich closed D23066: mobile: app: Fix TableOfContents.
Sat, Aug 10, 9:58 AM · Okular
jbbgameich updated the diff for D23066: mobile: app: Fix TableOfContents.

squash local commits just to make sure everything is in the diff

Sat, Aug 10, 9:56 AM · Okular
aacid closed D23037: Add support for cb7 comic book archives.
Sat, Aug 10, 9:45 AM · Okular
aacid added a comment to D23037: Add support for cb7 comic book archives.

Git it. You could have used my non expired key http://hkps.pool.sks-keyservers.net/pks/lookup?op=get&search=0xCA262C6C83DE4D2FB28A332A3A6A4DB839EAA6D7

Sat, Aug 10, 9:41 AM · Okular
bshah accepted D23066: mobile: app: Fix TableOfContents.

Tested.

Sat, Aug 10, 9:28 AM · Okular
jbbgameich updated the test plan for D23066: mobile: app: Fix TableOfContents.
Sat, Aug 10, 8:38 AM · Okular
jbbgameich added a reviewer for D23066: mobile: app: Fix TableOfContents: Okular.
Sat, Aug 10, 8:37 AM · Okular
jbbgameich requested review of D23066: mobile: app: Fix TableOfContents.
Sat, Aug 10, 8:36 AM · Okular
nhiga added a comment to D23037: Add support for cb7 comic book archives.

@aacid Please check your email. I noticed that your public key (0x3A6A4DB839EAA6D7) seems to have expired, but I used that key to encrypt my message anyway.

Sat, Aug 10, 1:58 AM · Okular
aacid closed D23027: Add information about substituting font into properties dialog.
Sat, Aug 10, 12:04 AM · Okular

Fri, Aug 9

aacid accepted D23027: Add information about substituting font into properties dialog.

Looks, good, i'll commit a slightly modified version that checks substituteName != fontname too, wanted to save us all the roundtrip

Fri, Aug 9, 11:57 PM · Okular
aacid added a comment to D23037: Add support for cb7 comic book archives.

Works well, thanks a lot! Let's wait for Okular maintainer approval.

Fri, Aug 9, 11:53 PM · Okular
aacid added a comment to D22262: Thumbnails sidebar always open when okular starts.

Ok, let's see the code you have and tell us where it fails and we'll try to help :)

Fri, Aug 9, 11:43 PM · Okular
mayankchoudhary added a comment to D22262: Thumbnails sidebar always open when okular starts.

I want to use the mouse to click on the sidebar.

Fri, Aug 9, 5:13 PM · Okular
nhiga updated subscribers of D23037: Add support for cb7 comic book archives.

Sorry for the mess, I accidentally changed the status and subscriber list.

Fri, Aug 9, 9:49 AM · Okular
nhiga reclaimed D23037: Add support for cb7 comic book archives.
Fri, Aug 9, 7:59 AM · Okular
jgrulich updated the diff for D23027: Add information about substituting font into properties dialog.

Better use of i18nc API

Fri, Aug 9, 7:52 AM · Okular
pino added inline comments to D23027: Add information about substituting font into properties dialog.
Fri, Aug 9, 7:48 AM · Okular
pino added a comment to D23037: Add support for cb7 comic book archives.

why did you abandon this?

Fri, Aug 9, 7:47 AM · Okular
nhiga abandoned D23037: Add support for cb7 comic book archives.
Fri, Aug 9, 7:21 AM · Okular
nhiga updated the diff for D23037: Add support for cb7 comic book archives.
Fri, Aug 9, 7:21 AM · Okular
jgrulich updated the diff for D23027: Add information about substituting font into properties dialog.

Use translatable string

Fri, Aug 9, 7:10 AM · Okular
broulik added a comment to D23037: Add support for cb7 comic book archives.

Works well, thanks a lot! Let's wait for Okular maintainer approval.

Fri, Aug 9, 7:04 AM · Okular
nhiga updated the diff for D23037: Add support for cb7 comic book archives.
Fri, Aug 9, 7:02 AM · Okular
pino added inline comments to D23027: Add information about substituting font into properties dialog.
Fri, Aug 9, 6:56 AM · Okular
pino added a comment to D23037: Add support for cb7 comic book archives.

Please do not manually change translated keys in desktop files: there is an automatic system that takes care of them.

Fri, Aug 9, 6:55 AM · Okular
jgrulich updated the diff for D23027: Add information about substituting font into properties dialog.

Move information about substituting fonto into the first column

Fri, Aug 9, 3:41 AM · Okular
ngraham added a reviewer for D23037: Add support for cb7 comic book archives: aacid.
Fri, Aug 9, 3:00 AM · Okular
nhiga requested review of D23037: Add support for cb7 comic book archives.
Fri, Aug 9, 2:34 AM · Okular

Thu, Aug 8

aacid added a comment to D22262: Thumbnails sidebar always open when okular starts.

Why do you want to move the mouse?

Thu, Aug 8, 9:12 PM · Okular
ngraham added a comment to D23027: Add information about substituting font into properties dialog.

I agree, yeah.

Thu, Aug 8, 6:38 PM · Okular
aacid added a comment to D23027: Add information about substituting font into properties dialog.

I don't think it makes sense to have it in the third column, personally i think it'd make more sense in the first

Thu, Aug 8, 5:50 PM · Okular
jgrulich requested review of D23027: Add information about substituting font into properties dialog.
Thu, Aug 8, 10:10 AM · Okular

Wed, Aug 7

aacid closed D23012: Fix an incorrect text bounding rectangle calculation inside the sidebar.
Wed, Aug 7, 10:27 PM · Okular
aacid accepted D23012: Fix an incorrect text bounding rectangle calculation inside the sidebar.

meh, the two boundingRect returning different rects (even if documented) is sad.

Wed, Aug 7, 10:26 PM · Okular
AndreyYashkin requested review of D23012: Fix an incorrect text bounding rectangle calculation inside the sidebar.
Wed, Aug 7, 9:31 PM · Okular
aacid added a comment to D21635: Re-arrange selection tool order and shortcuts to reflect new arrangement.

Personally I don't really about the button order, what i care is about the shortcuts i've been using for 10 years not changing

Wed, Aug 7, 9:10 PM · Okular

Mon, Aug 5

simgunz added a comment to D15580: [WIP] New annotation toolbar.

For my own UI review, I must continue to push for putting the annotation tools on a second toolbar that appears below the main one when needed.

Mon, Aug 5, 10:50 AM · Okular
jbbgameich closed D22903: Improve search field.
Mon, Aug 5, 5:07 AM · Okular
apol accepted D22903: Improve search field.
Mon, Aug 5, 12:51 AM · Okular