KDE Document Viewer
Needs a rebase for sure
Wed, Dec 11
Is it me or this thing doesn't compile?
Mon, Dec 9
Created a pull request on invent.kde.org. https://invent.kde.org/kde/okular/merge_requests/73
Trying to land this diff I get these errors:
Sun, Dec 8
Sat, Dec 7
The class has the features needed for both D15580 and D21195 and I do not see evident bugs. For me, this revision is good enough for now, and in case we can fix it later (it used in few places so it should not be hard to adapt the code if needed).
Thu, Dec 5
Moved to GitLab: https://invent.kde.org/kde/okular/merge_requests/71
Sorry, this technical discussion is beyond me. :)
This was moved to invent at https://invent.kde.org/kde/okular/merge_requests/22
Wed, Dec 4
Please rebase your patch on current master, since it will fail to merge properly, i prefer you do the work and not me ^_^
::distanceSqr() is going to be made const, so qAsConst isn't needed
It's cheaper to copy basic types than reference them
qAsConst isn't needed when iterating over member variable containers in const methods
Tue, Dec 3
Thanks for the patch!
Since you've moved it over there, you can Abandon this from the Add Action... menu.
An MR is drafted at invent, see https://invent.kde.org/kde/okular/merge_requests/69 .
Mon, Dec 2
Yes, I have found this, if okular is build / using new poppler versions, but I don't know why. (poppler version poppler-0.77.0 and poppler-0.62.0 is working)
Behaviorally this works great, but visually there's now a big regression: the content itself is no longer visible during the zoom operation; the view blanks out and displays the default white background.
Sun, Dec 1
Moved to gitlab.
Can you put this on invent instead?
Sat, Nov 30
Hi @davidhurka, thank you
Hey Yegor, I like this idea. I’m not sure what you mean with adding visual controls.
It took me a while to realize what the feature was, but now that I do, I might prefer to using it.
Thu, Nov 28
Wed, Nov 27
Fixed code styles
Tue, Nov 26
Thanks, this looks great. It works just fine and the UI seems sane to me. I have some code comments:
- Added "undo tab close"
- Added a test
Mon, Nov 25
I think we can assume that, but check in the code. I don't think we necessarily need to save anything in memory except the URL for the document shown in the closed tab.
The KDE Community is transitioning away from Phabricator and towards GitLab. The transition is not yet complete, which is why the documentation still points you towards Phab. Individual apps--such as Okular--have already made the jump as "early adopters", so to speak.
Sun, Nov 24
As a sidenote i don't think this makes sense at all, but i don't think allowing tabs in okular makes sense either and i let them in so i'll just say it and then go back to my cave