KDE Document Viewer
Thu, Apr 18
Tue, Apr 16
You've already got my approval. :)
Mon, Apr 15
OK, let's go for it!
Sun, Apr 14
i have not tested it, if you think it works, i guess it's ok from the pure code point of view.
Ping on this.
Sat, Apr 13
Thanks for landing.
Fri, Apr 12
Out of deference to @aacid, I'll wait to commit this until the mailing list thread has come to a conclusion we can all agree with, or at least graciously accept without complaining about it later. :)
Thu, Apr 11
1000/60 yields a floating-point value. Is it acceptable that std::chrono::milliseconds can be a non-integer value?
Even more clear
Thanks! I am happy with these comments (except maybe that people may read the "/ 60 fps" in line 3770 as a division).
Oh, and by the way, the _actual_ speed of the page is set by how far you move the mouse outside the viewport, that constant really doesn't matter, it's only set to a nice value
As requested I explain what the "arbitrary constant" does
Well, before my patch the hardcoded constant was "100", (the time between each page update)
Now I put an universal constant there (16, as in milliseconds to create a 60fps animation), and moved the hardcoded constant elsewhere
Hi Kezi, I don't have a good answer to all that, I am just a bit distrustful regarding hard-coded constants like '6'. But I acknowledge that there are situations where they cannot be avoided.
How did you determine the value of the damping variable? You write
It's the first time after years and dozen of contributions to dozen of projects that I see such a fuss about my internet name
Wed, Apr 10
Still has a fake name attached to it?
Looks awesome. @aacid?
Selection scrolling look super cool.
- Try to convince him/her to provide a real name and re-open the discussion on a mailing list or phab task
- Gracefully accept a conclusion you don't agree with
- Throw away the contributions
Tue, Apr 9
I think this is fine.
@sander I have added you as reviewer and subscriber.