From the https://invent.kde.org/education/gcompris/-/commit/e01e7531546837e29ebb0439b11fa2376c05bac7, I merged the button part in https://invent.kde.org/education/gcompris/-/commit/71eebf64df14a95f54bb90a2679e88f5aeca3d29 to simplify the update next time (there are too many conflicts to rebase)
Mon, Sep 21
The formatting of the numbers is great now. Good work :)
I tested now. If works just as you said (both Enter/Return and Space are bound to the "OK" button). Thanks again :)
Sun, Sep 20
Excellent work. Thanks for consider my request and adding so many more restart/reset buttons :)
Done for land_safe, and so I changed a bit the layout of the osd and on-screen control buttons, it should be even better to use on mobile too.
I guess we can close this task as resolved.
Sat, Sep 19
Done for watercycle (and fixed a few little bugs on the way).
For land_safe, the activity settings button already overlap the gravity text in resized window, so I'll take a look to have the text always above the bar and then add the reload button.
Done for submarine, explore_* and play_piano.
Fri, Sep 18
Also, I forgot to say, we also need to change a few of the existing reload buttons:
So, after going through all the activities, I didn't see other activities that would really benefit from adding a reload button.
What I meant is generally I prefer to not add reload buttons to more activities than what we have already, to respect the choice of each activity's developper wether they wanted to have the reload button or not.
@timotheegiet, just to clarify, do you prefer to make a list of all the activities you'd prefer we add (or not add) the reload button? We can discuss it later via irc and put the result here if needed :)
Thu, Sep 17
Yes, the example I gave for chess 2players was just one example from a quick guess. But like I said in my next comment, it was surely done for a reason anyway.
For chess, I'm not sure if it was to not click by mistake when you play with someone else
All good points.
... also to complete my comment about chess 2player mode, as the reload button is specifically made to appear only at the end of the game, it confirms that it was intended to work this way for some reasons.
I would prefer to not add a restart button when it's not really necessary for using an activity.
Also, as a general rule, we should avoid having more than 4 buttons in the bar as much as possible as it makes the bar (and so the buttons) smaller on smartphone with vertical screen, especially if we have the levels buttons.
Wed, Sep 16
Sounds great. Thanks :)
And fixed in commit e66601933b9dd1c132bcf0efcd71dedeb864eac4 :-)
Fixed in commit 29e6b0a986a659104851d73e296a54ddcfab7289
OK, I'll add that yes.
Ah, yes, yes! Thanks. I am submitting too many bug reports!! ;)
Isn't it land safe instead of solar system?
I'll take a look :)
Yep, that is right. I am just recommending better formatting of numbers. No effect on the string freeze.
Thanks for the useful feedback!
Sun, Sep 13
Seems we can't load dataset in parallel as they are created via the QQmlEngine and it needs to create its data in its own thread
Sat, Sep 12
- first step, adding Loader for DialogChooseLevel in Menu.qml
Fri, Sep 11
Done for balancebox in commit ef73835399c3fb575a6a2f3a47bb61ac319d8b74 .
Thu, Sep 10
Only remains balancebox and piano compositon.
Wed, Sep 9
OK, I'll take a look.
Fixed in commit 5d132e4315c92a839fe690d2e9192ee953491a61
closing as Resolved.