Oct 6 2019
Because I am unsure if you can interrupt a loop in a different function, I tried to figure out what KIO does. KIO seems to have a tiny jungle of jobs calling subjobs telling workers to suspend, and eventually the whole thing ends up at ConnectionBackend, which seems (TCP) Socket based. (With a local and remote modes, much like our download jobs).
Oct 5 2019
Sep 29 2019
Apr 25 2019
That does indeed look good, and not a huge departure from what we have already, which i'm sure will make people feel quite at home in the new version :) I do wonder if we'd want to, at some point, make it look closer to Discover, but certainly for now this seems a much more sensible direction.
Will be good see how it looks in dark theme, especially dark pictures.
Apr 24 2019
Looks great, though I would put the search field on top. It's a lot like the new GridView KCMs; maybe we can even use that template for it. The current Colors KCM looks a lot like that.
@ngraham: Fo sure, I will add my post from the forum here for better reference.
Apr 23 2019
To show that a thumbnail is clickable, switching to the pointing hand cursor when hovering over a thumbnail could work.
LGTM on a technical level. On a visual level also +1 because I hate that drop shadow with a fierce passion.
+1 for the change to the large thumbnail, but I think the smaller thumbnails need something to show that they can be clicked.
Adding VDG because this is a visual change. To the visual commenters: This is intended as a first step, removing the old drop-shadow method (see also the related bug for a more severe version of that drop-shadow being shown very incorrectly). If we decide we do want a drop shadow, then that will want to be done separately. Note also that as we cannot guarantee the image will not have any translucent areas (which is the cause of the highly nasty look in the bug report, rather than just the basic nastiness shown in the screenshots here), we will need to do something considerably more clever than just putting a 9-slice drop image around the image (for example), which might well be a fair bit more expensive computationally than we'd probably want.
Attempt to use arcanist, hopefully with less data loss this time
Apr 22 2019
This patch doesn't apply:
Apr 20 2019
Mar 28 2019
Mar 27 2019
Just accept any informational status as benign, rather than the specifically picked ones.
And why are 101 and 102 bad?
Should we just accept between 100 and 200?
Mar 20 2019
We'll see I guess.
Mar 19 2019
Mar 18 2019
Thanks! Makes sense, and fixes the bug. :)
Copypasta error... thanks Nate :)
Mar 14 2019
Mar 13 2019
Works great, thanks.
Quick ping, be good to get this in sometime before it becomes late again... :)