KNewStuffProject
ActivePublic

Recent Activity

Oct 6 2019

woltherav added a comment to T11825: Suspend/Resume/Kill for knewstuff file jobs..

Because I am unsure if you can interrupt a loop in a different function, I tried to figure out what KIO does. KIO seems to have a tiny jungle of jobs calling subjobs telling workers to suspend, and eventually the whole thing ends up at ConnectionBackend, which seems (TCP) Socket based. (With a local and remote modes, much like our download jobs).

Oct 6 2019, 12:40 PM · KNewStuff

Oct 5 2019

woltherav triaged T11825: Suspend/Resume/Kill for knewstuff file jobs. as Wishlist priority.
Oct 5 2019, 4:48 PM · KNewStuff

Sep 29 2019

woltherav triaged T11803: OPDS support as Wishlist priority.
Sep 29 2019, 7:01 PM · KNewStuff

Apr 25 2019

leinir closed D20693: Remove pixelated border.
Apr 25 2019, 11:19 AM · Frameworks, KNewStuff
leinir added a comment to D20693: Remove pixelated border.

That does indeed look good, and not a huge departure from what we have already, which i'm sure will make people feel quite at home in the new version :) I do wonder if we'd want to, at some point, make it look closer to Discover, but certainly for now this seems a much more sensible direction.

Apr 25 2019, 10:45 AM · Frameworks, KNewStuff
anthonyfieroni added a comment to D20693: Remove pixelated border.

Will be good see how it looks in dark theme, especially dark pictures.

Apr 25 2019, 5:49 AM · Frameworks, KNewStuff

Apr 24 2019

ngraham added a comment to D20693: Remove pixelated border.

Looks great, though I would put the search field on top. It's a lot like the new GridView KCMs; maybe we can even use that template for it. The current Colors KCM looks a lot like that.

Apr 24 2019, 10:18 PM · Frameworks, KNewStuff
mmustac added a comment to D20693: Remove pixelated border.

@ngraham: Fo sure, I will add my post from the forum here for better reference.

Apr 24 2019, 7:57 PM · Frameworks, KNewStuff
ngraham accepted D20693: Remove pixelated border.

i'm afraid the "it works" is an illusion brought on by looking at content which doesn't show the issue... The main problem here is that we're dealing with user-generated content, and we can't assume that just because an image has a certain size, that space is actually filled with image data :/

Apr 24 2019, 4:10 PM · Frameworks, KNewStuff
leinir added a comment to D20693: Remove pixelated border.

To show that a thumbnail clickable, switching to the pointing hand cursor when hovering over a thumbnail could work.

However I notice that the actual list delegates in the browse view seem to add frames and shadows to the thumbnails there, and they look okay. The frame's proportions even perfectly match the aspect ratio of the thumbnail:

Why doesn't any of that work here?

Apr 24 2019, 8:31 AM · Frameworks, KNewStuff

Apr 23 2019

ngraham added a comment to D20693: Remove pixelated border.

To show that a thumbnail is clickable, switching to the pointing hand cursor when hovering over a thumbnail could work.

Apr 23 2019, 1:41 PM · Frameworks, KNewStuff
leinir added a comment to D20693: Remove pixelated border.

So yes, in principle i'd certainly like there to be some kind of background or outline to suggest clickability, but the current state (and any other generic rectangular background we might come up with, higher resolution or not) would yield the same suboptimal result...

QGraphicsDropShadowEffect via QWidget::setGraphicsEffect may work for that?

Another approach would likely be to write a custom blur implementation since we fiddle with qpainter anyway, TBH I think finding a way to use the effect is likely the wise use of time though.

Apr 23 2019, 11:03 AM · Frameworks, KNewStuff
sitter added a comment to D20693: Remove pixelated border.

So yes, in principle i'd certainly like there to be some kind of background or outline to suggest clickability, but the current state (and any other generic rectangular background we might come up with, higher resolution or not) would yield the same suboptimal result...

Apr 23 2019, 10:57 AM · Frameworks, KNewStuff
leinir added a comment to D20693: Remove pixelated border.

LGTM on a technical level. On a visual level also +1 because I hate that drop shadow with a fierce passion.

@leinir lxr says a similar thumb is also used for some of the KAboutPerson stuff in kxmlgui. it may be prudent to also remove the thumb there, I expect it looks equally dated.

Apr 23 2019, 10:56 AM · Frameworks, KNewStuff
sitter added a comment to D20693: Remove pixelated border.

LGTM on a technical level. On a visual level also +1 because I hate that drop shadow with a fierce passion.

Apr 23 2019, 10:39 AM · Frameworks, KNewStuff
leinir added a comment to D20693: Remove pixelated border.

+1 for the change to the large thumbnail, but I think the smaller thumbnails need something to show that they can be clicked.

Apr 23 2019, 9:52 AM · Frameworks, KNewStuff
ndavis added a comment to D20693: Remove pixelated border.

+1 for the change to the large thumbnail, but I think the smaller thumbnails need something to show that they can be clicked.

Apr 23 2019, 9:38 AM · Frameworks, KNewStuff
leinir added a reviewer for D20693: Remove pixelated border: VDG.

Adding VDG because this is a visual change. To the visual commenters: This is intended as a first step, removing the old drop-shadow method (see also the related bug for a more severe version of that drop-shadow being shown very incorrectly). If we decide we do want a drop shadow, then that will want to be done separately. Note also that as we cannot guarantee the image will not have any translucent areas (which is the cause of the highly nasty look in the bug report, rather than just the basic nastiness shown in the screenshots here), we will need to do something considerably more clever than just putting a 9-slice drop image around the image (for example), which might well be a fair bit more expensive computationally than we'd probably want.

Apr 23 2019, 8:02 AM · Frameworks, KNewStuff
leinir added a comment to D20693: Remove pixelated border.

Before patch:

Apr 23 2019, 7:30 AM · Frameworks, KNewStuff
leinir added a comment to D20693: Remove pixelated border.

This patch doesn't apply:

 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D20693.
Checking patch src/ui/imagepreviewwidget_p.h...
Checking patch src/ui/imagepreviewwidget.cpp...
Checking patch data/thumb_frame.png...
error: the patch applies to 'data/thumb_frame.png' (afaf432793864e1fb3f1fc27aa1d53689f2243b5), which does not match the current contents.
error: data/thumb_frame.png: patch does not apply
Checking patch data/CMakeLists.txt...
Applied patch src/ui/imagepreviewwidget_p.h cleanly.
Applied patch src/ui/imagepreviewwidget.cpp cleanly.
Applied patch data/CMakeLists.txt cleanly.

 Patch Failed! 
Usage Exception: Unable to apply patch!

Also it would be helpful if you used arc for your patches, since then you can see the context here in the web UI: https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

Apr 23 2019, 7:28 AM · Frameworks, KNewStuff
leinir updated the diff for D20693: Remove pixelated border.

Attempt to use arcanist, hopefully with less data loss this time

Apr 23 2019, 7:22 AM · Frameworks, KNewStuff

Apr 22 2019

ngraham added a comment to D20693: Remove pixelated border.

This patch doesn't apply:

Apr 22 2019, 1:48 PM · Frameworks, KNewStuff

Apr 20 2019

leinir requested review of D20693: Remove pixelated border.
Apr 20 2019, 8:42 AM · Frameworks, KNewStuff

Mar 28 2019

leinir closed D20077: Accept any HTTP status between 100 and 199 as benign.
Mar 28 2019, 10:58 AM · Frameworks, KNewStuff

Mar 27 2019

ngraham accepted D20077: Accept any HTTP status between 100 and 199 as benign.
Mar 27 2019, 4:56 PM · Frameworks, KNewStuff
apol added a comment to D20077: Accept any HTTP status between 100 and 199 as benign.

LGTM

Mar 27 2019, 12:31 PM · Frameworks, KNewStuff
leinir updated the diff for D20077: Accept any HTTP status between 100 and 199 as benign.

Just accept any informational status as benign, rather than the specifically picked ones.

Mar 27 2019, 12:12 PM · Frameworks, KNewStuff
leinir added a comment to D20077: Accept any HTTP status between 100 and 199 as benign.
In D20077#439290, @apol wrote:

And why are 101 and 102 bad?
Should we just accept between 100 and 200?

Mar 27 2019, 12:07 PM · Frameworks, KNewStuff
apol added a comment to D20077: Accept any HTTP status between 100 and 199 as benign.

And why are 101 and 102 bad?
Should we just accept between 100 and 200?

Mar 27 2019, 12:02 PM · Frameworks, KNewStuff
leinir requested review of D20077: Accept any HTTP status between 100 and 199 as benign.
Mar 27 2019, 11:11 AM · Frameworks, KNewStuff

Mar 20 2019

leinir closed D19917: Additions for ProviderManager documentation.
Mar 20 2019, 4:27 PM · Frameworks, KNewStuff
apol accepted D19917: Additions for ProviderManager documentation.

We'll see I guess.

Mar 20 2019, 4:26 PM · Frameworks, KNewStuff
leinir added inline comments to D19917: Additions for ProviderManager documentation.
Mar 20 2019, 4:04 PM · Frameworks, KNewStuff
apol added inline comments to D19917: Additions for ProviderManager documentation.
Mar 20 2019, 4:02 PM · Frameworks, KNewStuff
leinir requested review of D19917: Additions for ProviderManager documentation.
Mar 20 2019, 3:59 PM · Frameworks, KNewStuff

Mar 19 2019

leinir closed D19900: Set category on Attica entries.
Mar 19 2019, 9:54 PM · Frameworks, KNewStuff
apol accepted D19900: Set category on Attica entries.
Mar 19 2019, 9:52 PM · Frameworks, KNewStuff
leinir requested review of D19900: Set category on Attica entries.
Mar 19 2019, 9:02 PM · Frameworks, KNewStuff

Mar 18 2019

leinir closed D19858: Handle unsupported OCS commands, and don't over-vote.
Mar 18 2019, 3:44 PM · KNewStuff, Frameworks
leinir added a comment to D19858: Handle unsupported OCS commands, and don't over-vote.

Thanks! Makes sense, and fixes the bug. :)

Of course the underlying issue is still present. If you can't vote from the GHNS dialogs, there shouldn't be a UI for let you try; it should be strictly read-only. I suppose that's a separate matter though.

Mar 18 2019, 3:40 PM · KNewStuff, Frameworks
ngraham accepted D19858: Handle unsupported OCS commands, and don't over-vote.

Thanks! Makes sense, and fixes the bug. :)

Mar 18 2019, 3:34 PM · KNewStuff, Frameworks
leinir updated the diff for D19858: Handle unsupported OCS commands, and don't over-vote.

Copypasta error... thanks Nate :)

Mar 18 2019, 3:31 PM · KNewStuff, Frameworks
leinir added inline comments to D19858: Handle unsupported OCS commands, and don't over-vote.
Mar 18 2019, 3:30 PM · KNewStuff, Frameworks
ngraham added inline comments to D19858: Handle unsupported OCS commands, and don't over-vote.
Mar 18 2019, 3:29 PM · KNewStuff, Frameworks
leinir requested review of D19858: Handle unsupported OCS commands, and don't over-vote.
Mar 18 2019, 3:25 PM · KNewStuff, Frameworks

Mar 14 2019

leinir closed D19338: New location for KNSRC files.
Mar 14 2019, 10:14 AM · Frameworks, KNewStuff

Mar 13 2019

ngraham accepted D19338: New location for KNSRC files.

Works great, thanks.

Mar 13 2019, 4:13 PM · Frameworks, KNewStuff
apol accepted D19338: New location for KNSRC files.
Mar 13 2019, 2:36 PM · Frameworks, KNewStuff
leinir added a comment to D19338: New location for KNSRC files.

Quick ping, be good to get this in sometime before it becomes late again... :)

Mar 13 2019, 11:58 AM · Frameworks, KNewStuff

Mar 4 2019

leinir updated the diff for D19338: New location for KNSRC files.

Since 5.57, not 5.56

Mar 4 2019, 12:45 PM · Frameworks, KNewStuff