####################### akonadi-calendar commit 1ff4ca3a0c59b062dbe08dfde29b535179cb3932 Author: Glen Ditchfield Date: Mon Apr 26 01:01:16 2021 +0000 Remove some compilation warnings In practice, these functions' results are rarely used, and the "ignoring return value" warnings they cause are just noise. * They may return -1 if their argument is invalid, but that would indicate a logical error in the call chain. The caller can't be expected to handle it, and the function has already logged it. * They may return job IDs, for future reference. In practice, callers don't bother recording them. ####################### cantor commit 95fee6514672cabd3daa1f04aa646b948cb29aae Author: Stefan Gerlach Date: Fri Apr 23 12:52:27 2021 +0200 typo commit 39f5e2faf7dce569f51bbf7f266e62dbd27d0e00 Author: Stefan Gerlach Date: Fri Apr 23 12:40:27 2021 +0200 plugins: fix path to server on Windows ####################### dolphin commit 56888a567fc741713b6c905aeed3842a7fa230c7 Author: Harald Sitter Date: Mon Apr 19 12:39:00 2021 +0200 fix padding in places view padding was only applied when the icon size was applied, the icon size however is only applied when the user had set an explicit size. this resulted in inconsistent spacing. by default no padding would be used if the user had changed the icon size to medium and back to small it would suddenly have padding. to fix this, set padding unconditionally on construction and never touch it again . BUG: 435731 ####################### elisa commit 253a32f0fdbf68a1ef3b8b1f5d46cd87e823b5fa Author: Tranter Madi Date: Thu Apr 22 15:07:23 2021 +0000 Correct ContextView's footer - Elide/Align stuff properly - Make the "Show in Folder" action visible again commit c36a00c149a5117f7da4afeb4998ed60b76ce1f2 Author: Nate Graham Date: Thu Apr 22 08:59:12 2021 -0600 [ContextView] Fix visibility of "Show In Folder" button commit 4ecec1a59321bc918aedc28d416a7d295c53a573 Author: Tranter Madi Date: Fri Apr 16 11:25:15 2021 +0700 Make contextView's footer as tall as playlistView's one ####################### eventviews commit 6f9cb2674a9035a3f3becfcdc83a3ea84bc7450f Author: Glen Ditchfield Date: Wed May 5 19:53:57 2021 +0000 Tidy up TimelineView's interface, some day. commit 9b08cf3d721f84f9bdd2372f5427c1720d4af452 Author: Glen Ditchfield Date: Sat May 1 17:09:05 2021 +0000 Adjust layout and resizing of the timeline view If KOrganizer shows the agenda view when it launches, and then is switched to the timeline view, the timeline gives too much space to the calendar list and too little to the time grid. Also, when the main window is resized, the calendar list is not resized. This patch sets the initial panel sizes and resize behavour, which makes `splitterMoved()` redundant. commit 55d91c645ef3457148cff70d92a7a9a73373f169 Author: Glen Ditchfield Date: Sun Apr 25 22:28:17 2021 +0000 Initialize the view's preferences When `TimelineView::showDates()` attempts to get the user's preferred calendar colors, `preferences()` returns an empty object, and the view ends up using random colors for the time blocks. commit 57d3025b146bb9cd3bef2c6eaef77f4970361c1a Author: Glen Ditchfield Date: Wed Apr 21 23:26:43 2021 +0000 Don't crash if an agenda item is deleted while it is being moved When a recurring event is moved, a dialog box asks which instances to move. Apparently `mActionItem` can be set to null by asynchronous events while the dialog is up. BUG: 435352 ####################### ffmpegthumbs commit 26c1d3b790d621f89cf1cbf56bdc0b8c97a95151 Author: Weng Xuetian Date: Sun Apr 25 13:55:09 2021 -0700 Restore the compatiblity with ffmpeg 3. BUG: 430266 ####################### filelight commit 0db4a8c6b941800d0616e726ebf3f2e751f2293d Author: Andreas Sturmlechner Date: Sat Apr 24 11:34:46 2021 +0200 Hide kdoctools_install() behind KF5DocTools_FOUND conditional The dependency is optional in this package so the macro call must be too. Signed-off-by: Andreas Sturmlechner ####################### gwenview commit acf6a0b483d62699c2e05e9704a828d2ce4d491b Author: Daniel Novomesky Date: Sun May 2 20:51:04 2021 +0200 List image/avif among supported mimetypes ####################### itinerary commit c38db6a33bdbb89e976febf7834afcdec943149d Author: Volker Krause Date: Tue Apr 27 18:12:05 2021 +0200 Exclude kde5_xml_mimetypes.qm from the APK commit 0056160651d8910dc98cac6dff79eb8a9b463646 Author: Volker Krause Date: Mon Apr 26 20:06:38 2021 +0200 Wrap overly long event venue names ####################### kalarm commit d157febaf3d91ec917aa84d102cd943b49d4cb33 Author: David Jarvie Date: Thu May 6 00:26:35 2021 +0100 If time format is AM/PM, allow zero hours as intermediate value in time edits commit 7a2db4b7e909310632418364bd09faaaaff1f6a5 Author: David Jarvie Date: Thu May 6 00:14:10 2021 +0100 constify commit 6992238a3bb1dc51e72f2d057f58524cc06ac876 Author: David Jarvie Date: Wed May 5 23:36:29 2021 +0100 Bug 436558: In alarm edit dialog, enable OK button when date is edited commit a70a2aea022840b52967b710ba202af3a020b661 Author: David Jarvie Date: Mon May 3 00:56:20 2021 +0100 Bug 436434: Fix date sometimes being hidden for selected alarms In the alarm list, when an alarm's time has a single digit hour, its date was hidden when it was selected/highlighted. commit 093949ddb6a037e27813493c7ad86e74bfcc14b1 Author: David Jarvie Date: Sun May 2 18:03:12 2021 +0100 Bug 436434: In alarm list, don't hide display alarm colour for selected alarms ####################### kate commit 83ec5582204d547bde2fb84526270ff9b1aa4db9 Author: Waqar Ahmed Date: Thu May 6 23:48:17 2021 +0500 Fix possible leak when commiting (cherry picked from commit 089814956625d80f097fed7722ce3f72bc4afbb8) commit 3a7d17f556c65d561d19b4354b5133c5d8c0c14d Author: Waqar Ahmed Date: Wed May 5 16:29:25 2021 +0500 Fix branch change not reflected if projectbase != dotGit Branch change isn't reflected in the UI if project base dir is different from dot git path. This is different from master which uses `std::optional` Signed-off-by: Waqar Ahmed commit 736d437953f459df521fc225893e74d038dcf9af Author: Christoph Cullmann Date: Thu May 6 15:56:19 2021 +0000 Revert "Fix branch change not reflected if projectbase != dotGit" This reverts commit 2dfc012862ac2b9fa7e2b88a6efb266961b58271 commit f216e2664bd64f75874354fdf5091822a0d4e776 Author: Christoph Cullmann Date: Thu May 6 15:56:07 2021 +0000 Revert "[addons/project/git/gitutils] Add missing include optional to make bsd happy" This reverts commit 319f39ef41fe41defc47a5f9cc548d9e872ac61e commit 319f39ef41fe41defc47a5f9cc548d9e872ac61e Author: Ömer Fadıl Usta Date: Thu May 6 01:47:01 2021 +0000 [addons/project/git/gitutils] Add missing include optional to make bsd happy (cherry picked from commit 5df5a9c4856dbdc1c652c68a26039b9f7ab4bcd2) commit 2dfc012862ac2b9fa7e2b88a6efb266961b58271 Author: Waqar Ahmed Date: Wed May 5 16:29:25 2021 +0500 Fix branch change not reflected if projectbase != dotGit Branch change isn't reflected in the UI if project base dir is different from dot git path. Signed-off-by: Waqar Ahmed (cherry picked from commit c7bd9acb389cbd687a90b4e1dfb0ad3fc2bad28a) commit 2f3da2ca0e3f829163b17b6d7f5f5d423a1b610f Author: Waqar Ahmed Date: Mon May 3 18:32:02 2021 +0500 git: Don't report error if git not found (cherry picked from commit fd6201e3c076dac5ababf71c6feac1a6e09fbbf4) commit 144dab9446e0c8adabcdc859a219c9add62f7543 Author: Waqar Ahmed Date: Sun May 2 15:52:13 2021 +0500 Fix changing branch doesn't update the branch button Signed-off-by: Waqar Ahmed (cherry picked from commit 8bbf212d08a1d45c3d97c915539deb0f238b402a) commit e9ff4c923c1a57765b2e16043f06cc9205e42bd9 Author: Waqar Ahmed Date: Tue Apr 27 15:47:10 2021 +0500 Try to fix of a rare crash with Ctrl + Click in LSP With Ctrl + Click kate sometimes crashes. I have been trying to reproduce this issue but have been unlucky so far. The problem seems to be a stale widget to me, so this will hopefully take care of the issue. Signed-off-by: Waqar Ahmed (cherry picked from commit 321e1c26b51de85f29ff80ddfdcc7a7c63baf15b) commit e4a8ec025580b0f1f0ec97192538a0584c3b8118 Author: Christoph Cullmann Date: Thu Apr 29 23:16:31 2021 +0200 show new mascot in about dialog (cherry picked from commit 18c51d386f703df923ea6fff4b925d37c043e709) commit 5823df3ec2394c1431f179ddbd730cdf3d986aa2 Author: Waqar Ahmed Date: Wed Apr 21 18:21:27 2021 +0500 Html escape lsptooltip text This is necessary as text like std::vector can break the tooltip very easily. Signed-off-by: Waqar Ahmed (cherry picked from commit 9d83ff8f49773e472b77ddf72e4b9bf02ac00b06) commit ae0bd0fd387145a4a44d2521e0b456f38b8d4ebe Author: Waqar Ahmed Date: Tue Apr 20 20:22:36 2021 +0500 Downgrade .git not found warning to info message BUG: 435945 Signed-off-by: Waqar Ahmed (cherry picked from commit 42ce4852c25c8c8d8524316c6f1f915c835d8108) ####################### kblocks commit 01fee40dfe11a69b0cc435378115fd94fec5eea6 Author: Jonathan Riddell Date: Wed Apr 28 11:31:02 2021 +0100 packaging in app repos has been rejected ####################### kdenlive commit 3ed0dbf11a251e19a74d717ae1161594e395d61d Author: Julius Künzel Date: Mon May 10 18:11:30 2021 +0200 Invalidate preview render on subtitle actions BUG: 435692 Related to #973 commit 5511f780a3cc525a811ca52b07464a1dfa85a422 Author: Julius Künzel Date: Sun May 9 23:24:39 2021 +0200 Fix timecode validation on settings dialog commit 75c3f0044b01e41d3adadbc75686cf57eba73d89 Author: Jean-Baptiste Mardelle Date: Fri Apr 30 11:47:07 2021 +0200 Fix proxied clip cannot be dragged from monitor to timeline. Fixes #1052 commit efab200479a9126efa2f0291f07e58a59b959fdb Author: Jean-Baptiste Mardelle Date: Fri Apr 30 07:49:09 2021 +0200 Fix incorrect speed cycling with j/l keys commit 27ef1e4d973ee1ca5c2948742a34f8e641c2cffe Author: Jean-Baptiste Mardelle Date: Wed Apr 28 11:18:11 2021 +0200 Ensure render widget is displayed again after being minimized commit 1e2494bb7b0160acc89fb31c74e6b48099b0d8f6 Author: Jean-Baptiste Mardelle Date: Wed Apr 28 10:10:46 2021 +0200 Fix playback speed not reset on pause commit 43e78433d23a61f3d38f93d53052e894d91bf111 Author: Julius Künzel Date: Mon Apr 26 16:42:30 2021 +0200 Update effect zones on effect deletion commit 4c668d8ccc0f407485deff813b63caefb68f33ff Author: Julius Künzel Date: Mon Apr 26 12:32:31 2021 +0200 Render presets: load default values properly to ui CCBUG: 421174 commit f559aa5d3351e59ddbd1ddf7eb8a32929d0179ff Author: Jean-Baptiste Mardelle Date: Mon Apr 26 08:20:18 2021 +0200 Fix spacer tool not workin on single clips (without groups) commit 232c1753d570f1f3f4b6f082e0297bd33c13031b Author: Julius Künzel Date: Mon Apr 26 01:40:55 2021 +0200 Improve naming of newely created profile BUG: 385981 commit 05f3314d59f9f94e947a9c0778da55c518a00fad Author: Julius Künzel Date: Mon Apr 26 01:21:01 2021 +0200 Archiver: Fix more bugs and crashes CCBUG: 432206 commit 62808fae1fe9ab294930909eead704a905e31e53 Author: Julius Künzel Date: Sun Apr 25 20:15:58 2021 +0200 Archiver: Block UI while job is running Related to #999 commit 3addc5fbf4f5f79bb17d6a8852c084efc96c30a8 Author: Julius Künzel Date: Sun Apr 25 19:58:22 2021 +0200 Archiver: Don't miss lumas,... on "timline only" mode, prettify code commit 80dc8d4e7afeaa24fac4cfc45cc219919ecd3eca Author: Julius Künzel Date: Sun Apr 25 17:36:11 2021 +0200 Fix several archiving issues with mlt files BUG: 435882 Related to #973 commit 03c0112172cbfa7fa43345e912de833f565decdd Author: Julius Künzel Date: Sun Apr 25 01:45:58 2021 +0200 Archive LUT files too commit e485c3ce74af3f14aba2d0368038324fd8335c59 Author: Julius Künzel Date: Sat Apr 17 11:35:23 2021 +0200 appimage: use mlt v6 branch ####################### kdepim-addons commit 2300b8fd9d9111fea248e7a1e1d2edf015a0002b Author: Volker Krause Date: Mon May 10 17:42:48 2021 +0200 Fix country field in address-based OSM map links commit 8ca8e8a2ff13f4db1c56de6002cd914da4c9a368 Author: Volker Krause Date: Mon May 10 17:41:55 2021 +0200 Add missing closing bold tag for canceled hotel reservations commit d2e97e9a0ae07c6ec297aca3cfff7ddb4e14e924 Author: Laurent Montel Date: Tue Apr 20 13:39:04 2021 +0200 Remove dead url ####################### kig commit 17c398d9eebfe81e601d37f29eee284e060f060f Author: Albert Astals Cid Date: Sun May 2 17:41:46 2021 +0200 Fix build in C++17 mode I think it's a bug, but now sure if of libstdc++ or the spec, have opened https://gcc.gnu.org/bugzilla/show_bug.cgi?id=100384 for the gcc people to comment on ####################### kio-extras commit 80b3335302a790803999a501b0c5cce8ba0d6177 Author: Antonio Rojas Date: Fri Apr 23 22:16:11 2021 +0200 Support building with OpenEXR 3 Try to find OpenEXR 3 first using the upstream cmake config, and fall back to using our FindOpenEXR ####################### kitinerary commit 0a61bfb8610e7ece23d9e4a7659db74bd4cb9075 Author: Volker Krause Date: Mon May 10 17:58:36 2021 +0200 Detect booking.com cancelations commit ece5df2b133fab8fc7593ee5c27fb1d5ead6c3c4 Author: Volker Krause Date: Thu May 6 17:44:54 2021 +0200 Handle more variants of NH hotel booking confirmation emails ####################### kldap commit d4b3b521cc398d85340075d99a2bf6964f13b544 Author: Andreas Sturmlechner Date: Sat Apr 24 11:38:58 2021 +0200 Hide kdoctools_install() behind KF5DocTools_FOUND conditional The dependency is optional in this package so the macro call must be too. Signed-off-by: Andreas Sturmlechner ####################### klickety commit 41a4acd66aa486f5a32f278f84688e90f91b05be Author: Friedrich W. H. Kossebau Date: Tue Apr 27 00:37:35 2021 +0200 Fix "New Game" action always generating a game for value 0 SLOT(newGame()) was hiding to the bad-eyed porting developer that actually a default -1 argument was passed in this case, as newGame(int) was taking an int, not no argument. Connecting to method pointer QAction::triggered(bool) would now have int(false) == 0 passed every time. ####################### kmahjongg commit 2a34cab6a57cc2d4f4417df714e1ee176f38b09f Author: Friedrich W. H. Kossebau Date: Mon Apr 26 22:10:02 2021 +0200 Fix "New Game" action always generating a game for value 0 SLOT(startNewGame()) was hiding to the bad-eyed porting developer that actually a default -1 argument was passed in this case, as startNewGame(int) was taking an int, not no argument. Connecting to method pointer QAction::triggered(bool) would now have int(false) == 0 passed every time. ####################### kmail commit fd28ed2c84d58b95a40377401cff1a82c81bf24b Author: Laurent Montel Date: Fri May 7 07:14:37 2021 +0200 Add mailing_list in messagelist view menu too commit 99c484d2992760405110c6fc014231b1da29212f Author: Laurent Montel Date: Fri Apr 30 08:57:43 2021 +0200 Fix Bug 436375 - "Editing as new" selects the wrong transport BUG: 436375 FIXED-IN: 5.17.1 ####################### konsole commit ba9a21090c6985bfc652afb2e79c19b4ed77d6fb Author: Carlos Alves Date: Wed May 5 06:43:41 2021 -0300 Fix Screen::_cuY position inside screen Keep _cuY position inside max screen lines in AppScreen mode. (cherry picked from commit 7b2a751b301f4066fc392c0041d3163813f4fa10) commit 7b769ff141e9d0f081e81fdf31f2bf44a5849af4 Author: Carlos Alves Date: Sat May 1 12:56:40 2021 -0300 Fix crash showing Settings Dialog When you open settings and close it, than open a new window, than close the old window, the MainWindow with the settings will delete the configDialog. If you try to open settings againg it crashes. Fix is each MainWindow now has its own configDialog. BUG: 436366 (cherry picked from commit 49692c0f14230781b1fa48332ff9e334c1b1f997) commit d7f3fec79d08a74ff66fff0da0c5f92e727cdcb4 Author: Kurt Hindenburg Date: Fri Apr 30 17:07:13 2021 -0400 Add missing include to fix build on gcc-11 (cherry picked from commit 242213afd9eb9886e04eb9e6e69a4caa9c606363) commit ed2a9a9e3c3e69f4611c61716f51bb7dc3f5e11f Author: Carlos Alves Date: Thu Apr 29 15:02:29 2021 -0300 Make CompactHistoryBlock size variable (v21.04.0) When needed CompactHistoryBlock can now increase from 256kb to a bigger size. BUG: 436031 commit 2b441030a745a17f76d8f010a299a74532e3f211 Author: Jan Blackquill Date: Fri Apr 23 18:09:41 2021 -0400 Use inverted colours when calculated fancy BG has too low contrast BUG: 435309 (cherry picked from commit 9f7cb32dc23246783d5a72164a37e82f4268bc58) ####################### korganizer commit 3c21cacce232f9f07b74470fbb6eb221aac82788 Author: Glen Ditchfield Date: Thu May 6 21:19:45 2021 +0000 Clazy warning: container inside loop commit 3a388a6e01dccf069416440448d7a8b349f25de2 Author: Glen Ditchfield Date: Wed May 5 01:57:25 2021 +0000 Replace some SIGNAL and SLOT macros commit 83f86296e0eb9d29675bbc31956107dd00b268e8 Author: Glen Ditchfield Date: Tue May 4 22:37:21 2021 +0000 Replace some SLOT macros commit e78a4ea649e8adbe2187d9248794c26855580c92 Author: Glen Ditchfield Date: Tue May 4 22:07:13 2021 +0000 Replace some SIGNAL macros commit b9c0ac2d500d23f48f5c1e7e030503f8fe3a02d8 Author: Glen Ditchfield Date: Tue May 4 21:54:44 2021 +0000 Replace some SIGNAL macros commit 5e85652cbf08e63064c6b143f7166efa5e515f7a Author: Glen Ditchfield Date: Tue May 4 21:37:07 2021 +0000 Replace some SIGNAL macros commit 66a2fe53903eb6c69ccb2361415470f02f302d18 Author: Glen Ditchfield Date: Tue May 4 21:09:08 2021 +0000 Replace some SIGNAL macros commit 3bd22dd4c80f9fea7d5594b9e94287aca3d3b457 Author: Glen Ditchfield Date: Tue May 4 19:53:16 2021 +0000 Replace some SIGNAL macros commit 0d67cdcc465366a43938a60c246c353c3878ba99 Author: Glen Ditchfield Date: Tue May 4 18:43:22 2021 +0000 Replace some SIGNAL macros commit c1814d2fc7c4001b45dd4b9df28a5c3a3fd1644b Author: Glen Ditchfield Date: Tue May 4 16:54:38 2021 +0000 Replace some SIGNAL macros commit 530ac630343b5f32b8d87b29cd9e7abcf154f2ba Author: Glen Ditchfield Date: Tue May 4 16:30:25 2021 +0000 Replace some SIGNAL macros commit bd675eaa538b442252e1046719537677861f3d16 Author: Glen Ditchfield Date: Mon May 3 21:50:04 2021 +0000 Replace some SIGNAL and SLOT macros commit a67b02d36f01369fd264df400c27192e47bd4d75 Author: Glen Ditchfield Date: Mon May 3 18:26:54 2021 +0000 Replace some SIGNAL and SLOT macros commit 05f2446f79b6e5cb0cb5df415be3497e0a8005b8 Author: Glen Ditchfield Date: Sun May 2 22:57:41 2021 +0000 Replace some SIGNAL and SLOT macros Note: `connectEditor()` is never called, and the signals it attempts to connect do not exist. commit 56502d733630e04bd8e2a0fbf512f31082fbdb96 Author: Glen Ditchfield Date: Sun Apr 25 22:43:52 2021 +0000 Initialize the timeline view's preferences When TimelineView attempts to get the user's preferred calendar colors, it uses an empty preferences object, and the view ends up using random colors for the time blocks. commit f35980ab9b5e25f3ab1d322349cbb338a41cf5a9 Author: Glen Ditchfield Date: Thu Apr 15 17:24:16 2021 +0000 Fix some compiler warnings These changes match the changes to the master branch in commit de11c043. ####################### kpat commit 638d8c2c6b47054bcf3deece3b065ac5c2fb01d8 Author: Michael Lang Date: Thu Apr 29 13:17:02 2021 -0600 Fix ace auto move crash Ace foundation auto moves were crashing after the game type was changed. Now removing PatPile before removing Pile during game type change. BUG: 436181 (cherry picked from commit d2372a8c2449aee6568148cf8b03bd8acd9aa025) commit 428375cd2780eb00883b268d470a6e366040f70f Author: Michael Lang Date: Sat Apr 24 21:57:35 2021 -0600 fix unitialized value sometimes causing solver to exit and report game as unsolvable (cherry picked from commit b5ca2391dc1e0013bb1d323b7f7b4b8292903c98) ####################### kpublictransport commit c852745020325131860b0f2a7dffcad5e30ae5cd Author: Heiko Becker Date: Tue Mar 30 17:25:07 2021 +0200 Fix cmake policy CMP0115 warning (cherry picked from commit fb190c78903ddab1da85f43e708b2db940c5cd7d) ####################### mailcommon commit a91ee8b0a7338e25e87c93940997aa1861537a0a Author: Laurent Montel Date: Fri May 7 07:01:38 2021 +0200 Fix Bug 436687 - Folder Properties Dialog is broken FIXED-IN: 5.17.2 BUG: 436687 ####################### messagelib commit 3b5b171e91ce78b966c98b1292a1bcbc8d984799 Author: Ingo Klöcker Date: Thu Apr 29 22:13:38 2021 +0200 Fix CVE-2021-31855 Deleting an attachment of a decrypted encrypted message stored on a remote server (e.g. an IMAP server) causes KMail to upload the decrypted content of the message to the remote server. This is not easily noticeable by the user because KMail does not display the decrypted content. commit 99b50c22b0e6ab37c100ba1e2e18218c11fa7e3c Author: Kevin Funk Date: Mon Apr 26 16:11:57 2021 +0200 Minor: Fix compiler warning Q_UNUSED_RESULT on void return type doesn't make sense ####################### okular commit be1f0de1960bc2e6c3c5f698562c49e01701a003 Author: Albert Astals Cid Date: Fri May 7 20:17:13 2021 +0200 try to stabilize test commit 72658e0ec389338baccd78af97183427e247636a Author: Albert Astals Cid Date: Thu May 6 23:07:57 2021 +0200 Fix saving signed revisions of a signature We don't need a QDataStream to assign a QByteArray to a QByteArray, and it was adding some noise at the beginning which is clearly not what we want commit f6b58ed804b70a953888f3c009c9fd351fb4c913 Author: Gerd Wachsmuth Date: Thu Apr 1 13:22:10 2021 +0200 Fix bug: select browse tool after trim select commit 61551d2356ea5f93ba3e921a1c4ab9cca88fdbda Author: Gerd Wachsmuth Date: Thu Apr 1 11:58:53 2021 +0200 Fix: Viewport coords normalized w.r.t. full page The coordinates in Viewport.rePos are normalized on the full page. In two functions within pageview.cpp, these were treated as coordinates on the cropped page. CCBUG: 198427 This partially fixes the bug 198427 in the case that the cropping of the target pages (and the pages around the target) is known at the time the link is clicked. That is, it works if - One uses 'Trim To Selection' - One uses 'Trim To Margin' and has already viewed at the target page(s). In the case that the cropping of the page at the target is unknown, we still end up at the wrong position. ####################### palapeli commit 30ff07fd12c0767ed033e71d2226053115963401 Author: Andreas Sturmlechner Date: Sat Apr 24 18:34:37 2021 +0200 Drop bogus Qt5::Concurrent from target_link_libraries BUG: 436132 Signed-off-by: Andreas Sturmlechner ####################### pimcommon commit a0d5b0e1536cf9a887e8b321a64de225588e33c6 Author: Laurent Montel Date: Mon Apr 26 13:34:38 2021 +0200 Use correct config name ####################### umbrello commit 7d3eb053739413a0eef8c111e0c9a41843227cf2 Author: Oliver Kellogg Date: Sun May 9 17:47:12 2021 +0200 Fix crash reported in https://bugs.kde.org/show_bug.cgi?id=338649#c20 related to multiple calls of m_source.unicode() where the calls return different address values. The solution is to call m_source.unicode() only once: lib/cppparser/lexer.h - In class Lexer add private member m_src of type const QChar*. lib/cppparser/lexer.cpp - In function Lexer::setSource, - assign m_source.unicode() to m_src; - if m_source.isEmpty() returns true then return without calling tokenize(). - In function Lexer::reset initialize m_src to null pointer. - In function Lexer::offset return m_src + offset. - In function Lexer::getOffset use m_src in lieu of src. This avoids the second call to m_source.unicode() which on newer Qt5 versions may return a different buffer. CCBUG: 338649 commit 4cea2f59e6b62bd0fd5686b4747fef5acbb3fbf0 Author: Oliver Kellogg Date: Sun May 9 17:21:32 2021 +0200 lib/cppparser/lexer.{h,cpp} cosmetics and error detection improvement: - Move function bodies from header file to implementation file. - Token::Token(const QString & text) - Token::Token(int type, int position, int length, const QString& txt) - Token::Token(const Token& source) - Token& Token::operator = (const Token& source) - Token::operator int () const - bool Token::operator == (const Token& token) const - bool Token::isNull() const - int Token::type() const - void Token::setType(int type) - int Token::position() const - QString Token::text() const - void Token::setStartPosition(int line, int column) - void Token::setEndPosition(int line, int column) - void Token::getStartPosition(int* line, int* column) const - void Token::getEndPosition(int* line, int* column) const - void Token::setPosition(int position) - unsigned int Token::length() const - void Token::setLength(unsigned int length) - const CHARTYPE* Lexer::offset(int offset) const - int Lexer::getOffset(const QChar* p) const - Lexer::readWhiteSpaces(bool skipNewLine, bool skipOnlyOnce) - bool Lexer::recordComments() const - void Lexer::setRecordComments(bool record) - bool Lexer::recordWhiteSpaces() const - void Lexer::setRecordWhiteSpaces(bool record) - QString Lexer::source() const - int Lexer::index() const - void Lexer::setIndex(int index) - const Token& Lexer::nextToken() - const Token& Lexer::tokenAt(int n) const - const Token& Lexer::lookAhead(int n) const - int Lexer::tokenPosition(const Token& token) const - void Lexer::nextChar() - void Lexer::nextChar(int n) - void Lexer::readIdentifier() - bool isTodo(const QString& txt, int position); static in cpp file - bool isFixme(const QString& txt, int position); static in cpp file - void Lexer::readLineComment() - void Lexer::readMultiLineComment() - void Lexer::readCharLiteral() - void Lexer::readStringLiteral() - void Lexer::readNumberLiteral() - int Lexer::findOperator3() const - int Lexer::findOperator2() const - bool Lexer::skipWordsEnabled() const - void Lexer::setSkipWordsEnabled(bool enabled) - bool Lexer::preprocessorEnabled() const - void Lexer::setPreprocessorEnabled(bool enabled) - int Lexer::currentPosition() const - const QChar Lexer::currentChar() const - QChar Lexer::peekChar(int n) const - bool Lexer::eof() const - bool Lexer::reportWarnings() const - void Lexer::setReportWarnings(bool enable) - bool Lexer::reportMessages() const - void Lexer::setReportMessages(bool enable) - void Lexer::insertCurrent(const QString& str) - At Lexer function readWhiteSpaces(bool skipNewLine=true, bool skipOnlyOnce=false) change return type from void to bool, return false on EOF. lib/cppparser/lexer.cpp - In Lexer::nextChar functions return immediately if m_ptr is beyond m_endPtr. - In Lexer::readLineComment() break out of while-loop if currentPosition() returns error. - In Lexer::readMultiLineComment() break out of while-loop if currentPosition() returns error. - In Lexer::readCharLiteral() while-loop add safety check that currentPosition() returns valid position. - In Lexer::readStringLiteral() while-loop add safety check that currentPosition() returns valid position. - In Lexer functions findOperator3, findOperator2, insertCurrent add initial check that currentPosition() returns valid position. - In Lexer function getOffset return -1 for error (argument `p' out of range of `src'). - In Lexer function nextToken, - return immediately if readWhiteSpaces() returns error; - return immediately if currentPosition() returns error. - In Lexer::tokenize() replace "for (;;)" loop by "while (currentPosition() >= 0)". - In Lexer::readArgument() return empty string if readWhiteSpaces() returns error. - In Lexer functions macroDefined, processDefine, processInclude, macroPrimary, - return 0 if readWhiteSpaces() returns error; - return 0 if currentPosition() returns error. - In Lexer::macroMultiplyDivide() replace "for (;;)" loop by "while (readWhiteSpaces(false))". - In Lexer functions macroAddSubtract, macroRelational, macroEquality, macroBoolAnd, macroBoolXor, macroBoolOr, macroLogicalAnd, macroLogicalOr return result immediately if readWhiteSpaces() returns error. - In Lexer::macroExpression() return 0 if readWhiteSpaces() returns error. commit af296cce784d6e169bce3022b6ed135b5db1353b Author: Oliver Kellogg Date: Sun May 9 16:08:12 2021 +0200 lib/cppparser/driver.cpp cosmetics in class Driver::ParseHelper : - At constructor insert linebreaks in member initializer list to avoid overlong line. - Factor constructor body into separate function init(). Reason: Constructors shall be light weight to remove risk of calls before end of construction not acting as expected (dynamic dispatch will only work on fully constructed objects). - In order to do this, add member variables for use in the init function: - bool m_reportMessages (assigned from ctor arg reportMessages); - QString m_includedFrom (assigned from ctor arg includedFrom). - Add member QString m_fileContent to capture return value from m_driver->sourceProvider()->contents(m_fileName) to remove risk of temporary QString object premature deconstruction at call to m_lex.setSource(). - In Driver functions addDependence and parseFile call init() on local variable of type ParseHelper. commit 464c7132349e4cf10a84fc9e6f3792087a934158 Author: Oliver Kellogg Date: Fri Apr 30 21:11:26 2021 +0200 Support C++11 "enum class" in C++ Import: lib/cppparser/ast.{h,cpp} class EnumSpecifierAST - Add functions setClass, isClass accessing new member m_isClass of type bool. - Add functions setEnumBase, enumBase accessing new member m_enumBase of type TypeSpecifierAST::Node. lib/cppparser/parser.cpp function parseEnumSpecifier - Add bool isClass initialized to false. - After consuming Token_enum add int tk initialized to m_lexer->lookAhead(0). - If tk is Token_class or Token_struct then set isClass true and call nextToken(). - After call to parseName(name) add variable enumBase of type TypeSpecifierAST::Node. - If m_lexer->lookAhead(0) is ':' then call nextToken() followed by parseSimpleTypeSpecifier(enumBase). - Reassign tk from m_lexer->lookAhead(0) and permit only ';' or '{' as its value. - Remove call to nextToken(), it is postponed to after the assignments to `ast'. - At assignments to `ast' call ast->setClass(isClass) and ast->setEnumBase(enumBase). test/import/cxx/cxx11-strongly-typed-enumerations.h - Rename second definition of Enum2,Enum3 to Enum4,Enum5 to avoid overlap. CCBUG: 338649 commit dd912a2df31b1179b3eb4d6b706a1bf6d9aa5d26 Author: Oliver Kellogg Date: Wed Apr 28 23:54:32 2021 +0200 Compile on Qt4: QStringLiteral -> QLatin1String commit 24f19c94137ceb6e6a04540dcdd5d1dfaa66d59e Author: Oliver Kellogg Date: Sun Apr 25 18:13:56 2021 +0200 lib/cppparser/README - Update of cpp parser to kdevelop's version 3.5 parser was done in commit 40d4232 on Feb 3, 2014. commit 5892e7e14438d400f4df52e8b6c20f1633bee34e Author: Oliver Kellogg Date: Tue Apr 20 23:09:20 2021 +0200 test/import/cxx/namespace-enum-literal.h : Document semicolon after end of namespace. commit 845a56144180546e9e5d04ab0b2459c3974f7083 Author: Oliver Kellogg Date: Tue Apr 20 23:07:08 2021 +0200 test/import/cxx/comments-class-enums.h: Fix typo in comment, add newline at EOF.