wsdfhjxc (Wojciech Stachurski)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 17 2018, 3:04 AM (100 w, 3 d)
Availability
Available

Recent Activity

Apr 3 2018

wsdfhjxc added a comment to D11746: Assign notification area category.

All of them seem to be accepted, but I can't land anything by myself. Feel free to do it on your own.

Apr 3 2018, 6:55 PM · Plasma

Mar 30 2018

wsdfhjxc requested review of D11822: Make the word/char count a global preference.
Mar 30 2018, 11:08 PM · Frameworks, Kate

Mar 27 2018

wsdfhjxc retitled D11750: Assign notification area category for Keyboard indicator from Assign notification area category to Assign notification area category for Keyboard indicator.
Mar 27 2018, 1:58 PM · Plasma
wsdfhjxc retitled D11749: Assign notification area category for Touchpad indicator from Assign notification area category to Assign notification area category for Touchpad indicator.
Mar 27 2018, 1:58 PM · Plasma
wsdfhjxc requested review of D11751: Assign notification area category.
Mar 27 2018, 1:56 PM · KDE Connect
wsdfhjxc requested review of D11750: Assign notification area category for Keyboard indicator.
Mar 27 2018, 1:53 PM · Plasma
wsdfhjxc requested review of D11749: Assign notification area category for Touchpad indicator.
Mar 27 2018, 1:51 PM · Plasma
wsdfhjxc requested review of D11748: Assign notification area category.
Mar 27 2018, 1:47 PM · Plasma
wsdfhjxc added a reviewer for D11746: Assign notification area category: Plasma.
Mar 27 2018, 1:39 PM · Plasma
wsdfhjxc requested review of D11746: Assign notification area category.
Mar 27 2018, 1:35 PM · Plasma

Mar 20 2018

wsdfhjxc added a comment to D11352: Use consistent ordering for System Tray items.

Unfortunately, comparing by item.text with a non-US language enabled makes the result worse than on previous screenshot (especially the order of items within the Hardware group is very odd). To get it consistent regardless of system's language setting it might be better to compare by item.itemId. Although StatusNotifierItem may have it undefined initially, it can be fixed with a timer hack and waiting till a proper Id is available, then updating the itemId property and calling updateItemVisibility() function.

Mar 20 2018, 11:19 AM · Plasma
wsdfhjxc added a comment to D11352: Use consistent ordering for System Tray items.

They are org.kde.plasma.keyboardindicator and org.kde.discovernotifier.

Mar 20 2018, 8:25 AM · Plasma
wsdfhjxc added a comment to D11352: Use consistent ordering for System Tray items.

Thanks for a fix.

Mar 20 2018, 12:44 AM · Plasma

Mar 16 2018

wsdfhjxc added a comment to D11352: Use consistent ordering for System Tray items.
In D11352#227154, @mart wrote:

yes, categories of those items need to be fixed, this was kinda forgotten as in plasma5 unfortunately the systray wasn't really using them

It would be great if that happened. The more precise item categories are, the more sensible auto ordering will be.

Mar 16 2018, 12:21 PM · Plasma
wsdfhjxc added a comment to D11352: Use consistent ordering for System Tray items.

That seems like you are getting some javascript error in updateItemVisibility. Can look at what plasma shell is reporting (or paste it here)?

There are no other errors except of ConfigEntries.qml:228:34: Unable to assign [undefined] to QKeySequence spam which is unrelated. Not sure what I did wrong.

Mar 16 2018, 9:59 AM · Plasma
wsdfhjxc added a comment to D11352: Use consistent ordering for System Tray items.

Doesn't seem to work for me. Only Notifications item is visible by default while there are multiple items set to be shown in the configuration. Also, changing the visibility state doesn't make any difference and the items are neither in panel nor in hidden panel, they just disappear. Only after going through configuration and manually switching every item to hidden and then to shown makes most of them visible.

Mar 16 2018, 7:00 AM · Plasma

Mar 14 2018

wsdfhjxc added a comment to D11292: [RFC] Ordered system tray v2.

Currently, dragging active items into the trash bin and saving changes results in setting auto visibility and displaying them at the end of both the system tray and configuration list, so it's not really deleting them from user's point of view. I was wondering, shouldn't the trash bin be accessible only while dragging inactive items (assuming statusNotifierModel will be fixed)?

Mar 14 2018, 9:40 PM · Plasma
wsdfhjxc abandoned D11233: Ordered system tray.
Mar 14 2018, 7:51 PM · Plasma
wsdfhjxc added a comment to D11292: [RFC] Ordered system tray v2.

I can no longer reproduce the issue with incorrect visibility state in combo boxes. It seems to be working correctly after last patch.

Mar 14 2018, 7:43 PM · Plasma
wsdfhjxc added a comment to D11292: [RFC] Ordered system tray v2.

I think it would be better to place new items on the left side of the system tray, as this is closer to default behavior. Also, sometimes the visibility state is updated incorrectly after moving items back and forth (showing hidden state for visible items). Other than that, works very nicely. It's indeed much easier to drag the items around instead of clicking their arrows multiple times. Thanks for tackling this!

Mar 14 2018, 2:54 AM · Plasma

Mar 13 2018

wsdfhjxc added a comment to D11292: [RFC] Ordered system tray v2.

As you said, that was a hack, and honestly I don't think it should be included because it's not the system tray applet's job to fix item identificators. Maybe some other component, e.g. related to StatusNotifier item registration, would be the place to look into. If not, the Dropbox client would be exceptionally placed always at the last position, but still there is a problem with previous entries stalled in the config property.

Mar 13 2018, 7:20 PM · Plasma
wsdfhjxc added a comment to D11292: [RFC] Ordered system tray v2.

As for the getFixedItemId function (which was connected to an id trimming method in my example), it was because of Dropbox client's StatusNotifier item having some random number suffix. Without this, at every boot it was duplicated in the new config list-type property with a new id and the previous one was stalled because of its id mismatch. So, I just wanted to let you know that there might be a problem for items identified with some randomly generated names. Although, it seems to be extremely rare, as I've only noticed Dropbox client doing this.

Mar 13 2018, 6:39 PM · Plasma

Mar 12 2018

wsdfhjxc updated the diff for D11233: Ordered system tray.
  • Wait for the item id before inserting it into tray
  • Sort the tray items by categories and ids
Mar 12 2018, 9:02 AM · Plasma

Mar 11 2018

wsdfhjxc updated the diff for D11233: Ordered system tray.
  • Squashed commit of the following:
  • Use theme based icons instead of char glyph labels for buttons
  • Use QRegularExpression instead of QRegExp
Mar 11 2018, 8:15 PM · Plasma
wsdfhjxc updated the summary of D11233: Ordered system tray.
Mar 11 2018, 2:45 PM · Plasma
wsdfhjxc requested review of D11233: Ordered system tray.
Mar 11 2018, 2:45 PM · Plasma